[jira] [Commented] (KYLIN-5285) has only one file after prune cuboid by sharby column, but launch 17 task when query
[ https://issues.apache.org/jira/browse/KYLIN-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626357#comment-17626357 ] ASF GitHub Bot commented on KYLIN-5285: --- hit-lacus commented on PR #2006: URL: https://github.com/apache/kylin/pull/2006#issuecomment-1296482570 Can one of the admins verify this patch? > has only one file after prune cuboid by sharby column, but launch 17 task > when query > > > Key: KYLIN-5285 > URL: https://issues.apache.org/jira/browse/KYLIN-5285 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Major > Attachments: image-2022-10-28-20-41-27-066.png, > image-2022-10-28-20-41-37-702.png, image-2022-10-28-20-41-52-544.png, > image-2022-10-28-20-42-01-694.png, image-2022-10-28-20-42-15-822.png, > screenshot-1.png > > > 使用了shardby，然后通过shardby裁剪到一个文件，该文件只有30多M（但这个cuboid下有17文件），结果查询的时候提交了17个task，只有一个有task在处理数据，其余都在空跑。 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5285) has only one file after prune cuboid by sharby column, but launch 17 task when query
[ https://issues.apache.org/jira/browse/KYLIN-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626356#comment-17626356 ] ASF GitHub Bot commented on KYLIN-5285: --- liuzhao-lz opened a new pull request, #2006: URL: https://github.com/apache/kylin/pull/2006 ## Proposed changes 当查询满足shardby条件，在创建 FileScanRDD 时，filePartitions 应该由 shardby 裁剪后的数据构建，而不是由回答当前查询的cuboid下的所有文件构成。 ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [x] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > has only one file after prune cuboid by sharby column, but launch 17 task > when query > > > Key: KYLIN-5285 > URL: https://issues.apache.org/jira/browse/KYLIN-5285 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Major > Attachments: image-2022-10-28-20-41-27-066.png, > image-2022-10-28-20-41-37-702.png, image-2022-10-28-20-41-52-544.png, > image-2022-10-28-20-42-01-694.png, image-2022-10-28-20-42-15-822.png, > screenshot-1.png > > > 使用了shardby，然后通过shardby裁剪到一个文件，该文件只有30多M（但这个cuboid下有17文件），结果查询的时候提交了17个task，只有一个有task在处理数据，其余都在空跑。 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] liuzhao-lz opened a new pull request, #2006: KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby
liuzhao-lz opened a new pull request, #2006: URL: https://github.com/apache/kylin/pull/2006 ## Proposed changes 当查询满足shardby条件，在创建 FileScanRDD 时，filePartitions 应该由 shardby 裁剪后的数据构建，而不是由回答当前查询的cuboid下的所有文件构成。 ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [x] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2006: KYLIN-5285 the number of filePartitions of FileScanRDD when used shardby
hit-lacus commented on PR #2006: URL: https://github.com/apache/kylin/pull/2006#issuecomment-1296482570 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5287) Kylin postgresql to store metadata
[
https://issues.apache.org/jira/browse/KYLIN-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626348#comment-17626348
]
Rohan Nimmagadda commented on KYLIN-5287:
-
[~mukvin] have you just used those two configs for Postgres to store Kylin’s
metadata ? As per docs and recommendations we also need to configure Postgres
dialect configurations in-order to connect with PostgreSQL db , Since Kylin
uses default MySQL dialect. We need to convert MySQL dialect to Postgres as I
mentioned above comments.
Without using those configurations I wonder how you would able to manage to
connect PostgreSQL for kylins metadata
> Kylin postgresql to store metadata
> ---
>
> Key: KYLIN-5287
> URL: https://issues.apache.org/jira/browse/KYLIN-5287
> Project: Kylin
> Issue Type: Bug
> Components: Driver - JDBC, Metadata
>Affects Versions: v4.0.2
>Reporter: Rohan Nimmagadda
>Priority: Major
> Attachments: metadata-jdbc-mysql.properties, screenshot-1.png
>
>
> We have configured Postgres to store kylin 4.0.2 metadata getting following
> error
>
> Kylin.properties
> {code:java}
> kylin.source.default=16
> kylin.metadata.url=kylin@jdbc,driverClassName=org.postgresql.Driver,url=jdbc:postgresql://127.0.0.1:5432/kylin,username=kylin1,password=,maxActive=10,maxIdle=10
> kylin.source.jdbc.connection-url=jdbc:postgresql://127.0.0.1:5432/kylin
> kylin.source.jdbc.adaptor=org.apache.kylin.sdk.datasource.adaptor.PostgresqlAdaptor
> kylin.source.jdbc.driver=org.postgresql.Driver
> kylin.source.jdbc.dialect=postgresql
> kylin.source.jdbc.user=kylin1
> kylin.source.jdbc.pass=XXX {code}
>
> {code:java}
> 2022-10-28 16:56:52,922 INFO [localhost-startStop-1]
> init.InitialSparderContext:40 : Maybe this is job node, or switch is off, do
> not need to start Spark, false2022-10-28 16:56:53,014 INFO
> [localhost-startStop-1] persistence.ResourceStore:90 : Using metadata url
> kylin@jdbc,driverClassName=org.postgresql.Driver,url=jdbc:postgresql://127.0.0.1:5432/kylin,username=kylin1,password=XX,maxActive=10,maxIdle=10
> for resource store2022-10-28 16:56:53,032 INFO [localhost-startStop-1]
> persistence.JDBCConnectionManager:92 : Connecting to Jdbc with
> url:jdbc:postgresql://127.0.0.1:5432/kylin by user kylin12022-10-28
> 16:56:53,230 INFO [localhost-startStop-1]
> persistence.JDBCConnectionManager:65 : Connected to PostgreSQL 11.12022-10-28
> 16:56:53,244 WARN [localhost-startStop-1]
> support.XmlWebApplicationContext:559 : Exception encountered during context
> initialization - cancelling refresh attempt:
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'diagnosisService': Unsatisfied dependency expressed
> through field 'aclEvaluate'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'aclEvaluate': Unsatisfied dependency expressed
> through field 'aclUtil'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'aclUtil' defined in URL
> [jar:file:/root/rpmbuild/SOURCES/apache-kylin-4.0.2-bin/tomcat/webapps/kylin/WEB-INF/lib/kylin-server-base-4.0.2.jar!/org/apache/kylin/rest/util/AclUtil.class]:
> Initialization of bean failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'expressionHandler' defined in class path resource
> [kylinSecurity.xml]: Cannot resolve reference to bean 'permissionEvaluator'
> while setting bean property 'permissionEvaluator'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'permissionEvaluator' defined in class path resource
> [kylinSecurity.xml]: Cannot resolve reference to bean 'aclService' while
> setting constructor argument; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'aclService' defined in URL
> [jar:file:/root/rpmbuild/SOURCES/apache-kylin-4.0.2-bin/tomcat/webapps/kylin/WEB-INF/lib/kylin-server-base-4.0.2.jar!/org/apache/kylin/rest/service/AclService.class]:
> Instantiation of bean failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to instantiate
> [org.apache.kylin.rest.service.AclService]: Constructor threw exception;
> nested exception is java.lang.IllegalArgumentException: Failed to find
> metadata store by url:
> kylin@jdbc,driverClassName=org.postgresql.Driver,url=jdbc:postgresql://127.0.0.1:5432/kylin,username=kylin1,password=XX,maxActive=10,maxIdle=102022-10-28
> 16:56:53,249 ERROR [localhost-startStop-1] context.ContextLoader:313 :
> Context initialization
>
[jira] [Commented] (KYLIN-5287) Kylin postgresql to store metadata
[
https://issues.apache.org/jira/browse/KYLIN-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626346#comment-17626346
]
mukvin commented on KYLIN-5287:
---
[~Rohannimmagadda] ,
I just configured the two configs as I mentioned before, and do not modify any
files again.
Would you try as I said?
> Kylin postgresql to store metadata
> ---
>
> Key: KYLIN-5287
> URL: https://issues.apache.org/jira/browse/KYLIN-5287
> Project: Kylin
> Issue Type: Bug
> Components: Driver - JDBC, Metadata
>Affects Versions: v4.0.2
>Reporter: Rohan Nimmagadda
>Priority: Major
> Attachments: metadata-jdbc-mysql.properties, screenshot-1.png
>
>
> We have configured Postgres to store kylin 4.0.2 metadata getting following
> error
>
> Kylin.properties
> {code:java}
> kylin.source.default=16
> kylin.metadata.url=kylin@jdbc,driverClassName=org.postgresql.Driver,url=jdbc:postgresql://127.0.0.1:5432/kylin,username=kylin1,password=,maxActive=10,maxIdle=10
> kylin.source.jdbc.connection-url=jdbc:postgresql://127.0.0.1:5432/kylin
> kylin.source.jdbc.adaptor=org.apache.kylin.sdk.datasource.adaptor.PostgresqlAdaptor
> kylin.source.jdbc.driver=org.postgresql.Driver
> kylin.source.jdbc.dialect=postgresql
> kylin.source.jdbc.user=kylin1
> kylin.source.jdbc.pass=XXX {code}
>
> {code:java}
> 2022-10-28 16:56:52,922 INFO [localhost-startStop-1]
> init.InitialSparderContext:40 : Maybe this is job node, or switch is off, do
> not need to start Spark, false2022-10-28 16:56:53,014 INFO
> [localhost-startStop-1] persistence.ResourceStore:90 : Using metadata url
> kylin@jdbc,driverClassName=org.postgresql.Driver,url=jdbc:postgresql://127.0.0.1:5432/kylin,username=kylin1,password=XX,maxActive=10,maxIdle=10
> for resource store2022-10-28 16:56:53,032 INFO [localhost-startStop-1]
> persistence.JDBCConnectionManager:92 : Connecting to Jdbc with
> url:jdbc:postgresql://127.0.0.1:5432/kylin by user kylin12022-10-28
> 16:56:53,230 INFO [localhost-startStop-1]
> persistence.JDBCConnectionManager:65 : Connected to PostgreSQL 11.12022-10-28
> 16:56:53,244 WARN [localhost-startStop-1]
> support.XmlWebApplicationContext:559 : Exception encountered during context
> initialization - cancelling refresh attempt:
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'diagnosisService': Unsatisfied dependency expressed
> through field 'aclEvaluate'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'aclEvaluate': Unsatisfied dependency expressed
> through field 'aclUtil'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'aclUtil' defined in URL
> [jar:file:/root/rpmbuild/SOURCES/apache-kylin-4.0.2-bin/tomcat/webapps/kylin/WEB-INF/lib/kylin-server-base-4.0.2.jar!/org/apache/kylin/rest/util/AclUtil.class]:
> Initialization of bean failed; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'expressionHandler' defined in class path resource
> [kylinSecurity.xml]: Cannot resolve reference to bean 'permissionEvaluator'
> while setting bean property 'permissionEvaluator'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'permissionEvaluator' defined in class path resource
> [kylinSecurity.xml]: Cannot resolve reference to bean 'aclService' while
> setting constructor argument; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'aclService' defined in URL
> [jar:file:/root/rpmbuild/SOURCES/apache-kylin-4.0.2-bin/tomcat/webapps/kylin/WEB-INF/lib/kylin-server-base-4.0.2.jar!/org/apache/kylin/rest/service/AclService.class]:
> Instantiation of bean failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to instantiate
> [org.apache.kylin.rest.service.AclService]: Constructor threw exception;
> nested exception is java.lang.IllegalArgumentException: Failed to find
> metadata store by url:
> kylin@jdbc,driverClassName=org.postgresql.Driver,url=jdbc:postgresql://127.0.0.1:5432/kylin,username=kylin1,password=XX,maxActive=10,maxIdle=102022-10-28
> 16:56:53,249 ERROR [localhost-startStop-1] context.ContextLoader:313 :
> Context initialization
> failedorg.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'diagnosisService': Unsatisfied dependency expressed
> through field 'aclEvaluate'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'aclEvaluate': Unsatisfied dependency expressed
> through field 'aclUtil'; nested
[jira] [Commented] (KYLIN-5283) JobWorker execute方法无法捕获原始异常
[ https://issues.apache.org/jira/browse/KYLIN-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626226#comment-17626226 ] liyang commented on KYLIN-5283: --- 值得修复，来个PR？ > JobWorker execute方法无法捕获原始异常 > --- > > Key: KYLIN-5283 > URL: https://issues.apache.org/jira/browse/KYLIN-5283 > Project: Kylin > Issue Type: Bug > Components: Job Engine, Spark Engine >Affects Versions: v4.0.1 >Reporter: huangsheng >Priority: Critical > Attachments: 截屏2022-10-25 15.17.56.png, 截屏2022-10-25 15.18.35.png > > > [SparkApplication.java|https://github.com/apache/kylin/blob/main/kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/application/SparkApplication.java] > 这里会捕获所有的原始异常，最终抛出一个RuntimeException > !截屏2022-10-25 15.17.56.png! > [JobWorker.scala|https://github.com/apache/kylin/blob/main/kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/spark/application/JobWorker.scala] > 所以JobWorker无法捕获原始异常，所有异常都走ResourceLack方法处理，这里存在问题 > !截屏2022-10-25 15.18.35.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (KYLIN-5286) Improve QueryConnection.getConnection?
[ https://issues.apache.org/jira/browse/KYLIN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Zhao closed KYLIN-5286. --- Resolution: Not A Problem > Improve QueryConnection.getConnection? > -- > > Key: KYLIN-5286 > URL: https://issues.apache.org/jira/browse/KYLIN-5286 > Project: Kylin > Issue Type: Wish > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Trivial > Attachments: image-2022-10-29-00-51-39-725.png, > image-2022-10-29-00-52-05-786.png > > > Is it possible to cache connections, similar to BasicDataSouce, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5286) Improve QueryConnection.getConnection?
[ https://issues.apache.org/jira/browse/KYLIN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626223#comment-17626223 ] liyang commented on KYLIN-5286: --- The QueryConnection is a lightweight object by design. That means there is no need to manage its lifecycle. Just create it when needed, and throw it away after it's used. That's the best management (unless we start to see performance issue in it). > Improve QueryConnection.getConnection? > -- > > Key: KYLIN-5286 > URL: https://issues.apache.org/jira/browse/KYLIN-5286 > Project: Kylin > Issue Type: Wish > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Trivial > Attachments: image-2022-10-29-00-51-39-725.png, > image-2022-10-29-00-52-05-786.png > > > Is it possible to cache connections, similar to BasicDataSouce, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (KYLIN-5286) Improve QueryConnection.getConnection?
[ https://issues.apache.org/jira/browse/KYLIN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626219#comment-17626219 ] Liu Zhao edited comment on KYLIN-5286 at 10/30/22 11:47 AM: [~liyang.g...@gmail.com] Thanks for responding to this.Is very low get a new QueryConnection cost in my env,I want to know if there is a better management connection:D was (Author: JIRAUSER288373): [~liyang] Thanks for responding to this.Is very low get a new QueryConnection cost in my env,I want to know if there is a better management connection:D > Improve QueryConnection.getConnection? > -- > > Key: KYLIN-5286 > URL: https://issues.apache.org/jira/browse/KYLIN-5286 > Project: Kylin > Issue Type: Wish > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Trivial > Attachments: image-2022-10-29-00-51-39-725.png, > image-2022-10-29-00-52-05-786.png > > > Is it possible to cache connections, similar to BasicDataSouce, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5286) Improve QueryConnection.getConnection?
[ https://issues.apache.org/jira/browse/KYLIN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626219#comment-17626219 ] Liu Zhao commented on KYLIN-5286: - [~liyang] Thanks for responding to this.Is very low get a new QueryConnection cost in my env,I want to know if there is a better management connection:D > Improve QueryConnection.getConnection? > -- > > Key: KYLIN-5286 > URL: https://issues.apache.org/jira/browse/KYLIN-5286 > Project: Kylin > Issue Type: Wish > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Trivial > Attachments: image-2022-10-29-00-51-39-725.png, > image-2022-10-29-00-52-05-786.png > > > Is it possible to cache connections, similar to BasicDataSouce, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5286) Improve QueryConnection.getConnection?
[ https://issues.apache.org/jira/browse/KYLIN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626216#comment-17626216 ] liyang commented on KYLIN-5286: --- Technically, cache is always possible, at the cost of designing how to refresh the metadata linked by the connection object. How many 'ms' it takes to get a new QueryConnection in your env? Let's check the potential benefit first. :) > Improve QueryConnection.getConnection? > -- > > Key: KYLIN-5286 > URL: https://issues.apache.org/jira/browse/KYLIN-5286 > Project: Kylin > Issue Type: Wish > Components: Query Engine >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Trivial > Attachments: image-2022-10-29-00-51-39-725.png, > image-2022-10-29-00-52-05-786.png > > > Is it possible to cache connections, similar to BasicDataSouce, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5277) MetadataCleanupJob.isJobComplete should include NSparkMergingJob
[ https://issues.apache.org/jira/browse/KYLIN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626208#comment-17626208 ] Liu Zhao commented on KYLIN-5277: - Hi [~xxyu], There is a merge conflict in the main branch, that is KYLIN-5008 and KYLIN-5245. They solve the same problem in two ways. > MetadataCleanupJob.isJobComplete should include NSparkMergingJob > > > Key: KYLIN-5277 > URL: https://issues.apache.org/jira/browse/KYLIN-5277 > Project: Kylin > Issue Type: Bug > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Major > Fix For: Future > > > MetadataCleanupJob.isJobComplete should include NSparkMergingJob, because > NSparkMergingJob include autoMerge,etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5277) MetadataCleanupJob.isJobComplete should include NSparkMergingJob
[ https://issues.apache.org/jira/browse/KYLIN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626206#comment-17626206 ] ASF GitHub Bot commented on KYLIN-5277: --- hit-lacus commented on PR #2005: URL: https://github.com/apache/kylin/pull/2005#issuecomment-1296193349 Can one of the admins verify this patch? > MetadataCleanupJob.isJobComplete should include NSparkMergingJob > > > Key: KYLIN-5277 > URL: https://issues.apache.org/jira/browse/KYLIN-5277 > Project: Kylin > Issue Type: Bug > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Major > Fix For: Future > > > MetadataCleanupJob.isJobComplete should include NSparkMergingJob, because > NSparkMergingJob include autoMerge,etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5277) MetadataCleanupJob.isJobComplete should include NSparkMergingJob
[ https://issues.apache.org/jira/browse/KYLIN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626205#comment-17626205 ] ASF GitHub Bot commented on KYLIN-5277: --- liuzhao-lz opened a new pull request, #2005: URL: https://github.com/apache/kylin/pull/2005 …ingJob ## Proposed changes The running data generated by kylin4 mergeCubeJob also needs to be cleaned. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [x] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > MetadataCleanupJob.isJobComplete should include NSparkMergingJob > > > Key: KYLIN-5277 > URL: https://issues.apache.org/jira/browse/KYLIN-5277 > Project: Kylin > Issue Type: Bug > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Major > Fix For: Future > > > MetadataCleanupJob.isJobComplete should include NSparkMergingJob, because > NSparkMergingJob include autoMerge,etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] hit-lacus commented on pull request #2005: KYLIN-5277 MetadataCleanupJob.isJobComplete should include NSparkMerg…
hit-lacus commented on PR #2005: URL: https://github.com/apache/kylin/pull/2005#issuecomment-1296193349 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liuzhao-lz opened a new pull request, #2005: KYLIN-5277 MetadataCleanupJob.isJobComplete should include NSparkMerg…
liuzhao-lz opened a new pull request, #2005: URL: https://github.com/apache/kylin/pull/2005 …ingJob ## Proposed changes The running data generated by kylin4 mergeCubeJob also needs to be cleaned. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [x] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
