[jira] [Created] (KYLIN-5398) Flame graph availability fix
Jiale He created KYLIN-5398: --- Summary: Flame graph availability fix Key: KYLIN-5398 URL: https://issues.apache.org/jira/browse/KYLIN-5398 Project: Kylin Issue Type: Bug Components: Spark Engine Affects Versions: 5.0-alpha Reporter: Jiale He Assignee: Jiale He Fix For: 5.0-alpha -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5398) Flame graph availability fix
[ https://issues.apache.org/jira/browse/KYLIN-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiale He updated KYLIN-5398: Description: 本ISSUE修复火焰图的一系列问题 > Flame graph availability fix > > > Key: KYLIN-5398 > URL: https://issues.apache.org/jira/browse/KYLIN-5398 > Project: Kylin > Issue Type: Bug > Components: Spark Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > > 本ISSUE修复火焰图的一系列问题 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] zznlime opened a new pull request, #2074: KYLIN-5391 Kylin metadata tool for read specific file.
zznlime opened a new pull request, #2074: URL: https://github.com/apache/kylin/pull/2074 Currently, kylin metadata tool supports backup metadata files at project level or model level. We can add an api for listing files under a specific folder path and fetching the specific metadata at file level. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN-5391), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-5391 Metadata tool for fetch and list at file level" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5391) Metadata tool for fetch and list at file level.
[ https://issues.apache.org/jira/browse/KYLIN-5391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656506#comment-17656506 ] ASF GitHub Bot commented on KYLIN-5391: --- zznlime opened a new pull request, #2074: URL: https://github.com/apache/kylin/pull/2074 Currently, kylin metadata tool supports backup metadata files at project level or model level. We can add an api for listing files under a specific folder path and fetching the specific metadata at file level. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN-5391), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-5391 Metadata tool for fetch and list at file level" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged > Metadata tool for fetch and list at file level. > > > Key: KYLIN-5391 > URL: https://issues.apache.org/jira/browse/KYLIN-5391 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Affects Versions: 5.0-alpha >Reporter: Zhenning Zhang >Assignee: Zhenning Zhang >Priority: Major > Fix For: 5.0-alpha > > > Currently, kylin metadata tool supports backup metadata files at project > level or model level. We can add an api for listing files under a specific > folder path and fetching the specific metadata at file level. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5398) Flame graph availability fix
[ https://issues.apache.org/jira/browse/KYLIN-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiale He updated KYLIN-5398: Attachment: KYLIN-5398 火焰图问题修复.pdf > Flame graph availability fix > > > Key: KYLIN-5398 > URL: https://issues.apache.org/jira/browse/KYLIN-5398 > Project: Kylin > Issue Type: Bug > Components: Spark Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: KYLIN-5398 火焰图问题修复.pdf > > > 本ISSUE修复火焰图的一系列问题 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5398) Flame graph availability fix
[
https://issues.apache.org/jira/browse/KYLIN-5398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiale He updated KYLIN-5398:
Description:
本ISSUE修复火焰图的一系列问题
{color:#de350b}详情见附件{color}
was:本ISSUE修复火焰图的一系列问题
> Flame graph availability fix
>
>
> Key: KYLIN-5398
> URL: https://issues.apache.org/jira/browse/KYLIN-5398
> Project: Kylin
> Issue Type: Bug
> Components: Spark Engine
>Affects Versions: 5.0-alpha
>Reporter: Jiale He
>Assignee: Jiale He
>Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: KYLIN-5398 火焰图问题修复.pdf
>
>
> 本ISSUE修复火焰图的一系列问题
> {color:#de350b}详情见附件{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376942829 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [77.5% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5361) suggest set email content from hard code to configurable files
[ https://issues.apache.org/jira/browse/KYLIN-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656526#comment-17656526 ] ASF GitHub Bot commented on KYLIN-5361: --- sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376942829 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [77.5% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) > suggest set email content from hard code to configurable files > > > Key: KYLIN-5361 > URL: https://issues.apache.org/jira/browse/KYLIN-5361 > Project: Kylin > Issue Type: Improvement > Components: Others >Affects Versions: 5.0-alpha >Reporter: Li Can >Assignee: Li Can >Priority: Major > Fix For: 5.0-alpha > > Attachments: 1672730611150.jpg, 1672730640332.jpg, 1672730668472.jpg, > 1672730705781.jpg, 1672730728444.jpg, UI.jpg, emailcontent.png > > > These all email information cannot configure by users with comfortable way, > only way just to change the hard code, this method is not suitable for > diversity customers. > So we need adjust the hard code to configurable files, and set relative path > to read the file, and then the users can easily modify the contents with the > files rather than hard code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5361) suggest set email content from hard code to configurable files
[ https://issues.apache.org/jira/browse/KYLIN-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656544#comment-17656544 ] ASF GitHub Bot commented on KYLIN-5361: --- Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376975380 retest this please > suggest set email content from hard code to configurable files > > > Key: KYLIN-5361 > URL: https://issues.apache.org/jira/browse/KYLIN-5361 > Project: Kylin > Issue Type: Improvement > Components: Others >Affects Versions: 5.0-alpha >Reporter: Li Can >Assignee: Li Can >Priority: Major > Fix For: 5.0-alpha > > Attachments: 1672730611150.jpg, 1672730640332.jpg, 1672730668472.jpg, > 1672730705781.jpg, 1672730728444.jpg, UI.jpg, emailcontent.png > > > These all email information cannot configure by users with comfortable way, > only way just to change the hard code, this method is not suitable for > diversity customers. > So we need adjust the hard code to configurable files, and set relative path > to read the file, and then the users can easily modify the contents with the > files rather than hard code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376975380 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (KYLIN-5399) core-common module dependency slimming
Jiale He created KYLIN-5399: --- Summary: core-common module dependency slimming Key: KYLIN-5399 URL: https://issues.apache.org/jira/browse/KYLIN-5399 Project: Kylin Issue Type: Improvement Components: Others Affects Versions: 5.0-alpha Reporter: Jiale He Assignee: Jiale He Fix For: 5.0-alpha -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5399) core-common module dependency slimming
[ https://issues.apache.org/jira/browse/KYLIN-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiale He updated KYLIN-5399: Description: 减小core-common的maven依赖 模块依赖最小化 > core-common module dependency slimming > -- > > Key: KYLIN-5399 > URL: https://issues.apache.org/jira/browse/KYLIN-5399 > Project: Kylin > Issue Type: Improvement > Components: Others >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > > 减小core-common的maven依赖 > 模块依赖最小化 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] JialeHe opened a new pull request, #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe opened a new pull request, #2075: URL: https://github.com/apache/kylin/pull/2075 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5389) Query error 'reference cc is ambiguous'
[ https://issues.apache.org/jira/browse/KYLIN-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656591#comment-17656591 ] ASF GitHub Bot commented on KYLIN-5389: --- JialeHe opened a new pull request, #2075: URL: https://github.com/apache/kylin/pull/2075 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > Query error 'reference cc is ambiguous' > --- > > Key: KYLIN-5389 > URL: https://issues.apache.org/jira/browse/KYLIN-5389 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: image-2023-01-09-16-07-53-176.png, > image-2023-01-09-16-10-51-617.png > > > h1. Root Cause > > 这个问题由 https://issues.apache.org/jira/browse/KYLIN-5324 引入 > 是这个功能特有的问题，只有打开开关 > *kylin.query.use-tableindex-answer-select-star.enabled=true* 时才会遇到。 > > 报错出现在calcite plan转换到spark > plan的时候，在解析的时候出现了重复列。重复列是来自打开开关的时候，在使用索引引用的列替换OlapContext的fields的时候没有去重。 > !image-2023-01-09-16-07-53-176.png|width=863,height=237! > > *org.apache.kylin.query.schema.OLAPTable#listTableColumnsIncludingCC* > !image-2023-01-09-16-10-51-617.png|width=861,height=487! > 1，dataflow的allColumns取的是indexPlan的allColumns属性，这个是很老的代码，包含了衍生维度的逻辑，会把维度、度量引用的列、join > key的外键都加进来。 > 2，取完模型上的列后再次拿取整个项目下的CC，如果在1里拿到了CC，则会引起重复。这次问题就出在这里。 > > h1. Fix Design > 在上述代码里去掉重复列。 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378144520 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5389) Query error 'reference cc is ambiguous'
[ https://issues.apache.org/jira/browse/KYLIN-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657037#comment-17657037 ] ASF GitHub Bot commented on KYLIN-5389: --- JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378144520 retest this please > Query error 'reference cc is ambiguous' > --- > > Key: KYLIN-5389 > URL: https://issues.apache.org/jira/browse/KYLIN-5389 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: image-2023-01-09-16-07-53-176.png, > image-2023-01-09-16-10-51-617.png > > > h1. Root Cause > > 这个问题由 https://issues.apache.org/jira/browse/KYLIN-5324 引入 > 是这个功能特有的问题，只有打开开关 > *kylin.query.use-tableindex-answer-select-star.enabled=true* 时才会遇到。 > > 报错出现在calcite plan转换到spark > plan的时候，在解析的时候出现了重复列。重复列是来自打开开关的时候，在使用索引引用的列替换OlapContext的fields的时候没有去重。 > !image-2023-01-09-16-07-53-176.png|width=863,height=237! > > *org.apache.kylin.query.schema.OLAPTable#listTableColumnsIncludingCC* > !image-2023-01-09-16-10-51-617.png|width=861,height=487! > 1，dataflow的allColumns取的是indexPlan的allColumns属性，这个是很老的代码，包含了衍生维度的逻辑，会把维度、度量引用的列、join > key的外键都加进来。 > 2，取完模型上的列后再次拿取整个项目下的CC，如果在1里拿到了CC，则会引起重复。这次问题就出在这里。 > > h1. Fix Design > 在上述代码里去掉重复列。 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
Jiale He created KYLIN-5400: --- Summary: The query statement contains count(distinct), and an error is reported that distinct aggregation not supported Key: KYLIN-5400 URL: https://issues.apache.org/jira/browse/KYLIN-5400 Project: Kylin Issue Type: Bug Components: Query Engine Affects Versions: 5.0-alpha Reporter: Jiale He Assignee: Jiale He Fix For: 5.0-alpha -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[ https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiale He updated KYLIN-5400: Attachment: image-2023-01-11-10-11-47-227.png > The query statement contains count(distinct), and an error is reported that > distinct aggregation not supported > -- > > Key: KYLIN-5400 > URL: https://issues.apache.org/jira/browse/KYLIN-5400 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: image-2023-01-11-10-11-47-227.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[
https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiale He updated KYLIN-5400:
Description:
参考如下SQL，where中的两个and条件互斥。
{code:java}
select count(distinct STR0)
from TDVT.CALCS
WHERE (CALCS."STR0" = '0330FH')
AND (CALCS."STR0" = '0798FH'){code}
h1. Root Cause
where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
aggregation然后报错。
!image-2023-01-11-10-11-47-227.png|width=644,height=172!
h1. Fix Design
修复Calcite的问题，难度比较大，时间跨度也会比较长。
快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
!image-2023-01-11-10-12-17-625.png|width=819,height=100!
> The query statement contains count(distinct), and an error is reported that
> distinct aggregation not supported
> --
>
> Key: KYLIN-5400
> URL: https://issues.apache.org/jira/browse/KYLIN-5400
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: 5.0-alpha
>Reporter: Jiale He
>Assignee: Jiale He
>Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2023-01-11-10-11-47-227.png,
> image-2023-01-11-10-12-17-625.png
>
>
>
> 参考如下SQL，where中的两个and条件互斥。
> {code:java}
> select count(distinct STR0)
> from TDVT.CALCS
> WHERE (CALCS."STR0" = '0330FH')
> AND (CALCS."STR0" = '0798FH'){code}
> h1. Root Cause
> where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
> aggregation然后报错。
> !image-2023-01-11-10-11-47-227.png|width=644,height=172!
>
> h1. Fix Design
> 修复Calcite的问题，难度比较大，时间跨度也会比较长。
> 快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
> !image-2023-01-11-10-12-17-625.png|width=819,height=100!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[ https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiale He updated KYLIN-5400: Attachment: image-2023-01-11-10-12-17-625.png > The query statement contains count(distinct), and an error is reported that > distinct aggregation not supported > -- > > Key: KYLIN-5400 > URL: https://issues.apache.org/jira/browse/KYLIN-5400 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: image-2023-01-11-10-11-47-227.png, > image-2023-01-11-10-12-17-625.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[
https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiale He updated KYLIN-5400:
Attachment: image-2023-01-11-10-13-13-657.png
> The query statement contains count(distinct), and an error is reported that
> distinct aggregation not supported
> --
>
> Key: KYLIN-5400
> URL: https://issues.apache.org/jira/browse/KYLIN-5400
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: 5.0-alpha
>Reporter: Jiale He
>Assignee: Jiale He
>Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2023-01-11-10-11-47-227.png,
> image-2023-01-11-10-12-17-625.png, image-2023-01-11-10-13-13-657.png,
> image-2023-01-11-10-13-27-688.png, image-2023-01-11-10-13-43-324.png
>
>
>
> 参考如下SQL，where中的两个and条件互斥。
> {code:java}
> select count(distinct STR0)
> from TDVT.CALCS
> WHERE (CALCS."STR0" = '0330FH')
> AND (CALCS."STR0" = '0798FH'){code}
> h1. Root Cause
> where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
> aggregation然后报错。
> !image-2023-01-11-10-11-47-227.png|width=644,height=172!
>
> h1. Fix Design
> 修复Calcite的问题，难度比较大，时间跨度也会比较长。
> 快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
> !image-2023-01-11-10-12-17-625.png|width=819,height=100!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[
https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiale He updated KYLIN-5400:
Attachment: image-2023-01-11-10-13-43-324.png
> The query statement contains count(distinct), and an error is reported that
> distinct aggregation not supported
> --
>
> Key: KYLIN-5400
> URL: https://issues.apache.org/jira/browse/KYLIN-5400
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: 5.0-alpha
>Reporter: Jiale He
>Assignee: Jiale He
>Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2023-01-11-10-11-47-227.png,
> image-2023-01-11-10-12-17-625.png, image-2023-01-11-10-13-13-657.png,
> image-2023-01-11-10-13-27-688.png, image-2023-01-11-10-13-43-324.png
>
>
>
> 参考如下SQL，where中的两个and条件互斥。
> {code:java}
> select count(distinct STR0)
> from TDVT.CALCS
> WHERE (CALCS."STR0" = '0330FH')
> AND (CALCS."STR0" = '0798FH'){code}
> h1. Root Cause
> where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
> aggregation然后报错。
> !image-2023-01-11-10-11-47-227.png|width=644,height=172!
>
> h1. Fix Design
> 修复Calcite的问题，难度比较大，时间跨度也会比较长。
> 快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
> !image-2023-01-11-10-12-17-625.png|width=819,height=100!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[
https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiale He updated KYLIN-5400:
Description:
参考如下SQL，where中的两个and条件互斥。
{code:java}
select count(distinct STR0)
from TDVT.CALCS
WHERE (CALCS."STR0" = '0330FH')
AND (CALCS."STR0" = '0798FH'){code}
h1. Root Cause
where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
aggregation然后报错。
!image-2023-01-11-10-11-47-227.png|width=644,height=172!
h1. Fix Design
修复Calcite的问题，难度比较大，时间跨度也会比较长。
快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
!image-2023-01-11-10-12-17-625.png|width=819,height=100!
h1. Test
!image-2023-01-11-10-13-13-657.png|width=641,height=374!
!image-2023-01-11-10-13-27-688.png|width=651,height=371!
!image-2023-01-11-10-13-43-324.png|width=808,height=165!
was:
参考如下SQL，where中的两个and条件互斥。
{code:java}
select count(distinct STR0)
from TDVT.CALCS
WHERE (CALCS."STR0" = '0330FH')
AND (CALCS."STR0" = '0798FH'){code}
h1. Root Cause
where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
aggregation然后报错。
!image-2023-01-11-10-11-47-227.png|width=644,height=172!
h1. Fix Design
修复Calcite的问题，难度比较大，时间跨度也会比较长。
快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
!image-2023-01-11-10-12-17-625.png|width=819,height=100!
> The query statement contains count(distinct), and an error is reported that
> distinct aggregation not supported
> --
>
> Key: KYLIN-5400
> URL: https://issues.apache.org/jira/browse/KYLIN-5400
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: 5.0-alpha
>Reporter: Jiale He
>Assignee: Jiale He
>Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2023-01-11-10-11-47-227.png,
> image-2023-01-11-10-12-17-625.png, image-2023-01-11-10-13-13-657.png,
> image-2023-01-11-10-13-27-688.png, image-2023-01-11-10-13-43-324.png
>
>
>
> 参考如下SQL，where中的两个and条件互斥。
> {code:java}
> select count(distinct STR0)
> from TDVT.CALCS
> WHERE (CALCS."STR0" = '0330FH')
> AND (CALCS."STR0" = '0798FH'){code}
> h1. Root Cause
> where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
> aggregation然后报错。
> !image-2023-01-11-10-11-47-227.png|width=644,height=172!
>
> h1. Fix Design
> 修复Calcite的问题，难度比较大，时间跨度也会比较长。
> 快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
> !image-2023-01-11-10-12-17-625.png|width=819,height=100!
>
> h1. Test
> !image-2023-01-11-10-13-13-657.png|width=641,height=374!
> !image-2023-01-11-10-13-27-688.png|width=651,height=371!
> !image-2023-01-11-10-13-43-324.png|width=808,height=165!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (KYLIN-5400) The query statement contains count(distinct), and an error is reported that distinct aggregation not supported
[
https://issues.apache.org/jira/browse/KYLIN-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiale He updated KYLIN-5400:
Attachment: image-2023-01-11-10-13-27-688.png
> The query statement contains count(distinct), and an error is reported that
> distinct aggregation not supported
> --
>
> Key: KYLIN-5400
> URL: https://issues.apache.org/jira/browse/KYLIN-5400
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: 5.0-alpha
>Reporter: Jiale He
>Assignee: Jiale He
>Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2023-01-11-10-11-47-227.png,
> image-2023-01-11-10-12-17-625.png, image-2023-01-11-10-13-13-657.png,
> image-2023-01-11-10-13-27-688.png, image-2023-01-11-10-13-43-324.png
>
>
>
> 参考如下SQL，where中的两个and条件互斥。
> {code:java}
> select count(distinct STR0)
> from TDVT.CALCS
> WHERE (CALCS."STR0" = '0330FH')
> AND (CALCS."STR0" = '0798FH'){code}
> h1. Root Cause
> where条件为 = 时，查询一定是互斥的，生成relnode之后会被解析为常量查询，走calcite，calcite这里有bug，不支持distinct
> aggregation然后报错。
> !image-2023-01-11-10-11-47-227.png|width=644,height=172!
>
> h1. Fix Design
> 修复Calcite的问题，难度比较大，时间跨度也会比较长。
> 快速的修复方案，可以通过修改是否路由到calcite的判断条件（org.apache.kylin.query.engine.QueryExec#isCalciteEngineCapable），当AggregateRel的input是values并且aggCall是distinct的时候，使该常量查询路由到spark，绕过calcite的问题。
> !image-2023-01-11-10-12-17-625.png|width=819,height=100!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378179768 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5361) suggest set email content from hard code to configurable files
[ https://issues.apache.org/jira/browse/KYLIN-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657056#comment-17657056 ] ASF GitHub Bot commented on KYLIN-5361: --- Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378179768 retest this please > suggest set email content from hard code to configurable files > > > Key: KYLIN-5361 > URL: https://issues.apache.org/jira/browse/KYLIN-5361 > Project: Kylin > Issue Type: Improvement > Components: Others >Affects Versions: 5.0-alpha >Reporter: Li Can >Assignee: Li Can >Priority: Major > Fix For: 5.0-alpha > > Attachments: 1672730611150.jpg, 1672730640332.jpg, 1672730668472.jpg, > 1672730705781.jpg, 1672730728444.jpg, UI.jpg, emailcontent.png > > > These all email information cannot configure by users with comfortable way, > only way just to change the hard code, this method is not suitable for > diversity customers. > So we need adjust the hard code to configurable files, and set relative path > to read the file, and then the users can easily modify the contents with the > files rather than hard code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] zznlime commented on pull request #2074: KYLIN-5391 Kylin metadata tool for read specific file.
zznlime commented on PR #2074: URL: https://github.com/apache/kylin/pull/2074#issuecomment-1378194669 retest please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5391) Metadata tool for fetch and list at file level.
[ https://issues.apache.org/jira/browse/KYLIN-5391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657061#comment-17657061 ] ASF GitHub Bot commented on KYLIN-5391: --- zznlime commented on PR #2074: URL: https://github.com/apache/kylin/pull/2074#issuecomment-1378194669 retest please. > Metadata tool for fetch and list at file level. > > > Key: KYLIN-5391 > URL: https://issues.apache.org/jira/browse/KYLIN-5391 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Affects Versions: 5.0-alpha >Reporter: Zhenning Zhang >Assignee: Zhenning Zhang >Priority: Major > Fix For: 5.0-alpha > > > Currently, kylin metadata tool supports backup metadata files at project > level or model level. We can add an api for listing files under a specific > folder path and fetching the specific metadata at file level. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378220480 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5389) Query error 'reference cc is ambiguous'
[ https://issues.apache.org/jira/browse/KYLIN-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657072#comment-17657072 ] ASF GitHub Bot commented on KYLIN-5389: --- JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378220480 retest this please > Query error 'reference cc is ambiguous' > --- > > Key: KYLIN-5389 > URL: https://issues.apache.org/jira/browse/KYLIN-5389 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: image-2023-01-09-16-07-53-176.png, > image-2023-01-09-16-10-51-617.png > > > h1. Root Cause > > 这个问题由 https://issues.apache.org/jira/browse/KYLIN-5324 引入 > 是这个功能特有的问题，只有打开开关 > *kylin.query.use-tableindex-answer-select-star.enabled=true* 时才会遇到。 > > 报错出现在calcite plan转换到spark > plan的时候，在解析的时候出现了重复列。重复列是来自打开开关的时候，在使用索引引用的列替换OlapContext的fields的时候没有去重。 > !image-2023-01-09-16-07-53-176.png|width=863,height=237! > > *org.apache.kylin.query.schema.OLAPTable#listTableColumnsIncludingCC* > !image-2023-01-09-16-10-51-617.png|width=861,height=487! > 1，dataflow的allColumns取的是indexPlan的allColumns属性，这个是很老的代码，包含了衍生维度的逻辑，会把维度、度量引用的列、join > key的外键都加进来。 > 2，取完模型上的列后再次拿取整个项目下的CC，如果在1里拿到了CC，则会引起重复。这次问题就出在这里。 > > h1. Fix Design > 在上述代码里去掉重复列。 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378267078 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5389) Query error 'reference cc is ambiguous'
[ https://issues.apache.org/jira/browse/KYLIN-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657090#comment-17657090 ] ASF GitHub Bot commented on KYLIN-5389: --- JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378267078 retest this please > Query error 'reference cc is ambiguous' > --- > > Key: KYLIN-5389 > URL: https://issues.apache.org/jira/browse/KYLIN-5389 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0-alpha >Reporter: Jiale He >Assignee: Jiale He >Priority: Major > Fix For: 5.0-alpha > > Attachments: image-2023-01-09-16-07-53-176.png, > image-2023-01-09-16-10-51-617.png > > > h1. Root Cause > > 这个问题由 https://issues.apache.org/jira/browse/KYLIN-5324 引入 > 是这个功能特有的问题，只有打开开关 > *kylin.query.use-tableindex-answer-select-star.enabled=true* 时才会遇到。 > > 报错出现在calcite plan转换到spark > plan的时候，在解析的时候出现了重复列。重复列是来自打开开关的时候，在使用索引引用的列替换OlapContext的fields的时候没有去重。 > !image-2023-01-09-16-07-53-176.png|width=863,height=237! > > *org.apache.kylin.query.schema.OLAPTable#listTableColumnsIncludingCC* > !image-2023-01-09-16-10-51-617.png|width=861,height=487! > 1，dataflow的allColumns取的是indexPlan的allColumns属性，这个是很老的代码，包含了衍生维度的逻辑，会把维度、度量引用的列、join > key的外键都加进来。 > 2，取完模型上的列后再次拿取整个项目下的CC，如果在1里拿到了CC，则会引起重复。这次问题就出在这里。 > > h1. Fix Design > 在上述代码里去掉重复列。 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378297376 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (KYLIN-5361) suggest set email content from hard code to configurable files
[ https://issues.apache.org/jira/browse/KYLIN-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657097#comment-17657097 ] ASF GitHub Bot commented on KYLIN-5361: --- Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378297376 retest this please > suggest set email content from hard code to configurable files > > > Key: KYLIN-5361 > URL: https://issues.apache.org/jira/browse/KYLIN-5361 > Project: Kylin > Issue Type: Improvement > Components: Others >Affects Versions: 5.0-alpha >Reporter: Li Can >Assignee: Li Can >Priority: Major > Fix For: 5.0-alpha > > Attachments: 1672730611150.jpg, 1672730640332.jpg, 1672730668472.jpg, > 1672730705781.jpg, 1672730728444.jpg, UI.jpg, emailcontent.png > > > These all email information cannot configure by users with comfortable way, > only way just to change the hard code, this method is not suitable for > diversity customers. > So we need adjust the hard code to configurable files, and set relative path > to read the file, and then the users can easily modify the contents with the > files rather than hard code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
