[jira] [Commented] (KYLIN-5973) Enable Streaming for Kylin5
[ https://issues.apache.org/jira/browse/KYLIN-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885243#comment-17885243 ] ASF GitHub Bot commented on KYLIN-5973: --- wuzhim opened a new pull request, #2231: URL: https://github.com/apache/kylin/pull/2231 (no comment) > Enable Streaming for Kylin5 > --- > > Key: KYLIN-5973 > URL: https://issues.apache.org/jira/browse/KYLIN-5973 > Project: Kylin > Issue Type: Bug > Components: Real-time Streaming >Affects Versions: 5.0-beta >Reporter: Zhimin Wu >Assignee: Zhimin Wu >Priority: Major > Fix For: 5.0.0 > > > KE5 Streaming job not avabile -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5975) Accept recommendations doesn't work
[ https://issues.apache.org/jira/browse/KYLIN-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883833#comment-17883833 ] ASF GitHub Bot commented on KYLIN-5975: --- liyang-kylin merged PR #2229: URL: https://github.com/apache/kylin/pull/2229 > Accept recommendations doesn't work > --- > > Key: KYLIN-5975 > URL: https://issues.apache.org/jira/browse/KYLIN-5975 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5975) Accept recommendations doesn't work
[ https://issues.apache.org/jira/browse/KYLIN-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883811#comment-17883811 ] ASF GitHub Bot commented on KYLIN-5975: --- pfzhan opened a new pull request, #2229: URL: https://github.com/apache/kylin/pull/2229 (no comment) > Accept recommendations doesn't work > --- > > Key: KYLIN-5975 > URL: https://issues.apache.org/jira/browse/KYLIN-5975 > Project: Kylin > Issue Type: Bug > Components: Modeling >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5970) Kylin5 standalone docker update
[ https://issues.apache.org/jira/browse/KYLIN-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881778#comment-17881778 ] ASF GitHub Bot commented on KYLIN-5970: --- liyang-kylin merged PR #2224: URL: https://github.com/apache/kylin/pull/2224 > Kylin5 standalone docker update > --- > > Key: KYLIN-5970 > URL: https://issues.apache.org/jira/browse/KYLIN-5970 > Project: Kylin > Issue Type: Improvement > Components: Release >Reporter: Yinghao Lin >Assignee: Yinghao Lin >Priority: Minor > Fix For: 5.0.0 > > > TODO > # Support new kylin5 internal table feature for out-of-box usage > # Update base image ubuntu version > # Update hadoop version > # Dockerfile refactor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5970) Kylin5 standalone docker update
[ https://issues.apache.org/jira/browse/KYLIN-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881763#comment-17881763 ] ASF GitHub Bot commented on KYLIN-5970: --- yhcast0 opened a new pull request, #2224: URL: https://github.com/apache/kylin/pull/2224 (no comment) > Kylin5 standalone docker update > --- > > Key: KYLIN-5970 > URL: https://issues.apache.org/jira/browse/KYLIN-5970 > Project: Kylin > Issue Type: Improvement > Components: Release >Reporter: Yinghao Lin >Priority: Minor > Fix For: 5.0.0 > > > TODO > # Support new kylin5 internal table feature for out-of-box usage > # Update base image ubuntu version > # Update hadoop version > # Dockerfile refactor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5970) Kylin5 standalone docker update
[ https://issues.apache.org/jira/browse/KYLIN-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881566#comment-17881566 ] ASF GitHub Bot commented on KYLIN-5970: --- liyang-kylin merged PR #2220: URL: https://github.com/apache/kylin/pull/2220 > Kylin5 standalone docker update > --- > > Key: KYLIN-5970 > URL: https://issues.apache.org/jira/browse/KYLIN-5970 > Project: Kylin > Issue Type: Improvement > Components: Release >Reporter: Yinghao Lin >Priority: Minor > Fix For: 5.0.0 > > > TODO > # Support new kylin5 internal table feature for out-of-box usage > # Update base image ubuntu version > # Update hadoop version > # Dockerfile refactor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5968) Support real-time for website
[ https://issues.apache.org/jira/browse/KYLIN-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881543#comment-17881543 ] ASF GitHub Bot commented on KYLIN-5968: --- liyang-kylin merged PR #2213: URL: https://github.com/apache/kylin/pull/2213 > Support real-time for website > - > > Key: KYLIN-5968 > URL: https://issues.apache.org/jira/browse/KYLIN-5968 > Project: Kylin > Issue Type: New Feature > Components: Website >Affects Versions: 5.0-beta >Reporter: huangsheng >Priority: Major > Fix For: 5.0.0 > > Attachments: 截屏2024-09-05 10.26.06.png, 截屏2024-09-05 10.26.11.png, > 截屏2024-09-05 13.55.19.png, 截屏2024-09-05 13.55.52.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5974) internal table detail page partition column read error
[ https://issues.apache.org/jira/browse/KYLIN-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881540#comment-17881540 ] ASF GitHub Bot commented on KYLIN-5974: --- liyang-kylin merged PR #2221: URL: https://github.com/apache/kylin/pull/2221 > internal table detail page partition column read error > -- > > Key: KYLIN-5974 > URL: https://issues.apache.org/jira/browse/KYLIN-5974 > Project: Kylin > Issue Type: Improvement > Components: Website >Reporter: huangsheng >Assignee: huangsheng >Priority: Trivial > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5974) internal table detail page partition column read error
[ https://issues.apache.org/jira/browse/KYLIN-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881538#comment-17881538 ] ASF GitHub Bot commented on KYLIN-5974: --- Mrhs121 opened a new pull request, #2221: URL: https://github.com/apache/kylin/pull/2221 (no comment) > internal table detail page partition column read error > -- > > Key: KYLIN-5974 > URL: https://issues.apache.org/jira/browse/KYLIN-5974 > Project: Kylin > Issue Type: Improvement > Components: Website >Reporter: huangsheng >Assignee: huangsheng >Priority: Trivial > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5970) Kylin5 standalone docker update
[ https://issues.apache.org/jira/browse/KYLIN-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881527#comment-17881527 ] ASF GitHub Bot commented on KYLIN-5970: --- yhcast0 opened a new pull request, #2220: URL: https://github.com/apache/kylin/pull/2220 (no comment) > Kylin5 standalone docker update > --- > > Key: KYLIN-5970 > URL: https://issues.apache.org/jira/browse/KYLIN-5970 > Project: Kylin > Issue Type: Improvement > Components: Release >Reporter: Yinghao Lin >Priority: Minor > Fix For: 5.0.0 > > > TODO > # Support new kylin5 internal table feature for out-of-box usage > # Update base image ubuntu version > # Update hadoop version > # Dockerfile refactor -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5973) KE5 Streaming job not avabile
[ https://issues.apache.org/jira/browse/KYLIN-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881499#comment-17881499 ] ASF GitHub Bot commented on KYLIN-5973: --- liyang-kylin merged PR #2217: URL: https://github.com/apache/kylin/pull/2217 > KE5 Streaming job not avabile > - > > Key: KYLIN-5973 > URL: https://issues.apache.org/jira/browse/KYLIN-5973 > Project: Kylin > Issue Type: Bug > Components: Real-time Streaming >Affects Versions: 5.0-beta >Reporter: Zhimin Wu >Assignee: Zhimin Wu >Priority: Major > Fix For: 5.0.0 > > > KE5 Streaming job not avabile -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5965) Update docs for kylin 5.0
[ https://issues.apache.org/jira/browse/KYLIN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881257#comment-17881257 ] ASF GitHub Bot commented on KYLIN-5965: --- lionelcao opened a new pull request, #2219: URL: https://github.com/apache/kylin/pull/2219 (no comment) > Update docs for kylin 5.0 > - > > Key: KYLIN-5965 > URL: https://issues.apache.org/jira/browse/KYLIN-5965 > Project: Kylin > Issue Type: Task >Reporter: Cao, Lionel >Assignee: Cao, Lionel >Priority: Major > > add content for internal table > add content for gluten integration > add content for recommendation > add content for new model storage > optimize doc structure and directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5973) KE5 Streaming job not avabile
[ https://issues.apache.org/jira/browse/KYLIN-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881215#comment-17881215 ] ASF GitHub Bot commented on KYLIN-5973: --- wuzhim opened a new pull request, #2217: URL: https://github.com/apache/kylin/pull/2217 (no comment) > KE5 Streaming job not avabile > - > > Key: KYLIN-5973 > URL: https://issues.apache.org/jira/browse/KYLIN-5973 > Project: Kylin > Issue Type: Bug > Components: Real-time Streaming >Affects Versions: 5.0-beta >Reporter: Zhimin Wu >Assignee: Zhimin Wu >Priority: Major > Fix For: 5.0.0 > > > KE5 Streaming job not avabile -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5972) Support start up without gluten
[ https://issues.apache.org/jira/browse/KYLIN-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880877#comment-17880877 ] ASF GitHub Bot commented on KYLIN-5972: --- liyang-kylin merged PR #2216: URL: https://github.com/apache/kylin/pull/2216 > Support start up without gluten > --- > > Key: KYLIN-5972 > URL: https://issues.apache.org/jira/browse/KYLIN-5972 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5971) Optimize bootstrap process when prepare gluten
[ https://issues.apache.org/jira/browse/KYLIN-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879749#comment-17879749 ] ASF GitHub Bot commented on KYLIN-5971: --- thy950523 opened a new pull request, #2214: URL: https://github.com/apache/kylin/pull/2214 - change gluten dependencies download url when packaging kylin. - remove update bootstrap script when packaging kylin. - check if exisit libch.so and prepare gluten initialization after start up. > Optimize bootstrap process when prepare gluten > -- > > Key: KYLIN-5971 > URL: https://issues.apache.org/jira/browse/KYLIN-5971 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5968) Support real-time for website
[ https://issues.apache.org/jira/browse/KYLIN-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879457#comment-17879457 ] ASF GitHub Bot commented on KYLIN-5968: --- Mrhs121 opened a new pull request, #2213: URL: https://github.com/apache/kylin/pull/2213 (no comment) > Support real-time for website > - > > Key: KYLIN-5968 > URL: https://issues.apache.org/jira/browse/KYLIN-5968 > Project: Kylin > Issue Type: New Feature > Components: Website >Affects Versions: 5.0-beta >Reporter: huangsheng >Priority: Major > Fix For: 5.0.0 > > Attachments: 截屏2024-09-05 10.26.06.png, 截屏2024-09-05 10.26.11.png, > 截屏2024-09-05 13.55.19.png, 截屏2024-09-05 13.55.52.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5964) Full build reports error when executing layoutOptimizer
[ https://issues.apache.org/jira/browse/KYLIN-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879231#comment-17879231 ] ASF GitHub Bot commented on KYLIN-5964: --- liyang-kylin merged PR #2207: URL: https://github.com/apache/kylin/pull/2207 > Full build reports error when executing layoutOptimizer > --- > > Key: KYLIN-5964 > URL: https://issues.apache.org/jira/browse/KYLIN-5964 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5963) Building snapshot with new storage type
[ https://issues.apache.org/jira/browse/KYLIN-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879160#comment-17879160 ] ASF GitHub Bot commented on KYLIN-5963: --- liyang-kylin merged PR #2206: URL: https://github.com/apache/kylin/pull/2206 > Building snapshot with new storage type > --- > > Key: KYLIN-5963 > URL: https://issues.apache.org/jira/browse/KYLIN-5963 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5961) Load as native table button was not visible on source data page
[ https://issues.apache.org/jira/browse/KYLIN-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879156#comment-17879156 ] ASF GitHub Bot commented on KYLIN-5961: --- liyang-kylin merged PR #2211: URL: https://github.com/apache/kylin/pull/2211 > Load as native table button was not visible on source data page > --- > > Key: KYLIN-5961 > URL: https://issues.apache.org/jira/browse/KYLIN-5961 > Project: Kylin > Issue Type: Bug >Affects Versions: 5.0-beta >Reporter: huangsheng >Assignee: huangsheng >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5969) Package gluten dependencies into spark
[ https://issues.apache.org/jira/browse/KYLIN-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879142#comment-17879142 ] ASF GitHub Bot commented on KYLIN-5969: --- thy950523 opened a new pull request, #2212: URL: https://github.com/apache/kylin/pull/2212 (no comment) > Package gluten dependencies into spark > -- > > Key: KYLIN-5969 > URL: https://issues.apache.org/jira/browse/KYLIN-5969 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Priority: Major > > After execute ./sbin/download-spark-user.sh, gluten relevant dependencies > will also be packaged into downloaded spark -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5966) Reorder the loading order of gluten jar
[ https://issues.apache.org/jira/browse/KYLIN-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878847#comment-17878847 ] ASF GitHub Bot commented on KYLIN-5966: --- pfzhan opened a new pull request, #2210: URL: https://github.com/apache/kylin/pull/2210 (no comment) > Reorder the loading order of gluten jar > --- > > Key: KYLIN-5966 > URL: https://issues.apache.org/jira/browse/KYLIN-5966 > Project: Kylin > Issue Type: Improvement > Components: Query Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5962) Realization type is wrong when hitting snapshot or internalTable
[ https://issues.apache.org/jira/browse/KYLIN-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878845#comment-17878845 ] ASF GitHub Bot commented on KYLIN-5962: --- pfzhan opened a new pull request, #2209: URL: https://github.com/apache/kylin/pull/2209 (no comment) > Realization type is wrong when hitting snapshot or internalTable > > > Key: KYLIN-5962 > URL: https://issues.apache.org/jira/browse/KYLIN-5962 > Project: Kylin > Issue Type: Bug > Components: Others, Query Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5965) Update docs for kylin 5.0
[ https://issues.apache.org/jira/browse/KYLIN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878844#comment-17878844 ] ASF GitHub Bot commented on KYLIN-5965: --- pfzhan opened a new pull request, #2208: URL: https://github.com/apache/kylin/pull/2208 (no comment) > Update docs for kylin 5.0 > - > > Key: KYLIN-5965 > URL: https://issues.apache.org/jira/browse/KYLIN-5965 > Project: Kylin > Issue Type: Task >Reporter: Cao, Lionel >Assignee: Cao, Lionel >Priority: Major > > add content for internal table > add content for gluten integration > add content for recommendation > add content for new model storage > optimize doc structure and directory -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5964) Full build reports error when executing layoutOptimizer
[ https://issues.apache.org/jira/browse/KYLIN-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878842#comment-17878842 ] ASF GitHub Bot commented on KYLIN-5964: --- pfzhan opened a new pull request, #2207: URL: https://github.com/apache/kylin/pull/2207 (no comment) > Full build reports error when executing layoutOptimizer > --- > > Key: KYLIN-5964 > URL: https://issues.apache.org/jira/browse/KYLIN-5964 > Project: Kylin > Issue Type: Bug > Components: Job Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5963) Building snapshot with new storage type
[ https://issues.apache.org/jira/browse/KYLIN-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878841#comment-17878841 ] ASF GitHub Bot commented on KYLIN-5963: --- pfzhan opened a new pull request, #2206: URL: https://github.com/apache/kylin/pull/2206 (no comment) > Building snapshot with new storage type > --- > > Key: KYLIN-5963 > URL: https://issues.apache.org/jira/browse/KYLIN-5963 > Project: Kylin > Issue Type: Improvement > Components: Job Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5827) Add frontend to adjust index optimization
[ https://issues.apache.org/jira/browse/KYLIN-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878684#comment-17878684 ] ASF GitHub Bot commented on KYLIN-5827: --- pfzhan opened a new pull request, #2204: URL: https://github.com/apache/kylin/pull/2204 (no comment) > Add frontend to adjust index optimization > - > > Key: KYLIN-5827 > URL: https://issues.apache.org/jira/browse/KYLIN-5827 > Project: Kylin > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: chunyan.huang >Assignee: pengfei.zhan >Priority: Major > Attachments: index-opt1.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5748) Skip build flat table for index build job if all new created indexes can be built from existed parent index
[ https://issues.apache.org/jira/browse/KYLIN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878562#comment-17878562 ] ASF GitHub Bot commented on KYLIN-5748: --- pfzhan commented on PR #2162: URL: https://github.com/apache/kylin/pull/2162#issuecomment-2324449892 @zznlime Does this pr need to be merged into the kylin code? If necessary, please send pr to @liyang-kylin . I will resolve this issue. > Skip build flat table for index build job if all new created indexes can be > built from existed parent index > --- > > Key: KYLIN-5748 > URL: https://issues.apache.org/jira/browse/KYLIN-5748 > Project: Kylin > Issue Type: Improvement >Affects Versions: 5.0-beta >Reporter: Zhenning Zhang >Assignee: Zhenning Zhang >Priority: Major > > For an index build job, if all the new added indexes can be built from their > existed parent index. No index was built from new created flat table. > For this case, there won't be any data inconsistency across indexes. And > there is no need to build a new flat table to serve the stage of index build > by layer. > So I think we can skip stage BUILD DICT and stage GENERATE FLAT TABLE for an > index build job in condition that all new added indexes can be built from > their existed parent index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-4969) Query results may be incorrect if the query filter condition contains derived dimensions
[ https://issues.apache.org/jira/browse/KYLIN-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878525#comment-17878525 ] ASF GitHub Bot commented on KYLIN-4969: --- wuzhim closed pull request #1818: KYLIN-4969 fix DerivedFilterTranslator loosen rule URL: https://github.com/apache/kylin/pull/1818 > Query results may be incorrect if the query filter condition contains derived > dimensions > > > Key: KYLIN-4969 > URL: https://issues.apache.org/jira/browse/KYLIN-4969 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: v3.1.1 >Reporter: Zhimin Wu >Assignee: Zhimin Wu >Priority: Major > Fix For: v3.1.4 > > Attachments: image-2021-04-11-16-11-03-058.png, > image-2021-04-11-16-14-10-698.png, image-2021-04-11-16-15-52-352.png, > image-2021-04-11-16-17-45-890.png, image-2021-04-11-16-21-53-243.png > > Original Estimate: 48h > Remaining Estimate: 48h > > There are three tables. > !image-2021-04-11-16-11-03-058.png|width=431,height=280! > Model as follows > !image-2021-04-11-16-14-10-698.png|width=824,height=328! > Cube as follows > !image-2021-04-11-16-15-52-352.png|width=765,height=425! > the query result on kylin > !image-2021-04-11-16-17-45-890.png|width=762,height=450! > result on hive > !image-2021-04-11-16-21-53-243.png|width=1207,height=913! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5955) Kylin Package support gluten
[
https://issues.apache.org/jira/browse/KYLIN-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878516#comment-17878516
]
ASF GitHub Bot commented on KYLIN-5955:
---
liyang-kylin merged PR #2199:
URL: https://github.com/apache/kylin/pull/2199
> Kylin Package support gluten
>
>
> Key: KYLIN-5955
> URL: https://issues.apache.org/jira/browse/KYLIN-5955
> Project: Kylin
> Issue Type: New Feature
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Major
>
> h3. update release script with gluten
> - add gluten relevant dependencies
> {code:bash}
> ./build/release/release.sh -withGluten
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5959) Support internal table for website
[ https://issues.apache.org/jira/browse/KYLIN-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878511#comment-17878511 ] ASF GitHub Bot commented on KYLIN-5959: --- liyang-kylin merged PR #2201: URL: https://github.com/apache/kylin/pull/2201 > Support internal table for website > -- > > Key: KYLIN-5959 > URL: https://issues.apache.org/jira/browse/KYLIN-5959 > Project: Kylin > Issue Type: New Feature > Components: Web , Website >Affects Versions: 5.0-beta >Reporter: huangsheng >Assignee: huangsheng >Priority: Major > Fix For: 5.0.0 > > > Support internal table for website -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5957) Fix download-async-profiler.sh
[ https://issues.apache.org/jira/browse/KYLIN-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878507#comment-17878507 ] ASF GitHub Bot commented on KYLIN-5957: --- liyang-kylin merged PR #2202: URL: https://github.com/apache/kylin/pull/2202 > Fix download-async-profiler.sh > -- > > Key: KYLIN-5957 > URL: https://issues.apache.org/jira/browse/KYLIN-5957 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > > missing `musl` related profilers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5960) Add frontend for recommendation
[ https://issues.apache.org/jira/browse/KYLIN-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878509#comment-17878509 ] ASF GitHub Bot commented on KYLIN-5960: --- liyang-kylin merged PR #2203: URL: https://github.com/apache/kylin/pull/2203 > Add frontend for recommendation > --- > > Key: KYLIN-5960 > URL: https://issues.apache.org/jira/browse/KYLIN-5960 > Project: Kylin > Issue Type: New Feature > Components: Modeling >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > Attachments: model1.png, model2.png, modeling1.png, modeling2.png, > modeling3.png, modeling4.png, project-setting1.png, project-setting2.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5960) Add frontend for recommendation
[ https://issues.apache.org/jira/browse/KYLIN-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878499#comment-17878499 ] ASF GitHub Bot commented on KYLIN-5960: --- pfzhan opened a new pull request, #2203: URL: https://github.com/apache/kylin/pull/2203 (no comment) > Add frontend for recommendation > --- > > Key: KYLIN-5960 > URL: https://issues.apache.org/jira/browse/KYLIN-5960 > Project: Kylin > Issue Type: New Feature > Components: Modeling >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5957) Fix download-async-profiler.sh
[ https://issues.apache.org/jira/browse/KYLIN-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878498#comment-17878498 ] ASF GitHub Bot commented on KYLIN-5957: --- pfzhan opened a new pull request, #2202: URL: https://github.com/apache/kylin/pull/2202 (no comment) > Fix download-async-profiler.sh > -- > > Key: KYLIN-5957 > URL: https://issues.apache.org/jira/browse/KYLIN-5957 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > > missing `musl` related profilers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5959) Support internal table for website
[ https://issues.apache.org/jira/browse/KYLIN-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878488#comment-17878488 ] ASF GitHub Bot commented on KYLIN-5959: --- Mrhs121 opened a new pull request, #2201: URL: https://github.com/apache/kylin/pull/2201 (no comment) > Support internal table for website > -- > > Key: KYLIN-5959 > URL: https://issues.apache.org/jira/browse/KYLIN-5959 > Project: Kylin > Issue Type: New Feature > Components: Web , Website >Affects Versions: 5.0-beta >Reporter: huangsheng >Assignee: huangsheng >Priority: Major > Fix For: 5.0.0 > > > Support internal table for website -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5957) Fix download-async-profiler.sh
[ https://issues.apache.org/jira/browse/KYLIN-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878026#comment-17878026 ] ASF GitHub Bot commented on KYLIN-5957: --- liyang-kylin merged PR #2200: URL: https://github.com/apache/kylin/pull/2200 > Fix download-async-profiler.sh > -- > > Key: KYLIN-5957 > URL: https://issues.apache.org/jira/browse/KYLIN-5957 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > > missing `musl` related profilers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5957) Fix download-async-profiler.sh
[ https://issues.apache.org/jira/browse/KYLIN-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878020#comment-17878020 ] ASF GitHub Bot commented on KYLIN-5957: --- pfzhan opened a new pull request, #2200: URL: https://github.com/apache/kylin/pull/2200 (no comment) > Fix download-async-profiler.sh > -- > > Key: KYLIN-5957 > URL: https://issues.apache.org/jira/browse/KYLIN-5957 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > > missing `musl` related profilers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5955) Kylin Package support gluten
[
https://issues.apache.org/jira/browse/KYLIN-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877693#comment-17877693
]
ASF GitHub Bot commented on KYLIN-5955:
---
thy950523 opened a new pull request, #2199:
URL: https://github.com/apache/kylin/pull/2199
# update release script with gluten
- add gluten relevant dependencies
```
./build/release/release.sh -withGluten
```
> Kylin Package support gluten
>
>
> Key: KYLIN-5955
> URL: https://issues.apache.org/jira/browse/KYLIN-5955
> Project: Kylin
> Issue Type: New Feature
>Reporter: zhong.zhu
>Priority: Major
>
> h3. update release script with gluten
> - add gluten relevant dependencies
> {code:bash}
> ./build/release/release.sh -withGluten
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5956) Incorrect spark.version used in `download-spark-user.sh`
[ https://issues.apache.org/jira/browse/KYLIN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877676#comment-17877676 ] ASF GitHub Bot commented on KYLIN-5956: --- liyang-kylin merged PR #2198: URL: https://github.com/apache/kylin/pull/2198 > Incorrect spark.version used in `download-spark-user.sh` > > > Key: KYLIN-5956 > URL: https://issues.apache.org/jira/browse/KYLIN-5956 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > > The file `download-spark-user.sh` uses wrong spark.version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[ https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877669#comment-17877669 ] ASF GitHub Bot commented on KYLIN-5731: --- thy950523 closed pull request #2161: KYLIN-5731 ~ KYLIN-5747 merge code into kylin5 URL: https://github.com/apache/kylin/pull/2161 > When there is a null value in the Kafka source data, the build job reports an > error > --- > > Key: KYLIN-5731 > URL: https://issues.apache.org/jira/browse/KYLIN-5731 > Project: Kylin > Issue Type: Bug >Affects Versions: 5.0-beta >Reporter: zhong.zhu >Assignee: pengfei.zhan >Priority: Minor > Fix For: 5.0.0 > > > If the field value in kafka json data is null, the task will report an error. > Null value field "clue_source_2_name":null > Field type is varchar > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5956) Incorrect spark.version used in `download-spark-user.sh`
[ https://issues.apache.org/jira/browse/KYLIN-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877668#comment-17877668 ] ASF GitHub Bot commented on KYLIN-5956: --- pfzhan opened a new pull request, #2198: URL: https://github.com/apache/kylin/pull/2198 (no comment) > Incorrect spark.version used in `download-spark-user.sh` > > > Key: KYLIN-5956 > URL: https://issues.apache.org/jira/browse/KYLIN-5956 > Project: Kylin > Issue Type: Bug > Components: Others >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > > The file `download-spark-user.sh` uses wrong spark.version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5954) optimize the startup process
[ https://issues.apache.org/jira/browse/KYLIN-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877644#comment-17877644 ] ASF GitHub Bot commented on KYLIN-5954: --- liyang-kylin merged PR #2197: URL: https://github.com/apache/kylin/pull/2197 > optimize the startup process > > > Key: KYLIN-5954 > URL: https://issues.apache.org/jira/browse/KYLIN-5954 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Major > > Remove unnecessary startup steps > Describe this addition in the manual: Skip some checks for fast startup! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5952) Support recommendation for Kylin5
[ https://issues.apache.org/jira/browse/KYLIN-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877646#comment-17877646 ] ASF GitHub Bot commented on KYLIN-5952: --- liyang-kylin merged PR #2195: URL: https://github.com/apache/kylin/pull/2195 > Support recommendation for Kylin5 > - > > Key: KYLIN-5952 > URL: https://issues.apache.org/jira/browse/KYLIN-5952 > Project: Kylin > Issue Type: New Feature > Components: Modeling >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5954) optimize the startup process
[ https://issues.apache.org/jira/browse/KYLIN-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877637#comment-17877637 ] ASF GitHub Bot commented on KYLIN-5954: --- thy950523 opened a new pull request, #2197: URL: https://github.com/apache/kylin/pull/2197 - Remove unnecessary startup steps - Describe this addition in the manual: Skip some checks for fast startup! - Co-authored-by: jiale.he Co-authored-by: junqing.cai > optimize the startup process > > > Key: KYLIN-5954 > URL: https://issues.apache.org/jira/browse/KYLIN-5954 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Major > > Remove unnecessary startup steps > Describe this addition in the manual: Skip some checks for fast startup! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5954) optimize the startup process
[ https://issues.apache.org/jira/browse/KYLIN-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877622#comment-17877622 ] ASF GitHub Bot commented on KYLIN-5954: --- thy950523 closed pull request #2196: KYLIN-5954 optimize the startup process URL: https://github.com/apache/kylin/pull/2196 > optimize the startup process > > > Key: KYLIN-5954 > URL: https://issues.apache.org/jira/browse/KYLIN-5954 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Major > > Remove unnecessary startup steps > Describe this addition in the manual: Skip some checks for fast startup! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5954) optimize the startup process
[ https://issues.apache.org/jira/browse/KYLIN-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877603#comment-17877603 ] ASF GitHub Bot commented on KYLIN-5954: --- thy950523 opened a new pull request, #2196: URL: https://github.com/apache/kylin/pull/2196 - Remove unnecessary startup steps - Describe this addition in the manual: Skip some checks for fast startup! > optimize the startup process > > > Key: KYLIN-5954 > URL: https://issues.apache.org/jira/browse/KYLIN-5954 > Project: Kylin > Issue Type: Improvement >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Major > > Remove unnecessary startup steps > Describe this addition in the manual: Skip some checks for fast startup! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-4440) IllegalStateException thrown when a query contains group by clause with case when of dimensional table columns
[
https://issues.apache.org/jira/browse/KYLIN-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877011#comment-17877011
]
ASF GitHub Bot commented on KYLIN-4440:
---
jshmchenxi closed pull request #1174: KYLIN-4440: IllegalStateException thrown
when a query contains group …
URL: https://github.com/apache/kylin/pull/1174
> IllegalStateException thrown when a query contains group by clause with case
> when of dimensional table columns
> --
>
> Key: KYLIN-4440
> URL: https://issues.apache.org/jira/browse/KYLIN-4440
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.2.0, v2.5.1, v2.6.5
>Reporter: Xi Chen
>Assignee: Yifei Wu
>Priority: Major
> Labels: calcite
>
> When a sub-query contains group by clause with case when of dimensional table
> columns, and the sub-query is joined by another sub-query, the whole query
> fails throwing java.lang.IllegalStateException.
> Example query of kylin_sales_cube:
> {code:java}
> SELECT *
> FROM
> (SELECT part_dt ,
> CASE
> WHEN buyer_id >= 10003000 THEN 'A'
> ELSE kylin_account.account_country
> END AS category ,
> sum(price) AS total_sold ,
> count(DISTINCT seller_id) AS sellers
>FROM kylin_sales
>JOIN kylin_account ON kylin_sales.buyer_id = kylin_account.account_id
>GROUP BY part_dt ,
> CASE
> WHEN buyer_id >= 10003000 THEN 'A'
> ELSE kylin_account.account_country
> END
>ORDER BY part_dt) t1
> JOIN
> (SELECT part_dt ,
> sum(price) AS total_sold ,
> count(DISTINCT seller_id) AS sellers
>FROM kylin_sales
>JOIN kylin_account ON kylin_sales.buyer_id = kylin_account.account_id
>GROUP BY part_dt
>ORDER BY part_dt) t2 ON t1.part_dt = t2.part_dt
> ORDER BY t1.part_dt DESC
> {code}
> Exception message:
> {code:java}
> RowType=7, ColumnRowType=8 while executing SQL: "SELECT * FROM ( SELECT
> part_dt , CASE WHEN buyer_id >= 10003000 THEN 'A' ELSE
> kylin_account.account_country END AS category , sum(price) AS total_sold ,
> count(DISTINCT seller_id) AS sellers FROM kylin_sales LEFT JOIN kylin_account
> ON kylin_sales.buyer_id = kylin_account.account_id GROUP BY part_dt , CASE
> WHEN buyer_id >= 10003000 THEN 'A' ELSE kylin_account.account_country END
> ORDER BY part_dt ) t1 LEFT JOIN ( SELECT part_dt , sum(price) AS total_sold ,
> count(DISTINCT seller_id) AS sellers FROM kylin_sales LEFT JOIN kylin_account
> ON kylin_sales.buyer_id = kylin_account.account_id GROUP BY part_dt ORDER BY
> part_dt ) t2 ON t1.part_dt = t2.part_dt ORDER BY t1.part_dt DESC LIMIT
> 5"{code}
> More message from kylin logs:
> {code:java}
> Caused by: java.lang.IllegalStateException: RowType=7, ColumnRowType=8
> at
> org.apache.kylin.query.relnode.OLAPJoinRel.buildColumnRowType(OLAPJoinRel.java:223)
> at
> org.apache.kylin.query.relnode.OLAPJoinRel.implementOLAP(OLAPJoinRel.java:174)
> at
> org.apache.kylin.query.relnode.OLAPRel$OLAPImplementor.visitChild(OLAPRel.java:84)
> at
> org.apache.kylin.query.relnode.OLAPSortRel.implementOLAP(OLAPSortRel.java:72)
> at
> org.apache.kylin.query.relnode.OLAPRel$OLAPImplementor.visitChild(OLAPRel.java:84)
> at
> org.apache.kylin.query.relnode.OLAPLimitRel.implementOLAP(OLAPLimitRel.java:77)
> at
> org.apache.kylin.query.relnode.OLAPRel$OLAPImplementor.visitChild(OLAPRel.java:84)
> at
> org.apache.kylin.query.relnode.OLAPToEnumerableConverter.implement(OLAPToEnumerableConverter.java:75)
> at
> org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.implementRoot(EnumerableRelImplementor.java:103)
> at
> org.apache.calcite.adapter.enumerable.EnumerableInterpretable.toBindable(EnumerableInterpretable.java:92)
> at
> org.apache.calcite.prepare.CalcitePrepareImpl$CalcitePreparingStmt.implement(CalcitePrepareImpl.java:1278)
> at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:331)
> at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:230)
> at
> org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:796)
> at
> org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:655)
> at
> org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:618)
> at
> org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:221)
> at
> org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:603)
> at
> org.apache.calcite.avatica.AvaticaConnection.p
[jira] [Commented] (KYLIN-5952) Support recommendation for Kylin5
[ https://issues.apache.org/jira/browse/KYLIN-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875728#comment-17875728 ] ASF GitHub Bot commented on KYLIN-5952: --- pfzhan opened a new pull request, #2195: URL: https://github.com/apache/kylin/pull/2195 **SQL-Based Model and Index Creation** 1. **Quick Model Creation:** Upload SQL files directly through the front-end interface to rapidly create models and generate corresponding indexes. 2. **Index Optimization Recommendations:** Leverage existing models to recommend and optimize indexes, improving query performance. 3. **Historical Query Analysis:** Generate index optimization suggestions based on query history. Select the most profitable recommendations through statistical analysis, which users can review and approve via the front-end interface. 4. **Unnecessary Index Elimination:** Use statistical insights to identify and recommend the removal of redundant indexes. 5. **Enhanced Left Join Models:** For left join models, add new dimension tables by configuring `kylin.smart.conf.model-opt-rule=append`. 6. **Optimized Aggregation Indexes:** For excluded columns, configure `kylin.smart.conf.propose-all-foreign-keys=false` to maximize the aggregation of recommended indexes. 7. **Further Configuration:** For additional recommended settings, refer to the full range of SmartConfig configurations and specific settings within the `KylinConfigBase` class. - Co-authored-by: Yifei.Wu Co-authored-by: Yifan Zhang Co-authored-by: Zhiting Guo <35057824+fre...@users.noreply.github.com> Co-authored-by: huangfeng1993 <715187...@qq.com> Co-authored-by: Junqing Cai Co-authored-by: Jiale He <965374...@qq.com> Co-authored-by: Liang.Hua <36814772+jacob...@users.noreply.github.com> Co-authored-by: lixiang <447399...@qq.com> Co-authored-by: Ruixuan Zhang Co-authored-by: lionelcao Co-authored-by: Cheng Hao Co-authored-by: xinbei Co-authored-by: bingfeng.guo <546745...@qq.com> Co-authored-by: lxian2shell > Support recommendation for Kylin5 > - > > Key: KYLIN-5952 > URL: https://issues.apache.org/jira/browse/KYLIN-5952 > Project: Kylin > Issue Type: New Feature > Components: Modeling >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5953) Minor bugs of InternalTable [FollowUp KYLIN-5948]
[ https://issues.apache.org/jira/browse/KYLIN-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875720#comment-17875720 ] ASF GitHub Bot commented on KYLIN-5953: --- liyang-kylin merged PR #2194: URL: https://github.com/apache/kylin/pull/2194 > Minor bugs of InternalTable [FollowUp KYLIN-5948] > - > > Key: KYLIN-5953 > URL: https://issues.apache.org/jira/browse/KYLIN-5953 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > Attachments: 5953.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5953) Minor bugs of InternalTable [FollowUp KYLIN-5948]
[ https://issues.apache.org/jira/browse/KYLIN-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875396#comment-17875396 ] ASF GitHub Bot commented on KYLIN-5953: --- pfzhan opened a new pull request, #2194: URL: https://github.com/apache/kylin/pull/2194 1. Add table properties for internal table list 2. Optimized delta delete 3. Restore build script 4. Skip validation only if source table is empty 5. Optimized the execution time of deletion tasks 6. Set jobName for internal table job 7. Bugfix empty internal table update - Co-authored-by: Zhiting Guo Co-authored-by: huangsheng Co-authored-by: Zhimin Wu <596361...@qq.com> Co-authored-by: 7mming7 <7mmi...@gmail.com> > Minor bugs of InternalTable [FollowUp KYLIN-5948] > - > > Key: KYLIN-5953 > URL: https://issues.apache.org/jira/browse/KYLIN-5953 > Project: Kylin > Issue Type: Bug > Components: Query Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5949) Support DeltaLake as Index storage
[
https://issues.apache.org/jira/browse/KYLIN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871020#comment-17871020
]
ASF GitHub Bot commented on KYLIN-5949:
---
liyang-kylin merged PR #2190:
URL: https://github.com/apache/kylin/pull/2190
> Support DeltaLake as Index storage
> --
>
> Key: KYLIN-5949
> URL: https://issues.apache.org/jira/browse/KYLIN-5949
> Project: Kylin
> Issue Type: New Feature
> Components: Job Engine, Query Engine
>Affects Versions: 5.0.0
>Reporter: pengfei.zhan
>Assignee: Zhimin Wu
>Priority: Major
> Fix For: 5.0.0
>
> Attachments: image-2024-08-05-17-48-53-286.png, image.png
>
>
> h3. 设计目标
> # Segment逻辑化：取消Segment管理索引数据的设定，Segment只保留逻辑概念
> # 索引存储为表：根据索引类型的不同，设定不同的表类型，索引表化可以更好的利用查询引擎对于表处理的能力
> # 索引存储类型可扩展：默认存储从Parquet替换为Delta Lake，同时可以支持Iceberg以及Hudi的快速替换
> # 构建和查询的运行时参数动态调整：按照索引的特性，在运行时(构建和查询)动态调整执行引擎参数
> # 查询效果的稳定：无论是早期还是近期数据，应该保持相对一致的查询性能
> # 索引定向优化的能力：能够根据特定的查询，定向优化相对应的索引，能够对特定查询极致加速
> h3. 存储格式的变化
> h4. 原 Segment + parquet 存储
> {code:java}
> # V1 Cube结果数据文件结构
> parquet/
> └── dc65dd61-dbe3-8f46-7d44-668b688b96c1 (模型 ID)
> └── 12d2c4c1-248f-b1f8-0bdb-88b0eb9c8580 （Segment ID）
> ├── 1 (聚合索引ID)
> │ └──
> part-0-393b8b08-84fc-40c6-8c2e-d579485dcc57-c000.snappy.parquet（数据）
> ├── 10001
> ├── 20001
> ├── 30001
> ├── 40001
> └── 201（明细索引ID）{code}
> h4. V3文件格式 - 数据由 delta lake 组织，以 Parquet 形式存储
> !image-2024-08-05-17-48-53-286.png|width=666,height=391!
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5950) Fix local debug mode
[ https://issues.apache.org/jira/browse/KYLIN-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870996#comment-17870996 ] ASF GitHub Bot commented on KYLIN-5950: --- liyang-kylin merged PR #2192: URL: https://github.com/apache/kylin/pull/2192 > Fix local debug mode > > > Key: KYLIN-5950 > URL: https://issues.apache.org/jira/browse/KYLIN-5950 > Project: Kylin > Issue Type: Bug > Components: Metadata >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Minor > Fix For: 5.0.0 > > > The local debug mode can not work -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5950) Fix local debug mode
[ https://issues.apache.org/jira/browse/KYLIN-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870994#comment-17870994 ] ASF GitHub Bot commented on KYLIN-5950: --- liyang-kylin merged PR #2191: URL: https://github.com/apache/kylin/pull/2191 > Fix local debug mode > > > Key: KYLIN-5950 > URL: https://issues.apache.org/jira/browse/KYLIN-5950 > Project: Kylin > Issue Type: Bug > Components: Metadata >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Minor > Fix For: 5.0.0 > > > The local debug mode can not work -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5950) Fix local debug mode
[ https://issues.apache.org/jira/browse/KYLIN-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870558#comment-17870558 ] ASF GitHub Bot commented on KYLIN-5950: --- pfzhan opened a new pull request, #2192: URL: https://github.com/apache/kylin/pull/2192 (no comment) > Fix local debug mode > > > Key: KYLIN-5950 > URL: https://issues.apache.org/jira/browse/KYLIN-5950 > Project: Kylin > Issue Type: Bug > Components: Metadata >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Minor > Fix For: 5.0.0 > > > The local debug mode can not work -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5950) Fix local debug mode
[ https://issues.apache.org/jira/browse/KYLIN-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870534#comment-17870534 ] ASF GitHub Bot commented on KYLIN-5950: --- pfzhan opened a new pull request, #2191: URL: https://github.com/apache/kylin/pull/2191 (no comment) > Fix local debug mode > > > Key: KYLIN-5950 > URL: https://issues.apache.org/jira/browse/KYLIN-5950 > Project: Kylin > Issue Type: Bug > Components: Metadata >Affects Versions: 5.0-alpha >Reporter: pengfei.zhan >Assignee: pengfei.zhan >Priority: Minor > Fix For: 5.0.0 > > > The local debug mode can not work -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5949) Support DeltaLake as Index storage
[ https://issues.apache.org/jira/browse/KYLIN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870389#comment-17870389 ] ASF GitHub Bot commented on KYLIN-5949: --- pfzhan opened a new pull request, #2190: URL: https://github.com/apache/kylin/pull/2190 1. Support Delta Lake as Index storage. 2. When querying, you can choose to cache the Delta Log on the driver or in RDD Cache mode. 3. V1 and V3 storage is isolated at the model level. 4. Data storage is no longer divided into segments. 5. Query storage optimization can be performed at the index level. > Support DeltaLake as Index storage > -- > > Key: KYLIN-5949 > URL: https://issues.apache.org/jira/browse/KYLIN-5949 > Project: Kylin > Issue Type: New Feature > Components: Job Engine, Query Engine >Affects Versions: 5.0.0 >Reporter: pengfei.zhan >Assignee: Zhimin Wu >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5947) Remove useless phantomjs-prebuilt
[
https://issues.apache.org/jira/browse/KYLIN-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870312#comment-17870312
]
ASF GitHub Bot commented on KYLIN-5947:
---
liyang-kylin merged PR #2189:
URL: https://github.com/apache/kylin/pull/2189
> Remove useless phantomjs-prebuilt
> -
>
> Key: KYLIN-5947
> URL: https://issues.apache.org/jira/browse/KYLIN-5947
> Project: Kylin
> Issue Type: Bug
> Components: Others
>Affects Versions: 5.0-alpha
>Reporter: pengfei.zhan
>Assignee: pengfei.zhan
>Priority: Minor
> Fix For: 5.0.0
>
> Attachments: npm_install.jpg
>
>
> Cannot download phantomjs-prebuilt
> {code:text}
> npm install --registry=https://registry.npmjs.org/ --legacy-peer-deps
> npm WARN deprecated phantomjs-prebuilt@2.1.16: this package is now deprecated
> > phantomjs-prebuilt@2.1.16 install
> > /Users/pengfei.zhan/projs/kylin/kystudio/node_modules/phantomjs-prebuilt
> > node install.js
> PhantomJS not found on PATH
> Downloading
> https://npm.taobao.org/mirrors/phantomjs//phantomjs-2.1.1-macosx.zip
> Saving to
> /var/folders/64/l8nwrqvj619btwr5hqkph3zmrkd2ql/T/phantomjs/phantomjs-2.1.1-macosx.zip
> Receiving...
> Error making request.
> Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match
> certificate's altnames: Host: npm.taobao.org. is not in the cert's altnames:
> DNS:*.tbcdn.cn, DNS:*.taobao.com, DNS:*.alicdn.com,
> DNS:*.cmos.greencompute.org, DNS:cmos.greencompute.org,
> DNS:m.intl.taobao.com, DNS:*.mobgslb.tbcache.com, DNS:*.alikunlun.com,
> DNS:alikunlun.com, DNS:*.django.t.taobao.com, DNS:alicdn.com,
> DNS:*.tbcache.com, DNS:*.tmall.com, DNS:*.1688.com, DNS:*.3c.tmall.com,
> DNS:*.alibaba.com, DNS:*.aliexpress.com, DNS:*.aliqin.tmall.com,
> DNS:*.alitrip.com, DNS:*.aliyun.com, DNS:*.cainiao.com, DNS:*.cainiao.com.cn,
> DNS:*.chi.taobao.com, DNS:*.chi.tmall.com, DNS:*.china.taobao.com,
> DNS:*.dingtalk.com, DNS:*.etao.com, DNS:*.feizhu.cn, DNS:*.feizhu.com,
> DNS:*.fliggy.com, DNS:*.fliggy.hk, DNS:*.food.tmall.com,
> DNS:*.jia.taobao.com, DNS:*.jia.tmall.com, DNS:*.ju.taobao.com,
> DNS:*.juhuasuan.com, DNS:*.lw.aliimg.com, DNS:*.m.1688.com,
> DNS:*.m.alibaba.com, DNS:*.m.alitrip.com, DNS:*.m.cainiao.com,
> DNS:*.m.etao.com, DNS:*.m.taobao.com, DNS:*.m.taopiaopiao.com,
> DNS:*.m.tmall.com, DNS:*.m.tmall.hk, DNS:*.mei.com, DNS:*.taopiaopiao.com,
> DNS:*.tmall.hk, DNS:*.trip.taobao.com, DNS:*.xiami.com, DNS:1688.com,
> DNS:alibaba.com, DNS:aliexpress.com, DNS:alitrip.com, DNS:aliyun.com,
> DNS:cainiao.com, DNS:cainiao.com.cn, DNS:dingtalk.com, DNS:etao.com,
> DNS:feizhu.cn, DNS:feizhu.com, DNS:fliggy.com, DNS:fliggy.hk,
> DNS:juhuasuan.com, DNS:mei.com, DNS:taobao.com, DNS:taopiaopiao.com,
> DNS:tmall.hk, DNS:xiami.com, DNS:tmall.com, DNS:*.cloudvideocdn.taobao.com,
> DNS:cloudvideocdn.taobao.com, DNS:tbcdn.cn
> at new NodeError (internal/errors.js:322:7)
> at Object.checkServerIdentity (tls.js:347:12)
> at TLSSocket.onConnectSecure (_tls_wrap.js:1525:27)
> at TLSSocket.emit (events.js:400:28)
> at TLSSocket._finishInit (_tls_wrap.js:937:8)
> at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:709:12)
> Please report this full log at https://github.com/Medium/phantomjs
> npm WARN ajv-keywords@2.1.1 requires a peer of ajv@^5.0.0 but none is
> installed. You must install peer dependencies yourself.
> npm WARN eslint-loader@4.0.2 requires a peer of eslint@^6.0.0 || ^7.0.0 but
> none is installed. You must install peer dependencies yourself.
> npm WARN eslint-loader@4.0.2 requires a peer of webpack@^4.0.0 || ^5.0.0 but
> none is installed. You must install peer dependencies yourself.
> npm WARN vue-virtual-scroller@1.1.2 requires a peer of vue@^2.6.11 but none
> is installed. You must install peer dependencies yourself.
> npm ERR! code ELIFECYCLE
> npm ERR! errno 1
> npm ERR! phantomjs-prebuilt@2.1.16 install: node install.js
> npm ERR! Exit status 1
> npm ERR!
> npm ERR! Failed at the phantomjs-prebuilt@2.1.16 install script.
> npm ERR! This is probably not a problem with npm. There is likely additional
> logging ou
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5947) Remove useless phantomjs-prebuilt
[
https://issues.apache.org/jira/browse/KYLIN-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870127#comment-17870127
]
ASF GitHub Bot commented on KYLIN-5947:
---
pfzhan opened a new pull request, #2189:
URL: https://github.com/apache/kylin/pull/2189
(no comment)
> Remove useless phantomjs-prebuilt
> -
>
> Key: KYLIN-5947
> URL: https://issues.apache.org/jira/browse/KYLIN-5947
> Project: Kylin
> Issue Type: Bug
> Components: Others
>Affects Versions: 5.0-alpha
>Reporter: pengfei.zhan
>Assignee: pengfei.zhan
>Priority: Minor
> Fix For: 5.0.0
>
> Attachments: npm_install.jpg
>
>
> Cannot download phantomjs-prebuilt
> {code:text}
> npm install --registry=https://registry.npmjs.org/ --legacy-peer-deps
> npm WARN deprecated phantomjs-prebuilt@2.1.16: this package is now deprecated
> > phantomjs-prebuilt@2.1.16 install
> > /Users/pengfei.zhan/projs/kylin/kystudio/node_modules/phantomjs-prebuilt
> > node install.js
> PhantomJS not found on PATH
> Downloading
> https://npm.taobao.org/mirrors/phantomjs//phantomjs-2.1.1-macosx.zip
> Saving to
> /var/folders/64/l8nwrqvj619btwr5hqkph3zmrkd2ql/T/phantomjs/phantomjs-2.1.1-macosx.zip
> Receiving...
> Error making request.
> Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match
> certificate's altnames: Host: npm.taobao.org. is not in the cert's altnames:
> DNS:*.tbcdn.cn, DNS:*.taobao.com, DNS:*.alicdn.com,
> DNS:*.cmos.greencompute.org, DNS:cmos.greencompute.org,
> DNS:m.intl.taobao.com, DNS:*.mobgslb.tbcache.com, DNS:*.alikunlun.com,
> DNS:alikunlun.com, DNS:*.django.t.taobao.com, DNS:alicdn.com,
> DNS:*.tbcache.com, DNS:*.tmall.com, DNS:*.1688.com, DNS:*.3c.tmall.com,
> DNS:*.alibaba.com, DNS:*.aliexpress.com, DNS:*.aliqin.tmall.com,
> DNS:*.alitrip.com, DNS:*.aliyun.com, DNS:*.cainiao.com, DNS:*.cainiao.com.cn,
> DNS:*.chi.taobao.com, DNS:*.chi.tmall.com, DNS:*.china.taobao.com,
> DNS:*.dingtalk.com, DNS:*.etao.com, DNS:*.feizhu.cn, DNS:*.feizhu.com,
> DNS:*.fliggy.com, DNS:*.fliggy.hk, DNS:*.food.tmall.com,
> DNS:*.jia.taobao.com, DNS:*.jia.tmall.com, DNS:*.ju.taobao.com,
> DNS:*.juhuasuan.com, DNS:*.lw.aliimg.com, DNS:*.m.1688.com,
> DNS:*.m.alibaba.com, DNS:*.m.alitrip.com, DNS:*.m.cainiao.com,
> DNS:*.m.etao.com, DNS:*.m.taobao.com, DNS:*.m.taopiaopiao.com,
> DNS:*.m.tmall.com, DNS:*.m.tmall.hk, DNS:*.mei.com, DNS:*.taopiaopiao.com,
> DNS:*.tmall.hk, DNS:*.trip.taobao.com, DNS:*.xiami.com, DNS:1688.com,
> DNS:alibaba.com, DNS:aliexpress.com, DNS:alitrip.com, DNS:aliyun.com,
> DNS:cainiao.com, DNS:cainiao.com.cn, DNS:dingtalk.com, DNS:etao.com,
> DNS:feizhu.cn, DNS:feizhu.com, DNS:fliggy.com, DNS:fliggy.hk,
> DNS:juhuasuan.com, DNS:mei.com, DNS:taobao.com, DNS:taopiaopiao.com,
> DNS:tmall.hk, DNS:xiami.com, DNS:tmall.com, DNS:*.cloudvideocdn.taobao.com,
> DNS:cloudvideocdn.taobao.com, DNS:tbcdn.cn
> at new NodeError (internal/errors.js:322:7)
> at Object.checkServerIdentity (tls.js:347:12)
> at TLSSocket.onConnectSecure (_tls_wrap.js:1525:27)
> at TLSSocket.emit (events.js:400:28)
> at TLSSocket._finishInit (_tls_wrap.js:937:8)
> at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:709:12)
> Please report this full log at https://github.com/Medium/phantomjs
> npm WARN ajv-keywords@2.1.1 requires a peer of ajv@^5.0.0 but none is
> installed. You must install peer dependencies yourself.
> npm WARN eslint-loader@4.0.2 requires a peer of eslint@^6.0.0 || ^7.0.0 but
> none is installed. You must install peer dependencies yourself.
> npm WARN eslint-loader@4.0.2 requires a peer of webpack@^4.0.0 || ^5.0.0 but
> none is installed. You must install peer dependencies yourself.
> npm WARN vue-virtual-scroller@1.1.2 requires a peer of vue@^2.6.11 but none
> is installed. You must install peer dependencies yourself.
> npm ERR! code ELIFECYCLE
> npm ERR! errno 1
> npm ERR! phantomjs-prebuilt@2.1.16 install: node install.js
> npm ERR! Exit status 1
> npm ERR!
> npm ERR! Failed at the phantomjs-prebuilt@2.1.16 install script.
> npm ERR! This is probably not a problem with npm. There is likely additional
> logging ou
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-4780) Refactor AbstractExecutable to extract the notification relevant business logic into a single component
[ https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865756#comment-17865756 ] ASF GitHub Bot commented on KYLIN-4780: --- codecov-commenter commented on PR #1596: URL: https://github.com/apache/kylin/pull/1596#issuecomment-2227270754 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1596?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `15.61562%` with `281 lines` in your changes missing coverage. Please review. > Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`kylin3@69368b0`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files](https://app.codecov.io/gh/apache/kylin/pull/1596?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/kylin/common/notify/DingTalkService.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FDingTalkService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvRGluZ1RhbGtTZXJ2aWNlLmphdmE=) | 0.00% | [62 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/kylin/common/notify/NotificationContext.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FNotificationContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uQ29udGV4dC5qYXZh) | 0.00% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/kylin/common/notify/NotificationTransmitter.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FNotificationTransmitter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uVHJhbnNtaXR0ZXIuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/kylin/rest/service/MigrationService.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=cube-migration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FMigrationService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3ViZS1taWdyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9NaWdyYXRpb25TZXJ2aWNlLmphdmE=) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/kylin/common/notify/MailService.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FMailService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTWFpbFNlcnZpY2UuamF2YQ==) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FCubingJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el
[jira] [Commented] (KYLIN-5848) Module refactor - make query/job/meta service standalone
[ https://issues.apache.org/jira/browse/KYLIN-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854979#comment-17854979 ] ASF GitHub Bot commented on KYLIN-5848: --- liyang-kylin merged PR #2182: URL: https://github.com/apache/kylin/pull/2182 > Module refactor - make query/job/meta service standalone > > > Key: KYLIN-5848 > URL: https://issues.apache.org/jira/browse/KYLIN-5848 > Project: Kylin > Issue Type: Improvement >Reporter: Yifan Zhang >Priority: Major > > Module refactor - make query/job/meta service standalone > Prepare for next-gen architecture -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5848) Module refactor - make query/job/meta service standalone
[ https://issues.apache.org/jira/browse/KYLIN-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854355#comment-17854355 ] ASF GitHub Bot commented on KYLIN-5848: --- eventd commented on PR #2182: URL: https://github.com/apache/kylin/pull/2182#issuecomment-2162585671 https://opencicd.kyligence.com/blue/organizations/jenkins/OpenSource%2FKylin-CI/detail/Kylin-CI/106/pipeline/ > Module refactor - make query/job/meta service standalone > > > Key: KYLIN-5848 > URL: https://issues.apache.org/jira/browse/KYLIN-5848 > Project: Kylin > Issue Type: Improvement >Reporter: Yifan Zhang >Priority: Major > > Module refactor - make query/job/meta service standalone > Prepare for next-gen architecture -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5848) Module refactor - make query/job/meta service standalone
[ https://issues.apache.org/jira/browse/KYLIN-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854354#comment-17854354 ] ASF GitHub Bot commented on KYLIN-5848: --- eventd opened a new pull request, #2182: URL: https://github.com/apache/kylin/pull/2182 (no comment) > Module refactor - make query/job/meta service standalone > > > Key: KYLIN-5848 > URL: https://issues.apache.org/jira/browse/KYLIN-5848 > Project: Kylin > Issue Type: Improvement >Reporter: Yifan Zhang >Priority: Major > > Module refactor - make query/job/meta service standalone > Prepare for next-gen architecture -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5823) improve text recognition dialog of add batch dimensions
[ https://issues.apache.org/jira/browse/KYLIN-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835995#comment-17835995 ] ASF GitHub Bot commented on KYLIN-5823: --- liyang-kylin merged PR #2180: URL: https://github.com/apache/kylin/pull/2180 > improve text recognition dialog of add batch dimensions > --- > > Key: KYLIN-5823 > URL: https://issues.apache.org/jira/browse/KYLIN-5823 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > Attachments: image-2024-04-11-11-42-40-903.png, > image-2024-04-11-11-43-11-768.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5825) fix aggregate modal and table index modal ui and fix chrome 50 layout bug
[ https://issues.apache.org/jira/browse/KYLIN-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835993#comment-17835993 ] ASF GitHub Bot commented on KYLIN-5825: --- liyang-kylin merged PR #2176: URL: https://github.com/apache/kylin/pull/2176 > fix aggregate modal and table index modal ui and fix chrome 50 layout bug > - > > Key: KYLIN-5825 > URL: https://issues.apache.org/jira/browse/KYLIN-5825 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > Attachments: image-2024-04-11-12-00-01-336.png, > image-2024-04-11-12-00-56-539.png, image-2024-04-11-12-02-44-264.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5823) improve text recognition dialog of add batch dimensions
[ https://issues.apache.org/jira/browse/KYLIN-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835980#comment-17835980 ] ASF GitHub Bot commented on KYLIN-5823: --- anyisky opened a new pull request, #2180: URL: https://github.com/apache/kylin/pull/2180 (no comment) > improve text recognition dialog of add batch dimensions > --- > > Key: KYLIN-5823 > URL: https://issues.apache.org/jira/browse/KYLIN-5823 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > Attachments: image-2024-04-11-11-42-40-903.png, > image-2024-04-11-11-43-11-768.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5822) support history table adds left-closed and right-closed time interval
[ https://issues.apache.org/jira/browse/KYLIN-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835929#comment-17835929 ] ASF GitHub Bot commented on KYLIN-5822: --- liyang-kylin merged PR #2178: URL: https://github.com/apache/kylin/pull/2178 > support history table adds left-closed and right-closed time interval > - > > Key: KYLIN-5822 > URL: https://issues.apache.org/jira/browse/KYLIN-5822 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5824) refine handel error for export models
[ https://issues.apache.org/jira/browse/KYLIN-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835925#comment-17835925 ] ASF GitHub Bot commented on KYLIN-5824: --- liyang-kylin merged PR #2175: URL: https://github.com/apache/kylin/pull/2175 > refine handel error for export models > - > > Key: KYLIN-5824 > URL: https://issues.apache.org/jira/browse/KYLIN-5824 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > The system reports error when the number of models exceeds 256 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5823) improve text recognition dialog of add batch dimensions
[ https://issues.apache.org/jira/browse/KYLIN-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835923#comment-17835923 ] ASF GitHub Bot commented on KYLIN-5823: --- liyang-kylin merged PR #2174: URL: https://github.com/apache/kylin/pull/2174 > improve text recognition dialog of add batch dimensions > --- > > Key: KYLIN-5823 > URL: https://issues.apache.org/jira/browse/KYLIN-5823 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5826) fix table index select all issue and fix load user or usergroup list filter issue
[ https://issues.apache.org/jira/browse/KYLIN-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835927#comment-17835927 ] ASF GitHub Bot commented on KYLIN-5826: --- liyang-kylin merged PR #2177: URL: https://github.com/apache/kylin/pull/2177 > fix table index select all issue and fix load user or usergroup list filter > issue > - > > Key: KYLIN-5826 > URL: https://issues.apache.org/jira/browse/KYLIN-5826 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Critical > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5821) fix model edit page pfk flag bug and enhance model canvas window position
[ https://issues.apache.org/jira/browse/KYLIN-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835921#comment-17835921 ] ASF GitHub Bot commented on KYLIN-5821: --- liyang-kylin merged PR #2172: URL: https://github.com/apache/kylin/pull/2172 > fix model edit page pfk flag bug and enhance model canvas window position > - > > Key: KYLIN-5821 > URL: https://issues.apache.org/jira/browse/KYLIN-5821 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5819) optimize the warning message on the dialog for editing computed column
[ https://issues.apache.org/jira/browse/KYLIN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835919#comment-17835919 ] ASF GitHub Bot commented on KYLIN-5819: --- liyang-kylin merged PR #2170: URL: https://github.com/apache/kylin/pull/2170 > optimize the warning message on the dialog for editing computed column > -- > > Key: KYLIN-5819 > URL: https://issues.apache.org/jira/browse/KYLIN-5819 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5813) improve query history page filter item and model list page button text
[ https://issues.apache.org/jira/browse/KYLIN-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835095#comment-17835095 ] ASF GitHub Bot commented on KYLIN-5813: --- liyang-kylin merged PR #2169: URL: https://github.com/apache/kylin/pull/2169 > improve query history page filter item and model list page button text > -- > > Key: KYLIN-5813 > URL: https://issues.apache.org/jira/browse/KYLIN-5813 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Major > Fix For: 5.0.0 > > Attachments: image-2024-04-09-09-38-42-450.png, > image-2024-04-09-09-39-13-571.png, image-2024-04-09-09-39-40-593.png, > image-2024-04-09-09-44-16-515.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5820) added pagination and add count distinct function in batch measure dialog
[ https://issues.apache.org/jira/browse/KYLIN-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835097#comment-17835097 ] ASF GitHub Bot commented on KYLIN-5820: --- liyang-kylin merged PR #2171: URL: https://github.com/apache/kylin/pull/2171 > added pagination and add count distinct function in batch measure dialog > - > > Key: KYLIN-5820 > URL: https://issues.apache.org/jira/browse/KYLIN-5820 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Critical > Fix For: 5.0.0 > > Attachments: image-2024-04-09-09-54-05-858.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5822) scd issue
[ https://issues.apache.org/jira/browse/KYLIN-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834508#comment-17834508 ] ASF GitHub Bot commented on KYLIN-5822: --- anyisky opened a new pull request, #2178: URL: https://github.com/apache/kylin/pull/2178 (no comment) > scd issue > - > > Key: KYLIN-5822 > URL: https://issues.apache.org/jira/browse/KYLIN-5822 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > Unable to save after modifying the Shardby column of the existing table index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5822) only edit shardby disable save issue
[ https://issues.apache.org/jira/browse/KYLIN-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834504#comment-17834504 ] ASF GitHub Bot commented on KYLIN-5822: --- anyisky closed pull request #2173: KYLIN-5822,only edit shardby disable save issue(cp from 4.6.16) URL: https://github.com/apache/kylin/pull/2173 > only edit shardby disable save issue > > > Key: KYLIN-5822 > URL: https://issues.apache.org/jira/browse/KYLIN-5822 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > Unable to save after modifying the Shardby column of the existing table index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5826) fix table index select all issue and fix load user or usergroup list filter issue
[ https://issues.apache.org/jira/browse/KYLIN-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834497#comment-17834497 ] ASF GitHub Bot commented on KYLIN-5826: --- anyisky opened a new pull request, #2177: URL: https://github.com/apache/kylin/pull/2177 …group list filter issue > fix table index select all issue and fix load user or usergroup list filter > issue > - > > Key: KYLIN-5826 > URL: https://issues.apache.org/jira/browse/KYLIN-5826 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Critical > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5825) clear all mandatory
[ https://issues.apache.org/jira/browse/KYLIN-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834228#comment-17834228 ] ASF GitHub Bot commented on KYLIN-5825: --- anyisky opened a new pull request, #2176: URL: https://github.com/apache/kylin/pull/2176 (no comment) > clear all mandatory > --- > > Key: KYLIN-5825 > URL: https://issues.apache.org/jira/browse/KYLIN-5825 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > Support clearing required dimensions -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5824) refine handel error for export models
[ https://issues.apache.org/jira/browse/KYLIN-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834221#comment-17834221 ] ASF GitHub Bot commented on KYLIN-5824: --- anyisky opened a new pull request, #2175: URL: https://github.com/apache/kylin/pull/2175 (no comment) > refine handel error for export models > - > > Key: KYLIN-5824 > URL: https://issues.apache.org/jira/browse/KYLIN-5824 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > The system reports error when the number of models exceeds 256 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5823) recognize add dimensions for model edit and text Recognize table index issue
[ https://issues.apache.org/jira/browse/KYLIN-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834213#comment-17834213 ] ASF GitHub Bot commented on KYLIN-5823: --- anyisky opened a new pull request, #2174: URL: https://github.com/apache/kylin/pull/2174 …e table index issue > recognize add dimensions for model edit and text Recognize table index issue > - > > Key: KYLIN-5823 > URL: https://issues.apache.org/jira/browse/KYLIN-5823 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > feature: > Support adding dimensions in batches using the text recognition function when > setting dimensions on the model editing page > bug: > When adding a table index, the text recognition function cannot be used to > identify the columns contained in the measure -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5822) only edit shardby disable save issue
[ https://issues.apache.org/jira/browse/KYLIN-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834201#comment-17834201 ] ASF GitHub Bot commented on KYLIN-5822: --- anyisky opened a new pull request, #2173: URL: https://github.com/apache/kylin/pull/2173 (no comment) > only edit shardby disable save issue > > > Key: KYLIN-5822 > URL: https://issues.apache.org/jira/browse/KYLIN-5822 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > Fix For: 5.0.0 > > > Unable to save after modifying the Shardby column of the existing table index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5821) refine setTableInView issue
[ https://issues.apache.org/jira/browse/KYLIN-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834191#comment-17834191 ] ASF GitHub Bot commented on KYLIN-5821: --- anyisky opened a new pull request, #2172: URL: https://github.com/apache/kylin/pull/2172 (no comment) > refine setTableInView issue > --- > > Key: KYLIN-5821 > URL: https://issues.apache.org/jira/browse/KYLIN-5821 > Project: Kylin > Issue Type: Bug >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > > On the model editing page, the positioning of the "Show Table" function in > the search bar is not accurate -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5820) batch add measures issue
[ https://issues.apache.org/jira/browse/KYLIN-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834187#comment-17834187 ] ASF GitHub Bot commented on KYLIN-5820: --- anyisky opened a new pull request, #2171: URL: https://github.com/apache/kylin/pull/2171 (no comment) > batch add measures issue > > > Key: KYLIN-5820 > URL: https://issues.apache.org/jira/browse/KYLIN-5820 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Critical > > h1. Batch adding measure pages supports paging display columns to optimize > the page response performance when there are too many columns -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5819) edit cc tips issue
[ https://issues.apache.org/jira/browse/KYLIN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834172#comment-17834172 ] ASF GitHub Bot commented on KYLIN-5819: --- anyisky opened a new pull request, #2170: URL: https://github.com/apache/kylin/pull/2170 (no comment) > edit cc tips issue > -- > > Key: KYLIN-5819 > URL: https://issues.apache.org/jira/browse/KYLIN-5819 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Minor > > h1. Optimize the copywriting tips that will clear the relevant indexes after > modifying the expression of the computed column -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5813) history filter issue
[ https://issues.apache.org/jira/browse/KYLIN-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834162#comment-17834162 ] ASF GitHub Bot commented on KYLIN-5813: --- anyisky opened a new pull request, #2169: URL: https://github.com/apache/kylin/pull/2169 (no comment) > history filter issue > > > Key: KYLIN-5813 > URL: https://issues.apache.org/jira/browse/KYLIN-5813 > Project: Kylin > Issue Type: Improvement >Reporter: chunyan.huang >Assignee: chunyan.huang >Priority: Major > Fix For: 5.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5748) Skip build flat table for index build job if all new created indexes can be built from existed parent index
[ https://issues.apache.org/jira/browse/KYLIN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831024#comment-17831024 ] ASF GitHub Bot commented on KYLIN-5748: --- Mrhs121 commented on PR #2162: URL: https://github.com/apache/kylin/pull/2162#issuecomment-2021131685 Your proposal will be invalid in this use case: if you add a new bitmap type metric to the model, you can build the new index separately, and the task type is also INDEX_BUIDL. If you skip building the dictionary, an error will occur when generating encoding columns for the flat table later. > Skip build flat table for index build job if all new created indexes can be > built from existed parent index > --- > > Key: KYLIN-5748 > URL: https://issues.apache.org/jira/browse/KYLIN-5748 > Project: Kylin > Issue Type: Improvement >Affects Versions: 5.0-beta >Reporter: Zhenning Zhang >Assignee: Zhenning Zhang >Priority: Major > > For an index build job, if all the new added indexes can be built from their > existed parent index. No index was built from new created flat table. > For this case, there won't be any data inconsistency across indexes. And > there is no need to build a new flat table to serve the stage of index build > by layer. > So I think we can skip stage BUILD DICT and stage GENERATE FLAT TABLE for an > index build job in condition that all new added indexes can be built from > their existed parent index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-4413) Add canary tool to Kylin
[ https://issues.apache.org/jira/browse/KYLIN-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826955#comment-17826955 ] ASF GitHub Bot commented on KYLIN-4413: --- zhoukangcn closed pull request #1152: KYLIN-4413: add canary tool URL: https://github.com/apache/kylin/pull/1152 > Add canary tool to Kylin > > > Key: KYLIN-4413 > URL: https://issues.apache.org/jira/browse/KYLIN-4413 > Project: Kylin > Issue Type: Improvement >Reporter: ZhouKang >Priority: Major > > Canary tool can be used to detect service availability, and also can detect > query latency. > Many other hadoop system has canary, such as HBase and HDFS. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-4227) add segment build callback
[ https://issues.apache.org/jira/browse/KYLIN-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826954#comment-17826954 ] ASF GitHub Bot commented on KYLIN-4227: --- zhoukangcn closed pull request #1008: KYLIN-4227: add segment build callback URL: https://github.com/apache/kylin/pull/1008 > add segment build callback > -- > > Key: KYLIN-4227 > URL: https://issues.apache.org/jira/browse/KYLIN-4227 > Project: Kylin > Issue Type: New Feature >Reporter: ZhouKang >Priority: Major > Attachments: 1.png, 2.png > > > add HTTP callback for cube, some other system could use this feature to add a > hook when segment building done. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5386) 使用Segment元数据完成部分数据过滤加速长时间范围数据查询
[ https://issues.apache.org/jira/browse/KYLIN-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808862#comment-17808862 ] ASF GitHub Bot commented on KYLIN-5386: --- hit-lacus closed pull request #2069: KYLIN-5386 segment过滤完成时间分区过滤从而提升cuboid的查询粒度 URL: https://github.com/apache/kylin/pull/2069 > 使用Segment元数据完成部分数据过滤加速长时间范围数据查询 > --- > > Key: KYLIN-5386 > URL: https://issues.apache.org/jira/browse/KYLIN-5386 > Project: Kylin > Issue Type: New Feature > Components: Query Engine >Affects Versions: v4.0.3 >Reporter: xjlem >Priority: Major > Attachments: KYLIN-5386.v4.0.3-release.001.patch > > > Query中分区字段影响segement过滤，为此查询中会带上分区字段作限制，但分区字段将会影响cuboid选择，使得cuboid始终是天粒度。为此我们使用segment的元数据信息满足查询的过滤，可以通过segment元数据进行过滤的部分将使用更粗粒度的cuboid进行聚合查询。 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5748) Skip build flat table for index build job if all new created indexes can be built from existed parent index
[ https://issues.apache.org/jira/browse/KYLIN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800428#comment-17800428 ] ASF GitHub Bot commented on KYLIN-5748: --- zznlime commented on PR #2162: URL: https://github.com/apache/kylin/pull/2162#issuecomment-1869324455 @hit-lacus PTAL, Thanks > Skip build flat table for index build job if all new created indexes can be > built from existed parent index > --- > > Key: KYLIN-5748 > URL: https://issues.apache.org/jira/browse/KYLIN-5748 > Project: Kylin > Issue Type: Improvement >Affects Versions: 5.0-beta >Reporter: Zhenning Zhang >Assignee: Zhenning Zhang >Priority: Major > > For an index build job, if all the new added indexes can be built from their > existed parent index. No index was built from new created flat table. > For this case, there won't be any data inconsistency across indexes. And > there is no need to build a new flat table to serve the stage of index build > by layer. > So I think we can skip stage BUILD DICT and stage GENERATE FLAT TABLE for an > index build job in condition that all new added indexes can be built from > their existed parent index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5748) Skip build flat table for index build job if all new created indexes can be built from existed parent index
[ https://issues.apache.org/jira/browse/KYLIN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800421#comment-17800421 ] ASF GitHub Bot commented on KYLIN-5748: --- zznlime opened a new pull request, #2162: URL: https://github.com/apache/kylin/pull/2162 For an index build job, if all the new added indexes can be built from their existed parent index. No index was built from new created flat table. For this case, there won't be any data inconsistency across indexes. And there is no need to build a new flat table to serve the stage of index build by layer. So I think we can skip stage BUILD DICT and stage GENERATE FLAT TABLE for an index build job in condition that all new added indexes can be built from their existed parent index > Skip build flat table for index build job if all new created indexes can be > built from existed parent index > --- > > Key: KYLIN-5748 > URL: https://issues.apache.org/jira/browse/KYLIN-5748 > Project: Kylin > Issue Type: Improvement >Affects Versions: 5.0-beta >Reporter: Zhenning Zhang >Assignee: Zhenning Zhang >Priority: Major > > For an index build job, if all the new added indexes can be built from their > existed parent index. No index was built from new created flat table. > For this case, there won't be any data inconsistency across indexes. And > there is no need to build a new flat table to serve the stage of index build > by layer. > So I think we can skip stage BUILD DICT and stage GENERATE FLAT TABLE for an > index build job in condition that all new added indexes can be built from > their existed parent index -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798503#comment-17798503
]
ASF GitHub Bot commented on KYLIN-5731:
---
pfzhan commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1431123891
##
src/tool/src/main/java/org/apache/kylin/helper/MetadataToolHelper.java:
##
@@ -374,7 +373,7 @@ private int doRestore(ResourceStore currentResourceStore,
ResourceStore restoreR
}
public void cleanStorage(boolean storageCleanup, List projects,
double requestFSRate,
-int retryTimes) {
+ int retryTimes) {
Review Comment:
这个文件的 format 都有问题
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[ https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798501#comment-17798501 ] ASF GitHub Bot commented on KYLIN-5731: --- pfzhan commented on code in PR #2161: URL: https://github.com/apache/kylin/pull/2161#discussion_r1431121745 ## src/modeling-service/src/main/java/org/apache/kylin/rest/service/MetaStoreService.java: ## @@ -121,19 +91,45 @@ import org.springframework.stereotype.Component; import org.springframework.web.multipart.MultipartFile; -import org.apache.kylin.guava30.shaded.common.collect.Lists; -import org.apache.kylin.guava30.shaded.common.collect.Maps; -import org.apache.kylin.guava30.shaded.common.collect.Sets; -import org.apache.kylin.guava30.shaded.common.io.ByteSource; - -import org.apache.kylin.metadata.recommendation.candidate.JdbcRawRecStore; -import org.apache.kylin.metadata.recommendation.candidate.RawRecItem; -import org.apache.kylin.metadata.recommendation.candidate.RawRecManager; -import org.apache.kylin.metadata.recommendation.ref.OptRecManagerV2; +import javax.servlet.http.HttpServletRequest; +import javax.xml.bind.DatatypeConverter; +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.nio.charset.Charset; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import java.util.zip.ZipEntry; +import java.util.zip.ZipInputStream; +import java.util.zip.ZipOutputStream; -import lombok.Setter; -import lombok.val; -import lombok.var; +import static org.apache.kylin.common.constant.Constants.KE_VERSION; +import static org.apache.kylin.common.exception.ServerErrorCode.FAILED_CREATE_MODEL; +import static org.apache.kylin.common.exception.ServerErrorCode.MODEL_EXPORT_ERROR; +import static org.apache.kylin.common.exception.ServerErrorCode.MODEL_IMPORT_ERROR; +import static org.apache.kylin.common.exception.ServerErrorCode.MODEL_METADATA_FILE_ERROR; +import static org.apache.kylin.common.exception.code.ErrorCodeServer.MODEL_ID_NOT_EXIST; +import static org.apache.kylin.common.exception.code.ErrorCodeServer.MODEL_NAME_DUPLICATE; +import static org.apache.kylin.common.exception.code.ErrorCodeServer.MODEL_NAME_INVALID; +import static org.apache.kylin.common.persistence.ResourceStore.METASTORE_UUID_TAG; +import static org.apache.kylin.common.persistence.ResourceStore.VERSION_FILE; +import static org.apache.kylin.metadata.model.schema.ImportModelContext.MODEL_REC_PATH; +import static org.apache.kylin.metadata.model.schema.SchemaNodeType.MODEL_DIM; +import static org.apache.kylin.metadata.model.schema.SchemaNodeType.MODEL_FACT; Review Comment: 格式不对？ > When there is a null value in the Kafka source data, the build job reports an > error > --- > > Key: KYLIN-5731 > URL: https://issues.apache.org/jira/browse/KYLIN-5731 > Project: Kylin > Issue Type: Bug >Affects Versions: 5.0-beta >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Minor > Fix For: 5.0.0 > > > If the field value in kafka json data is null, the task will report an error. > Null value field "clue_source_2_name":null > Field type is varchar > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798502#comment-17798502
]
ASF GitHub Bot commented on KYLIN-5731:
---
pfzhan commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1431123373
##
src/tool/src/main/java/org/apache/kylin/helper/MetadataToolHelper.java:
##
@@ -98,7 +97,7 @@ public void backup(KylinConfig kylinConfig, String dir,
String folder) throws Ex
}
public Pair backup(KylinConfig kylinConfig, String
project, String path, String folder,
-boolean compress, boolean excludeTableExd) throws Exception {
+ boolean compress, boolean
excludeTableExd) throws Exception {
Review Comment:
格式
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798500#comment-17798500
]
ASF GitHub Bot commented on KYLIN-5731:
---
pfzhan commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1431119481
##
src/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/NDefaultScheduler.java:
##
@@ -232,6 +232,12 @@ public static double currentAvailableMem() {
return 1.0 * memoryRemaining.availablePermits();
}
+public int getMaxConcurrentJobLimitByProjectForInitThread(KylinConfig
config, JobEngineConfig jobEngineConfig,
+ String project)
{
+int jobLimit = getMaxConcurrentJobLimitByProject(config,
jobEngineConfig, project);
Review Comment:
format 不对
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798436#comment-17798436
]
ASF GitHub Bot commented on KYLIN-5731:
---
weiwei121723 commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1430942237
##
src/common-server/src/main/java/org/apache/kylin/rest/controller/NEpochController.java:
##
@@ -48,7 +51,11 @@ public class NEpochController extends NBasicController {
@PostMapping(value = "", produces = { HTTP_VND_APACHE_KYLIN_JSON,
HTTP_VND_APACHE_KYLIN_V4_PUBLIC_JSON })
@ResponseBody
public EnvelopeResponse updateEpochOwner(@RequestBody EpochRequest
epochRequest) {
-checkCollectionRequiredArg("projects", epochRequest.getProjects());
+if (Objects.isNull(epochRequest.getProjects())) {
+// Avoid following NPEs.
+epochRequest.setProjects(new ArrayList<>(0));
+}
+// Empty projects has specified meanings: all projects do change epoch.
Review Comment:
我主要担心这个接口，忘记传projects参数，不小心更新了所有的epoch。如果为空或者emptyList，应该直接报错比较稳妥些；
感觉/api/epoch/all 更适合做这个事情
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798419#comment-17798419
]
ASF GitHub Bot commented on KYLIN-5731:
---
thy950523 commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1430893586
##
src/common-server/src/main/java/org/apache/kylin/rest/controller/NEpochController.java:
##
@@ -48,7 +51,11 @@ public class NEpochController extends NBasicController {
@PostMapping(value = "", produces = { HTTP_VND_APACHE_KYLIN_JSON,
HTTP_VND_APACHE_KYLIN_V4_PUBLIC_JSON })
@ResponseBody
public EnvelopeResponse updateEpochOwner(@RequestBody EpochRequest
epochRequest) {
-checkCollectionRequiredArg("projects", epochRequest.getProjects());
+if (Objects.isNull(epochRequest.getProjects())) {
+// Avoid following NPEs.
+epochRequest.setProjects(new ArrayList<>(0));
+}
+// Empty projects has specified meanings: all projects do change epoch.
Review Comment:
这个issue是修复，projects参数为null情况下的NPE问题。
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798151#comment-17798151
]
ASF GitHub Bot commented on KYLIN-5731:
---
weiwei121723 commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1429932159
##
src/common-server/src/main/java/org/apache/kylin/rest/controller/NEpochController.java:
##
@@ -48,7 +51,11 @@ public class NEpochController extends NBasicController {
@PostMapping(value = "", produces = { HTTP_VND_APACHE_KYLIN_JSON,
HTTP_VND_APACHE_KYLIN_V4_PUBLIC_JSON })
@ResponseBody
public EnvelopeResponse updateEpochOwner(@RequestBody EpochRequest
epochRequest) {
-checkCollectionRequiredArg("projects", epochRequest.getProjects());
+if (Objects.isNull(epochRequest.getProjects())) {
+// Avoid following NPEs.
+epochRequest.setProjects(new ArrayList<>(0));
+}
+// Empty projects has specified meanings: all projects do change epoch.
Review Comment:
已经有一个updateAllEpochOwner接口了，这个接口默认更新所有的epoch，有点过重了；
就算要更新所有的epoch，也可以调用，org.apache.kylin.rest.service.EpochService#updateAllEpochs这个方法
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[ https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798146#comment-17798146 ] ASF GitHub Bot commented on KYLIN-5731: --- weiwei121723 commented on code in PR #2161: URL: https://github.com/apache/kylin/pull/2161#discussion_r1429997144 ## src/common-service/src/main/java/org/apache/kylin/rest/service/ProjectService.java: ## @@ -25,6 +25,7 @@ import static org.apache.kylin.common.constant.Constants.KYLIN_SOURCE_JDBC_SOURCE_ENABLE_KEY; import static org.apache.kylin.common.constant.Constants.KYLIN_SOURCE_JDBC_SOURCE_NAME_KEY; import static org.apache.kylin.common.constant.Constants.KYLIN_SOURCE_JDBC_USER_KEY; +import static org.apache.kylin.common.constant.Constants.KYLIN_JOB_MAX_CONCURRENT_JOBS; Review Comment: KYLIN-5738，这个commit的issue号写错了 > When there is a null value in the Kafka source data, the build job reports an > error > --- > > Key: KYLIN-5731 > URL: https://issues.apache.org/jira/browse/KYLIN-5731 > Project: Kylin > Issue Type: Bug >Affects Versions: 5.0-beta >Reporter: zhong.zhu >Assignee: zhong.zhu >Priority: Minor > Fix For: 5.0.0 > > > If the field value in kafka json data is null, the task will report an error. > Null value field "clue_source_2_name":null > Field type is varchar > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798138#comment-17798138
]
ASF GitHub Bot commented on KYLIN-5731:
---
weiwei121723 commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1429954352
##
src/core-common/src/main/java/org/apache/kylin/common/msg/CnMessage.java:
##
@@ -32,6 +32,7 @@ public class CnMessage extends Message {
private static final String TASK_TIMEOUT = "执行超时";
private static final String PARAMETER_EMPTY = "请输入参数 “%s” 的值。";
+private static final String PARAMETER_MUST_BE_POSITIVE_NUMBER= "参数 %s
的值必须为非负数.";
Review Comment:
中文句号
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KYLIN-5731) When there is a null value in the Kafka source data, the build job reports an error
[
https://issues.apache.org/jira/browse/KYLIN-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798134#comment-17798134
]
ASF GitHub Bot commented on KYLIN-5731:
---
weiwei121723 commented on code in PR #2161:
URL: https://github.com/apache/kylin/pull/2161#discussion_r1429932159
##
src/common-server/src/main/java/org/apache/kylin/rest/controller/NEpochController.java:
##
@@ -48,7 +51,11 @@ public class NEpochController extends NBasicController {
@PostMapping(value = "", produces = { HTTP_VND_APACHE_KYLIN_JSON,
HTTP_VND_APACHE_KYLIN_V4_PUBLIC_JSON })
@ResponseBody
public EnvelopeResponse updateEpochOwner(@RequestBody EpochRequest
epochRequest) {
-checkCollectionRequiredArg("projects", epochRequest.getProjects());
+if (Objects.isNull(epochRequest.getProjects())) {
+// Avoid following NPEs.
+epochRequest.setProjects(new ArrayList<>(0));
+}
+// Empty projects has specified meanings: all projects do change epoch.
Review Comment:
已经有一个updateAllEpochOwner接口了，这个接口默认更新所有的epoch，有点过重了
> When there is a null value in the Kafka source data, the build job reports an
> error
> ---
>
> Key: KYLIN-5731
> URL: https://issues.apache.org/jira/browse/KYLIN-5731
> Project: Kylin
> Issue Type: Bug
>Affects Versions: 5.0-beta
>Reporter: zhong.zhu
>Assignee: zhong.zhu
>Priority: Minor
> Fix For: 5.0.0
>
>
> If the field value in kafka json data is null, the task will report an error.
> Null value field "clue_source_2_name":null
> Field type is varchar
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
