[GitHub] [kylin] sonarcloud[bot] commented on pull request #2080: KYLIN-5309 exclude columns frontend
sonarcloud[bot] commented on PR #2080: URL: https://github.com/apache/kylin/pull/2080#issuecomment-1397194617 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2080) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2080&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2080&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2080&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2080&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2080&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2080&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] LauraXia123 opened a new pull request, #2080: KYLIN-5309 exclude columns frontend
LauraXia123 opened a new pull request, #2080: URL: https://github.com/apache/kylin/pull/2080 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] shaofengshi commented on pull request #2079: Second pr
shaofengshi commented on PR #2079: URL: https://github.com/apache/kylin/pull/2079#issuecomment-1384750161 Please create apache JIRA and describe the changes; Otherwise it won't be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] shaofengshi closed pull request #2079: Second pr
shaofengshi closed pull request #2079: Second pr URL: https://github.com/apache/kylin/pull/2079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2022: KYLIN-5280 Introduce memcached as a distributed cache for queries for Kylin5
sonarcloud[bot] commented on PR #2022: URL: https://github.com/apache/kylin/pull/2022#issuecomment-1383836380 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2022) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2022&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2022&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2022&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2022&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2022&metric=new_coverage&view=list) [56.0% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2022&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2022&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2022&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2079: Second pr
sonarcloud[bot] commented on PR #2079: URL: https://github.com/apache/kylin/pull/2079#issuecomment-1383570149 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2079) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2079&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2079&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2079&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2079&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2079&metric=new_coverage&view=list) [83.7% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2079&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2079&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2079&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] dethrive commented on pull request #2079: Second pr
dethrive commented on PR #2079: URL: https://github.com/apache/kylin/pull/2079#issuecomment-1383499593 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] dethrive commented on pull request #2079: Second pr
dethrive commented on PR #2079: URL: https://github.com/apache/kylin/pull/2079#issuecomment-1382757075 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] dethrive opened a new pull request, #2079: Second pr
dethrive opened a new pull request, #2079: URL: https://github.com/apache/kylin/pull/2079 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2074: KYLIN-5391 Kylin metadata tool for read specific file.
hit-lacus commented on PR #2074: URL: https://github.com/apache/kylin/pull/2074#issuecomment-1381352769 PR merged in https://github.com/apache/kylin/pull/2078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus closed pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
hit-lacus closed pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file URL: https://github.com/apache/kylin/pull/2068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
hit-lacus commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1381353192 PR merged in https://github.com/apache/kylin/pull/2078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus closed pull request #2074: KYLIN-5391 Kylin metadata tool for read specific file.
hit-lacus closed pull request #2074: KYLIN-5391 Kylin metadata tool for read specific file. URL: https://github.com/apache/kylin/pull/2074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2078: Kylin 5
hit-lacus merged PR #2078: URL: https://github.com/apache/kylin/pull/2078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2078: Kylin 5
sonarcloud[bot] commented on PR #2078: URL: https://github.com/apache/kylin/pull/2078#issuecomment-1381331506 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2078) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2078&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2078&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2078&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2078&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2078&metric=new_coverage&view=list) [80.3% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2078&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2078&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2078&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus opened a new pull request, #2078: Kylin 5
hit-lacus opened a new pull request, #2078: URL: https://github.com/apache/kylin/pull/2078 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liukun4515 commented on pull request #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
liukun4515 commented on PR #2072: URL: https://github.com/apache/kylin/pull/2072#issuecomment-1381277815 @hit-lacus add the google doc to describe what I do in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] yuanoOo opened a new pull request, #2077: Enhancement: Optimize code logic for pushdown queries
yuanoOo opened a new pull request, #2077: URL: https://github.com/apache/kylin/pull/2077 ## Proposed changes It is found that the push-down query in kylin4.0.x is very slow for the simple query eg: `select * from table limit 10`. It should respond in seconds, but it often takes a few minutes, and the larger the query data set, the more time-consuming it takes Long, which is very abnormal.BI tools often execute some simple queries to display detailed data. Abnormal query duration often causes BI tools to time out and return error messages, which is very unfriendly to user experience. Through investigation, it is found that there is a **shuffle** process in the query plan of this very simple detailed query, which is outrageous. The main logic of Kylin executing push-down query is concentrated in `org.apache.kylin.query.pushdown.SparkSqlClient`.Unnecessary Spark DataFrame type transform in `org.apache.kylin.query.pushdown.SparkSqlClient#DFToList` is the main cause of this problem. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [x] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
sonarcloud[bot] commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1380096647 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2075) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=VULNERABILITY) [1 Vulnerability](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2075&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2075&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2075&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=CODE_SMELL) [84 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_coverage&view=list) [63.0% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
hit-lacus merged PR #2075: URL: https://github.com/apache/kylin/pull/2075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1379784888 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [80.3% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
sonarcloud[bot] commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1379763617 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2075) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=VULNERABILITY) [1 Vulnerability](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2075&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2075&resolved=false&types=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2075&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=CODE_SMELL) [84 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2075&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_coverage&view=list) [62.9% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2075&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1379719065 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1379710519 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
sonarcloud[bot] commented on PR #2072: URL: https://github.com/apache/kylin/pull/2072#issuecomment-1378863845 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2072) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2072&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2072&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2072&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=CODE_SMELL) [79 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2072&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2072&metric=new_coverage&view=list) [7.0% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2072&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2072&metric=new_duplicated_lines_density&view=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2072&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
hit-lacus commented on PR #2072: URL: https://github.com/apache/kylin/pull/2072#issuecomment-1378753390 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2074: KYLIN-5391 Kylin metadata tool for read specific file.
hit-lacus commented on PR #2074: URL: https://github.com/apache/kylin/pull/2074#issuecomment-1378751782 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
hit-lacus commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378751274 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
hit-lacus commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378750751 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2076: Remove test for RecCandidateTool
hit-lacus merged PR #2076: URL: https://github.com/apache/kylin/pull/2076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2076: Remove test for RecCandidateTool
sonarcloud[bot] commented on PR #2076: URL: https://github.com/apache/kylin/pull/2076#issuecomment-1378676866 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2076) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2076&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2076&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2076&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2076&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2076&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2076&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus opened a new pull request, #2076: Remove test for RecCandidateTool
hit-lacus opened a new pull request, #2076: URL: https://github.com/apache/kylin/pull/2076 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378526351 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2073: Kylin 5.0.0 alpha license check
hit-lacus commented on PR #2073: URL: https://github.com/apache/kylin/pull/2073#issuecomment-1378491253 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2073: Kylin 5.0.0 alpha license check
hit-lacus commented on PR #2073: URL: https://github.com/apache/kylin/pull/2073#issuecomment-1378475499 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2073: Kylin 5.0.0 alpha license check
hit-lacus commented on PR #2073: URL: https://github.com/apache/kylin/pull/2073#issuecomment-1378420549 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2073: Kylin 5.0.0 alpha license check
hit-lacus commented on PR #2073: URL: https://github.com/apache/kylin/pull/2073#issuecomment-1378399136 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378297376 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378267078 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378220480 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zznlime commented on pull request #2074: KYLIN-5391 Kylin metadata tool for read specific file.
zznlime commented on PR #2074: URL: https://github.com/apache/kylin/pull/2074#issuecomment-1378194669 retest please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1378179768 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] JialeHe commented on pull request #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe commented on PR #2075: URL: https://github.com/apache/kylin/pull/2075#issuecomment-1378144520 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] JialeHe opened a new pull request, #2075: KYLIN-5389-5390;KYLIN-5392-5399 Batch ISSUE
JialeHe opened a new pull request, #2075: URL: https://github.com/apache/kylin/pull/2075 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376975380 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376942829 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [77.5% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zznlime opened a new pull request, #2074: KYLIN-5391 Kylin metadata tool for read specific file.
zznlime opened a new pull request, #2074: URL: https://github.com/apache/kylin/pull/2074 Currently, kylin metadata tool supports backup metadata files at project level or model level. We can add an api for listing files under a specific folder path and fetching the specific metadata at file level. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN-5391), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-5391 Metadata tool for fetch and list at file level" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376849875 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus opened a new pull request, #2073: Kylin 5.0.0 alpha license check
hit-lacus opened a new pull request, #2073: URL: https://github.com/apache/kylin/pull/2073 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376744649 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [68.2% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1376689219 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liukun4515 commented on a diff in pull request #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
liukun4515 commented on code in PR #2072: URL: https://github.com/apache/kylin/pull/2072#discussion_r1065302713 ## src/kylin-it/src/test/java/org/apache/kylin/metadata/cube/planner/algorithm/ITAlgorithmTestBase.java: ## @@ -0,0 +1,567 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one Review Comment: The test cases are migrated from kylin3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liukun4515 commented on a diff in pull request #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
liukun4515 commented on code in PR #2072:
URL: https://github.com/apache/kylin/pull/2072#discussion_r1065294892
##
src/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java:
##
@@ -3673,4 +3679,53 @@ public int getSecondStorageWaitLockTimeout() {
public boolean getDDLEnabled(){
return Boolean.parseBoolean(getOptional("kylin.source.ddl.enabled",
FALSE));
}
+
+//
+// Cost case cuboid Planner
+//
+
+public boolean enableCostBasedIndexPlanner() {
+// If we enable the cost base cuboid planner, we will recommend subset
of layouts from the rule.
+return
Boolean.parseBoolean(getOptional("kylin.index.costbased.enabled", FALSE));
Review Comment:
The default of cost based index is not enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375959669 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [68.0% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375846261 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375836160 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375827722 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375596618 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [65.1% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
sonarcloud[bot] commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375568365 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [65.1% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375508821 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liukun4515 commented on a diff in pull request #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
liukun4515 commented on code in PR #2072: URL: https://github.com/apache/kylin/pull/2072#discussion_r1064537167 ## src/core-metadata/src/main/java/org/apache/kylin/metadata/cube/planner/algorithm/AbstractRecommendAlgorithm.java: ## @@ -0,0 +1,82 @@ +/* Review Comment: The files in this package are migrated from kylin3.1, the codes have not been changed. ## src/core-metadata/src/main/java/org/apache/kylin/metadata/cube/planner/algorithm/genetic/BitsChromosome.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one Review Comment: The files in this package are migrated from kylin3.1, the codes have not been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liukun4515 opened a new pull request, #2072: [KYLIN-5387]: migrate cube planner1 to kylin5
liukun4515 opened a new pull request, #2072: URL: https://github.com/apache/kylin/pull/2072 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zznlime opened a new pull request, #2071: Kylin-5388 Add a rest api to support to update database name and table name without rebuilding data
zznlime opened a new pull request, #2071: URL: https://github.com/apache/kylin/pull/2071 Add a rest api to support to update database name and table name without rebuilding data. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN-5388), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related [jira ID](https://issues.apache.org/jira/browse/KYLIN-5388), like "KYLIN-5388 Add a rest api to support to update database name and table name without rebuilding data" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2070: KYLIN-5342-5349; KYLIN-5356-5357 BATCH ISSUE
hit-lacus merged PR #2070: URL: https://github.com/apache/kylin/pull/2070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] gleonSun commented on pull request #2070: KYLIN-5342-5349; KYLIN-5356-5357 BATCH ISSUE
gleonSun commented on PR #2070: URL: https://github.com/apache/kylin/pull/2070#issuecomment-1373170716 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
hit-lacus commented on PR #2068: URL: https://github.com/apache/kylin/pull/2068#issuecomment-1372053458 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] gleonSun commented on pull request #2070: KYLIN-5342-5349; KYLIN-5356-5357 BATCH ISSUE
gleonSun commented on PR #2070: URL: https://github.com/apache/kylin/pull/2070#issuecomment-1371879453 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] gleonSun opened a new pull request, #2070: KYLIN-5342-5349; KYLIN-5356-5357 BATCH ISSUE
gleonSun opened a new pull request, #2070: URL: https://github.com/apache/kylin/pull/2070 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] xjlem opened a new pull request, #2069: KYLIN-5386 segment过滤完成时间分区过滤从而提升cuboid的查询粒度
xjlem opened a new pull request, #2069: URL: https://github.com/apache/kylin/pull/2069 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2051: KYLIN-5368 Fix when stop ke job on yarn are not be killed for yarn cluster mode
sonarcloud[bot] commented on PR #2051: URL: https://github.com/apache/kylin/pull/2051#issuecomment-1370453760 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2051) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2051&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2051&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2051&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2051&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2051&metric=new_coverage&view=list) [87.1% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2051&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2051&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2051&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zheniantoushipashi closed pull request #2051: KYLIN-5368 Fix when stop ke job on yarn are not be killed for yarn cluster mode
zheniantoushipashi closed pull request #2051: KYLIN-5368 Fix when stop ke job on yarn are not be killed for yarn cluster mode URL: https://github.com/apache/kylin/pull/2051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2067: KYLIN-5370 DDL operations ignore table name case
hit-lacus merged PR #2067: URL: https://github.com/apache/kylin/pull/2067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zheniantoushipashi closed pull request #2052: KYLIN-5369 Fix job is running, the job fails after the KE restart and failure information is displayed for several times
zheniantoushipashi closed pull request #2052: KYLIN-5369 Fix job is running, the job fails after the KE restart and failure information is displayed for several times URL: https://github.com/apache/kylin/pull/2052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #2051: KYLIN-5368 Fix when stop ke job on yarn are not be killed for yarn cluster mode
hit-lacus commented on PR #2051: URL: https://github.com/apache/kylin/pull/2051#issuecomment-1370412254 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2050: KYLIN-5367 fix updata layoutHits error in fusion model
hit-lacus merged PR #2050: URL: https://github.com/apache/kylin/pull/2050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Syleechan opened a new pull request, #2068: [KYLIN-5361] modify email notification function and adjust email hard code to config file
Syleechan opened a new pull request, #2068: URL: https://github.com/apache/kylin/pull/2068 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [x] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [x] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [x] Compiling and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2067: KE-39911 DDL operations ignore table name case
sonarcloud[bot] commented on PR #2067: URL: https://github.com/apache/kylin/pull/2067#issuecomment-1368361821 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2067) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2067&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2067&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2067&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2067&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2067&metric=new_coverage&view=list) [89.8% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2067&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2067&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2067&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zheniantoushipashi commented on pull request #2067: KE-39911 DDL operations ignore table name case
zheniantoushipashi commented on PR #2067: URL: https://github.com/apache/kylin/pull/2067#issuecomment-1368345403 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zheniantoushipashi commented on pull request #2067: KE-39911 DDL operations ignore table name case
zheniantoushipashi commented on PR #2067: URL: https://github.com/apache/kylin/pull/2067#issuecomment-1367700405 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] zheniantoushipashi opened a new pull request, #2067: KE-39911 DDL operations ignore table name case
zheniantoushipashi opened a new pull request, #2067: URL: https://github.com/apache/kylin/pull/2067 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2062: KYLIN-5385 add bigquery pushdown
hit-lacus merged PR #2062: URL: https://github.com/apache/kylin/pull/2062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2061: KYLIN-5384 fix nativeQueryRealization deserialization failed,fix query timeout when redis connection failed
hit-lacus merged PR #2061: URL: https://github.com/apache/kylin/pull/2061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2060: KYLIN-5383 remove baseIndex for streaming when update fusion model
hit-lacus merged PR #2060: URL: https://github.com/apache/kylin/pull/2060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2059: KYLIN-5382 Block the agg pushdown when there is a non RexCall in the project
hit-lacus merged PR #2059: URL: https://github.com/apache/kylin/pull/2059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2058: KYLIN-5381 Avoid timeout when cleaning query history by limiting the number of data deleted each time
hit-lacus merged PR #2058: URL: https://github.com/apache/kylin/pull/2058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2058: KYLIN-5381 Avoid timeout when cleaning query history by limiting the number of data deleted each time
sonarcloud[bot] commented on PR #2058: URL: https://github.com/apache/kylin/pull/2058#issuecomment-1366516495 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2058) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2058&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2058&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2058&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2058&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2058&metric=new_coverage&view=list) [93.0% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2058&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2058&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2058&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2057: KYLIN-5380 fix npe when sql filter having null <> 0
hit-lacus merged PR #2057: URL: https://github.com/apache/kylin/pull/2057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2056: KYLIN-5375 sql performance enhancement
hit-lacus merged PR #2056: URL: https://github.com/apache/kylin/pull/2056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2055: KYLIN-5374 support DDL on view
hit-lacus merged PR #2055: URL: https://github.com/apache/kylin/pull/2055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2054: KYLIN-5373 fix user/usergroup display error in project acl
hit-lacus merged PR #2054: URL: https://github.com/apache/kylin/pull/2054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2053: KYLIN-5372 If the Job occurs permission exception error ,then let the Job failed instead of retry
hit-lacus merged PR #2053: URL: https://github.com/apache/kylin/pull/2053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Mukvin commented on pull request #2049: KYLIN-5371 fix segment prune
Mukvin commented on PR #2049: URL: https://github.com/apache/kylin/pull/2049#issuecomment-1366411948 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] Mukvin commented on a diff in pull request #2049: KYLIN-5371 fix segment prune
Mukvin commented on code in PR #2049:
URL: https://github.com/apache/kylin/pull/2049#discussion_r1058096474
##
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala:
##
@@ -366,7 +366,9 @@ class FilePruner(cubeInstance: CubeInstance,
val pruned = segDirs.filter {
e => {
val tsRange = cubeInstance.getSegment(e.segmentName,
SegmentStatusEnum.READY).getTSRange
-SegFilters(tsRange.startValue, tsRange.endValue, pattern)
+// tsRange:
2022121900_2022121901、2022121901_2022121902, pattern: -MM-dd
+val start = DateFormat.getFormatTimeStamp(tsRange.startValue,
pattern)
+SegFilters(start, tsRange.endValue, pattern)
Review Comment:
As for clearance, please comment on the place of tsRange.endValue then help
others to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kylin] sonarcloud[bot] commented on pull request #2054: KYLIN-5373 fix user/usergroup display error in project acl
sonarcloud[bot] commented on PR #2054: URL: https://github.com/apache/kylin/pull/2054#issuecomment-1366344618 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2054) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2054&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2054&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2054&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2054&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2054&metric=new_coverage&view=list) [84.9% Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2054&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2054&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2054&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] leejaywei commented on pull request #2054: KYLIN-5373 fix user/usergroup display error in project acl
leejaywei commented on PR #2054: URL: https://github.com/apache/kylin/pull/2054#issuecomment-1366317677 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] andreoss closed pull request #1995: KYLIN-3561 Migrate core modules to Junit 5
andreoss closed pull request #1995: KYLIN-3561 Migrate core modules to Junit 5 URL: https://github.com/apache/kylin/pull/1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] leejaywei commented on pull request #2054: KYLIN-5373 fix user/usergroup display error in project acl
leejaywei commented on PR #2054: URL: https://github.com/apache/kylin/pull/2054#issuecomment-1365789680 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liuzhao-lz commented on pull request #2049: KYLIN-5371 fix segment prune
liuzhao-lz commented on PR #2049: URL: https://github.com/apache/kylin/pull/2049#issuecomment-1365673651  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kylin] liuzhao-lz commented on a diff in pull request #2049: KYLIN-5371 fix segment prune
liuzhao-lz commented on code in PR #2049:
URL: https://github.com/apache/kylin/pull/2049#discussion_r1057488331
##
core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java:
##
@@ -194,4 +202,18 @@ public static boolean isDatePattern(String ptn) {
return COMPACT_DATE_PATTERN.equals(ptn) || MMDDHH.equals(ptn) ||
MMDDHHMM.equals(ptn)
|| MMDDHHMMSS.equals(ptn);
}
+
+public static Long getFormatTimeStamp(long time, String pattern) {
+try {
+if (StringUtils.isNotBlank(pattern)) {
+SimpleDateFormat sdf = new SimpleDateFormat(pattern,
Locale.getDefault(Locale.Category.FORMAT));
+sdf.setTimeZone(TimeZone.getTimeZone("GMT"));
Review Comment:
##
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala:
##
@@ -366,7 +366,9 @@ class FilePruner(cubeInstance: CubeInstance,
val pruned = segDirs.filter {
e => {
val tsRange = cubeInstance.getSegment(e.segmentName,
SegmentStatusEnum.READY).getTSRange
-SegFilters(tsRange.startValue, tsRange.endValue, pattern)
+// tsRange:
2022121900_2022121901、2022121901_2022121902, pattern: -MM-dd
+val start = DateFormat.getFormatTimeStamp(tsRange.startValue,
pattern)
+SegFilters(start, tsRange.endValue, pattern)
Review Comment:
tsRange.endValue 不需要考虑，DateFormat.getFormatTimeStamp(tsRange.startValue,
pattern) 这个的作用是将 startValue 格式化成天的时间戳值（忽略小时），原因是 SegFilters 的 foldFilter
中是按天格式化where 分区字段值的（记作ts），后续比较也是 “ts >= start && ts < end” end
如果是到时间其对应的时间戳一定是大于天的时间戳值因而可以不用处理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kylin] leejaywei commented on pull request #2054: KYLIN-5373 fix user/usergroup display error in project acl
leejaywei commented on PR #2054: URL: https://github.com/apache/kylin/pull/2054#issuecomment-1365648075 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kylin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
