[jira] [Assigned] (KYLIN-4553) Expose job filtered with more job types
[ https://issues.apache.org/jira/browse/KYLIN-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Pan reassigned KYLIN-4553: - Assignee: Zhong Yanghong (was: Julian Pan) > Expose job filtered with more job types > --- > > Key: KYLIN-4553 > URL: https://issues.apache.org/jira/browse/KYLIN-4553 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Zhong Yanghong >Priority: Major > > It's better to expose jobs by filtering with all job types. Currently jobs > only be filtered by "Cubing" & "CheckPoint". There're more job types, like > "Lookup snapshot", "Calculate Cardinality", etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (KYLIN-4553) Expose job filtered with more job types
[ https://issues.apache.org/jira/browse/KYLIN-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Pan reassigned KYLIN-4553: - Assignee: Julian Pan (was: Zhong Yanghong) > Expose job filtered with more job types > --- > > Key: KYLIN-4553 > URL: https://issues.apache.org/jira/browse/KYLIN-4553 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Major > > It's better to expose jobs by filtering with all job types. Currently jobs > only be filtered by "Cubing" & "CheckPoint". There're more job types, like > "Lookup snapshot", "Calculate Cardinality", etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4553) Expose job filtered with more job types
[ https://issues.apache.org/jira/browse/KYLIN-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147251#comment-17147251 ] Julian Pan commented on KYLIN-4553: --- The pr should be reviewed, could you help to merge the pr? [~yaho] > Expose job filtered with more job types > --- > > Key: KYLIN-4553 > URL: https://issues.apache.org/jira/browse/KYLIN-4553 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Major > > It's better to expose jobs by filtering with all job types. Currently jobs > only be filtered by "Cubing" & "CheckPoint". There're more job types, like > "Lookup snapshot", "Calculate Cardinality", etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (KYLIN-4553) Expose job filtered with more job types
[ https://issues.apache.org/jira/browse/KYLIN-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146046#comment-17146046 ] Julian Pan edited comment on KYLIN-4553 at 6/28/20, 7:53 AM: - [~gxcheng] I suppose you mean the PR [https://github.com/apache/kylin/pull/1254|https://github.com/apache/kylin/pull/1254/files] And I have concern about type set for new job type, and add the comments in PR. Could you help to double check? was (Author: julianpan): I suppose you mean the PR [https://github.com/apache/kylin/pull/1254|https://github.com/apache/kylin/pull/1254/files] And I have concern about type set for new job type, and add the comments in PR. Could you help to double check? > Expose job filtered with more job types > --- > > Key: KYLIN-4553 > URL: https://issues.apache.org/jira/browse/KYLIN-4553 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Major > > It's better to expose jobs by filtering with all job types. Currently jobs > only be filtered by "Cubing" & "CheckPoint". There're more job types, like > "Lookup snapshot", "Calculate Cardinality", etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4550) Provide advanced refresh interface inside the refresh panel
[ https://issues.apache.org/jira/browse/KYLIN-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146122#comment-17146122 ] Julian Pan commented on KYLIN-4550: --- [https://github.com/sanjulian/kylin/tree/KYLIN-4550] > Provide advanced refresh interface inside the refresh panel > --- > > Key: KYLIN-4550 > URL: https://issues.apache.org/jira/browse/KYLIN-4550 > Project: Kylin > Issue Type: Improvement >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Major > > Currently for cube refresh, only single segment is allowed in the web portal. > Users may want to refresh multiple segments at once with single job. > Therefore, it's better to provide an advanced refresh interface, which can > refresh multiple segments' data and finally comes to one bigger segment. For > this advanced refresh interface, the starting time should be alined with the > boundary of existing segments, and the ending time should be larger than the > starting time and also should be alined with the boundary of existing > segments or larger than the biggest ending time of existing segments. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4553) Expose job filtered with more job types
[ https://issues.apache.org/jira/browse/KYLIN-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146046#comment-17146046 ] Julian Pan commented on KYLIN-4553: --- I suppose you mean the PR [https://github.com/apache/kylin/pull/1254|https://github.com/apache/kylin/pull/1254/files] And I have concern about type set for new job type, and add the comments in PR. Could you help to double check? > Expose job filtered with more job types > --- > > Key: KYLIN-4553 > URL: https://issues.apache.org/jira/browse/KYLIN-4553 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Major > > It's better to expose jobs by filtering with all job types. Currently jobs > only be filtered by "Cubing" & "CheckPoint". There're more job types, like > "Lookup snapshot", "Calculate Cardinality", etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4551) Provide interfaces to transfer cube/model/project ownership
[ https://issues.apache.org/jira/browse/KYLIN-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146015#comment-17146015 ] Julian Pan commented on KYLIN-4551: --- Thanks [~gxcheng] , it is similar with my implementation except I put the trigger in action instead of cube detail. [~yaho] could you help to merge the pr? > Provide interfaces to transfer cube/model/project ownership > --- > > Key: KYLIN-4551 > URL: https://issues.apache.org/jira/browse/KYLIN-4551 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Guangxu Cheng >Priority: Major > > In many companies, employee variation is very common. If cube owners leave > office, it's necessary to transfer the cube ownership to others. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4398) Display Kylin Version on UI
[ https://issues.apache.org/jira/browse/KYLIN-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093000#comment-17093000 ] Julian Pan commented on KYLIN-4398: --- It is duplicate with https://issues.apache.org/jira/browse/KYLIN-1850, and it is already migrate to 3.0 release, which put the version and commit id to header instead of footer. > Display Kylin Version on UI > --- > > Key: KYLIN-4398 > URL: https://issues.apache.org/jira/browse/KYLIN-4398 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4398) Display Kylin Version on UI
[ https://issues.apache.org/jira/browse/KYLIN-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054298#comment-17054298 ] Julian Pan commented on KYLIN-4398: --- Here is the pull request: [https://github.com/apache/kylin/pull/1150] > Display Kylin Version on UI > --- > > Key: KYLIN-4398 > URL: https://issues.apache.org/jira/browse/KYLIN-4398 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (KYLIN-4398) Display Kylin Version on UI
[ https://issues.apache.org/jira/browse/KYLIN-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Pan updated KYLIN-4398: -- Comment: was deleted (was: Here is the PR: [https://github.com/apache/kylin/pull/1149]) > Display Kylin Version on UI > --- > > Key: KYLIN-4398 > URL: https://issues.apache.org/jira/browse/KYLIN-4398 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (KYLIN-4398) Display Kylin Version on UI
[ https://issues.apache.org/jira/browse/KYLIN-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Pan reopened KYLIN-4398: --- > Display Kylin Version on UI > --- > > Key: KYLIN-4398 > URL: https://issues.apache.org/jira/browse/KYLIN-4398 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4398) Display Kylin Version on UI
[ https://issues.apache.org/jira/browse/KYLIN-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054288#comment-17054288 ] Julian Pan commented on KYLIN-4398: --- Here is the PR: [https://github.com/apache/kylin/pull/1149] > Display Kylin Version on UI > --- > > Key: KYLIN-4398 > URL: https://issues.apache.org/jira/browse/KYLIN-4398 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (KYLIN-4398) Display Kylin Version on UI
[ https://issues.apache.org/jira/browse/KYLIN-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Pan resolved KYLIN-4398. --- Resolution: Fixed > Display Kylin Version on UI > --- > > Key: KYLIN-4398 > URL: https://issues.apache.org/jira/browse/KYLIN-4398 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: Zhong Yanghong >Assignee: Julian Pan >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (KYLIN-1080) [Query Page] upgrade ng-grid to ui-grid for query result in query page
[ https://issues.apache.org/jira/browse/KYLIN-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438555#comment-15438555 ] julian pan edited comment on KYLIN-1080 at 8/26/16 7:16 AM: Great, maybe we can use ui-grid to replace kylinPagination directive. Implement the front-end pagination which will reduce the call to restful. I add new ticket KYLIN-1977 [https://issues.apache.org/jira/browse/KYLIN-1977], which includes it. Please contact me if you are interested in. was (Author: julianpan): Great, maybe we can use ui-grid to replace kylinPagination directive. Implement the front-end pagination which will reduce the call to restful. > [Query Page] upgrade ng-grid to ui-grid for query result in query page > -- > > Key: KYLIN-1080 > URL: https://issues.apache.org/jira/browse/KYLIN-1080 > Project: Kylin > Issue Type: Improvement > Components: Web >Affects Versions: v1.4.0, v1.1 >Reporter: Zhong,Jason >Assignee: Zhong,Jason >Priority: Critical > Fix For: Backlog > > > now we use ng-grid to show query result > ui-grid performance better than ng-grid on render time, and development on > ng-grid has stopped, all development and new featuer move to ui-grid. > FYI: > http://ui-grid.info/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-1977) Update front end dependency (bower)
[ https://issues.apache.org/jira/browse/KYLIN-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438578#comment-15438578 ] julian pan commented on KYLIN-1977: --- Here is the rough summary some effect for upgrade task: (I did not list task for tree and something else, I'm not familiar) 1. angular-bootstrap *upgrade (code affect) 2. angular upgrade maybe just remove it cause depends on other angular 3. angular-resouce depends on angular 4. angular-route replace to angular-ui-router (code affect) 5. ng-grid replace by angular-ui-grid official remove it? 6. angular-ui-grid 7. angular-chosen-localytics replace by angular-ui-select? 8. animate.css depends on angular-animate 9. bootstrap depends on angular-bootstrap and fuelux 10. font-awesome upgrade 11. angular-ui-ace // format text 12. angular-tree-control //table tree 13. angularLocalStorage maybe we replace by angular-local-storage (code effect) 14. messenger // message 15. d3 remove it let it depends on nvd3 version 16. nvd3 upgrade or remove it let it depends on angular-nvd3-*** 17. angularjs-nvd3-directives replace to angular-nvd3 (code affect) 18. angular-sweetalert // alert dialog 19. angular-underscore 20. angular-ui-sortable 21. underscore // same as lodash 22. fuelux // extends bootstrap 23. angular-animate 24. angular-cookies depends on angularLocalStorage 25. angular-bootstrap-nav-tree": "*", 26. components-font-awesome // shim repo with font-awesome we just choose one of them 27. bootstrap-sweetalert 28. angular-toggle-switch //just use in model design page maybe it can replaced 29. angular-ui-select // same as angular-chosen-localytics 30. angular-sanitize 31. angular-tree-control ? 32. angular-bootstrap-datetimepicker maybe replace to bootstrap-daterangepicker directive by ourselves And maybe we can double check and remove unnecessary dependency and some component already depend on. > Update front end dependency (bower) > --- > > Key: KYLIN-1977 > URL: https://issues.apache.org/jira/browse/KYLIN-1977 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: julian pan >Assignee: Zhong,Jason > > 1. There is warning "Code incompatibilities may occur.", when I install bower > component. [angular, nvd3, d3, moment, angular-cookies version not consistent] > 2. Some duplicate component: ng-grid & angular-ui-grid, > angular-chosen-localytics & angular-ui-select, font-awesome & > components-font-awesome > 3. angularjs-nvd3-directives is beta version, maybe we can replace it by > angular-nvd3. > 4. some components version are out of date, could we upgrade them such as > angular-bootstrap... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-1977) Update front end dependency (bower)
[ https://issues.apache.org/jira/browse/KYLIN-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438568#comment-15438568 ] julian pan commented on KYLIN-1977: --- Here is the error message when I bower install: Please note that, angularjs-nvd3-directives#0.0.5-beta depends on moment#2.4.0 which resolved to moment#2.4.0 base depends on moment#2.5.1 which resolved to moment#2.5.1 fuelux#3.5.1 depends on moment#2.x which resolved to moment#2.5.1 angular-bootstrap-datetimepicker#0.3.15 depends on moment#^2.10.6 which resolved to moment#2.14.1 Resort to using moment#2.4.0 which resolved to moment#2.4.0 Code incompatibilities may occur. Please note that, angularjs-nvd3-directives#0.0.5-beta depends on angular#1.2.4 which resolved to angular#1.2.4 angular-route#1.2.15 depends on angular#1.2.15 which resolved to angular#1.2.15 angular-sanitize#1.2.18 depends on angular#1.2.18 which resolved to angular#1.2.18 angular-tree-control#0.2.8 depends on angular#~1.2.7 which resolved to angular#1.2.29 angular-sweetalert#1.0.4 depends on angular#~1.2.0 which resolved to angular#1.2.29 base depends on angular#1.2.29 which resolved to angular#1.2.29 angular-animate#1.2.30, angular-cookies#1.2.30 depends on angular#1.2.30 which resolved to angular#1.2.30 angular-resource#1.3.20 depends on angular#1.3.20 which resolved to angular#1.3.20 angular-bootstrap#0.10.0 depends on angular#>=1 which resolved to angular#1.4.12 angular-ui-select#0.13.2 depends on angular#>=1.2.18 which resolved to angular#1.4.12 angularLocalStorage#0.3.2 depends on angular#~1.4.7 which resolved to angular#1.4.12 angular-cookies#1.4.12 depends on angular#1.4.12 which resolved to angular#1.4.12 angular-bootstrap-datetimepicker#0.3.15 depends on angular#^1.4.7 which resolved to angular#1.4.12 angular-bootstrap-nav-tree#7fb14dd72d depends on angular#>=1.0 which resolved to angular#1.4.12 angular-ui-ace#0.1.0 depends on angular#~1.x which resolved to angular#1.4.12 angular-base64#2.0.1 depends on angular#>= 1.0.8 which resolved to angular#1.4.12 angular-chosen-localytics#1.0.6 depends on angular#>=1.2.0 which resolved to angular#1.4.12 angular-ui-sortable#0.13.1 depends on angular#>=1.2.x which resolved to angular#1.4.12 ng-grid#2.0.11 depends on angular#^1.0.8 which resolved to angular#1.4.12 angular-ui-grid#3.1.1 depends on angular#>=1.2.16 1.4.x which resolved to angular#1.4.12 Resort to using angular#1.2.29 which resolved to angular#1.2.29 Code incompatibilities may occur. > Update front end dependency (bower) > --- > > Key: KYLIN-1977 > URL: https://issues.apache.org/jira/browse/KYLIN-1977 > Project: Kylin > Issue Type: Improvement > Components: Web >Reporter: julian pan >Assignee: Zhong,Jason > > 1. There is warning "Code incompatibilities may occur.", when I install bower > component. [angular, nvd3, d3, moment, angular-cookies version not consistent] > 2. Some duplicate component: ng-grid & angular-ui-grid, > angular-chosen-localytics & angular-ui-select, font-awesome & > components-font-awesome > 3. angularjs-nvd3-directives is beta version, maybe we can replace it by > angular-nvd3. > 4. some components version are out of date, could we upgrade them such as > angular-bootstrap... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KYLIN-1977) Update front end dependency (bower)
julian pan created KYLIN-1977: - Summary: Update front end dependency (bower) Key: KYLIN-1977 URL: https://issues.apache.org/jira/browse/KYLIN-1977 Project: Kylin Issue Type: Improvement Components: Web Reporter: julian pan Assignee: Zhong,Jason 1. There is warning "Code incompatibilities may occur.", when I install bower component. [angular, nvd3, d3, moment, angular-cookies version not consistent] 2. Some duplicate component: ng-grid & angular-ui-grid, angular-chosen-localytics & angular-ui-select, font-awesome & components-font-awesome 3. angularjs-nvd3-directives is beta version, maybe we can replace it by angular-nvd3. 4. some components version are out of date, could we upgrade them such as angular-bootstrap... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KYLIN-1976) Update front end dependency (bower)
julian pan created KYLIN-1976: - Summary: Update front end dependency (bower) Key: KYLIN-1976 URL: https://issues.apache.org/jira/browse/KYLIN-1976 Project: Kylin Issue Type: Improvement Reporter: julian pan 1. There is warning "Code incompatibilities may occur.", when I install bower component. [angular, nvd3, d3, moment, angular-cookies version not consistent] 2. Some duplicate component: ng-grid & angular-ui-grid, angular-chosen-localytics & angular-ui-select, font-awesome & components-font-awesome 3. angularjs-nvd3-directives is beta version, maybe we can replace it by angular-nvd3. 4. some components version are out of date, could we upgrade them such as angular-bootstrap... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-1080) [Query Page] upgrade ng-grid to ui-grid for query result in query page
[ https://issues.apache.org/jira/browse/KYLIN-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438555#comment-15438555 ] julian pan commented on KYLIN-1080: --- Great, maybe we can use ui-grid to replace kylinPagination directive. Implement the front-end pagination which will reduce the call to restful. > [Query Page] upgrade ng-grid to ui-grid for query result in query page > -- > > Key: KYLIN-1080 > URL: https://issues.apache.org/jira/browse/KYLIN-1080 > Project: Kylin > Issue Type: Improvement > Components: Web >Affects Versions: v1.4.0, v1.1 >Reporter: Zhong,Jason >Assignee: Zhong,Jason >Priority: Critical > Fix For: Backlog > > > now we use ng-grid to show query result > ui-grid performance better than ng-grid on render time, and development on > ng-grid has stopped, all development and new featuer move to ui-grid. > FYI: > http://ui-grid.info/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1970) System Menu UI ACL issue
[ https://issues.apache.org/jira/browse/KYLIN-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1970: -- Priority: Major (was: Minor) > System Menu UI ACL issue > > > Key: KYLIN-1970 > URL: https://issues.apache.org/jira/browse/KYLIN-1970 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: julian pan >Assignee: Zhong,Jason > Attachments: Kylin System Menu.png, fix_ui_system_menu_acl.patch > > > There is the admin ACL in restful for admin part. But in UI there is no ACL > control for it. If I'm not admin user login and click System menu, then I > will get the ACL error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1972) get access denied when query seek to hybrid
[ https://issues.apache.org/jira/browse/KYLIN-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1972: -- Priority: Major (was: Minor) > get access denied when query seek to hybrid > --- > > Key: KYLIN-1972 > URL: https://issues.apache.org/jira/browse/KYLIN-1972 > Project: Kylin > Issue Type: Bug > Components: REST Service >Reporter: julian pan >Assignee: Zhong,Jason > Attachments: fix_query_hybrid_access_denied.patch > > > The user who has the rights to visit the cube, but when he/she query cube > seek to hybrid, then will get the access denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-1972) get access denied when query seek to hybrid
[ https://issues.apache.org/jira/browse/KYLIN-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434478#comment-15434478 ] julian pan commented on KYLIN-1972: --- BTW, I'm using the version 1.5.2.1. There is the IIInstance ACL check for my branch now. I saw the master already remove invertedindex project. Does it means IIInstance will never used in future? And if the yes, could you double check RealizationType [https://github.com/apache/kylin/blob/master/core-metadata/src/main/java/org/apache/kylin/metadata/realization/RealizationType.java] the "INVERTED_INDEX" should be exist or not? > get access denied when query seek to hybrid > --- > > Key: KYLIN-1972 > URL: https://issues.apache.org/jira/browse/KYLIN-1972 > Project: Kylin > Issue Type: Bug > Components: REST Service >Reporter: julian pan >Assignee: Zhong,Jason >Priority: Minor > Attachments: fix_query_hybrid_access_denied.patch > > > The user who has the rights to visit the cube, but when he/she query cube > seek to hybrid, then will get the access denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1972) get access denied when query seek to hybrid
[ https://issues.apache.org/jira/browse/KYLIN-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1972: -- Attachment: fix_query_hybrid_access_denied.patch Here is the fix patch. > get access denied when query seek to hybrid > --- > > Key: KYLIN-1972 > URL: https://issues.apache.org/jira/browse/KYLIN-1972 > Project: Kylin > Issue Type: Bug > Components: REST Service >Reporter: julian pan >Assignee: Zhong,Jason >Priority: Minor > Attachments: fix_query_hybrid_access_denied.patch > > > The user who has the rights to visit the cube, but when he/she query cube > seek to hybrid, then will get the access denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1972) get access denied when query seek to hybrid
[ https://issues.apache.org/jira/browse/KYLIN-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1972: -- Summary: get access denied when query seek to hybrid (was: get access denied when query touch hybrid) > get access denied when query seek to hybrid > --- > > Key: KYLIN-1972 > URL: https://issues.apache.org/jira/browse/KYLIN-1972 > Project: Kylin > Issue Type: Bug > Components: REST Service >Reporter: julian pan >Assignee: Zhong,Jason >Priority: Minor > > The user who has the rights to visit the cube, but when he/she query cube > seek to hybrid, then will get the access denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KYLIN-1972) get access denied when query touch hybrid
julian pan created KYLIN-1972: - Summary: get access denied when query touch hybrid Key: KYLIN-1972 URL: https://issues.apache.org/jira/browse/KYLIN-1972 Project: Kylin Issue Type: Bug Components: REST Service Reporter: julian pan Assignee: Zhong,Jason Priority: Minor The user who has the rights to visit the cube, but when he/she query cube seek to hybrid, then will get the access denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1970) System Menu UI ACL issue
[ https://issues.apache.org/jira/browse/KYLIN-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1970: -- Attachment: fix_ui_system_menu_acl.patch Here is the quick fix for it. > System Menu UI ACL issue > > > Key: KYLIN-1970 > URL: https://issues.apache.org/jira/browse/KYLIN-1970 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: julian pan >Assignee: Zhong,Jason >Priority: Minor > Attachments: Kylin System Menu.png, fix_ui_system_menu_acl.patch > > > There is the admin ACL in restful for admin part. But in UI there is no ACL > control for it. If I'm not admin user login and click System menu, then I > will get the ACL error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1970) System Menu UI ACL issue
[ https://issues.apache.org/jira/browse/KYLIN-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1970: -- Attachment: Kylin System Menu.png Here is attached image for detail. > System Menu UI ACL issue > > > Key: KYLIN-1970 > URL: https://issues.apache.org/jira/browse/KYLIN-1970 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: julian pan >Assignee: Zhong,Jason >Priority: Minor > Attachments: Kylin System Menu.png > > > There is the admin ACL in restful for admin part. But in UI there is no ACL > control for it. If I'm not admin user login and click System menu, then I > will get the ACL error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KYLIN-1970) System Menu UI ACL issue
julian pan created KYLIN-1970: - Summary: System Menu UI ACL issue Key: KYLIN-1970 URL: https://issues.apache.org/jira/browse/KYLIN-1970 Project: Kylin Issue Type: Bug Components: Web Reporter: julian pan Assignee: Zhong,Jason Priority: Minor There is the admin ACL in restful for admin part. But in UI there is no ACL control for it. If I'm not admin user login and click System menu, then I will get the ACL error messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KYLIN-1909) Wrong access control to rest get cubes
[ https://issues.apache.org/jira/browse/KYLIN-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] julian pan updated KYLIN-1909: -- Attachment: fix_cube_list_acl_bug.patch Attached the fix patch. > Wrong access control to rest get cubes > -- > > Key: KYLIN-1909 > URL: https://issues.apache.org/jira/browse/KYLIN-1909 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v1.5.2 >Reporter: Dong Li >Assignee: Shaofeng SHI >Priority: Minor > Fix For: v1.5.3 > > Attachments: fix_cube_list_acl_bug.patch > > > 1. Import sample data > 2. Login with user: ANALYST, see nothing > 3. Request rest api: > http://sandbox:7070/kylin/api/cubes?limit=15=0=learn_kylin > Then found the list of cubes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KYLIN-1909) Wrong access control to rest get cubes
[
https://issues.apache.org/jira/browse/KYLIN-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427959#comment-15427959
]
julian pan commented on KYLIN-1909:
---
diff --git
a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
index 7932211..133fdbc 100644
---
a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
+++
b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
@@ -21,6 +21,7 @@
import java.io.IOException;
import java.net.UnknownHostException;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
@@ -97,7 +98,21 @@
@RequestMapping(value = "", method = { RequestMethod.GET })
@ResponseBody
public List getCubes(@RequestParam(value = "cubeName",
required = false) String cubeName, @RequestParam(value = "modelName", required
= false) String modelName, @RequestParam(value = "projectName", required =
false) String projectName, @RequestParam(value = "limit", required = false)
Integer limit, @RequestParam(value = "offset", required = false) Integer
offset) {
-return cubeService.getCubes(cubeName, projectName, modelName, limit,
offset);
+List cubes;
+cubes = cubeService.getCubes(cubeName, projectName, modelName);
+
+int climit = (null == limit) ? cubes.size() : limit;
+int coffset = (null == offset) ? 0 : offset;
+
+if (cubes.size() <= coffset) {
+return Collections.emptyList();
+}
+
+if ((cubes.size() - coffset) < climit) {
+return cubes.subList(coffset, cubes.size());
+}
+
+return cubes.subList(coffset, coffset + climit);
}
@RequestMapping(value = "validEncodings", method = { RequestMethod.GET })
diff --git
a/server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
b/server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
index cfb4cf8..030ff22 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
@@ -93,7 +93,7 @@
private AccessService accessService;
@PostFilter(Constant.ACCESS_POST_FILTER_READ)
-public List listAllCubes(final String cubeName, final String
projectName, final String modelName) {
+public List getCubes(final String cubeName, final String
projectName, final String modelName) {
List cubeInstances = null;
ProjectInstance project = (null != projectName) ?
getProjectManager().getProject(projectName) : null;
@@ -126,26 +126,6 @@
}
return filterCubes;
-}
-
-@PostFilter(Constant.ACCESS_POST_FILTER_READ)
-public List getCubes(final String cubeName, final String
projectName, final String modelName, final Integer limit, final Integer offset)
{
-
-List cubes;
-cubes = listAllCubes(cubeName, projectName, modelName);
-
-int climit = (null == limit) ? cubes.size() : limit;
-int coffset = (null == offset) ? 0 : offset;
-
-if (cubes.size() <= coffset) {
-return Collections.emptyList();
-}
-
-if ((cubes.size() - coffset) < climit) {
-return cubes.subList(coffset, cubes.size());
-}
-
-return cubes.subList(coffset, coffset + climit);
}
@PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN + " or hasPermission(#cube,
'ADMINISTRATION') or hasPermission(#cube, 'MANAGEMENT')")
> Wrong access control to rest get cubes
> --
>
> Key: KYLIN-1909
> URL: https://issues.apache.org/jira/browse/KYLIN-1909
> Project: Kylin
> Issue Type: Bug
> Components: REST Service
>Affects Versions: v1.5.2
>Reporter: Dong Li
>Assignee: Shaofeng SHI
>Priority: Minor
> Fix For: v1.5.3
>
>
> 1. Import sample data
> 2. Login with user: ANALYST, see nothing
> 3. Request rest api:
> http://sandbox:7070/kylin/api/cubes?limit=15=0=learn_kylin
> Then found the list of cubes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KYLIN-1909) Wrong access control to rest get cubes
[ https://issues.apache.org/jira/browse/KYLIN-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427905#comment-15427905 ] julian pan commented on KYLIN-1909: --- Hi The fix for list cube ACL has some issues. If the cube user has permission not in the range (offset ~ limit), then the cube will not return. [https://github.com/apache/kylin/blob/kylin-1.5.3/server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java] The root cause is org.apache.kylin.rest.service.CubeService.getCubes method will call listAllCubes. Due to internal call, the annotation for listAllCubes will not work. getCubes get all cubes from listAllCubes. Then get the sub cubes from all cube instead of the permission cube. The ACL will double check the sub cubes, and return permission cube in sub cubes. If the permission not in sub cube list, then user can not get it. The ticket closed, so I cannot attached patch for this ticket. I'm glad to attached my patch if you open it. Thanks & Regards Julian > Wrong access control to rest get cubes > -- > > Key: KYLIN-1909 > URL: https://issues.apache.org/jira/browse/KYLIN-1909 > Project: Kylin > Issue Type: Bug > Components: REST Service >Affects Versions: v1.5.2 >Reporter: Dong Li >Assignee: Shaofeng SHI >Priority: Minor > Fix For: v1.5.3 > > > 1. Import sample data > 2. Login with user: ANALYST, see nothing > 3. Request rest api: > http://sandbox:7070/kylin/api/cubes?limit=15=0=learn_kylin > Then found the list of cubes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
