[GitHub] [kylin] codecov-io edited a comment on issue #507: KYLIN-3857 Disable quote when needed
codecov-io edited a comment on issue #507: KYLIN-3857 Disable quote when needed URL: https://github.com/apache/kylin/pull/507#issuecomment-471365737 # [Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=h1) Report > Merging [#507](https://codecov.io/gh/apache/kylin/pull/507?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/595c4e2112afeaea8c2881626959e37bbed50c84?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `31.57%`. [](https://codecov.io/gh/apache/kylin/pull/507?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #507 +/- ## + Coverage 25.29% 25.29% +<.01% - Complexity 5826 5828 +2 Files 1379 1379 Lines 8172081736 +16 Branches 1144411445 +1 + Hits 2066720673 +6 - Misses5903959048 +9 - Partials 2014 2015 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/507?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../org/apache/kylin/source/kafka/KafkaInputBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvS2Fma2FJbnB1dEJhc2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/kylin/source/jdbc/JdbcHiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNIaXZlSW5wdXRCYXNlLmphdmE=) | `10.57% <0%> (ø)` | `3 <0> (ø)` | :arrow_down: | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `13.1% <0%> (-0.05%)` | `42 <0> (ø)` | | | [...ylin/source/jdbc/extensible/JdbcHiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0hpdmVJbnB1dEJhc2UuamF2YQ==) | `84% <100%> (ø)` | `2 <0> (ø)` | :arrow_down: | | [.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==) | `25.86% <45.45%> (+4.7%)` | `12 <7> (+3)` | :arrow_up: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `48.83% <0%> (-3.49%)` | `7% <0%> (ø)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | | | ... and [2 more](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=footer). Last update [595c4e2...d229fd1](https://codecov.io/gh/apache/kylin/pull/507?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] [kylin] codecov-io edited a comment on issue #507: KYLIN-3857 Disable quote when needed
codecov-io edited a comment on issue #507: KYLIN-3857 Disable quote when needed URL: https://github.com/apache/kylin/pull/507#issuecomment-471365737 # [Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@fe43a3e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `35%`. [](https://codecov.io/gh/apache/kylin/pull/507?src=pr=tree) ```diff @@Coverage Diff@@ ## master #507 +/- ## = Coverage ? 24.44% Complexity? 5025 = Files ? 1160 Lines ?70407 Branches ?10015 = Hits ?17212 Misses?51457 Partials ? 1738 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/507?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.21% <0%> (ø)` | `42 <0> (?)` | | | [...kylin/source/adhocquery/HivePushDownConverter.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2FkaG9jcXVlcnkvSGl2ZVB1c2hEb3duQ29udmVydGVyLmphdmE=) | `65.51% <0%> (ø)` | `16 <0> (?)` | | | [...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...java/org/apache/kylin/metadata/model/TableRef.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVSZWYuamF2YQ==) | `50% <0%> (ø)` | `11 <0> (?)` | | | [...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...pache/kylin/source/datagen/ModelDataGenerator.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vTW9kZWxEYXRhR2VuZXJhdG9yLmphdmE=) | `89.3% <100%> (ø)` | `53 <1> (?)` | | | [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `82.19% <100%> (ø)` | `12 <0> (?)` | | | [...in/sdk/datasource/framework/conv/SqlConverter.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9jb252L1NxbENvbnZlcnRlci5qYXZh) | `90.62% <100%> (ø)` | `7 <3> (?)` | | | [.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==) | `21.81% <37.5%> (ø)` | `10 <2> (?)` | | | [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/507/diff?src=pr=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `13.17% <62.5%> (ø)` | `4 <0> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/507?src=pr=footer). Last update [fe43a3e...4011eff](https://codecov.io/gh/apache/kylin/pull/507?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
