[GitHub] [kylin] hit-lacus commented on a change in pull request #507: KYLIN-3857 Disable quote when needed

[GitBox]

hit-lacus commented on a change in pull request #507: KYLIN-3857 Disable quote 
when needed
URL: https://github.com/apache/kylin/pull/507#discussion_r266774070
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##
 @@ -982,6 +982,14 @@ public int getDefaultDecimalScale() {
 }
 }
 
+public boolean enableHiveDdlQuote(){
+return 
Boolean.parseBoolean(getOptional("kylin.source.hive.quote-enabled", TRUE));
+}
+
+public static String getQuoteCharacter(){
 
 Review comment:
   Make it configurable do not make harm, I will change it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on a change in pull request #507: KYLIN-3857 Disable quote when needed

[GitBox]

hit-lacus commented on a change in pull request #507: KYLIN-3857 Disable quote 
when needed
URL: https://github.com/apache/kylin/pull/507#discussion_r266772588
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##
 @@ -982,6 +982,14 @@ public int getDefaultDecimalScale() {
 }
 }
 
+public boolean enableHiveDdlQuote(){
+return 
Boolean.parseBoolean(getOptional("kylin.source.hive.quote-enabled", TRUE));
+}
+
+public static String getQuoteCharacter(){
 
 Review comment:
   The quote character used by Hive is **`**, I think it wouldn't be changed 
easily. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on a change in pull request #507: KYLIN-3857 Disable quote when needed

[GitBox]

hit-lacus commented on a change in pull request #507: KYLIN-3857 Disable quote 
when needed
URL: https://github.com/apache/kylin/pull/507#discussion_r265395327
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
 ##
 @@ -982,6 +982,14 @@ public int getDefaultDecimalScale() {
 }
 }
 
+public boolean enableHiveDdlQuote(){
+return 
Boolean.parseBoolean(getOptional("kylin.source.hive.enable.quote", TRUE));
 
 Review comment:
   I have fix this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services