[GitHub] [kylin] shaofengshi commented on pull request #1488: [KYLIN-4827] Fix SparkMergingDictionary parallelize not work.

2020-12-16 Thread GitBox 


shaofengshi commented on pull request #1488:
URL: https://github.com/apache/kylin/pull/1488#issuecomment-747276562


   How much performance improvement from this change? I'd like to know it. 
Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kylin] shaofengshi commented on pull request #1488: [KYLIN-4827] Fix SparkMergingDictionary parallelize not work.

2020-12-30 Thread GitBox 


shaofengshi commented on pull request #1488:
URL: https://github.com/apache/kylin/pull/1488#issuecomment-752822387


   thanks Ted, it looks good to me!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org