[jira] [Comment Edited] (KYLIN-2884) Add delete segment function for portal

2018-02-23 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375314#comment-16375314
 ] 

Zhixiong Chen edited comment on KYLIN-2884 at 2/24/18 5:34 AM:
---

OK, this patch is fine with me.

[~julianpan] Could you make a pull request about this patch in master branch.

Then I will merge it.


was (Author: zhixiong chen):
OK, then this patch is fine with me.

> Add delete segment function for portal
> --
>
> Key: KYLIN-2884
> URL: https://issues.apache.org/jira/browse/KYLIN-2884
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, 
> KYLIN-2884.patch, KYLIN-2884.patch, screenshot-1.png, screenshot-2.png
>
>
> Kylin restful already support delete segment function. Could we add a action 
> button for front-end to user?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (KYLIN-2884) Add delete segment function for portal

2018-02-23 Thread Pan, Julian (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374209#comment-16374209
 ] 

Pan, Julian edited comment on KYLIN-2884 at 2/23/18 10:58 AM:
--

I add new patch for it. I'm not sure whether it need combine or not.

Please let me know, if it need combine 2 commits.


was (Author: julianpan):
I add new patch for it. I'm not sure whether it need separate or not.

Please let me know, if it need separate 2 commit.

> Add delete segment function for portal
> --
>
> Key: KYLIN-2884
> URL: https://issues.apache.org/jira/browse/KYLIN-2884
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, 
> KYLIN-2884.patch, screenshot-1.png, screenshot-2.png
>
>
> Kylin restful already support delete segment function. Could we add a action 
> button for front-end to user?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (KYLIN-2884) Add delete segment function for portal

2018-01-24 Thread Zhixiong Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337581#comment-16337581
 ] 

Zhixiong Chen edited comment on KYLIN-2884 at 1/24/18 1:27 PM:
---

Hi, [~julianpan]

If there isn't 'metaModel.model.partition_desc.partition_date_column' in 
'deleteSegment.html'

It will show 'If you want to drop the cube, please click "Drop".'

However if model hasn't partition_date_column, the cube could full build. And 
the cube should support delete segment.


was (Author: zhixiong chen):
Hi, [~julianpan]

If there isn't metaModel.model.partition_desc.partition_date_column in 
deleteSegment.html

It will show 'If you want to drop the cube, please click "Drop".

However if model hasn't partition_date_column, the cube could full build. And 
the cube also support delete segment.

> Add delete segment function for portal
> --
>
> Key: KYLIN-2884
> URL: https://issues.apache.org/jira/browse/KYLIN-2884
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Attachments: KYLIN-2884.patch
>
>
> Kylin restful already support delete segment function. Could we add a action 
> button for front-end to user?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)