[jira] [Commented] (KYLIN-1851) Improve build dictionary, consider that input is already sorted

2016-12-10 Thread XIE FAN (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737984#comment-15737984
 ] 

XIE FAN commented on KYLIN-1851:


It's already ok. The new dictionary class is TrieDictionaryForest.

> Improve build dictionary, consider that input is already sorted
> ---
>
> Key: KYLIN-1851
> URL: https://issues.apache.org/jira/browse/KYLIN-1851
> Project: Kylin
>  Issue Type: Bug
>Reporter: liyang
>Assignee: XIE FAN
> Attachments: 
> 0001-KYLIN-1851-unfinished-add-TrieDictionaryForest-and-N.patch
>
>
> Currently dictionary build may encounter OOM when cardinality is huge. This 
> can benefit from that the input (which is the output of FactDistinctColumn 
> reducer) is already sorted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KYLIN-1851) Improve build dictionary, consider that input is already sorted

2016-12-10 Thread hongbin ma (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15737861#comment-15737861
 ] 

hongbin ma commented on KYLIN-1851:
---

what's the status of this JIRA and KYLIN-1178?

> Improve build dictionary, consider that input is already sorted
> ---
>
> Key: KYLIN-1851
> URL: https://issues.apache.org/jira/browse/KYLIN-1851
> Project: Kylin
>  Issue Type: Bug
>Reporter: liyang
>Assignee: XIE FAN
> Attachments: 
> 0001-KYLIN-1851-unfinished-add-TrieDictionaryForest-and-N.patch
>
>
> Currently dictionary build may encounter OOM when cardinality is huge. This 
> can benefit from that the input (which is the output of FactDistinctColumn 
> reducer) is already sorted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)