[jira] [Commented] (KYLIN-3001) Fix the wrong Cache key issue
[
https://issues.apache.org/jira/browse/KYLIN-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423810#comment-16423810
]
Pan, Julian commented on KYLIN-3001:
It is replace for multiple space to one space, which will reduce the sql length.
> Fix the wrong Cache key issue
> --
>
> Key: KYLIN-3001
> URL: https://issues.apache.org/jira/browse/KYLIN-3001
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN_3001_Cache_key_issue.patch
>
>
> Currently the cacheKey generate by SQLRequest getCacheKey:
> cacheKey = Lists.newArrayList(sql.replaceAll("\\s+", ""), project, offset,
> limit, acceptPartial,
> backdoorToggles);
> Which will remove all the space and break line.
> If I have a sql:
> select a, sum(c) from table
> --where a > 0 group by a;
> and another sql:
> select a, sum(c) from table
> --where a > 0
> group by a;
> The two sql will share same cache key.
> But the first sql should be break. If you query second sql, and then query
> the first again. It will return result.
> And another issue is if remove all space, which will mix a as b and aasb.
> I think the better way is just replace multiple space to one space
> Should I create a patch? Or just provide the fix:
> cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " "), project, offset,
> limit, acceptPartial,
> backdoorToggles);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KYLIN-3001) Fix the wrong Cache key issue
[
https://issues.apache.org/jira/browse/KYLIN-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423344#comment-16423344
]
liyang commented on KYLIN-3001:
---
Sorry I don't understand the patch. Replace "[ ]" with " ", replace a space
with a space, what is the use?
> Fix the wrong Cache key issue
> --
>
> Key: KYLIN-3001
> URL: https://issues.apache.org/jira/browse/KYLIN-3001
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
>Affects Versions: v2.1.0
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN_3001_Cache_key_issue.patch
>
>
> Currently the cacheKey generate by SQLRequest getCacheKey:
> cacheKey = Lists.newArrayList(sql.replaceAll("\\s+", ""), project, offset,
> limit, acceptPartial,
> backdoorToggles);
> Which will remove all the space and break line.
> If I have a sql:
> select a, sum(c) from table
> --where a > 0 group by a;
> and another sql:
> select a, sum(c) from table
> --where a > 0
> group by a;
> The two sql will share same cache key.
> But the first sql should be break. If you query second sql, and then query
> the first again. It will return result.
> And another issue is if remove all space, which will mix a as b and aasb.
> I think the better way is just replace multiple space to one space
> Should I create a patch? Or just provide the fix:
> cacheKey = Lists.newArrayList(sql.replaceAll("[ ]", " "), project, offset,
> limit, acceptPartial,
> backdoorToggles);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
