[jira] [Commented] (KYLIN-3308) Improvement exception in REST

2018-04-30 Thread liyang (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458509#comment-16458509
 ] 

liyang commented on KYLIN-3308:
---

Nice proposal~

> Improvement exception in REST
> -
>
> Key: KYLIN-3308
> URL: https://issues.apache.org/jira/browse/KYLIN-3308
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
>
> There are kinds of exception throw by rest call, and we need better defined 
> the exception. 
> For example:
> 1> There are three types of exception for cube equals null in CubeController:
> NotFoundException (deleteCube)
> InternalErrorException(getCube)
> BadRequestException (cloneCube)
> 2> And sometimes InternalErrorException will warp the BadRequestException in 
> CubeController.saveCubeDesc
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3308) Improvement exception in REST

2018-03-21 Thread Pan, Julian (JIRA)

[ 
https://issues.apache.org/jira/browse/KYLIN-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407559#comment-16407559
 ] 

Pan, Julian commented on KYLIN-3308:


I can lead the exception defined if needed.

BTW, I'm not sure whether the controller2 will cover it or not. 

> Improvement exception in REST
> -
>
> Key: KYLIN-3308
> URL: https://issues.apache.org/jira/browse/KYLIN-3308
> Project: Kylin
>  Issue Type: Improvement
>  Components: REST Service
>Reporter: Pan, Julian
>Assignee: Pan, Julian
>Priority: Major
>
> There are kinds of exception throw by rest call, and we need better defined 
> the exception. 
> For example:
> 1> There are three types of exception for cube equals null in CubeController:
> NotFoundException (deleteCube)
> InternalErrorException(getCube)
> BadRequestException (cloneCube)
> 2> And sometimes InternalErrorException will warp the BadRequestException in 
> CubeController.saveCubeDesc
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)