[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-10-29 Thread Chao Long (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668239#comment-16668239
 ] 

Chao Long commented on KYLIN-3527:
--

I verified this, it works now.

> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618490#comment-16618490
 ] 

ASF subversion and git services commented on KYLIN-3527:


Commit 7e2391d5785df12b379f2da808befe12e5bd3331 in kylin's branch 
refs/heads/2.5.x from Emiya0306
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7e2391d ]

KYLIN-3527 fix hybrid couldn't save when there is only 1 cube


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618488#comment-16618488
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

luguosheng1314 closed pull request #234: KYLIN-3527 fix hybrid couldn't save 
when there is only 1 cube
URL: https://github.com/apache/kylin/pull/234
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/js/controllers/hybridInstanceSchema.js 
b/webapp/app/js/controllers/hybridInstanceSchema.js
index c4f61b496a..668f6dcc78 100644
--- a/webapp/app/js/controllers/hybridInstanceSchema.js
+++ b/webapp/app/js/controllers/hybridInstanceSchema.js
@@ -118,9 +118,8 @@ KylinApp.controller('HybridInstanceSchema', function (
 var schema = getSchema();
 
 return Object.keys(schema).every(function(key) {
-  // Array.length for checking select cubes count >= 2
   // otherwise checking empty value
-  return schema[key] instanceof Array ? schema[key].length > 1 : 
schema[key];
+  return !!schema[key];
 });
   };
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618393#comment-16618393
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

asfgit commented on issue #234: KYLIN-3527 fix hybrid couldn't save when there 
is only 1 cube
URL: https://github.com/apache/kylin/pull/234#issuecomment-422231803
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618392#comment-16618392
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

asfgit commented on issue #234: KYLIN-3527 fix hybrid couldn't save when there 
is only 1 cube
URL: https://github.com/apache/kylin/pull/234#issuecomment-422231802
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618391#comment-16618391
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

Emiya0306 opened a new pull request #234: KYLIN-3527 fix hybrid couldn't save 
when there is only 1 cube
URL: https://github.com/apache/kylin/pull/234
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617306#comment-16617306
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

luguosheng1314 closed pull request #232: KYLIN-3527 fix hybrid couldn't save 
when there is only 1 cube
URL: https://github.com/apache/kylin/pull/232
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/js/controllers/hybridInstanceSchema.js 
b/webapp/app/js/controllers/hybridInstanceSchema.js
index c4f61b496a..668f6dcc78 100644
--- a/webapp/app/js/controllers/hybridInstanceSchema.js
+++ b/webapp/app/js/controllers/hybridInstanceSchema.js
@@ -118,9 +118,8 @@ KylinApp.controller('HybridInstanceSchema', function (
 var schema = getSchema();
 
 return Object.keys(schema).every(function(key) {
-  // Array.length for checking select cubes count >= 2
   // otherwise checking empty value
-  return schema[key] instanceof Array ? schema[key].length > 1 : 
schema[key];
+  return !!schema[key];
 });
   };
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617307#comment-16617307
 ] 

ASF subversion and git services commented on KYLIN-3527:


Commit 535c9ed00f0a72c3e6c379e505985e519de7e8ce in kylin's branch 
refs/heads/master from Emiya0306
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=535c9ed ]

KYLIN-3527 fix hybrid couldn't save when there is only 1 cube


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.1
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617006#comment-16617006
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

asfgit commented on issue #232: KYLIN-3527 fix hybrid couldn't save when there 
is only 1 cube
URL: https://github.com/apache/kylin/pull/232#issuecomment-421876194
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617005#comment-16617005
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

Emiya0306 opened a new pull request #232: KYLIN-3527 fix hybrid couldn't save 
when there is only 1 cube
URL: https://github.com/apache/kylin/pull/232
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617007#comment-16617007
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

asfgit commented on issue #232: KYLIN-3527 fix hybrid couldn't save when there 
is only 1 cube
URL: https://github.com/apache/kylin/pull/232#issuecomment-421876193
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610068#comment-16610068
 ] 

ASF subversion and git services commented on KYLIN-3527:


Commit 5ce6588eda365cf4aca5f53ab6cb1adaa4ffe9e8 in kylin's branch 
refs/heads/2.5.x-hadoop3.1 from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5ce6588 ]

KYLIN-3527 Hybrid allows 0,1 cube


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610063#comment-16610063
 ] 

ASF subversion and git services commented on KYLIN-3527:


Commit 5ce6588eda365cf4aca5f53ab6cb1adaa4ffe9e8 in kylin's branch 
refs/heads/2.5.x from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5ce6588 ]

KYLIN-3527 Hybrid allows 0,1 cube


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609957#comment-16609957
 ] 

ASF subversion and git services commented on KYLIN-3527:


Commit 5faddf6eb5ba7e8bb682e1ee6fded4a7e89a2d92 in kylin's branch 
refs/heads/master-hadoop3.1 from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5faddf6 ]

KYLIN-3527 Hybrid allows 0,1 cube


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608892#comment-16608892
 ] 

ASF subversion and git services commented on KYLIN-3527:


Commit 5faddf6eb5ba7e8bb682e1ee6fded4a7e89a2d92 in kylin's branch 
refs/heads/master from chao long
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5faddf6 ]

KYLIN-3527 Hybrid allows 0,1 cube


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602569#comment-16602569
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

luguosheng1314 closed pull request #220: KYLIN-3527 fix grunt script - font 
build
URL: https://github.com/apache/kylin/pull/220
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/Gruntfile.js b/webapp/Gruntfile.js
index d871f4f934..a977a7321e 100644
--- a/webapp/Gruntfile.js
+++ b/webapp/Gruntfile.js
@@ -105,6 +105,12 @@ module.exports = function (grunt) {
 src: ['fonts/*'],
 dest: 'dist/'
   },
+  {
+expand: true,
+cwd: 'app',
+src: ['fonts/*'],
+dest: 'dist/'
+  },
   {
 expand: true,
 cwd: 'app/components/ace/',


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602563#comment-16602563
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

Emiya0306 opened a new pull request #220: KYLIN-3527 fix grunt script - font 
build
URL: https://github.com/apache/kylin/pull/220
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KYLIN-3527) Hybrid couldn't save when there is only 1 cube

2018-09-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KYLIN-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602564#comment-16602564
 ] 

ASF GitHub Bot commented on KYLIN-3527:
---

asfgit commented on issue #220: KYLIN-3527 fix grunt script - font build
URL: https://github.com/apache/kylin/pull/220#issuecomment-418227622
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Hybrid couldn't save when there is only 1 cube
> --
>
> Key: KYLIN-3527
> URL: https://issues.apache.org/jira/browse/KYLIN-3527
> Project: Kylin
>  Issue Type: Bug
>  Components: Web 
>Affects Versions: v2.5.0
>Reporter: Shaofeng SHI
>Assignee: Roger
>Priority: Minor
> Fix For: v2.5.0
>
> Attachments: hybrid-not-saved.png, move-in-out-icons.png
>
>
> I created a hybrid with two cubes; Later I want to remove one cube from it, 
> but I found when there is only 1 cube, the "Submit" button was disabled.
>  
> The hybrid should allows 0, 1 or more cubes.
>  
> Besides, I found the move in and out icons were not properly displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)