[jira] [Commented] (KYLIN-3739) Use table alias rather than table identity for snapshots in CubeSegment, CubeInstance, CubeDesc
[ https://issues.apache.org/jira/browse/KYLIN-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731520#comment-16731520 ] liyang commented on KYLIN-3739: --- Sounds fine to me if we can keep it backward compatible. I guess the logic will be, first check if the name is an alias, and if not then check if it's a full table name. Should be a small change by line of code I assume. > Use table alias rather than table identity for snapshots in CubeSegment, > CubeInstance, CubeDesc > --- > > Key: KYLIN-3739 > URL: https://issues.apache.org/jira/browse/KYLIN-3739 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: Zhong Yanghong >Priority: Major > > In 2.0.0, Kylin introduced table alias in DataModelDesc. Most of the elements > in CubeDesc, CubeInstance & CubeSegment use the table alias rather than the > table identity. However, for the lookup table snapshots, it still uses table > identity. > It's better for us to use only table alias instead of table identity in > CubeDesc, CubeInstance & CubeSegment. If so, it can provide several > advantages: > # For CubeDesc, CubeInstance & CubeSegment, what exposed to them is only the > snowflake model and they don't need to care which real table is used. > # If users want to change the table name in the snowflake model, we can still > keep the table alias unchanged and what we need to change is only the > DataModelDesc. And we don't need to do any change for CubeDesc, CubeInstance > & CubeSegment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3739) Use table alias rather than table identity for snapshots in CubeSegment, CubeInstance, CubeDesc
[ https://issues.apache.org/jira/browse/KYLIN-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728860#comment-16728860 ] Shaofeng SHI commented on KYLIN-3739: - [~yaho] Legacy cube instances are using the table ID as the key, when make this change, the old metadata should be supported, otherwise they won't get the snapshot. > Use table alias rather than table identity for snapshots in CubeSegment, > CubeInstance, CubeDesc > --- > > Key: KYLIN-3739 > URL: https://issues.apache.org/jira/browse/KYLIN-3739 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: Zhong Yanghong >Priority: Major > > In 2.0.0, Kylin introduced table alias in DataModelDesc. Most of the elements > in CubeDesc, CubeInstance & CubeSegment use the table alias rather than the > table identity. However, for the lookup table snapshots, it still uses table > identity. > It's better for us to use only table alias instead of table identity in > CubeDesc, CubeInstance & CubeSegment. If so, it can provide several > advantages: > # For CubeDesc, CubeInstance & CubeSegment, what exposed to them is only the > snowflake model and they don't need to care which real table is used. > # If users want to change the table name in the snowflake model, we can still > keep the table alias unchanged and what we need to change is only the > DataModelDesc. And we don't need to do any change for CubeDesc, CubeInstance > & CubeSegment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3739) Use table alias rather than table identity for snapshots in CubeSegment, CubeInstance, CubeDesc
[ https://issues.apache.org/jira/browse/KYLIN-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728656#comment-16728656 ] Zhong Yanghong commented on KYLIN-3739: --- Hi [~Shaofengshi], there's no impact on the data under '/table_snapshot'. * In CubeInstance & CubeSegment, there's a map for snapshots. The value will not be changed. Only the key will be replaced by table alias instead of table identity. * In CubeDesc, there's a list of SnapshotTableDesc for cube-level snapshots. In SnapshotTableDesc, the tableName should be table alias instead of table identity. > Use table alias rather than table identity for snapshots in CubeSegment, > CubeInstance, CubeDesc > --- > > Key: KYLIN-3739 > URL: https://issues.apache.org/jira/browse/KYLIN-3739 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: Zhong Yanghong >Priority: Major > > In 2.0.0, Kylin introduced table alias in DataModelDesc. Most of the elements > in CubeDesc, CubeInstance & CubeSegment use the table alias rather than the > table identity. However, for the lookup table snapshots, it still uses table > identity. > It's better for us to use only table alias instead of table identity in > CubeDesc, CubeInstance & CubeSegment. If so, it can provide several > advantages: > # For CubeDesc, CubeInstance & CubeSegment, what exposed to them is only the > snowflake model and they don't need to care which real table is used. > # If users want to change the table name in the snowflake model, we can still > keep the table alias unchanged and what we need to change is only the > DataModelDesc. And we don't need to do any change for CubeDesc, CubeInstance > & CubeSegment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3739) Use table alias rather than table identity for snapshots in CubeSegment, CubeInstance, CubeDesc
[ https://issues.apache.org/jira/browse/KYLIN-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728578#comment-16728578 ] Shaofeng SHI commented on KYLIN-3739: - Today the table snapshots are shared across cubes, as the table ID is the same. If change to this way, can the snapshot be shared as before? > Use table alias rather than table identity for snapshots in CubeSegment, > CubeInstance, CubeDesc > --- > > Key: KYLIN-3739 > URL: https://issues.apache.org/jira/browse/KYLIN-3739 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: Zhong Yanghong >Priority: Major > > In 2.0.0, Kylin introduced table alias in DataModelDesc. Most of the elements > in CubeDesc, CubeInstance & CubeSegment use the table alias rather than the > table identity. However, for the lookup table snapshots, it still uses table > identity. > It's better for us to use only table alias instead of table identity in > CubeDesc, CubeInstance & CubeSegment. If so, it can provide several > advantages: > # For CubeDesc, CubeInstance & CubeSegment, what exposed to them is only the > snowflake model and they don't need to care which real table is used. > # If users want to change the table name in the snowflake model, we can still > keep the table alias unchanged and what we need to change is only the > DataModelDesc. And we don't need to do any change for CubeDesc, CubeInstance > & CubeSegment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3739) Use table alias rather than table identity for snapshots in CubeSegment, CubeInstance, CubeDesc
[ https://issues.apache.org/jira/browse/KYLIN-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728577#comment-16728577 ] Zhong Yanghong commented on KYLIN-3739: --- Hi [~liyang.g...@gmail.com] & [~Shaofengshi], what do you think? > Use table alias rather than table identity for snapshots in CubeSegment, > CubeInstance, CubeDesc > --- > > Key: KYLIN-3739 > URL: https://issues.apache.org/jira/browse/KYLIN-3739 > Project: Kylin > Issue Type: Improvement > Components: Metadata >Reporter: Zhong Yanghong >Priority: Major > > In 2.0.0, Kylin introduced table alias in DataModelDesc. Most of the elements > in CubeDesc, CubeInstance & CubeSegment use the table alias rather than the > table identity. However, for the lookup table snapshots, it still uses table > identity. > It's better for us to use only table alias instead of table identity in > CubeDesc, CubeInstance & CubeSegment. If so, it can provide several > advantages: > # For CubeDesc, CubeInstance & CubeSegment, what exposed to them is only the > snowflake model and they don't need to care which real table is used. > # If users want to change the table name in the snowflake model, we can still > keep the table alias unchanged and what we need to change is only the > DataModelDesc. And we don't need to do any change for CubeDesc, CubeInstance > & CubeSegment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
