[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[ https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094287#comment-17094287 ] ASF subversion and git services commented on KYLIN-3844: Commit 4cad22dc3c847b66ad030d20d4563dce12ff18a7 in kylin's branch refs/heads/master from yaqian.zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=4cad22d ] KYLIN-3844 Add interface for HbaseMappingAdapter > some instruction about config 'kylin.metadata.hbasemapping-adapter' > --- > > Key: KYLIN-3844 > URL: https://issues.apache.org/jira/browse/KYLIN-3844 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Reporter: Yuzhang QIU >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > Hi team: > When someone want to self-define hbase column family mapping, they may > need to know how to config 'kylin.metadata.hbasemapping-adapter'. > Although tracing the code at CubeDesc:around 678 will show the usage of > this configuration, some official instruction in document may be better. > Just a small suggestion. :) > >Best regards > > yuzhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[
https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092237#comment-17092237
]
ASF GitHub Bot commented on KYLIN-3844:
---
shaofengshi commented on a change in pull request #1183:
URL: https://github.com/apache/kylin/pull/1183#discussion_r415064892
##
File path:
core-cube/src/main/java/org/apache/kylin/cube/model/IHbaseMappingAdapter.java
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.cube.model;
+
+/**
+ */
+public interface IHbaseMappingAdapter {
Review comment:
Two comments here:
1) "HBase" not "Hbase", need make consistent with the method name:
"IHBaseMappingAdapter"
2) Please add a description for this interface and its methods;
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> some instruction about config 'kylin.metadata.hbasemapping-adapter'
> ---
>
> Key: KYLIN-3844
> URL: https://issues.apache.org/jira/browse/KYLIN-3844
> Project: Kylin
> Issue Type: Improvement
> Components: Documentation
>Reporter: Yuzhang QIU
>Assignee: Yaqian Zhang
>Priority: Minor
> Fix For: v3.0.1
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Hi team:
> When someone want to self-define hbase column family mapping, they may
> need to know how to config 'kylin.metadata.hbasemapping-adapter'.
> Although tracing the code at CubeDesc:around 678 will show the usage of
> this configuration, some official instruction in document may be better.
> Just a small suggestion. :)
>
>Best regards
>
> yuzhang
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[ https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091233#comment-17091233 ] ASF GitHub Bot commented on KYLIN-3844: --- coveralls commented on pull request #1183: URL: https://github.com/apache/kylin/pull/1183#issuecomment-618824064 ## Pull Request Test Coverage Report for [Build 5845](https://coveralls.io/builds/30307042) * **0** of **3** **(0.0%)** changed or added relevant lines in **1** file are covered. * **3** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.002%**) to **27.468%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/30307042/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L654) | 0 | 3 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/30307042/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/30307042/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% | | Totals | [](https://coveralls.io/builds/30307042) | | :-- | --: | | Change from base [Build 5830](https://coveralls.io/builds/30067502): | 0.002% | | Covered Lines: | 24317 | | Relevant Lines: | 88530 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > some instruction about config 'kylin.metadata.hbasemapping-adapter' > --- > > Key: KYLIN-3844 > URL: https://issues.apache.org/jira/browse/KYLIN-3844 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Reporter: Yuzhang QIU >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.0.1 > > Original Estimate: 4h > Remaining Estimate: 4h > > Hi team: > When someone want to self-define hbase column family mapping, they may > need to know how to config 'kylin.metadata.hbasemapping-adapter'. > Although tracing the code at CubeDesc:around 678 will show the usage of > this configuration, some official instruction in document may be better. > Just a small suggestion. :) > >Best regards > > yuzhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[ https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090286#comment-17090286 ] ASF GitHub Bot commented on KYLIN-3844: --- zhangayqian opened a new pull request #1184: URL: https://github.com/apache/kylin/pull/1184 …dapter ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > some instruction about config 'kylin.metadata.hbasemapping-adapter' > --- > > Key: KYLIN-3844 > URL: https://issues.apache.org/jira/browse/KYLIN-3844 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Reporter: Yuzhang QIU >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.0.1 > > Original Estimate: 4h > Remaining Estimate: 4h > > Hi team: > When someone want to self-define hbase column family mapping, they may > need to know how to config 'kylin.metadata.hbasemapping-adapter'. > Although tracing the code at CubeDesc:around 678 will show the usage of > this configuration, some official instruction in document may be better. > Just a small suggestion. :) > >Best regards > > yuzhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[ https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090285#comment-17090285 ] ASF GitHub Bot commented on KYLIN-3844: --- zhangayqian opened a new pull request #1183: URL: https://github.com/apache/kylin/pull/1183 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > some instruction about config 'kylin.metadata.hbasemapping-adapter' > --- > > Key: KYLIN-3844 > URL: https://issues.apache.org/jira/browse/KYLIN-3844 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Reporter: Yuzhang QIU >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.0.1 > > Original Estimate: 4h > Remaining Estimate: 4h > > Hi team: > When someone want to self-define hbase column family mapping, they may > need to know how to config 'kylin.metadata.hbasemapping-adapter'. > Although tracing the code at CubeDesc:around 678 will show the usage of > this configuration, some official instruction in document may be better. > Just a small suggestion. :) > >Best regards > > yuzhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[ https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089323#comment-17089323 ] Yaqian Zhang commented on KYLIN-3844: - Hi YuZhang： Thank you for your suggestion! I will check this. > some instruction about config 'kylin.metadata.hbasemapping-adapter' > --- > > Key: KYLIN-3844 > URL: https://issues.apache.org/jira/browse/KYLIN-3844 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Reporter: Yuzhang QIU >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.0.1 > > Original Estimate: 4h > Remaining Estimate: 4h > > Hi team: > When someone want to self-define hbase column family mapping, they may > need to know how to config 'kylin.metadata.hbasemapping-adapter'. > Although tracing the code at CubeDesc:around 678 will show the usage of > this configuration, some official instruction in document may be better. > Just a small suggestion. :) > >Best regards > > yuzhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3844) some instruction about config 'kylin.metadata.hbasemapping-adapter'
[ https://issues.apache.org/jira/browse/KYLIN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784207#comment-16784207 ] Yuzhang QIU commented on KYLIN-3844: And for extensibility and robustness, Implementing a interface of extending an abstract class for hbaseMappingAdapter may be more appropriate rather then any class which contain static method 'initHBaseMapping(CubeDesc)' and 'initMeasureReferenceToColumnFailyWithChecking(CubeDesc)'. > some instruction about config 'kylin.metadata.hbasemapping-adapter' > --- > > Key: KYLIN-3844 > URL: https://issues.apache.org/jira/browse/KYLIN-3844 > Project: Kylin > Issue Type: Improvement > Components: Documentation >Affects Versions: v2.5.2 >Reporter: Yuzhang QIU >Priority: Minor > > Hi team: > When someone want to self-define hbase column family mapping, they may > need to know how to config 'kylin.metadata.hbasemapping-adapter'. > Although tracing the code at CubeDesc:around 678 will show the usage of > this configuration, some official instruction in document may be better. > Just a small suggestion. :) > >Best regards > > yuzhang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
