[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838430#comment-16838430 ] ASF subversion and git services commented on KYLIN-3968: Commit 20b3721a88e52df447ca640236526d545145da11 in kylin's branch refs/heads/2.6.x-hadoop3.1 from majie [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=20b3721 ] KYLIN-3968 Customized precision doesn't work in web > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837084#comment-16837084 ] ASF subversion and git services commented on KYLIN-3968: Commit 20b3721a88e52df447ca640236526d545145da11 in kylin's branch refs/heads/2.6.x from majie [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=20b3721 ] KYLIN-3968 Customized precision doesn't work in web > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837085#comment-16837085 ] nichunen commented on KYLIN-3968: - Committed to 2.6.x branch > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829893#comment-16829893 ] Jack commented on KYLIN-3968: - [~nichunen] It's my pleasure :) . Thank you for your advise and help. > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829250#comment-16829250 ] nichunen commented on KYLIN-3968: - [~maji...@163.com] Hi, Jack. Pr reviewed, it's fine to me. Code merged. Thanks for your contribution. > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829249#comment-16829249 ] ASF subversion and git services commented on KYLIN-3968: Commit 956ecde679285a8bac7289779b091e2e7f4d1b04 in kylin's branch refs/heads/master from majie [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=956ecde ] KYLIN-3968 Customized precision doesn't work in web > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829248#comment-16829248 ] ASF GitHub Bot commented on KYLIN-3968: --- nichunen commented on pull request #623: KYLIN-3968 Customized precision doesn't work in web URL: https://github.com/apache/kylin/pull/623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3968) Customized precision doesn't work in web
[ https://issues.apache.org/jira/browse/KYLIN-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827924#comment-16827924 ] ASF GitHub Bot commented on KYLIN-3968: --- majic31 commented on pull request #623: KYLIN-3968 Customized precision doesn't work in web URL: https://github.com/apache/kylin/pull/623 In the cubeMeasures.js, It will withdraw precision and scale by using Regular Expression. The scale parameter is ok, but precision use the magic number 19. So we fixed it, In cubeMeasures.js, around line 469: “var precision = 19;” --> "var precision = returnValue[2] || 0;" and we test ok including building cube and querying when the column is decimal(38,18). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Customized precision doesn't work in web > > > Key: KYLIN-3968 > URL: https://issues.apache.org/jira/browse/KYLIN-3968 > Project: Kylin > Issue Type: Bug > Components: Web >Reporter: Jack >Priority: Minor > Fix For: v2.6.2 > > > In the cubeMeasures.js, It will withdraw precision and scale by using Regular > Expression. The scale parameter is ok, but precision use the magic number 19. > So we fixed it, In cubeMeasures.js, around line 469: > “var precision = 19;” --> "var precision = returnValue[2] || 0;" > and we test ok including building cube and querying when the column is > decimal(38,18). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
