[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202165#comment-17202165 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1423: URL: https://github.com/apache/kylin/pull/1423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202156#comment-17202156 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1423: URL: https://github.com/apache/kylin/pull/1423#issuecomment-698135437 This looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201298#comment-17201298 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1423: URL: https://github.com/apache/kylin/pull/1423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201297#comment-17201297 ] ASF subversion and git services commented on KYLIN-4660: Commit 23d06772a46451d45475db8f31c88154e70fbaaf in kylin's branch refs/heads/kylin-on-parquet-v2 from Zhichao Zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=23d0677 ] KYLIN-4660 Remove some unused code from FilePruner.scala (cherry picked from commit 109598539dd22bc17a218de03e3125a90fda43f1) > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201296#comment-17201296 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1423: URL: https://github.com/apache/kylin/pull/1423#issuecomment-698135437 This looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201204#comment-17201204 ] ASF GitHub Bot commented on KYLIN-4660: --- zzcclp opened a new pull request #1423: URL: https://github.com/apache/kylin/pull/1423 (cherry picked from commit 109598539dd22bc17a218de03e3125a90fda43f1) ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193521#comment-17193521 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1404: URL: https://github.com/apache/kylin/pull/1404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193522#comment-17193522 ] ASF subversion and git services commented on KYLIN-4660: Commit bb4130d5455f5bc462ad4d6703da47ec1546e4fc in kylin's branch refs/heads/kylin-on-parquet-v2 from Zhichao Zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=bb4130d ] KYLIN-4660 Add parameter 'skipRunIt' for maven to support running 'Integration Test' > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193523#comment-17193523 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1404: URL: https://github.com/apache/kylin/pull/1404#issuecomment-690143036 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193335#comment-17193335 ] ASF GitHub Bot commented on KYLIN-4660: --- zzcclp commented on pull request #1404: URL: https://github.com/apache/kylin/pull/1404#issuecomment-689959610 > This pull request **introduces 1 alert** when merging [fe8bc3a](https://github.com/apache/kylin/commit/fe8bc3ab6bde31e93ae63480ef6ea84e245523af) into [f7c4ede](https://github.com/apache/kylin/commit/f7c4ede01c6b9b46c1b007d94500038789a94fc6) - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-cc89a928847b7108adfc8b69fa4cc8a56588ea7a) > > **new alerts:** > > * 1 for Missing format argument Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193323#comment-17193323 ] ASF GitHub Bot commented on KYLIN-4660: --- lgtm-com[bot] commented on pull request #1404: URL: https://github.com/apache/kylin/pull/1404#issuecomment-689951663 This pull request **introduces 1 alert** when merging fe8bc3ab6bde31e93ae63480ef6ea84e245523af into f7c4ede01c6b9b46c1b007d94500038789a94fc6 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-cc89a928847b7108adfc8b69fa4cc8a56588ea7a) **new alerts:** * 1 for Missing format argument This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193312#comment-17193312 ] ASF GitHub Bot commented on KYLIN-4660: --- zzcclp opened a new pull request #1404: URL: https://github.com/apache/kylin/pull/1404 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192119#comment-17192119 ] ASF subversion and git services commented on KYLIN-4660: Commit bc94f4978bc3009a5ad7853c2c6f86c8f2f1c39d in kylin's branch refs/heads/kylin-on-parquet-v2 from Xiaoxiang Yu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=bc94f49 ] KYLIN-4660 Refine kylin-default.properties > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191430#comment-17191430 ] ASF subversion and git services commented on KYLIN-4660: Commit 53b62a9bd11c6d5b2e3be9ca099f57309238241f in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=53b62a9 ] KYLIN-4660 FIX UT > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191322#comment-17191322 ] ASF subversion and git services commented on KYLIN-4660: Commit 83ac152b9812a973d6fb778f2db072f58bd72744 in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=83ac152 ] KYLIN-4660 FIX UT > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191313#comment-17191313 ] ASF subversion and git services commented on KYLIN-4660: Commit 524e2da496b86e22590cf8e46ab7766a819b1e25 in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=524e2da ] KYLIN-4660 Fix QueryMetricsTest - QueryMetricsTest will not start a sparder context. - Skip some module because I want to make sure UT pass at 30 mins. > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191307#comment-17191307 ] ASF subversion and git services commented on KYLIN-4660: Commit a31a2b11d9334f9817663a32e0a084f957ad63f4 in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a31a2b1 ] KYLIN-4660 Fix QueryMetricsTest - QueryMetricsTest will not start a sparder context. - Skip some module because I want to make sure UT pass at 30 mins. > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191309#comment-17191309 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus closed pull request #1399: URL: https://github.com/apache/kylin/pull/1399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191302#comment-17191302 ] ASF subversion and git services commented on KYLIN-4660: Commit 11475536e42bc742757599a1a53738de5e4485dd in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=1147553 ] KYLIN-4660 Cleanup > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191295#comment-17191295 ] ASF subversion and git services commented on KYLIN-4660: Commit 97db36c0fc8480b1dbb89bf34eab845e95dc739f in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=97db36c ] KYLIN-4660 Remove some module from maven project Some feature is plan to be removed in Kylin 4.X, let us keep the source code clean. > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191291#comment-17191291 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1399: URL: https://github.com/apache/kylin/pull/1399#issuecomment-687810547 I will merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191259#comment-17191259 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus opened a new pull request #1399: URL: https://github.com/apache/kylin/pull/1399 - QueryMetricsTest will not start a sparder context. - Skip some module because I want to make sure UT pass at 30 mins. ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190234#comment-17190234 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1393: URL: https://github.com/apache/kylin/pull/1393#issuecomment-686578769 I will merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190236#comment-17190236 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1393: URL: https://github.com/apache/kylin/pull/1393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190235#comment-17190235 ] ASF subversion and git services commented on KYLIN-4660: Commit 11475536e42bc742757599a1a53738de5e4485dd in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=1147553 ] KYLIN-4660 Cleanup > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190211#comment-17190211 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus opened a new pull request #1393: URL: https://github.com/apache/kylin/pull/1393 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: Xiaoxiang Yu >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185686#comment-17185686 ] ASF subversion and git services commented on KYLIN-4660: Commit 621868cb04d03df9683bb4c2508afc92f23058ad in kylin's branch refs/heads/kylin-on-parquet-v2 from Zhichao Zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=621868c ] KYLIN-4660 remove deprecated config 'spark.yarn.executor.memoryOverhead' > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185682#comment-17185682 ] ASF subversion and git services commented on KYLIN-4660: Commit 7a336fab3eb9c5bb931eba031f9249f334fad066 in kylin's branch refs/heads/kylin-on-parquet-v2 from Zhichao Zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=7a336fa ] KYLIN-4660 Remove duplicated/misleading code or comment > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-alpha > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183750#comment-17183750 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1371: URL: https://github.com/apache/kylin/pull/1371 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183751#comment-17183751 ] ASF subversion and git services commented on KYLIN-4660: Commit ccdff322431e90eef8807f3fd3eb9870b726d73c in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=ccdff32 ] KYLIN-4660 Add comparison with prepared data set > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183360#comment-17183360 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus opened a new pull request #1371: URL: https://github.com/apache/kylin/pull/1371 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182812#comment-17182812 ] ASF subversion and git services commented on KYLIN-4660: Commit 656d9f3c923b18610aa93a9975a5eb6a9f2d8ec8 in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=656d9f3 ] KYLIN-4660 Cleanup for IT and logger > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > https://cwiki.apache.org/confluence/display/KYLIN/Kylin+4.X+Feature+List -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168363#comment-17168363 ] ASF subversion and git services commented on KYLIN-4660: Commit dc1a80f2c1ad11fbd821014ae7975bb11c6db1d1 in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=dc1a80f ] KYLIN-4660 fix package.sh > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168364#comment-17168364 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1336: URL: https://github.com/apache/kylin/pull/1336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168362#comment-17168362 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1336: URL: https://github.com/apache/kylin/pull/1336#issuecomment-666892996 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167710#comment-17167710 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus opened a new pull request #1336: URL: https://github.com/apache/kylin/pull/1336 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[
https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166985#comment-17166985
]
ASF GitHub Bot commented on KYLIN-4660:
---
hit-lacus commented on a change in pull request #1332:
URL: https://github.com/apache/kylin/pull/1332#discussion_r462028446
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeDictionaryBuilder.scala
##
@@ -70,7 +70,7 @@ class DFDictionaryBuilder(val dataset: Dataset[Row],
val columnName = ref.identity
logInfo(s"Start building global dictionaries V2 for column $columnName.")
Review comment:
V2 need to be removed?
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/ParentSourceChooser.scala
##
@@ -163,7 +162,6 @@ class ParentSourceChooser(
val flatTable = new CreateFlatTable(seg, toBuildTree, ss, sourceInfo)
val afterJoin: Dataset[Row] = flatTable.generateDataset(needEncoding, true)
sourceInfo.setFlattableDS(afterJoin)
-sourceInfo.setCount(afterJoin.count())
Review comment:
Good catch!
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CubeBuildJob.java
##
@@ -120,7 +120,7 @@ protected void doExecute() throws Exception {
infos.recordSpanningTree(segId, spanningTree);
logger.info("Updating segment info");
-updateSegmentInfo(getParam(MetadataConstants.P_CUBE_ID), seg,
buildFromFlatTable.getCount());
+updateSegmentInfo(getParam(MetadataConstants.P_CUBE_ID), seg,
buildFromFlatTable.getParentDS().count());
Review comment:
What's the reason of `getParentDS`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove duplicated/misleading code or comment
>
>
> Key: KYLIN-4660
> URL: https://issues.apache.org/jira/browse/KYLIN-4660
> Project: Kylin
> Issue Type: Sub-task
> Components: Storage - Parquet
>Reporter: Xiaoxiang Yu
>Assignee: wangrupeng
>Priority: Major
> Fix For: v4.0.0-beta
>
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> Source code is located at
> [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still
> test and verify it.
>
>
> ||Feature to be removed||commit id||Jira ID for the feature||
> |Advanced Snapshot|todo|todo|
> |JDBC Source|todo| |
> |Kafka Source (NRT)|todo| |
> |Kafka Source (Real-time OLAP)|todo| |
> | Build Engine - MR|todo| |
> | Build Engine - Spark|todo| |
> | Build Engine - Flink|todo| |
> | Storgae Engine - HBase|todo| |
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[
https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167037#comment-17167037
]
ASF GitHub Bot commented on KYLIN-4660:
---
RupengWang commented on a change in pull request #1332:
URL: https://github.com/apache/kylin/pull/1332#discussion_r462032895
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CubeBuildJob.java
##
@@ -120,7 +120,7 @@ protected void doExecute() throws Exception {
infos.recordSpanningTree(segId, spanningTree);
logger.info("Updating segment info");
-updateSegmentInfo(getParam(MetadataConstants.P_CUBE_ID), seg,
buildFromFlatTable.getCount());
+updateSegmentInfo(getParam(MetadataConstants.P_CUBE_ID), seg,
buildFromFlatTable.getParentDS().count());
Review comment:
Well, it'd be better to use getFlattableDS.
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeDictionaryBuilder.scala
##
@@ -70,7 +70,7 @@ class DFDictionaryBuilder(val dataset: Dataset[Row],
val columnName = ref.identity
logInfo(s"Start building global dictionaries V2 for column $columnName.")
Review comment:
Right, there're still some logs need to be modified.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove duplicated/misleading code or comment
>
>
> Key: KYLIN-4660
> URL: https://issues.apache.org/jira/browse/KYLIN-4660
> Project: Kylin
> Issue Type: Sub-task
> Components: Storage - Parquet
>Reporter: Xiaoxiang Yu
>Assignee: wangrupeng
>Priority: Major
> Fix For: v4.0.0-beta
>
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> Source code is located at
> [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still
> test and verify it.
>
>
> ||Feature to be removed||commit id||Jira ID for the feature||
> |Advanced Snapshot|todo|todo|
> |JDBC Source|todo| |
> |Kafka Source (NRT)|todo| |
> |Kafka Source (Real-time OLAP)|todo| |
> | Build Engine - MR|todo| |
> | Build Engine - Spark|todo| |
> | Build Engine - Flink|todo| |
> | Storgae Engine - HBase|todo| |
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167023#comment-17167023 ] ASF GitHub Bot commented on KYLIN-4660: --- RupengWang opened a new pull request #1332: URL: https://github.com/apache/kylin/pull/1332 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166973#comment-17166973 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1332: URL: https://github.com/apache/kylin/pull/1332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166956#comment-17166956 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus merged pull request #1327: URL: https://github.com/apache/kylin/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166893#comment-17166893 ] ASF subversion and git services commented on KYLIN-4660: Commit 5764e4797c90b3c9225c5c5c8c1d4fea27fe59a4 in kylin's branch refs/heads/kylin-on-parquet-v2 from rupengwang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=5764e47 ] KYLIN-4660 Normalize variable and file naming > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166062#comment-17166062 ] ASF subversion and git services commented on KYLIN-4660: Commit db866b7d0a9e6a1911a367e393c9c1f9018fa71f in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=db866b7 ] KYLIN-4660 remove some unsupported features - Advanced snapshot - Shrunken dictionary > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166063#comment-17166063 ] ASF subversion and git services commented on KYLIN-4660: Commit 82045c24a4b1cc3c4e541ec66acbf8009878d41f in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=82045c2 ] KYLIN-4660 Fix UT and compile error > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166061#comment-17166061 ] ASF subversion and git services commented on KYLIN-4660: Commit db1eba82b3c6a538f9b12f814e77f410157e3a83 in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=db1eba8 ] KYLIN-4660 remove some useless modules > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166060#comment-17166060 ] ASF subversion and git services commented on KYLIN-4660: Commit a8de6d49135c4efc9afd68ffd3f7c306a1367dee in kylin's branch refs/heads/kylin-on-parquet-v2 from XiaoxiangYu [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a8de6d4 ] KYLIN-4660 Create two module > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165420#comment-17165420 ] ASF GitHub Bot commented on KYLIN-4660: --- lgtm-com[bot] commented on pull request #1327: URL: https://github.com/apache/kylin/pull/1327#issuecomment-664108015 This pull request **fixes 38 alerts** when merging 97db36c0fc8480b1dbb89bf34eab845e95dc739f into 95b1af050a708dbd16710e530a8df10335eb09fd - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-c14a55c9e0bf742561fcca4f6996263e863d88ff) **fixed alerts:** * 8 for Dereferenced variable may be null * 6 for Boxed variable is never null * 5 for Implicit narrowing conversion in compound assignment * 4 for Useless null check * 3 for Useless comparison test * 2 for Implicit conversion from array to string * 2 for Spurious Javadoc @param tags * 2 for Unused format argument * 2 for Potential input resource leak * 1 for Result of multiplication cast to wider type * 1 for Potential database resource leak * 1 for Potential output resource leak * 1 for Iterable wrapping an iterator This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165374#comment-17165374 ] ASF GitHub Bot commented on KYLIN-4660: --- lgtm-com[bot] commented on pull request #1327: URL: https://github.com/apache/kylin/pull/1327#issuecomment-664064157 This pull request **fixes 38 alerts** when merging 9ff4b7eca700ead4d76fac50a364d114df9b2137 into 95b1af050a708dbd16710e530a8df10335eb09fd - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-079b44d1d9ec6604495b8fd708ab1f7b86a9ff95) **fixed alerts:** * 8 for Dereferenced variable may be null * 6 for Boxed variable is never null * 5 for Implicit narrowing conversion in compound assignment * 4 for Useless null check * 3 for Useless comparison test * 2 for Implicit conversion from array to string * 2 for Spurious Javadoc @param tags * 2 for Unused format argument * 2 for Potential input resource leak * 1 for Result of multiplication cast to wider type * 1 for Potential database resource leak * 1 for Potential output resource leak * 1 for Iterable wrapping an iterator This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165373#comment-17165373 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus edited a comment on pull request #1327: URL: https://github.com/apache/kylin/pull/1327#issuecomment-664062646 Travis-CI failed because log size exceed limit. We should open another ticket to fix this.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165372#comment-17165372 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus edited a comment on pull request #1327: URL: https://github.com/apache/kylin/pull/1327#issuecomment-664062646 Travis-CI failed because log size exceed limit.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165371#comment-17165371 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1327: URL: https://github.com/apache/kylin/pull/1327#issuecomment-664062646 Travis-CI failed because log size exceed limit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165369#comment-17165369 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus commented on pull request #1327: URL: https://github.com/apache/kylin/pull/1327#issuecomment-664060095  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Fix For: v4.0.0-beta > > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. > > > ||Feature to be removed||commit id||Jira ID for the feature|| > |Advanced Snapshot|todo|todo| > |JDBC Source|todo| | > |Kafka Source (NRT)|todo| | > |Kafka Source (Real-time OLAP)|todo| | > | Build Engine - MR|todo| | > | Build Engine - Spark|todo| | > | Build Engine - Flink|todo| | > | Storgae Engine - HBase|todo| | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-4660) Remove duplicated/misleading code or comment
[ https://issues.apache.org/jira/browse/KYLIN-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163687#comment-17163687 ] ASF GitHub Bot commented on KYLIN-4660: --- hit-lacus opened a new pull request #1327: URL: https://github.com/apache/kylin/pull/1327 Some feature is plan to be removed in Kylin 4.X, let us keep the source code and remove them from maven. ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove duplicated/misleading code or comment > > > Key: KYLIN-4660 > URL: https://issues.apache.org/jira/browse/KYLIN-4660 > Project: Kylin > Issue Type: Sub-task > Components: Storage - Parquet >Reporter: Xiaoxiang Yu >Assignee: wangrupeng >Priority: Major > Original Estimate: 672h > Remaining Estimate: 672h > > Source code is located at > [https://github.com/apache/kylin/tree/kylin-on-parquet-v2] , we are still > test and verify it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
