[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619332#comment-17619332 ] ASF GitHub Bot commented on KYLIN-5238: --- hit-lacus commented on PR #1966: URL: https://github.com/apache/kylin/pull/1966#issuecomment-1281997542 This patch looks good to me. > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: Liu Zhao >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599871#comment-17599871 ] ASF GitHub Bot commented on KYLIN-5238: --- zhaoliu17 closed pull request #1952: KYLIN-5238 add cleanup cube_statistics URL: https://github.com/apache/kylin/pull/1952 > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599870#comment-17599870 ] ASF GitHub Bot commented on KYLIN-5238: --- zhaoliu17 opened a new pull request, #1966: URL: https://github.com/apache/kylin/pull/1966 ## Proposed changes 我认为在 kylin4 的StorageCleanupJob 中增加对无引用的 cube_stataistics 数据清理是有意义的： 1. 可以降低无用数据占用的存储空间，同时避免过多无用小文件对nn的压力 2. 默认情况下清理无引用的 cube_stataistics 数据，但可以通过 -cleanupCubeStatistics false 禁用 ## Branch to commit - [ ] Branch **kylin3** for v2.x to v3.x - [ ] Branch **kylin4** for v4.x - [ ] Branch **kylin5** for v5.x ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585088#comment-17585088 ] ASF GitHub Bot commented on KYLIN-5238: --- hit-lacus commented on PR #1952: URL: https://github.com/apache/kylin/pull/1952#issuecomment-1227919019 Hi, @zhaoliu17 , please check if your patch passed the unit test.  > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585086#comment-17585086 ] Xiaoxiang Yu commented on KYLIN-5238: - Thanks for contribution, I will check it. > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KYLIN-5238) StorageCleanupJob add cleanup cube_statistics
[ https://issues.apache.org/jira/browse/KYLIN-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584111#comment-17584111 ] ASF GitHub Bot commented on KYLIN-5238: --- zhaoliu17 opened a new pull request, #1952: URL: https://github.com/apache/kylin/pull/1952 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Github Branch As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 : 1. The default branch _main_ is for **Kylin 4.x** (Parquet storage); 2. The original branch _master_ for **Kylin 3.x** (HBase storage) has been renamed to **kylin3** ; Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc... > StorageCleanupJob add cleanup cube_statistics > - > > Key: KYLIN-5238 > URL: https://issues.apache.org/jira/browse/KYLIN-5238 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v4.0.1 >Reporter: zhaoliu >Priority: Minor > > 在 StorageCleanupJob 中增加对 cube_statistics 数据的清理 -- This message was sent by Atlassian Jira (v8.20.10#820010)
