[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success

2022-12-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645923#comment-17645923
 ] 

ASF GitHub Bot commented on KYLIN-5245:
---

liuzhao-lz opened a new pull request, #2046:
URL: https://github.com/apache/kylin/pull/2046

   ## Proposed changes
   
   对已修复的bug,选用更合理的实现方式.
   
   ## Branch to commit
   - [ ] Branch **kylin3** for v2.x to v3.x
   - [x] Branch **kylin4** for v4.x
   - [ ] Branch **kylin5** for v5.x
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have created an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] I have added necessary documentation (if appropriate)
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the 
solution you did and what alternatives you considered, etc...
   




> When a job is submitted with deployMode=cluster and the application driver is 
> abnormal, Kylin displays the job status as success
> 
>
> Key: KYLIN-5245
> URL: https://issues.apache.org/jira/browse/KYLIN-5245
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: Liu Zhao
>Priority: Major
> Attachments: image-2022-08-31-14-34-56-081.png
>
>
>  !image-2022-08-31-14-34-56-081.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success

2022-10-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617631#comment-17617631
 ] 

ASF subversion and git services commented on KYLIN-5245:


Commit 6face85dd87385aa19f355cb23ac7a3448254378 in kylin's branch 
refs/heads/main from Liu Zhao
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=6face85dd8 ]

KYLIN-5245 fix incorrect job status is displayed when deployMode is cluster 
execution error (#1959)

Co-authored-by: zhaoliu4 
Co-authored-by: XiaoxiangYu 

> When a job is submitted with deployMode=cluster and the application driver is 
> abnormal, Kylin displays the job status as success
> 
>
> Key: KYLIN-5245
> URL: https://issues.apache.org/jira/browse/KYLIN-5245
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: Liu Zhao
>Priority: Major
> Attachments: image-2022-08-31-14-34-56-081.png
>
>
>  !image-2022-08-31-14-34-56-081.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success

2022-10-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617630#comment-17617630
 ] 

ASF GitHub Bot commented on KYLIN-5245:
---

hit-lacus merged PR #1959:
URL: https://github.com/apache/kylin/pull/1959




> When a job is submitted with deployMode=cluster and the application driver is 
> abnormal, Kylin displays the job status as success
> 
>
> Key: KYLIN-5245
> URL: https://issues.apache.org/jira/browse/KYLIN-5245
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: Liu Zhao
>Priority: Major
> Attachments: image-2022-08-31-14-34-56-081.png
>
>
>  !image-2022-08-31-14-34-56-081.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success

2022-09-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599829#comment-17599829
 ] 

ASF GitHub Bot commented on KYLIN-5245:
---

zhaoliu17 commented on PR #1959:
URL: https://github.com/apache/kylin/pull/1959#issuecomment-1236068041

   好的,我将添加变更描述




> When a job is submitted with deployMode=cluster and the application driver is 
> abnormal, Kylin displays the job status as success
> 
>
> Key: KYLIN-5245
> URL: https://issues.apache.org/jira/browse/KYLIN-5245
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: zhaoliu
>Priority: Major
> Attachments: image-2022-08-31-14-34-56-081.png
>
>
>  !image-2022-08-31-14-34-56-081.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success

2022-09-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599822#comment-17599822
 ] 

ASF GitHub Bot commented on KYLIN-5245:
---

liyang-kylin commented on PR #1959:
URL: https://github.com/apache/kylin/pull/1959#issuecomment-1236062567

   需要更多信息在 PR 描述里,比如 Proposed changes 等。




> When a job is submitted with deployMode=cluster and the application driver is 
> abnormal, Kylin displays the job status as success
> 
>
> Key: KYLIN-5245
> URL: https://issues.apache.org/jira/browse/KYLIN-5245
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: zhaoliu
>Priority: Major
> Attachments: image-2022-08-31-14-34-56-081.png
>
>
>  !image-2022-08-31-14-34-56-081.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KYLIN-5245) When a job is submitted with deployMode=cluster and the application driver is abnormal, Kylin displays the job status as success

2022-08-31 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/KYLIN-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598228#comment-17598228
 ] 

ASF GitHub Bot commented on KYLIN-5245:
---

zhaoliu17 opened a new pull request, #1959:
URL: https://github.com/apache/kylin/pull/1959

   …luster execution error
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Branch to commit
   - [ ] Branch **kylin3** for v2.x to v3.x
   - [ ] Branch **kylin4** for v4.x
   - [ ] Branch **kylin5** for v5.x
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have created an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN- Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] I have added necessary documentation (if appropriate)
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
u...@kylin.apache.org or d...@kylin.apache.org by explaining why you chose the 
solution you did and what alternatives you considered, etc...
   




> When a job is submitted with deployMode=cluster and the application driver is 
> abnormal, Kylin displays the job status as success
> 
>
> Key: KYLIN-5245
> URL: https://issues.apache.org/jira/browse/KYLIN-5245
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v4.0.1
>Reporter: zhaoliu
>Priority: Major
> Attachments: image-2022-08-31-14-34-56-081.png
>
>
>  !image-2022-08-31-14-34-56-081.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)