[jira] [Updated] (KYLIN-4132) Kylin needn't use "org.apache.directory.api.util.Strings" to import api-util.jar
[ https://issues.apache.org/jira/browse/KYLIN-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen updated KYLIN-4132: Fix Version/s: v2.6.6 > Kylin needn't use "org.apache.directory.api.util.Strings" to import > api-util.jar > > > Key: KYLIN-4132 > URL: https://issues.apache.org/jira/browse/KYLIN-4132 > Project: Kylin > Issue Type: Improvement > Components: REST Service > Environment: Fusion Insight >Reporter: zhao jintao >Assignee: wangrupeng >Priority: Major > Fix For: v3.0.2, v2.6.6 > > Original Estimate: 168h > Remaining Estimate: 168h > > Hi Team: > I read kylin code find that JobService class and ProjectService class import > "org.apache.directory.api.util.Strings" use the function of > "Strings.isEmpty(String)" from "api-util.jar" to judge whether a string is > empty. > This function can be replaced by importing > "org.apache.commons.lang.StringUtils" use "StringUtils.isEmpty(String)" from > “common-lang.jar”. > The "api-util.jar" was dependent by hbase-client. When kylin build, > there isn't "api-util.jar" in kylin.war. When start kylin process, it will be > imported from hbase client lib. But if hbase client doesn't dependency > "api-util.jar", kylin running failed and will throw exception. > In fact, I encountered this problem in the latest Fusion-Insignt version. > Kylin start failed because there isn't "api-util.jar" in hbase client lib. > > So I suggest replace "org.apache.directory.api.util.Strings.isEmpty(String)" > to "org.apache.commons.lang.StringUtils.isEmpty(String)" to avoid this > problem. > Best wishes > Yours zjt. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KYLIN-4132) Kylin needn't use "org.apache.directory.api.util.Strings" to import api-util.jar
[ https://issues.apache.org/jira/browse/KYLIN-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Feng Shi updated KYLIN-4132: - Fix Version/s: v3.0.2 > Kylin needn't use "org.apache.directory.api.util.Strings" to import > api-util.jar > > > Key: KYLIN-4132 > URL: https://issues.apache.org/jira/browse/KYLIN-4132 > Project: Kylin > Issue Type: Improvement > Components: REST Service > Environment: Fusion Insight >Reporter: zhao jintao >Assignee: wangrupeng >Priority: Major > Fix For: v3.0.2 > > Original Estimate: 168h > Remaining Estimate: 168h > > Hi Team: > I read kylin code find that JobService class and ProjectService class import > "org.apache.directory.api.util.Strings" use the function of > "Strings.isEmpty(String)" from "api-util.jar" to judge whether a string is > empty. > This function can be replaced by importing > "org.apache.commons.lang.StringUtils" use "StringUtils.isEmpty(String)" from > “common-lang.jar”. > The "api-util.jar" was dependent by hbase-client. When kylin build, > there isn't "api-util.jar" in kylin.war. When start kylin process, it will be > imported from hbase client lib. But if hbase client doesn't dependency > "api-util.jar", kylin running failed and will throw exception. > In fact, I encountered this problem in the latest Fusion-Insignt version. > Kylin start failed because there isn't "api-util.jar" in hbase client lib. > > So I suggest replace "org.apache.directory.api.util.Strings.isEmpty(String)" > to "org.apache.commons.lang.StringUtils.isEmpty(String)" to avoid this > problem. > Best wishes > Yours zjt. -- This message was sent by Atlassian Jira (v8.3.4#803005)
