[GitHub] [lucene] gus-asf commented on pull request #12096: remove username from MANIFEST.MF in build artifacts
gus-asf commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1399171309 I don't understand what you mean by differentiate artifacts for the same commit hash. How would a time stamp do this? If they are different artifacts the contents and the name are all different, and a timestamp doesn't actually tell you which is which anyway. If they are the "same" artifact from the same commit hash, every bit of difference is a bad thing, creating doubt about whether or not they are actually equivalent. The point of repeatability is that if you build the same artifact from the same commit hash it should contain the same bytes in the same order and the sha/md5 hashes should be the same. Putting timestamps and usernames in the files makes them non-reproducible (there's also some question of how much detail about the build OS is worth while for this too, but that's a harder question) So adding information that tells the user what conditions are necessary to reproduce the artifact is good (JDK, OS, etc) but adding a timestamp that they can't ever hope to reproduce (without mindless post processing doesn't help. As I said it would only be progress towards a goal which takes additional changes to realize. For example zips and jars also embed time stamps, but there are ways of dealing with that... https://wiki.debian.org/ReproducibleBuilds/TimestampsInZip In any case this is a set of folks who's arguments seemed persuasive to me: https://reproducible-builds.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] magibney commented on pull request #12096: remove username from MANIFEST.MF in build artifacts
magibney commented on PR #12096:
URL: https://github.com/apache/lucene/pull/12096#issuecomment-1399161958
MANIFEST.MF `ImplementationVersion` field does include the revision hash --
`${gitRev}` in the line that's edited in this PR. I think the build date/time
is a potentially useful bit of metadata, if nothing else to fall back on to
differentiate artifacts for the same commit hash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] gus-asf commented on pull request #12096: remove username from MANIFEST.MF in build artifacts
gus-asf commented on PR #12096: URL: https://github.com/apache/lucene/pull/12096#issuecomment-1399159488 While we are at it maybe we should remove the timestamp too. It really ought to be a revision hash. This moves toward making the build repeatable. It's not actually important which day it was built, what's important is which revision it was built with and if there were any uncommitted changes. I implemented this in a couple of my projects (see https://github.com/nsoft/uno-jar/blob/master/core/build.gradle#L143 for example...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on pull request #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final
janhoy commented on PR #2676: URL: https://github.com/apache/lucene-solr/pull/2676#issuecomment-1398961127 > missing solr/CHANGES.txt entry? That's right. I added it on the same line as the previous upgrade from SOLR-16424, keeping both JIRA-numbers. Do you think we should just mention this last one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] itygh commented on pull request #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final
itygh commented on PR #2676: URL: https://github.com/apache/lucene-solr/pull/2676#issuecomment-1398560219 这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy opened a new pull request, #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final
janhoy opened a new pull request, #2676: URL: https://github.com/apache/lucene-solr/pull/2676 Backport from 9.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] risdenk commented on pull request #12029: introduce support in KnnVectorQuery for getters/setters
risdenk commented on PR #12029: URL: https://github.com/apache/lucene/pull/12029#issuecomment-1398549982 Re: immutable Query in Solr - See https://issues.apache.org/jira/browse/SOLR-16509 and https://github.com/apache/solr/pull/1146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] alessandrobenedetti commented on pull request #12029: introduce support in KnnVectorQuery for getters/setters
alessandrobenedetti commented on PR #12029: URL: https://github.com/apache/lucene/pull/12029#issuecomment-1398524390 waiting for the checks and then I'll merge tonight! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #12029: introduce support in KnnVectorQuery for getters/setters
alessandrobenedetti commented on code in PR #12029: URL: https://github.com/apache/lucene/pull/12029#discussion_r1082676520 ## lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java: ## @@ -33,6 +33,7 @@ import org.apache.lucene.store.Directory; import org.apache.lucene.util.TestVectorUtil; import org.apache.lucene.util.VectorUtil; +import org.junit.Assert; Review Comment: done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mkhludnev commented on issue #11218: GraphTokenStreamFiniteStrings#articulationPointsRecurse can run into stack overflows [LUCENE-10181]
mkhludnev commented on issue #11218: URL: https://github.com/apache/lucene/issues/11218#issuecomment-1398122320 @hassenome , can you share versions, stacktrace and invocation arguments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] hassenome commented on issue #11218: GraphTokenStreamFiniteStrings#articulationPointsRecurse can run into stack overflows [LUCENE-10181]
hassenome commented on issue #11218: URL: https://github.com/apache/lucene/issues/11218#issuecomment-1398087851 Hello, We are facing this error, as a root cause for a feature used by ElasticSearch. We are wondering if there is an update to this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
