[jira] [Commented] (SOLR-14102) FacetModule use number of responses from shards as number of shards
[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008542#comment-17008542 ] Tomohiro Manabe commented on SOLR-14102: Sorry for my shortage of explanation. Our custom SearchComponent splits all shards into multiple portions without duplication or omission, then send different requests to the different portions. So in my opinion, FacetModule should hit all documents correctly by handling multiple shard requests correctly. > FacetModule use number of responses from shards as number of shards > --- > > Key: SOLR-14102 > URL: https://issues.apache.org/jira/browse/SOLR-14102 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomohiro Manabe >Priority: Major > Attachments: SOLR-14102.patch > > > Hi, I am developing a SearchComponent which sends some requests to only a > part of shards. > Basically it works well, but using it with facetting triggers an error. > I found that FacetModule use the number of responses from shards > (sreq.responses.size()) as the number of shards. > Of course this assumption is incorrect in case that only a part of shards > respond. > Instead of the number of responses, using rb.shards.length may be better. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14102) FacetModule use number of responses from shards as number of shards
[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003833#comment-17003833 ] Tomohiro Manabe commented on SOLR-14102: Thanks for reviewing. I think we need a mock SearchComponent for asserting this problem. Is this plan fine with you? > FacetModule use number of responses from shards as number of shards > --- > > Key: SOLR-14102 > URL: https://issues.apache.org/jira/browse/SOLR-14102 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomohiro Manabe >Priority: Major > Attachments: SOLR-14102.patch > > > Hi, I am developing a SearchComponent which sends some requests to only a > part of shards. > Basically it works well, but using it with facetting triggers an error. > I found that FacetModule use the number of responses from shards > (sreq.responses.size()) as the number of shards. > Of course this assumption is incorrect in case that only a part of shards > respond. > Instead of the number of responses, using rb.shards.length may be better. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14102) FacetModule use number of responses from shards as number of shards
[ https://issues.apache.org/jira/browse/SOLR-14102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomohiro Manabe updated SOLR-14102: --- Attachment: SOLR-14102.patch Status: Open (was: Open) I have attached a tiny patch. > FacetModule use number of responses from shards as number of shards > --- > > Key: SOLR-14102 > URL: https://issues.apache.org/jira/browse/SOLR-14102 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Tomohiro Manabe >Priority: Major > Attachments: SOLR-14102.patch > > > Hi, I am developing a SearchComponent which sends some requests to only a > part of shards. > Basically it works well, but using it with facetting triggers an error. > I found that FacetModule use the number of responses from shards > (sreq.responses.size()) as the number of shards. > Of course this assumption is incorrect in case that only a part of shards > respond. > Instead of the number of responses, using rb.shards.length may be better. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (SOLR-14102) FacetModule use number of responses from shards as number of shards
Tomohiro Manabe created SOLR-14102: -- Summary: FacetModule use number of responses from shards as number of shards Key: SOLR-14102 URL: https://issues.apache.org/jira/browse/SOLR-14102 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Reporter: Tomohiro Manabe Hi, I am developing a SearchComponent which sends some requests to only a part of shards. Basically it works well, but using it with facetting triggers an error. I found that FacetModule use the number of responses from shards (sreq.responses.size()) as the number of shards. Of course this assumption is incorrect in case that only a part of shards respond. Instead of the number of responses, using rb.shards.length may be better. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
