[GitHub] [lucene-solr] HoustonPutman commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build
HoustonPutman commented on pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-728176570 That's fair, we can certainly move it. I included it there because that seemed like the place to put help files for gradle usage. All of the files used in the `help.gradle` are in that directory, but I guess there's no actual requirement for that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build
HoustonPutman commented on pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-724264582 Thanks for the sanity check! I've tested pretty thoroughly, and the PR test does some checks on its own too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build
HoustonPutman commented on pull request #2020: URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-717343306 @dweiss Is the way I am declaring and obtaining variables the correct way of doing it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org