[GitHub] [lucene-solr] andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()
andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank() URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578409637 I previously did a quick grep looking for `.trim(` and found these three instances that were obvious ones to change. The edismax instance is biting us as we get occasional exceptions in production due to junk queries, so that was my priority. There are lots more that could change, though I suspect they're much less likely to receive other unusual whitespace chars than the query parsers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()
andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank() URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578408900 hi Christine - thanks for looking at this, and for the tip! I've made the change to use `StringUtils.isBlank()`, which efficiency-wise looks just the same as `isWhitespace()` to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
