dsmiley commented on a change in pull request #1942: URL: https://github.com/apache/lucene-solr/pull/1942#discussion_r498887554
########## File path: solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java ########## @@ -493,7 +493,7 @@ Action authorize() throws IOException { } if (statusCode == AuthorizationResponse.FORBIDDEN.statusCode) { if (log.isDebugEnabled()) { - log.debug("UNAUTHORIZED auth header {} context : {}, msg: {}", req.getHeader("Authorization"), context, authResponse.getMessage()); // logOk + log.debug("UNAUTHORIZED auth header {} context : {}, msg: {}", req.getHeader("Authorization"), context, authResponse.getMessage()); // nowarn Review comment: What does our source validation complain about here? Many of the logok/nowarn places look fine to me at a glance but I'm no match for the logging policeman ;-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org