dsmiley opened a new pull request #1672: URL: https://github.com/apache/lucene-solr/pull/1672
* SolrRrdBackendFactory should not be created if history is disabled * Disable MetricsHistoryHandler by default in tests * Await shutdown of all executors Interestingly, all tests passed with the history handler disabled. Isn't that a problem @sigram ? Somewhat related: I'm also inclined to make a little refactor in CoreContainer.shutdown such that `IOUtils.closeQuietly(metricsHistoryHandler.getSolrClient());` can move _into_ metricsHistoryHandler.close() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
