dweiss commented on pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#issuecomment-630892331
It's fine, although the snippet I copy-pasted showed a way which I think is more elegant in the long term: separates the actual property configuration bit from its declaration in the task. The difference is subtle - if we move the task to buildSrc, for example, the configuration can still happen in the relevant part of the script but the task stays precompiled and ready. These are tiny things that definitely can be polished later on. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
