[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-534189327 Waiting for you to update the PR with more test cases, is that correct @chenkovsky ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539152280 Would like to get this into 8.3, and release process starts in one week. @chenkovsky, do you have time to wrap it up? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539152601 Also, please add an entry in lucene/CHANGES.txt to this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539153980 @mikemccand or @msokolov are you available for quick review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-540814515 Hmm, your commit 867cbeff010ff0febbbd258368a58ddecc770b93 labeled "bug fix" is changing a ton of code and changing this PR from a quite simple low-risk patch into a more complex one. And you disabled a test, I don't know the consequences of that, are you saying the new patch has a performance hit? I have not attempted to review the patch (I don't even know the code) but invited two committers to review, so far no response. Until then it would be helpful if you could clean up any whitespace-only edits, and other things that would make it easier to understand your changes. I'll leave further review to the experts :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
