[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395418877 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; Review comment: The zkclient may get closed or recreated. Always safer to get the current one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395419029 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); Review comment: good catch. it was supposed to be `s` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395419555 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { Review comment: does it even matter? Why interrupt the thread when this thread is not doing anything at all. This is the `qtp` thread. Interrupting it makes no sense This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395419935 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { +d = coreContainer.getZkController().getZkClient().getData(path, null, null, false); +if (d == null || d.length == 0) { + rsp.add(path, null); + return; +} + +Map map = new HashMap<>(1); +map.put(WT, "raw"); +map.put(OMIT_HEADER, "true"); +req.setParams(SolrParams.wrapDefaults(new MapSolrParams(map), req.getParams())); Review comment: This is important if we are ever writing out raw content that comes from ZK. We should not use any of the `ResponseWriter` in Solr This is an automated messag
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395419984 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { +d = coreContainer.getZkController().getZkClient().getData(path, null, null, false); +if (d == null || d.length == 0) { + rsp.add(path, null); + return; +} + +Map map = new HashMap<>(1); +map.put(WT, "raw"); +map.put(OMIT_HEADER, "true"); +req.setParams(SolrParams.wrapDefaults(new MapSolrParams(map), req.getParams())); + + +rsp.add(CONTENT, new ContentStreamBase.ByteArrayStream(d, null, +d[0] == '{' ? CommonParams.JSON_MIME : BinaryResponseParser.BINARY_CONTENT_TYPE)); + + } + +} catch (Exception e) { Review comment: it does n
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395420255 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { Review comment: fixing it. you can explicitly request for the node data using a param `leaf=true` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r395421010 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java ## @@ -74,6 +78,39 @@ public void tearDown() throws Exception { super.tearDown(); } + @Test + public void testZkread() throws Exception { +URL baseUrl = cluster.getJettySolrRunner(0).getBaseUrl(); +String basezk = baseUrl.toString().replace("/solr", "/api") + "/cluster/zk"; + +try( HttpSolrClient client = new HttpSolrClient.Builder(baseUrl.toString()).build()) { + Object o = Utils.executeGET(client.getHttpClient(), + basezk + "/security.json", + Utils.JSONCONSUMER ); + assertNotNull(o); + o = Utils.executeGET(client.getHttpClient(), + basezk + "/configs", + Utils.JSONCONSUMER ); + assertEquals("0", String.valueOf(getObjectByPath(o,true, split(":/configs:_default:dataLength",':'; + assertEquals("0", String.valueOf(getObjectByPath(o,true, split(":/configs:conf:dataLength",':'; + byte[] bytes = new byte[1024*5]; + for (int i = 0; i < bytes.length; i++) { +bytes[i] = (byte) random().nextInt(128); Review comment: this was the easiest way to create a `byte[]` . could use anything else. But this code was simpler This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r396164857 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { Review comment: Please take a look at the latest * NoNodeException returns with a `404` * Other Exceptions return with `500` This is supposed to just fail fast if there is a problem. It does not need to be any more sophisticated than that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail:
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r396288196 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperReadTest.java ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.lang.invoke.MethodHandles; +import java.net.URL; +import java.util.Map; + +import org.apache.solr.client.solrj.impl.HttpSolrClient; +import org.apache.solr.cloud.SolrCloudTestCase; +import org.apache.solr.common.util.Utils; +import org.apache.zookeeper.CreateMode; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.solr.common.util.StrUtils.split; +import static org.apache.solr.common.util.Utils.getObjectByPath; + +public class ZookeeperReadTest extends SolrCloudTestCase { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + @BeforeClass + public static void setupCluster() throws Exception { +configureCluster(1) +.addConfig("conf", configset("cloud-minimal")) +.configure(); + } + + @Before + @Override + public void setUp() throws Exception { +super.setUp(); + } + + @After + @Override + public void tearDown() throws Exception { +super.tearDown(); + } + + @Test + public void testZkread() throws Exception { +URL baseUrl = cluster.getJettySolrRunner(0).getBaseUrl(); +String basezk = baseUrl.toString().replace("/solr", "/api") + "/cluster/zk"; + +try (HttpSolrClient client = new HttpSolrClient.Builder(baseUrl.toString()).build()) { + Object o = Utils.executeGET(client.getHttpClient(), + basezk + "/security.json", + Utils.JSONCONSUMER); + assertNotNull(o); + o = Utils.executeGET(client.getHttpClient(), + basezk + "/configs", + Utils.JSONCONSUMER); + assertEquals("0", String.valueOf(getObjectByPath(o, true, split(":/configs:_default:dataLength", ':'; + assertEquals("0", String.valueOf(getObjectByPath(o, true, split(":/configs:conf:dataLength", ':'; + + o = Utils.executeGET(client.getHttpClient(), + basezk + "/configs?leaf=true", + Utils.JSONCONSUMER); + assertTrue(((Map)o).containsKey("/configs")); Review comment: what are the warnings? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r396368718 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { +d = coreContainer.getZkController().getZkClient().getData(path, null, null, false); +if (d == null || d.length == 0) { + rsp.add(path, null); + return; +} + +Map map = new HashMap<>(1); +map.put(WT, "raw"); +map.put(OMIT_HEADER, "true"); +req.setParams(SolrParams.wrapDefaults(new MapSolrParams(map), req.getParams())); + + +rsp.add(CONTENT, new ContentStreamBase.ByteArrayStream(d, null, +d[0] == '{' ? CommonParams.JSON_MIME : BinaryResponseParser.BINARY_CONTENT_TYPE)); + + } + +} catch (Exception e) { Review comment: this is f
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400704740 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { Review comment: I fail to see the problem. Could you please explain This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400704943 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZookeeperRead.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZookeeperRead { Review comment: APIs are named as *API This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400704740 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { Review comment: I fail to see the problem. Could you please explain This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400712562 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperReadTest.java ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.lang.invoke.MethodHandles; +import java.net.URL; +import java.util.Map; + +import org.apache.solr.client.solrj.impl.HttpSolrClient; +import org.apache.solr.cloud.SolrCloudTestCase; +import org.apache.solr.common.util.Utils; +import org.apache.zookeeper.CreateMode; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.solr.common.util.StrUtils.split; +import static org.apache.solr.common.util.Utils.getObjectByPath; + +public class ZookeeperReadTest extends SolrCloudTestCase { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + @BeforeClass + public static void setupCluster() throws Exception { +configureCluster(1) +.addConfig("conf", configset("cloud-minimal")) +.configure(); + } + + @Before + @Override + public void setUp() throws Exception { +super.setUp(); + } + + @After + @Override + public void tearDown() throws Exception { +super.tearDown(); + } + + @Test + public void testZkread() throws Exception { +URL baseUrl = cluster.getJettySolrRunner(0).getBaseUrl(); +String basezk = baseUrl.toString().replace("/solr", "/api") + "/cluster/zk"; + +try (HttpSolrClient client = new HttpSolrClient.Builder(baseUrl.toString()).build()) { + Object o = Utils.executeGET(client.getHttpClient(), + basezk + "/security.json", + Utils.JSONCONSUMER); + assertNotNull(o); + o = Utils.executeGET(client.getHttpClient(), + basezk + "/configs", + Utils.JSONCONSUMER); + assertEquals("0", String.valueOf(getObjectByPath(o, true, split(":/configs:_default:dataLength", ':'; + assertEquals("0", String.valueOf(getObjectByPath(o, true, split(":/configs:conf:dataLength", ':'; + + o = Utils.executeGET(client.getHttpClient(), + basezk + "/configs?leaf=true", + Utils.JSONCONSUMER); + assertTrue(((Map)o).containsKey("/configs")); Review comment: NO. I couldn't see it. Maybe you can just commit that directly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400712704 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { Review comment: must be fixed now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405920137 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { +d = coreContainer.getZkController().getZkClient().getData(path, null, null, false); +if (d == null || d.length == 0) { + rsp.add(path, null); + return; +} + +Map map = new HashMap<>(1); +map.put(WT, "raw"); +map.put(OMIT_HEADER, "true"); +req.setParams(SolrParams.wrapDefaults(new MapSolrParams(map), req.getParams())); Review comment: no if you are requesting data , you should expect raw data. it will not honour the `wt` param This is an automated message from the Apache Git Service. To res
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405920325 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java ## @@ -74,6 +78,39 @@ public void tearDown() throws Exception { super.tearDown(); } + @Test + public void testZkread() throws Exception { +URL baseUrl = cluster.getJettySolrRunner(0).getBaseUrl(); +String basezk = baseUrl.toString().replace("/solr", "/api") + "/cluster/zk"; + +try( HttpSolrClient client = new HttpSolrClient.Builder(baseUrl.toString()).build()) { + Object o = Utils.executeGET(client.getHttpClient(), + basezk + "/security.json", + Utils.JSONCONSUMER ); + assertNotNull(o); + o = Utils.executeGET(client.getHttpClient(), + basezk + "/configs", + Utils.JSONCONSUMER ); + assertEquals("0", String.valueOf(getObjectByPath(o,true, split(":/configs:_default:dataLength",':'; + assertEquals("0", String.valueOf(getObjectByPath(o,true, split(":/configs:conf:dataLength",':'; + byte[] bytes = new byte[1024*5]; + for (int i = 0; i < bytes.length; i++) { +bytes[i] = (byte) random().nextInt(128); Review comment: I wanted a big enough `byte[]` not a small one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405920137 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { +d = coreContainer.getZkController().getZkClient().getData(path, null, null, false); +if (d == null || d.length == 0) { + rsp.add(path, null); + return; +} + +Map map = new HashMap<>(1); +map.put(WT, "raw"); +map.put(OMIT_HEADER, "true"); +req.setParams(SolrParams.wrapDefaults(new MapSolrParams(map), req.getParams())); Review comment: no if you are requesting data , you should expect raw data. it will not honour the `wt` param. If you request `/api/cluster/zk/list` you will get response in any format that you ask for `javabin` , `xml` , `json`
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405921183 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; Review comment: We should probably support a `Supplier`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405924050 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { Review comment: ``` public void list(SolrQueryRequest req, SolrQueryResponse rsp) { String path = req.getPathTemplateValues().get("*"); if (path == null || path.isEmpty()) path = "/"; try { List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); String prefix = path.endsWith("/") ? path : path + "/"; rsp.add(path, (MapWriter) ew -> { for (String s : l) { Stat stat = null; try { stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); } catch (Exception e) { throw new RuntimeException(e); } printStat(ew, s, stat);
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405924222 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.handler.admin; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import org.apache.solr.api.Command; +import org.apache.solr.api.EndPoint; +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.impl.BinaryResponseParser; +import org.apache.solr.common.MapWriter; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.MapSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.ContentStreamBase; +import org.apache.solr.common.util.Utils; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.zookeeper.data.Stat; + +import static org.apache.solr.common.params.CommonParams.OMIT_HEADER; +import static org.apache.solr.common.params.CommonParams.WT; +import static org.apache.solr.response.RawResponseWriter.CONTENT; +import static org.apache.solr.security.PermissionNameProvider.Name.COLL_READ_PERM; + +/**Exposes the content of the Zookeeper + * This is an expert feature that exposes the data inside the back end zookeeper.This API may change or + * be removed in future versions. + * This is not a public API. The data that is returned is not guaranteed to remain same + * across releases, as the data stored in Zookeeper may change from time to time. + */ +@EndPoint(path = "/cluster/zk/*", +method = SolrRequest.METHOD.GET, +permission = COLL_READ_PERM) +public class ZkRead { + private final CoreContainer coreContainer; + + public ZkRead(CoreContainer coreContainer) { +this.coreContainer = coreContainer; + } + + @Command + public void get(SolrQueryRequest req, SolrQueryResponse rsp) { +String path = req.getPathTemplateValues().get("*"); +if (path == null || path.isEmpty()) path = "/"; +byte[] d = null; +try { + List l = coreContainer.getZkController().getZkClient().getChildren(path, null, false); + if (l != null && !l.isEmpty()) { +String prefix = path.endsWith("/") ? path : path + "/"; + +rsp.add(path, (MapWriter) ew -> { + for (String s : l) { +try { + Stat stat = coreContainer.getZkController().getZkClient().exists(prefix + s, null, false); + ew.put(s, (MapWriter) ew1 -> { +ew1.put("version", stat.getVersion()); +ew1.put("aversion", stat.getAversion()); +ew1.put("children", stat.getNumChildren()); +ew1.put("ctime", stat.getCtime()); +ew1.put("cversion", stat.getCversion()); +ew1.put("czxid", stat.getCzxid()); +ew1.put("ephemeralOwner", stat.getEphemeralOwner()); +ew1.put("mtime", stat.getMtime()); +ew1.put("mzxid", stat.getMzxid()); +ew1.put("pzxid", stat.getPzxid()); +ew1.put("dataLength", stat.getDataLength()); + }); +} catch (Exception e) { + ew.put("s", Collections.singletonMap("error", e.getMessage())); +} + } +}); + + } else { +d = coreContainer.getZkController().getZkClient().getData(path, null, null, false); +if (d == null || d.length == 0) { + rsp.add(path, null); + return; +} + +Map map = new HashMap<>(1); +map.put(WT, "raw"); +map.put(OMIT_HEADER, "true"); +req.setParams(SolrParams.wrapDefaults(new MapSolrParams(map), req.getParams())); Review comment: yes, for list operations , you can get data in any format This is an automated message from the Apache Git Service. To respond to the message, please log on to