[GitHub] [lucene-solr] rmuir commented on pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.

2020-09-17 Thread GitBox


rmuir commented on pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882#issuecomment-694177068


   we may want to apply new logic to the CompressingTermVectorsWriter as well 
for consistency?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] rmuir commented on pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.

2020-09-17 Thread GitBox


rmuir commented on pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882#issuecomment-694339576


   +1
   
   We can always try to improve this thing later in subsequent issues. This 
still keeps a hard safety net on the number of dirty chunks, so I can't see it 
introducing any new worst-case behavior



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org