[GitHub] [lucene-solr] s1monw commented on pull request #1849: LUCENE-9517: Add doPrivileged block when creating BugfixDeflater_JDK8252739 objects

2020-09-09 Thread GitBox


s1monw commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689995922


   @uschindler why are you so grumpy, you have so much to add to this issue, 
why don’t you do it in a positive way?
   
   You could have reacted with something like „oh man what a pity, that’s a bug 
in the JDK. Let’s fix it in a more elegant and general way than adding a 
doProviledged block... I have some ideas“ - it’s as important as not adding 
hacks to lucene. Community over code buddy. You are around long enough, folks 
reading this are discouraged.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-solr] s1monw commented on pull request #1849: LUCENE-9517: Add doPrivileged block when creating BugfixDeflater_JDK8252739 objects

2020-09-09 Thread GitBox


s1monw commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689577005


   change LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org