Re: [PR] Remove concatenation in String.format() calls [lucene]
uschindler merged PR #13038: URL: https://github.com/apache/lucene/pull/13038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Remove concatenation in String.format() calls [lucene]
uschindler commented on PR #13038: URL: https://github.com/apache/lucene/pull/13038#issuecomment-1915649179 Thanks for this. The code also has safety problems. If the concatted text para contain percent signs it would break. So format strings should never ever be constructed with variables containing inches ked strings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Remove concatenation in String.format() calls [lucene]
sabi0 opened a new pull request, #13038: URL: https://github.com/apache/lucene/pull/13038 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
