[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461975#comment-17461975 ] ASF subversion and git services commented on LUCENE-10308: -- Commit 2a44ff532ee715349523355eda97bd1ed589d11f in lucene's branch refs/heads/main from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=2a44ff5 ] LUCENE-10308: sort input files for ecj so that module-info.java comes first. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461976#comment-17461976 ] ASF subversion and git services commented on LUCENE-10308: -- Commit 1114cf2c2505b6417729d3dea2847650fa9557d3 in lucene's branch refs/heads/branch_9x from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=1114cf2 ] LUCENE-10308: sort input files for ecj so that module-info.java comes first. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461965#comment-17461965 ] ASF subversion and git services commented on LUCENE-10308: -- Commit 5b3b75efd80e027bfbe9640b4cde5bd77360c513 in lucene's branch refs/heads/main from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=5b3b75e ] LUCENE-10308: Make ecj and javadoc run with modular paths > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459118#comment-17459118 ] Dawid Weiss commented on LUCENE-10308: -- Thanks, I added it (again). Bugzilla is confusing like hell. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459115#comment-17459115 ] Uwe Schindler commented on LUCENE-10308: I don't see an attachment on the ECJ bug. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459100#comment-17459100 ] Dawid Weiss commented on LUCENE-10308: -- > The issue here is a bug in ecj. I know. But it doesn't help me much, does it? :) > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459096#comment-17459096 ] Dawid Weiss commented on LUCENE-10308: -- Filed a bug to ECJ. https://bugs.eclipse.org/bugs/show_bug.cgi?id=577790 > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459093#comment-17459093 ] Uwe Schindler commented on LUCENE-10308: That's explicitly wanted by log4j, because it makes the module info file only visible to Java 9+ code. It was added because of complaints by Users where classpath scanners and IDEs broke when finding the file. We had the discussion on the openjdk committer meeting on Fosdem 2 years ago with Maven people and the result was that it's the recommendation to only add Module-Info.class in the MR part of Jar file for best compatibility. Maven does this by default I think. The issue here is a bug in ecj. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > Attachments: repro.zip > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459087#comment-17459087 ] Dawid Weiss commented on LUCENE-10308: -- The root cause of this is ECJ failing to parse log4j JAR as a module because log4j is a multi-release JAR and has the module descriptor inside META-INF/ mr folder for Java 9+. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[
https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458012#comment-17458012
]
Dawid Weiss commented on LUCENE-10308:
--
I made it all work... only to discover ecj must have a bug parsing the
module-path somewhere. It currently shows this:
{code}
> Task :lucene:memory:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
> Task :lucene:luke:ecjLintMain FAILED
--
1. ERROR in C:\Work\apache\lucene\main\lucene\luke\src\java\module-info.java
(at line 28)
requires org.apache.logging.log4j;
org.apache.logging.log4j cannot be resolved to a module
--
1 problem (1 error)
{code}
but the module path passed to ecj is fine (run with --info to gradle) and javac
compilation also works.
> Make ecj and javadoc run with modular paths
> ---
>
> Key: LUCENE-10308
> URL: https://issues.apache.org/jira/browse/LUCENE-10308
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10308) Make ecj and javadoc run with modular paths
[ https://issues.apache.org/jira/browse/LUCENE-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17457723#comment-17457723 ] Dawid Weiss commented on LUCENE-10308: -- I made the gradle code patches but ecj is really rough to work with. Passing directories as sources confuses the compiler (the module-info has to reside in the same directory as the rest of the code). I also had to turn off API leaks warning similar to javac linter. The code is at: https://github.com/dweiss/lucene/tree/LUCENE-10308 It's not ready yet. It'd have to be combined with javadoc compiling in full modular mode or omitting module-info.java somehow in a different way. > Make ecj and javadoc run with modular paths > --- > > Key: LUCENE-10308 > URL: https://issues.apache.org/jira/browse/LUCENE-10308 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
