[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507418#comment-17507418 ] ASF subversion and git services commented on LUCENE-10451: -- Commit 5c273159c8ea8e847630415aa8d62a2d9b7aa55c in lucene's branch refs/heads/branch_9x from Peter Gromov [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=5c27315 ] LUCENE-10452, LUCENE-10451: mention hunspell changes in CHANGES.txt > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507419#comment-17507419 ] ASF subversion and git services commented on LUCENE-10451: -- Commit 385fd560fa2b3b70121b8dcb9acc03001b7fe9a8 in lucene's branch refs/heads/branch_9x from Peter Gromov [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=385fd56 ] LUCENE-10451 Hunspell: don't perform potentially expensive spellchecking after timeout (#721) move all expensive operations closer to the suggestion creation, encapsulate case and output conversion into a new Suggestion class > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507415#comment-17507415 ] ASF subversion and git services commented on LUCENE-10451: -- Commit 0e3c315b7662799658f331ca2c9985457d0cd161 in lucene's branch refs/heads/main from Peter Gromov [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=0e3c315 ] LUCENE-10452, LUCENE-10451: mention hunspell changes in CHANGES.txt > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507402#comment-17507402 ] Peter Gromov commented on LUCENE-10451: --- OK, convinced, will add. > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507394#comment-17507394 ] Dawid Weiss commented on LUCENE-10451: -- It's an issue in Jira and changes.txt is the log of changes made. Many people use Lucene in various contexts - some of those people (like me) do actually read those changes.txt, files, especially when something stops working... ;) > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507393#comment-17507393 ] Peter Gromov commented on LUCENE-10451: --- I will cherry-pick a bit later, thanks! As for changes.txt, I have doubts that anyone except JetBrains cares for these minor changes, so unless you insist, I'd leave that out. > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507377#comment-17507377 ] Dawid Weiss commented on LUCENE-10451: -- Yes, sure! Just cherry pick the commit. I would also add an entry to changes.txt - this was missed by my in the original PR (it'd have to be applied to main and 9x). > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507227#comment-17507227 ] Peter Gromov commented on LUCENE-10451: --- [~dweiss] That'd be nice. Do you approve this backport? > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507197#comment-17507197 ] Dawid Weiss commented on LUCENE-10451: -- Hi Peter. You may want to backport to branch_9x as well? > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Fix For: 9.2 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507119#comment-17507119 ] ASF subversion and git services commented on LUCENE-10451: -- Commit 92a20c24e93915a79ef53391a70cf2fb35cb1e93 in lucene's branch refs/heads/main from Peter Gromov [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=92a20c2 ] LUCENE-10451 Hunspell: don't perform potentially expensive spellchecking after timeout (#721) move all expensive operations closer to the suggestion creation, encapsulate case and output conversion into a new Suggestion class > Hunspell: don't perform potentially expensive spellchecking after timeout > - > > Key: LUCENE-10451 > URL: https://issues.apache.org/jira/browse/LUCENE-10451 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis >Reporter: Peter Gromov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently, to return partial result after timeout, additional processing with > case-adjustment and `spell` calls is performed, which can take time and also > result in superfluous `checkCanceled` invocations. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
