[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481865#comment-17481865 ] Tomoko Uchida commented on LUCENE-8930: --- I increased the timeout to 60 seconds but the forked process could possibly hang on the vm. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Fix For: 9.1, 10.0 (main) > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481840#comment-17481840 ] ASF subversion and git services commented on LUCENE-8930: - Commit fd817b6fb121723db6e9635a3ec9795ec0dd9a0d in lucene's branch refs/heads/main from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=fd817b6 ] LUCENE-8930: increase timeout to 1 minite for the launched luke (seems it occationaly takes long time on windows vm) > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Fix For: 9.1, 10.0 (main) > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481842#comment-17481842 ] ASF subversion and git services commented on LUCENE-8930: - Commit bf6a035ca064905b2928426e9d44a45613d1fa30 in lucene's branch refs/heads/branch_9x from Tomoko Uchida [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=bf6a035 ] LUCENE-8930: increase timeout to 1 minite for the launched luke (seems it occationaly takes long time on windows vm) > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Fix For: 9.1, 10.0 (main) > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479466#comment-17479466 ] ASF subversion and git services commented on LUCENE-8930: - Commit 77ee2a7c3cfbe72c59e4f9dee531fe07c8399ca2 in lucene's branch refs/heads/branch_9x from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=77ee2a7 ] LUCENE-8930: increase timeout for the launched luke. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Fix For: 9.1, 10.0 (main) > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479460#comment-17479460 ] ASF subversion and git services commented on LUCENE-8930: - Commit 08d6633d9454180ac936e5a17e3c9c95394c599a in lucene's branch refs/heads/main from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=08d6633 ] LUCENE-8930: increase timeout for the launched luke. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Fix For: 9.1, 10.0 (main) > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479329#comment-17479329 ] ASF subversion and git services commented on LUCENE-8930: - Commit 5f1bcc6481bdad215ab9a7d644d2dac5f8efa9af in lucene's branch refs/heads/branch_9x from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=5f1bcc6 ] LUCENE-8930: script testing in the distribution (#550) > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Time Spent: 7h 10m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478755#comment-17478755 ] ASF subversion and git services commented on LUCENE-8930: - Commit 72ba7ae2eed4e69ed5015b51ea9d69009bc82bd4 in lucene's branch refs/heads/main from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene.git;h=72ba7ae ] LUCENE-8930: script testing in the distribution (#550) > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Time Spent: 6h 50m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463609#comment-17463609 ] Dawid Weiss commented on LUCENE-8930: - I ran it on Windows and it works too. Ok, I'll merge it in. I thought you'd want to add some checks for the available factories, etc - like you already had in your previous patch. This can wait though - perhaps there is a better way to do it once I figure out how to run tests in module mode. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463537#comment-17463537 ] Tomoko Uchida commented on LUCENE-8930: --- The patch works well for me (I ran it only on *nix machine). There would not be much I can do or want to do about it. Could you please merge it to the upstream when you have some time. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462438#comment-17462438 ] Dawid Weiss commented on LUCENE-8930: - I wouldn't worry about the delay or time frame - it's not a job, it's a hobby. Ask me questions if you need anything explained. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462434#comment-17462434 ] Tomoko Uchida commented on LUCENE-8930: --- I will try to take a look this week. I might need some time to get a full picture; please don't wait for me if my response is too slow. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462170#comment-17462170 ] Dawid Weiss commented on LUCENE-8930: - Please do continue, Tomoko. I don't think it's complete - it's just showing how things can be done (and I know they work because it's the pattern I've been using elsewhere). Feel free to rearrange anything you want and copy over to your github - I'm swamped with trying to get those test framework/ modules working so I don't think I'll be returning to this soon and luke needs some love in terms of regression tests. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462168#comment-17462168 ] Tomoko Uchida commented on LUCENE-8930: --- Thank you - the work seems almost complete. I have unassigned myself here since I could break something by touching it. I have not run it yet, but I will do that sometime soon and let you know if I notice anything. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461997#comment-17461997 ] Dawid Weiss commented on LUCENE-8930: - I added a rough sketch of a more realistic test for distribution scripts - https://github.com/apache/lucene/pull/550/files this actually runs Luke and simulates odd paths occasionally (with a space inside). I didn't check the Unix script but a change is required to pass arguments to Luke. The Windows script requires a subtle change too since we have to run integration tests with blocking/ exit code. It's a draft, but should give you an idea of what this can look like. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461973#comment-17461973 ] Dawid Weiss commented on LUCENE-8930: - Hi Tomoko. Let me add a scaffolding for such a test I already have elsewhere - maybe it'll be helpful as a starter. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461878#comment-17461878 ] Tomoko Uchida commented on LUCENE-8930: --- I think I can start this once [https://github.com/apache/lucene/pull/533] is merged. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461875#comment-17461875 ] Tomoko Uchida commented on LUCENE-8930: --- The launch script for Windows uses "javaw" to spawn the luke process; this makes it difficult to check the actual return code (%errorlevel%). I think we should change it to the plain "java" command. > Integrate Luke app health check to nightly tests (CI) > - > > Key: LUCENE-8930 > URL: https://issues.apache.org/jira/browse/LUCENE-8930 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Assignee: Tomoko Uchida >Priority: Minor > > Would it be possible to add some release smoke tests for Luke? > https://stackoverflow.com/questions/79891/what-is-the-best-testing-tool-for-swing-based-applications -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
