[jira] [Commented] (LUCENE-8945) Allow to change the output file delimiter on Luke "export terms" feature
[ https://issues.apache.org/jira/browse/LUCENE-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932320#comment-16932320 ] Tomoko Uchida commented on LUCENE-8945: --- Seems that ASF bot is not working... Committed to the master and 8x, with slight modification (moved Delimiter to private enum, it's used only in the factory anyway). Here is the final patch [^LUCENE-8945-final.patch] [https://github.com/apache/lucene-solr/commit/369df12c2cc54e929bd25dd77424242ddd0fb047] Thanks [~shahamish150294]! > Allow to change the output file delimiter on Luke "export terms" feature > > > Key: LUCENE-8945 > URL: https://issues.apache.org/jira/browse/LUCENE-8945 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Attachments: LUCENE-8945-final.patch, LUCENE-8945.patch, > LUCENE-8945.patch, delimiter_comma_exported_file.PNG, > delimiter_space_exported_file.PNG, delimiter_tab_exported_file.PNG, > luke_export_delimiter.png > > > This is a follow-up issue for LUCENE-8764. > Current delimiter is fixed to "," (comma), but terms also can include comma > and they are not escaped. It would be better if the delimiter can be > changed/selected to a tab or whitespace when exporting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8945) Allow to change the output file delimiter on Luke "export terms" feature
[ https://issues.apache.org/jira/browse/LUCENE-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932147#comment-16932147 ] Tomoko Uchida commented on LUCENE-8945: --- +1 I will commit it to the ASF repo in shortly. > Allow to change the output file delimiter on Luke "export terms" feature > > > Key: LUCENE-8945 > URL: https://issues.apache.org/jira/browse/LUCENE-8945 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Attachments: LUCENE-8945.patch, LUCENE-8945.patch, > delimiter_comma_exported_file.PNG, delimiter_space_exported_file.PNG, > delimiter_tab_exported_file.PNG, luke_export_delimiter.png > > > This is a follow-up issue for LUCENE-8764. > Current delimiter is fixed to "," (comma), but terms also can include comma > and they are not escaped. It would be better if the delimiter can be > changed/selected to a tab or whitespace when exporting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8945) Allow to change the output file delimiter on Luke "export terms" feature
[ https://issues.apache.org/jira/browse/LUCENE-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932039#comment-16932039 ] Amish Shah commented on LUCENE-8945: Thanks for the suggestions. I have made the changes and they can be reviewed in the latest patch attached. [^Lucene-8945.patch] > Allow to change the output file delimiter on Luke "export terms" feature > > > Key: LUCENE-8945 > URL: https://issues.apache.org/jira/browse/LUCENE-8945 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Attachments: LUCENE-8945.patch, Lucene-8945.patch, > delimiter_comma_exported_file.PNG, delimiter_space_exported_file.PNG, > delimiter_tab_exported_file.PNG, luke_export_delimiter.png > > > This is a follow-up issue for LUCENE-8764. > Current delimiter is fixed to "," (comma), but terms also can include comma > and they are not escaped. It would be better if the delimiter can be > changed/selected to a tab or whitespace when exporting. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8945) Allow to change the output file delimiter on Luke "export terms" feature
[ https://issues.apache.org/jira/browse/LUCENE-8945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930004#comment-16930004 ] Amish Shah commented on LUCENE-8945: Yes, I set comma as a default selection. Patch: [^LUCENE-8945.patch] Screenshots: !delimiter_comma_exported_file.PNG! !delimiter_space_exported_file.PNG! !delimiter_tab_exported_file.PNG! > Allow to change the output file delimiter on Luke "export terms" feature > > > Key: LUCENE-8945 > URL: https://issues.apache.org/jira/browse/LUCENE-8945 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/luke >Reporter: Tomoko Uchida >Priority: Minor > Attachments: LUCENE-8945.patch, delimiter_comma_exported_file.PNG, > delimiter_space_exported_file.PNG, delimiter_tab_exported_file.PNG, > luke_export_delimiter.png > > > This is a follow-up issue for LUCENE-8764. > Current delimiter is fixed to "," (comma), but terms also can include comma > and they are not escaped. It would be better if the delimiter can be > changed/selected to a tab or whitespace when exporting. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
