[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962195#comment-16962195
]
ASF subversion and git services commented on LUCENE-9010:
-
Commit 6beac1dc39d3ebadf01335e11f71a19da92a0da3 in lucene-solr's branch
refs/heads/jira/SOLR-13101 from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6beac1d ]
LUCENE-9010: extend TopGroups.merge test coverage
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Test
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch, LUCENE-9010.patch
>
>
> This -sub--task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
> edit: converted from LUCENE-8996 bug-fix sub-task to test-type task of its
> own so that its life can extend beyond the LUCENE-8996 bug-fix ticket's life
> for further test coverage extensions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957817#comment-16957817
]
ASF subversion and git services commented on LUCENE-9010:
-
Commit 6beac1dc39d3ebadf01335e11f71a19da92a0da3 in lucene-solr's branch
refs/heads/branch_8_3 from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6beac1d ]
LUCENE-9010: extend TopGroups.merge test coverage
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch, LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957797#comment-16957797
]
ASF subversion and git services commented on LUCENE-9010:
-
Commit 516f607618a501596272bbfdcb533277072e485e in lucene-solr's branch
refs/heads/branch_8x from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=516f607 ]
LUCENE-9010: extend TopGroups.merge test coverage
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch, LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957455#comment-16957455
]
ASF subversion and git services commented on LUCENE-9010:
-
Commit f8292f5372502598dc8cabc50642c4f783e1c811 in lucene-solr's branch
refs/heads/jira/SOLR-13822 from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f8292f5 ]
LUCENE-9010: extend TopGroups.merge test coverage
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch, LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957173#comment-16957173
]
ASF subversion and git services commented on LUCENE-9010:
-
Commit f8292f5372502598dc8cabc50642c4f783e1c811 in lucene-solr's branch
refs/heads/master from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f8292f5 ]
LUCENE-9010: extend TopGroups.merge test coverage
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch, LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953876#comment-16953876
]
Lucene/Solr QA commented on LUCENE-9010:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
17s{color} | {color:green} grouping in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-9010 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983268/LUCENE-9010.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 63e9bcf |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/211/testReport/ |
| modules | C: lucene/grouping U: lucene/grouping |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/211/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch, LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953274#comment-16953274
]
Lucene/Solr QA commented on LUCENE-9010:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 46s{color}
| {color:red} lucene_grouping generated 4 new + 107 unchanged - 0 fixed = 111
total (was 107) {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
3s{color} | {color:green} grouping in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 5m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-9010 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983203/LUCENE-9010.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / ebc720c |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/210/artifact/out/diff-compile-javac-lucene_grouping.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/210/testReport/ |
| modules | C: lucene/grouping U: lucene/grouping |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/210/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9010) extend TopGroups.merge test coverage
[
https://issues.apache.org/jira/browse/LUCENE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953077#comment-16953077
]
Christine Poerschke commented on LUCENE-9010:
-
The attached proposed patch tries to reduce the "amount of numbers" in the test
e.g. instead of integer group values 1 and 2 there's string group values "red"
and "blue" and a narrative and local variable names (redAntScore,
blueDragonflyScore, blueDragonflySize, redSquirrelScore, blueWhaleScore) try to
make it easier to work out what the {{expectedMaxScore}} value is.
> extend TopGroups.merge test coverage
>
>
> Key: LUCENE-9010
> URL: https://issues.apache.org/jira/browse/LUCENE-9010
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: LUCENE-9010.patch
>
>
> This sub-task proposes to add test coverage for the {{TopGroups.merge}}
> method, separately from but as preparation for LUCENE-8996 fixing the
> 'maxScore is sometimes missing' bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
