[jira] [Commented] (LUCENE-9338) Clean up type safety in SimpleBindings

2020-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091388#comment-17091388
 ] 

ASF subversion and git services commented on LUCENE-9338:
-

Commit b66b970d1b06e56b0d685613855be5ef6d1a2c60 in lucene-solr's branch 
refs/heads/branch_8x from Alan Woodward
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b66b970 ]

LUCENE-9338: Clean up type safety in SimpleBindings (#1444)

Replaces SimpleBindings' Map with a map of
Function to improve type safety, and
reworks cycle detection and validation to avoid catching 
StackOverflowException

> Clean up type safety in SimpleBindings
> --
>
> Key: LUCENE-9338
> URL: https://issues.apache.org/jira/browse/LUCENE-9338
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> SimpleBindings holds its bindings as a Map, and then casts 
> things when it builds its value sources.  We can instead store a map of 
> Supplier and avoid casts entirely.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9338) Clean up type safety in SimpleBindings

2020-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091372#comment-17091372
 ] 

ASF subversion and git services commented on LUCENE-9338:
-

Commit ed3caab2d86b69ec4b3ed8e787827c0931b43d1b in lucene-solr's branch 
refs/heads/master from Alan Woodward
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ed3caab ]

LUCENE-9338: Clean up type safety in SimpleBindings (#1444)

Replaces SimpleBindings' Map with a map of
Function to improve type safety, and
reworks cycle detection and validation to avoid catching 
StackOverflowException

> Clean up type safety in SimpleBindings
> --
>
> Key: LUCENE-9338
> URL: https://issues.apache.org/jira/browse/LUCENE-9338
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> SimpleBindings holds its bindings as a Map, and then casts 
> things when it builds its value sources.  We can instead store a map of 
> Supplier and avoid casts entirely.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org