[jira] [Commented] (LUCENE-9464) Add high(er)-level hit highlighter example that demonstrates and uses low-level components
[ https://issues.apache.org/jira/browse/LUCENE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199621#comment-17199621 ] David Smiley commented on LUCENE-9464: -- Yes, "lucene.experimental" is mostly about API stability within a minor release, not really other stability. It does tend to get over-used just in case but this here is fresh code that advertises itself as an example. As a project we don't remove it when we should probably. The other highlighters have very stable APIs. > Add high(er)-level hit highlighter example that demonstrates and uses > low-level components > -- > > Key: LUCENE-9464 > URL: https://issues.apache.org/jira/browse/LUCENE-9464 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9464) Add high(er)-level hit highlighter example that demonstrates and uses low-level components
[ https://issues.apache.org/jira/browse/LUCENE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196722#comment-17196722 ] Dawid Weiss commented on LUCENE-9464: - The MatchHighlighter is fully functional - I think it may be useful for folks who don't want to assemble their own pipeline from lower-level components. Tests already have a number of examples as well [1]. https://github.com/apache/lucene-solr/blob/master/lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchHighlighter.java As for marking these classes with lucene.experimental - sure, we can. I am not sure what it implies though. That the API is still unstable, right? Because the code itself is fairly well tested. > Add high(er)-level hit highlighter example that demonstrates and uses > low-level components > -- > > Key: LUCENE-9464 > URL: https://issues.apache.org/jira/browse/LUCENE-9464 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9464) Add high(er)-level hit highlighter example that demonstrates and uses low-level components
[ https://issues.apache.org/jira/browse/LUCENE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196718#comment-17196718 ] David Smiley commented on LUCENE-9464: -- Maybe these classes, particularly so-called "example" classes should be marked lucene.experimental? Maybe example code should actually be in tests? I leave to your discretion. > Add high(er)-level hit highlighter example that demonstrates and uses > low-level components > -- > > Key: LUCENE-9464 > URL: https://issues.apache.org/jira/browse/LUCENE-9464 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9464) Add high(er)-level hit highlighter example that demonstrates and uses low-level components
[ https://issues.apache.org/jira/browse/LUCENE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193550#comment-17193550 ] ASF subversion and git services commented on LUCENE-9464: - Commit e2f3f626ee4c7f2d2df1e09a31b971c81e95be44 in lucene-solr's branch refs/heads/master from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e2f3f62 ] LUCENE-9464: Add high(er)-level hit highlighter example that demonstrates and uses low-level components (#1820) > Add high(er)-level hit highlighter example that demonstrates and uses > low-level components > -- > > Key: LUCENE-9464 > URL: https://issues.apache.org/jira/browse/LUCENE-9464 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9464) Add high(er)-level hit highlighter example that demonstrates and uses low-level components
[ https://issues.apache.org/jira/browse/LUCENE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189136#comment-17189136 ] Dawid Weiss commented on LUCENE-9464: - Hi Alan ([~romseygeek]). Finally got down to writing something that would be end-user usable and would at the same time showcase those match highlighter components. I didn't want to make the "MatchHighlighter" too simple because then it wouldn't show all the advantages of using this code. I also didn't want to make it too complex because it's not the point (if you need something really complex, you'd use those low-level components directly rather than jump through hoops to make the high-level highlighter work for you). Please feel free to review when you have time. I think the best start would be test [1], which takes you step-by-step trough various scenarios. Let me know what you think. [1] https://github.com/dweiss/lucene-solr/blob/LUCENE-9464/lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchHighlighter.java#L118-L400 > Add high(er)-level hit highlighter example that demonstrates and uses > low-level components > -- > > Key: LUCENE-9464 > URL: https://issues.apache.org/jira/browse/LUCENE-9464 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
