[jira] [Commented] (LUCENE-9587) Tests in gradle do not run with "--illegal-access=deny" like in 8.x

2020-10-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221805#comment-17221805
 ] 

ASF subversion and git services commented on LUCENE-9587:
-

Commit 9ce4b98af2155ba9d6d41e12ff12017c557a9ea4 in lucene-solr's branch 
refs/heads/master from Uwe Schindler
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9ce4b98 ]

LUCENE-9587: Add '--illegal-access=deny' to test runner (#2039)



> Tests in gradle do not run with "--illegal-access=deny" like in 8.x
> ---
>
> Key: LUCENE-9587
> URL: https://issues.apache.org/jira/browse/LUCENE-9587
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: general/test
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Major
>  Labels: Java16
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In LUCENE-8035 we added {{--illegal-access=deny}} to the JVM options to 
> enfoce that no code is using any internal JDK APIs.
> https://github.com/apache/lucene-solr/blob/branch_8x/lucene/common-build.xml#L1053-L1055
> While changing to Gradle we lost this option somehow. We need to add it back, 
> as JDK 16 or latest JDK 17 will default to this setting anyways, so we should 
> again make sure that testing works under restricted conditions! Here is the 
> JEP: https://openjdk.java.net/jeps/396



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-9587) Tests in gradle do not run with "--illegal-access=deny" like in 8.x

2020-10-27 Thread Uwe Schindler (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-9587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221724#comment-17221724
 ] 

Uwe Schindler commented on LUCENE-9587:
---

PR is here: https://github.com/apache/lucene-solr/pull/2039

Will commit this soon, when all tests were run.

On my windows PC command line of JVM looks like this:
{noformat}
"C:\Program Files\Java\jdk-11.0.8\bin\java.exe" "-Dcommon.dir=C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\lucene" 
"-Dgradle.lib.dir=C:/Users/Uwe 
Schindler/.gradle/wrapper/dists/gradle-6.6.1-all/ejrtlte9hlw8v6ii20a9584rs/gradle-6.6.1/lib"
 
"-Dgradle.user.home=C:\Users\Uwe Schindler\.gradle" 
"-Dgradle.worker.jar=C:\Users\Uwe 
Schindler\.gradle\caches\6.6.1\workerMain\gradle-worker.jar" 
-Djava.awt.headless=true 
-Djava.security.manager=org.apache.lucene.util.TestSecurityManager 
"-Djava.security.policy=C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\gradle\testing\randomization\policies\tests.policy"
 
"-Djava.util.logging.config.file=C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\gradle\testing\defaults-tests\logging.properties"
 
-Djdk.map.althashing.threshold=0 -Djetty.insecurerandom=1 -Djetty.testMode=1 
-Djunit4.childvm.count=1 -Djunit4.childvm.id=0 -Dorg.gradle.native=false 
"-DtempDir=C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\lucene\highlighter\build\tmp\tests-tmp" 
-Dtests.LUCENE_VERSION=9.0.0 -Dtests.asserts=true -Dtests.badapples=false 
-Dtests.codec=random -Dtests.directory=random -Dtests.docvaluesformat=random 
-Dtests.dups=0 -Dtests.failfast=false -Dtests.file.encoding=US-ASCII 
-Dtests.haltonfailure=true -Dtests.heapsize=512m -Dtests.infostream=false 
-Dtests.jvmargs=-XX:TieredStopAtLevel=1 -Dtests.jvms=4 
-Dtests.leaveTemporary=false -Dtests.linedocsfile=europarl.lines.txt.gz 
-Dtests.locale=random 
-Dtests.minheapsize=256m -Dtests.monster=false -Dtests.multiplier=1 
-Dtests.nightly=false -Dtests.postingsformat=random -Dtests.profile=false 
-Dtests.seed=D3A864B87D8B2694 -Dtests.slow=false -Dtests.timezone=random 
-Dtests.useSecurityManager=true -Dtests.verbose=false 
-Dtests.weekly=false "-Dtests.workDir=C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\lucene\highlighter\build\tmp\tests-tmp" 
-XX:TieredStopAtLevel=1 --illegal-access=deny -da:java.util.HashMap 
-esa "@C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\.gradle\tmp\gradle-worker-classpath8918994235680622943txt"
 
-Xms256m -Xmx512m -Dfile.encoding=UTF-8 "-Djava.io.tmpdir=C:\Users\Uwe 
Schindler\Projects\lucene\trunk-lusolr1\lucene\highlighter\build\tmp\tests-tmp" 
-Duser.country=DE -Duser.language=de -Duser.variant -ea 
worker.org.gradle.process.internal.worker.GradleWorkerMain "'Gradle Test 
Executor 38'"
{noformat}

> Tests in gradle do not run with "--illegal-access=deny" like in 8.x
> ---
>
> Key: LUCENE-9587
> URL: https://issues.apache.org/jira/browse/LUCENE-9587
> Project: Lucene - Core
>  Issue Type: Bug
>  Components: general/test
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Assignee: Uwe Schindler
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In LUCENE-8035 we added {{--illegal-access=deny}} to the JVM options to 
> enfoce that no code is using any internal JDK APIs.
> https://github.com/apache/lucene-solr/blob/branch_8x/lucene/common-build.xml#L1053-L1055
> While changing to Gradle we lost this option somehow. We need to add it back, 
> as JDK 16 will default to this setting anyways, so we should again make sure 
> that testing works under restricted conditions!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org