[jira] [Commented] (LUCENE-9595) Component2D#withinPoint logic is inconsistent with ShapeQuery logic
[ https://issues.apache.org/jira/browse/LUCENE-9595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237222#comment-17237222 ] ASF subversion and git services commented on LUCENE-9595: - Commit 2d7d315f970ae413b27d5a11c10de1cb643b089d in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2d7d315 ] LUCENE-9595: Make Component2D#withinPoint implementations consistent with ShapeQuery logic (#2059) > Component2D#withinPoint logic is inconsistent with ShapeQuery logic > --- > > Key: LUCENE-9595 > URL: https://issues.apache.org/jira/browse/LUCENE-9595 > Project: Lucene - Core > Issue Type: Bug >Reporter: Ignacio Vera >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The logic of ShapeQuery for contains assumes that if a branch of the BKD tree > is inside of the shape query, the all documents in that branch are excluded > from the result. On the other hand, Component2D#withinPoint implementation, > eg. Polygon2D, ignores points even when the point is inside the query. > That might lead to inconsistencies in edges cases with geometry collections. > The proposal here is to keep the logic of the shapeQuery and therefore > contains logic will only return true if the query shape is inside a geometry > and it does not intersects with any other geometry belonging to the same > document. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9595) Component2D#withinPoint logic is inconsistent with ShapeQuery logic
[ https://issues.apache.org/jira/browse/LUCENE-9595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237220#comment-17237220 ] ASF subversion and git services commented on LUCENE-9595: - Commit 44be9f903dbad601d3b46108802a951555a6d7ba in lucene-solr's branch refs/heads/master from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=44be9f9 ] LUCENE-9595: Make Component2D#withinPoint implementations consistent with ShapeQuery logic (#2059) > Component2D#withinPoint logic is inconsistent with ShapeQuery logic > --- > > Key: LUCENE-9595 > URL: https://issues.apache.org/jira/browse/LUCENE-9595 > Project: Lucene - Core > Issue Type: Bug >Reporter: Ignacio Vera >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The logic of ShapeQuery for contains assumes that if a branch of the BKD tree > is inside of the shape query, the all documents in that branch are excluded > from the result. On the other hand, Component2D#withinPoint implementation, > eg. Polygon2D, ignores points even when the point is inside the query. > That might lead to inconsistencies in edges cases with geometry collections. > The proposal here is to keep the logic of the shapeQuery and therefore > contains logic will only return true if the query shape is inside a geometry > and it does not intersects with any other geometry belonging to the same > document. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
