[jira] [Commented] (SOLR-13390) Provide Query Elevation Component by default
[ https://issues.apache.org/jira/browse/SOLR-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041004#comment-17041004 ] Jason Gerlowski commented on SOLR-13390: bq. Isn’t the point of introducing Plugins to Solr to reduce what is on by default? Well, that's one point of it, sure. But that's begging the question a bit. A plugin only makes sense *if* QEC should be disabled by default. Erik's making a case that it shouldn't, and for my part I agree. > Provide Query Elevation Component by default > > > Key: SOLR-13390 > URL: https://issues.apache.org/jira/browse/SOLR-13390 > Project: Solr > Issue Type: Bug >Reporter: Erik Hatcher >Priority: Major > > Like other components, like highlighting and faceting, it'd be useful to have > this work out of the box by just enabling it on the request. Currently the > component needs to be added to `/select` and an empty elevate.xml file needs > to be added to the config - a bit unnecessarily arduous. > Let's add the component to `/select` and modify the component to be happy > with or without an elevate.xml (since id's can be sent on the request to > elevate, so fixed config isn't needed either). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13390) Provide Query Elevation Component by default
[
https://issues.apache.org/jira/browse/SOLR-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040770#comment-17040770
]
Jan Høydahl commented on SOLR-13390:
[~epugh] replied on the mailing list:
{quote}"Isn’t the point of introducing Plugins to Solr to reduce what is on by
default? And deal with potentially issues like this?"
{quote}
I don't like the way packages currently "deploy" themselves through a JSON with
arbitrary HTTP requests. I feel the plugin description of the plugin itself
should be able to express how it would insert itself. That is easy with things
like response-writers, they can just add themselves with a name "xslt". I think
we should define in the java interfaces for various types of plugins how they
would wire themselves in if that even makes sense.
For SearchComponents some of them can be used ootb without config, and it is
always correct to add them as first-components or last-components. For other
SearchCompnents they are useless without config and it is perhaps not obvious
how the order between them should be.
Perhaps we'd need a way to enable a component per request as we can with URPs?
So that for QEC it won't insert itself into the chain by default, but you can
easily insert it explicitly with e.g.
{{q=foo&*components.last=elevate*&elevate.config=elevate.xml}}. That is
explicit and nice and easy to add in your section or from the client
request. I dont think there should be any magic with what config it should pick.
> Provide Query Elevation Component by default
>
>
> Key: SOLR-13390
> URL: https://issues.apache.org/jira/browse/SOLR-13390
> Project: Solr
> Issue Type: Bug
>Reporter: Erik Hatcher
>Priority: Major
>
> Like other components, like highlighting and faceting, it'd be useful to have
> this work out of the box by just enabling it on the request. Currently the
> component needs to be added to `/select` and an empty elevate.xml file needs
> to be added to the config - a bit unnecessarily arduous.
> Let's add the component to `/select` and modify the component to be happy
> with or without an elevate.xml (since id's can be sent on the request to
> elevate, so fixed config isn't needed either).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13390) Provide Query Elevation Component by default
[ https://issues.apache.org/jira/browse/SOLR-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040379#comment-17040379 ] Chris M. Hostetter commented on SOLR-13390: --- the main issue would be ensuring we don't break backcompat for people who already have QEC configured -- even if they have it configured with a weird name. (ie: it's not enough to say "don't register a QEC if a component with the name 'elevate' already exists") the second thing to consider is what kind of implicit configuration this new implicit QEC instance should have? ... should it's "configured elevations" be hardcoded with an "empty set" or should it be configured to look for a file with a specific name (like "elevate.xml") that is happily ignores if it doesn't exist but happily loads if it does? > Provide Query Elevation Component by default > > > Key: SOLR-13390 > URL: https://issues.apache.org/jira/browse/SOLR-13390 > Project: Solr > Issue Type: Bug >Reporter: Erik Hatcher >Priority: Major > > Like other components, like highlighting and faceting, it'd be useful to have > this work out of the box by just enabling it on the request. Currently the > component needs to be added to `/select` and an empty elevate.xml file needs > to be added to the config - a bit unnecessarily arduous. > Let's add the component to `/select` and modify the component to be happy > with or without an elevate.xml (since id's can be sent on the request to > elevate, so fixed config isn't needed either). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13390) Provide Query Elevation Component by default
[ https://issues.apache.org/jira/browse/SOLR-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033703#comment-17033703 ] Jason Gerlowski commented on SOLR-13390: Sounds reasonable to me. +1 QEC is used somewhat commonly and seems safe to enable by default. > Provide Query Elevation Component by default > > > Key: SOLR-13390 > URL: https://issues.apache.org/jira/browse/SOLR-13390 > Project: Solr > Issue Type: Bug >Reporter: Erik Hatcher >Priority: Major > > Like other components, like highlighting and faceting, it'd be useful to have > this work out of the box by just enabling it on the request. Currently the > component needs to be added to `/select` and an empty elevate.xml file needs > to be added to the config - a bit unnecessarily arduous. > Let's add the component to `/select` and modify the component to be happy > with or without an elevate.xml (since id's can be sent on the request to > elevate, so fixed config isn't needed either). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
