[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[ https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954726#comment-16954726 ] ASF subversion and git services commented on SOLR-13827: Commit 2cbe03429ef945cbcd1a97fe5107063479fab27f in lucene-solr's branch refs/heads/branch_8x from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2cbe034 ] SOLR-13827: fail on unknown operation in Request Parameters API > Fail on Unknown operation in Request Parameters API > --- > > Key: SOLR-13827 > URL: https://issues.apache.org/jira/browse/SOLR-13827 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: config-api >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13827.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Request Parameters API supports set, update and delete operations. For any > other operation, The API should fail and return error. > Currently, for unknown operation API returns 200 status > The config/overlay API fails on unknown operations -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[ https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954715#comment-16954715 ] ASF subversion and git services commented on SOLR-13827: Commit dce0c5953cdce6f740b07e5d342bf55f629b3f0b in lucene-solr's branch refs/heads/master from Munendra S N [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=dce0c59 ] SOLR-13827: fail on unknown operation in Request Parameters API > Fail on Unknown operation in Request Parameters API > --- > > Key: SOLR-13827 > URL: https://issues.apache.org/jira/browse/SOLR-13827 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: config-api >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13827.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Request Parameters API supports set, update and delete operations. For any > other operation, The API should fail and return error. > Currently, for unknown operation API returns 200 status > The config/overlay API fails on unknown operations -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[ https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950715#comment-16950715 ] Munendra S N commented on SOLR-13827: - I have raised the PR. > Fail on Unknown operation in Request Parameters API > --- > > Key: SOLR-13827 > URL: https://issues.apache.org/jira/browse/SOLR-13827 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: config-api >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13827.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Request Parameters API supports set, update and delete operations. For any > other operation, The API should fail and return error. > Currently, for unknown operation API returns 200 status > The config/overlay API fails on unknown operations -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[ https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950623#comment-16950623 ] Noble Paul commented on SOLR-13827: --- Can you raise a PR? . It make sit easy to review & feed back bq. So, should we remove wt=json from defaults of the implicit API? Yes > Fail on Unknown operation in Request Parameters API > --- > > Key: SOLR-13827 > URL: https://issues.apache.org/jira/browse/SOLR-13827 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: config-api >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > Attachments: SOLR-13827.patch > > > Request Parameters API supports set, update and delete operations. For any > other operation, The API should fail and return error. > Currently, for unknown operation API returns 200 status > The config/overlay API fails on unknown operations -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[
https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950112#comment-16950112
]
Lucene/Solr QA commented on SOLR-13827:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 87m
39s{color} | {color:green} core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
15s{color} | {color:green} solrj in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}110m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-13827 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12982847/SOLR-13827.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 88f457e |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/573/testReport/ |
| modules | C: solr/core solr/solrj U: solr |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/573/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Fail on Unknown operation in Request Parameters API
> ---
>
> Key: SOLR-13827
> URL: https://issues.apache.org/jira/browse/SOLR-13827
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: config-api
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-13827.patch
>
>
> Request Parameters API supports set, update and delete operations. For any
> other operation, The API should fail and return error.
> Currently, for unknown operation API returns 200 status
> The config/overlay API fails on unknown operations
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[
https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950030#comment-16950030
]
Munendra S N commented on SOLR-13827:
-
[^SOLR-13827.patch]
This includes
* Changes to fail on unknown operation type
* Fix error message in case of delete params so that it includes the parameter
name
I haven't handled unsupported HTTP method because both v1 API and V2 API behave
differently in this case. For example,
This V1 API behaves similar to GET request parameters
{code:java}
curl -X DELETE "http://localhost:8983/solr/coll1/config/params;
{code}
but returns different result with V2 API
{code:java}
curl -X DELETE "http://localhost:8983/api/c/coll1/config/params;
{code}
I think this is not specific to one API. So, might require separate issue for
this. Also, Changing the issue to type bug
[~noble.paul]
A quick question(not related to this issue)
As I was looking into this API, I checked implicit API definitions. From solr
7, {{wt=json}} is default. So, should we remove wt=json from {{defaults}} of
the implicit API?
> Fail on Unknown operation in Request Parameters API
> ---
>
> Key: SOLR-13827
> URL: https://issues.apache.org/jira/browse/SOLR-13827
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: config-api
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Minor
> Attachments: SOLR-13827.patch
>
>
> Request Parameters API supports set, update and delete operations. For any
> other operation, The API should fail and return error.
> Currently, for unknown operation API returns 200 status
> The config/overlay API fails on unknown operations
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[ https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949715#comment-16949715 ] Noble Paul commented on SOLR-13827: --- I guess we should just fix this opne issue and use the rewrite using annotations later > Fail on Unknown operation in Request Parameters API > --- > > Key: SOLR-13827 > URL: https://issues.apache.org/jira/browse/SOLR-13827 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: config-api >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > > Request Parameters API supports set, update and delete operations. For any > other operation, The API should fail and return error. > Currently, for unknown operation API returns 200 status > The config/overlay API fails on unknown operations -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[
https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949133#comment-16949133
]
Munendra S N commented on SOLR-13827:
-
{quote}Can you just rewrite the config API using the new annotations? It'll
take care of most of these issues
{quote}
I think you are referring to SOLR-13787. If I understand correctly, it is
specific to V2 API. Current issue exists for both V1 API and V2 API.
Is there a way to ensure that issue is resolved for both versions when config
handler is rewritten using new annotations?
> Fail on Unknown operation in Request Parameters API
> ---
>
> Key: SOLR-13827
> URL: https://issues.apache.org/jira/browse/SOLR-13827
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: config-api
>Reporter: Munendra S N
>Assignee: Munendra S N
>Priority: Minor
>
> Request Parameters API supports set, update and delete operations. For any
> other operation, The API should fail and return error.
> Currently, for unknown operation API returns 200 status
> The config/overlay API fails on unknown operations
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[ https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947328#comment-16947328 ] Noble Paul commented on SOLR-13827: --- bq.Any reason for not failing on unknown operation in Request Parameter API? Well, it should fail bq. Ideally, for unsupported HTTP methods request should fail. Is there any reason for handling this way? It should Can you just rewrite the config API using the new annotations? It'll take care of most of these issues bq.Randomly observed that /config/params/bleh/bl is equivalent to /config/params where /bleh/bl is some non-existent paths this was designed for you to fetch arbitrary params (read only) > Fail on Unknown operation in Request Parameters API > --- > > Key: SOLR-13827 > URL: https://issues.apache.org/jira/browse/SOLR-13827 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: config-api >Reporter: Munendra S N >Assignee: Munendra S N >Priority: Minor > > Request Parameters API supports set, update and delete operations. For any > other operation, The API should fail and return error. > Currently, for unknown operation API returns 200 status > The config/overlay API fails on unknown operations -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13827) Fail on Unknown operation in Request Parameters API
[
https://issues.apache.org/jira/browse/SOLR-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946776#comment-16946776
]
Munendra S N commented on SOLR-13827:
-
[~noble.paul]
Any reason for not failing on unknown operation in Request Parameter API?
Few other observations in Request Parameters
* Request with any other HTTP method than POST defaults to GET in the codebase.
Ideally, for unsupported HTTP methods should fail. Is there any reason for
handling this way?
* Randomly observed that {{/config/params/bleh/bl}} is equivalent to
{{/config/params}} where {{/bleh/bl}} is some non-existent paths
> Fail on Unknown operation in Request Parameters API
> ---
>
> Key: SOLR-13827
> URL: https://issues.apache.org/jira/browse/SOLR-13827
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: config-api
>Reporter: Munendra S N
>Priority: Minor
>
> Request Parameters API supports set, update and delete operations. For any
> other operation, The API should fail and return error.
> Currently, for unknown operation API returns 200 status
> The config/overlay API fails on unknown operations
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
