Re: [I] TestDocumentsWriterStallControl.assertState() does not do what it appears it would [lucene]
s1monw closed issue #13061: TestDocumentsWriterStallControl.assertState() does not do what it appears it would URL: https://github.com/apache/lucene/issues/13061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestDocumentsWriterStallControl.assertState() does not do what it appears it would [lucene]
sabi0 commented on issue #13061: URL: https://github.com/apache/lucene/issues/13061#issuecomment-1919391573 You were faster :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestDocumentsWriterStallControl.assertState() does not do what it appears it would [lucene]
s1monw commented on issue #13061: URL: https://github.com/apache/lucene/issues/13061#issuecomment-1919370836 I opened a pr for this.. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestDocumentsWriterStallControl.assertState() does not do what it appears it would [lucene]
sabi0 commented on issue #13061: URL: https://github.com/apache/lucene/issues/13061#issuecomment-1919335755 I think the idea was to wait for the blocked threads for up to 2 minutes. And then fail the test if there are still blocked threads. The progressive sleep time build-up is likely to avoid the test taking too long if the threads are unblocked quickly. Currently however it just sleeps for 100 ms and then exits. The fix is then to remove the `break` on line 190. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] TestDocumentsWriterStallControl.assertState() does not do what it appears it would [lucene]
s1monw commented on issue #13061: URL: https://github.com/apache/lucene/issues/13061#issuecomment-1919290712 oh I wish I knew what I was thinking back then 12 years ago 藍 I think that code tries to break out only of the for loop which needs a label I guess to go back to the while loop. Do you wanna take a stab at it and fix it. I think we need to make sure that the for loop runs through at one point and then step out of the outer while loop. Tricky... @mikemccand do you recall exactly what we tried to test back then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
