[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122200#comment-16122200
 ] 

ASF GitHub Bot commented on MADLIB-1118:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-madlib/pull/163
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/148/



> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122029#comment-16122029
 ] 

ASF GitHub Bot commented on MADLIB-1118:


Github user iyerr3 commented on the issue:

https://github.com/apache/incubator-madlib/pull/163
  
Jenkins please retest. 


> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121994#comment-16121994
 ] 

ASF GitHub Bot commented on MADLIB-1118:


Github user edespino commented on the issue:

https://github.com/apache/incubator-madlib/pull/163
  
@iyerr3 - Thanks for the review. Very much appreciated. Additionally, I 
should have reviewed the `install-check` options. Thanks for the info.


> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121990#comment-16121990
 ] 

ASF GitHub Bot commented on MADLIB-1118:


Github user iyerr3 commented on the issue:

https://github.com/apache/incubator-madlib/pull/163
  
The change looks good. 

Few comments: 
- An alternative to changing the threshold is to reduce the max number of 
iterations. Even with the lower threshold, we're not necessarily guaranteed 
quicker completion. 
- The log file can be accessed even with the test passing by adding `-vl` 
option to the `madpack install-check` command. The options indicate `-v: 
Verbose` and `-l: Keep logs`. 
- The install-check itself also provides the run time for execution of the 
whole file. However, `\timing` is needed if run time for individual queries is 
desired. 

@njayaram2 Any idea why the asserts on `log_likelihood` are commented out? 


> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120865#comment-16120865
 ] 

ASF GitHub Bot commented on MADLIB-1118:


Github user njayaram2 commented on the issue:

https://github.com/apache/incubator-madlib/pull/163
  
LGTM, since we anyway don't assert on `relative_error` on `log_likelihood` 
in elastic_net.


> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120552#comment-16120552
 ] 

ASF GitHub Bot commented on MADLIB-1118:


Github user edespino commented on the issue:

https://github.com/apache/incubator-madlib/pull/163
  
For future reference, this is how I reviewed the elastic_net install-check 
execution:

* Update the following file:`/src/ports/postgres/modules/elastic_net/test/elastic_net_install_check.sql_in`
  * Added `\timing` to top of the file.
  * Added `SELECT ASSERT (FALSE, 'Deliberately forced failure');` to the 
bottom of the file to force a failure condition. This will allowed me to review 
the timing information in the log files from the test execution.
* From build directory run `make install` to push updated install-check 
file to installation directory
* Run only the elastic_net test suite (using Postgres): 
`/usr/local/madlib/bin/madpack -s madlib -p postgres install-check -t 
elastic_net

I updated the elastic_net_train tolerance values with varying values and 
reran the repeated the scenario reviewing the recorded `Time:` values.


> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1118) Reduce size of elastic net install check table

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119491#comment-16119491
 ] 

ASF GitHub Bot commented on MADLIB-1118:


GitHub user edespino opened a pull request:

https://github.com/apache/incubator-madlib/pull/163

MADLIB-1118. Change tolerance to 1e-2 (from 1e-6)

This changes the execution elapsed time to 2252 milliseconds from
10171 milliseconds on mac with Postgre 9.6

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/edespino/incubator-madlib MADLIB-1138

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-madlib/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit 8c3bc61047f8a4cab61dd239502d08ede415316f
Author: Ed Espino 
Date:   2017-08-09T06:40:13Z

MADLIB-1118. Change tolerance to 1e-2 (from 1e-6)

This changes the execution elapsed time to 2252 milliseconds from
10171 milliseconds on mac with Postgre 9.6




> Reduce size of elastic net install check table
> --
>
> Key: MADLIB-1118
> URL: https://issues.apache.org/jira/browse/MADLIB-1118
> Project: Apache MADlib
>  Issue Type: Task
>  Components: Module: Regularized Regression
>Reporter: Frank McQuillan
>Assignee: Ed Espino
>Priority: Minor
> Fix For: v1.12
>
>
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)