[jira] [Commented] (MADLIB-1146) Elastic Net fails when used without normalization with grouping

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133934#comment-16133934
 ] 

ASF GitHub Bot commented on MADLIB-1146:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-madlib/pull/172


> Elastic Net fails when used without normalization with grouping
> ---
>
> Key: MADLIB-1146
> URL: https://issues.apache.org/jira/browse/MADLIB-1146
> Project: Apache MADlib
>  Issue Type: Bug
>Reporter: Cooper Sloan
>Assignee: Nandish Jayaram
>Priority: Minor
>
> ```
> DROP TABLE IF EXISTS house_en,house_en_summary;
> SELECT madlib.elastic_net_train(
> 'lin_housing_wi',
> 'house_en',
> 'y',
> 'x',
> 'gaussian',
> 0.5,
> 0.5,
> False,
> 'grp_by_col',
> 'fista',
> '',
> NULL,
> 1,
> 1e-6
> );
> psql:/Users/csloan/elastic_net.sql:1: NOTICE:  table "house_en" does not 
> exist, skipping
> psql:/Users/csloan/elastic_net.sql:1: NOTICE:  table "house_en_summary" does 
> not exist, skipping
> DROP TABLE
> psql:/Users/csloan/elastic_net.sql:17: ERROR:  KeyError: 'select_grp'
> CONTEXT:  Traceback (most recent call last):
>   PL/Python function "elastic_net_train", line 27, in 
> excluded, max_iter, tolerance)
>   PL/Python function "elastic_net_train", line 467, in elastic_net_train
>   PL/Python function "elastic_net_train", line 502, in 
> _internal_elastic_net_train
>   PL/Python function "elastic_net_train", line 24, in 
> _elastic_net_gaussian_fista_train
>   PL/Python function "elastic_net_train", line 171, in 
> _elastic_net_fista_train
>   PL/Python function "elastic_net_train", line 297, in 
> _elastic_net_fista_train_compute
>   PL/Python function "elastic_net_train", line 83, in 
> _elastic_net_generate_result
> PL/Python function "elastic_net_train"
> ```



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MADLIB-1146) Elastic Net fails when used without normalization with grouping

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MADLIB-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133294#comment-16133294
 ] 

ASF GitHub Bot commented on MADLIB-1146:


GitHub user njayaram2 opened a pull request:

https://github.com/apache/incubator-madlib/pull/172

Elastic_net: Fix grouping without normalization bug

JIRA: MADLIB-1146

Selecting grouping columns into the output table was not working
when data was NOT scaled, but grouping was used. This commit
fixes it.

Closes #172

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/njayaram2/incubator-madlib bugfix/MADlib_1146

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-madlib/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #172


commit 54c09a64b98a070cd4f18c85bf47bf77a2546264
Author: Nandish Jayaram 
Date:   2017-08-18T17:10:58Z

Elastic_net: Fix grouping without normalization bug

JIRA: MADLIB-1146

Selecting grouping columns into the output table was not working
when data was NOT scaled, but grouping was used. This commit
fixes it.

Closes #172




> Elastic Net fails when used without normalization with grouping
> ---
>
> Key: MADLIB-1146
> URL: https://issues.apache.org/jira/browse/MADLIB-1146
> Project: Apache MADlib
>  Issue Type: Bug
>Reporter: Cooper Sloan
>Assignee: Nandish Jayaram
>Priority: Minor
>
> ```
> DROP TABLE IF EXISTS house_en,house_en_summary;
> SELECT madlib.elastic_net_train(
> 'lin_housing_wi',
> 'house_en',
> 'y',
> 'x',
> 'gaussian',
> 0.5,
> 0.5,
> False,
> 'grp_by_col',
> 'fista',
> '',
> NULL,
> 1,
> 1e-6
> );
> psql:/Users/csloan/elastic_net.sql:1: NOTICE:  table "house_en" does not 
> exist, skipping
> psql:/Users/csloan/elastic_net.sql:1: NOTICE:  table "house_en_summary" does 
> not exist, skipping
> DROP TABLE
> psql:/Users/csloan/elastic_net.sql:17: ERROR:  KeyError: 'select_grp'
> CONTEXT:  Traceback (most recent call last):
>   PL/Python function "elastic_net_train", line 27, in 
> excluded, max_iter, tolerance)
>   PL/Python function "elastic_net_train", line 467, in elastic_net_train
>   PL/Python function "elastic_net_train", line 502, in 
> _internal_elastic_net_train
>   PL/Python function "elastic_net_train", line 24, in 
> _elastic_net_gaussian_fista_train
>   PL/Python function "elastic_net_train", line 171, in 
> _elastic_net_fista_train
>   PL/Python function "elastic_net_train", line 297, in 
> _elastic_net_fista_train_compute
>   PL/Python function "elastic_net_train", line 83, in 
> _elastic_net_generate_result
> PL/Python function "elastic_net_train"
> ```



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)