[jira] (MNG-5536) Wrong runtime classpath if inheriting dependencies specified by profile from parent
Tibor Digana created MNG-5536: - Summary: Wrong runtime classpath if inheriting dependencies specified by profile from parent Key: MNG-5536 URL: https://jira.codehaus.org/browse/MNG-5536 Project: Maven 2 & 3 Issue Type: Bug Components: Profiles Affects Versions: 3.1.1 Environment: Win Reporter: Tibor Digana Attachments: with profiles and with parents.zip The module DAO-BOM(pom) defines dependency within a profile. Other module webapp(war) which indirectly inherits from DAO-BOM does not see such dependency hibernate-core-4.2.6.Final.jar and dependency which was not excluded hibernate-commons-annotations-4.0.2.Final.jar Since the failure results in dependency and war plugin, it looks like the bug is in Maven core and related to profiles. I found this issue when I examied the workaround for https://jira.codehaus.org/browse/MNG-2205 The problem is that the build result is different in Maven 2.2.1 and Maven 3.1.1 in webapp module. The Maven 2.2.1 works as expected. There are two issues with Maven 3.1.1 : + Maven 3 ignored two Hibernate runtime artifacts which I expect in WAR file; + classpath produced by maven-dependency-plugin:build-classpath does not have those two runtime artifacts if includeScope=runtime. See the webapp POM. The Zip file contains the project and four text files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIA-506) move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package
Herve Boutemy created DOXIA-506: --- Summary: move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package Key: DOXIA-506 URL: https://jira.codehaus.org/browse/DOXIA-506 Project: Maven Doxia Issue Type: Wish Components: Core Affects Versions: 1.5 Reporter: Herve Boutemy doxia-sink-api "owns" o.a.m.doxia.sink package: http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-sink-api/apidocs/index.html there shouldn't be classes from doxia-core in the same package: http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-core/apidocs/org/apache/maven/doxia/sink/package-summary.html moving these classes to an "impl" subpackage will make things clearer, while being only internal between doxia-core and modules -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIA-506) move classes from doxia-core in sink package (same as doxia-sink-api) to dedicated sink.impl package
[ https://jira.codehaus.org/browse/DOXIA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIA-506: Fix Version/s: 2.0 > move classes from doxia-core in sink package (same as doxia-sink-api) to > dedicated sink.impl package > > > Key: DOXIA-506 > URL: https://jira.codehaus.org/browse/DOXIA-506 > Project: Maven Doxia > Issue Type: Wish > Components: Core >Affects Versions: 1.5 >Reporter: Herve Boutemy > Fix For: 2.0 > > > doxia-sink-api "owns" o.a.m.doxia.sink package: > http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-sink-api/apidocs/index.html > there shouldn't be classes from doxia-core in the same package: > http://maven.apache.org/doxia/doxia-archives/doxia-1.5/doxia-core/apidocs/org/apache/maven/doxia/sink/package-summary.html > moving these classes to an "impl" subpackage will make things clearer, while > being only internal between doxia-core and modules -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release
[ https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335889#comment-335889 ] Jeremie H commented on MRELEASE-812: @Catalin Patruica Yes, setting the system language to English worked. But I strongly agree with Richard Eckart de Castilho : the plugin should work regardless of the system language. > "prepare" does not commit before tagging and therefore deploys snapshot > instead of release > -- > > Key: MRELEASE-812 > URL: https://jira.codehaus.org/browse/MRELEASE-812 > Project: Maven Release Plugin > Issue Type: Bug > Components: Git >Affects Versions: 2.4 >Reporter: Andrei Pozolotin >Priority: Critical > Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt > > > thank you very much for new release! > http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E > it seems we need an emergency fix: > attached are 2 logs: > 1) mvn-2.3.2.txt invocation that works fine with 2.3.2 > 2) mvn-2.4.0.txt invocation that fails with 2.4 > problem: > "perform" does not commit tags, deploys snapshot instead of release > here is project parent: > http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom > build is invoked both times with this: > mvn --define resume=false release:prepare > mvn --define resume=false release:perform -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MWAR-264) Goal war:exploded should support packagingExcludes too
[ https://jira.codehaus.org/browse/MWAR-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335888#comment-335888 ] Filipe Sousa commented on MWAR-264: --- Any news on this? > Goal war:exploded should support packagingExcludes too > -- > > Key: MWAR-264 > URL: https://jira.codehaus.org/browse/MWAR-264 > Project: Maven WAR Plugin > Issue Type: Improvement >Affects Versions: 2.1.1 >Reporter: Geoffrey De Smet > > The war:war goals supports packagingExcludes, but the war:exploded doesn't > support it yet. > This means the exploded war and the packaged war behave differently, which is > something that shouldn't happen by default. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release
[ https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335887#comment-335887 ] Richard Eckart de Castilho commented on MRELEASE-812: - Last time I checked, it was necessary to change the system language to English for releases to work? In any case, I think this should only be closed when/if the maven-release-plugin itself chooses providers that work. The user should not need to manually upgrade dependencies of a plugin for it to work. > "prepare" does not commit before tagging and therefore deploys snapshot > instead of release > -- > > Key: MRELEASE-812 > URL: https://jira.codehaus.org/browse/MRELEASE-812 > Project: Maven Release Plugin > Issue Type: Bug > Components: Git >Affects Versions: 2.4 >Reporter: Andrei Pozolotin >Priority: Critical > Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt > > > thank you very much for new release! > http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E > it seems we need an emergency fix: > attached are 2 logs: > 1) mvn-2.3.2.txt invocation that works fine with 2.3.2 > 2) mvn-2.4.0.txt invocation that fails with 2.4 > problem: > "perform" does not commit tags, deploys snapshot instead of release > here is project parent: > http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom > build is invoked both times with this: > mvn --define resume=false release:prepare > mvn --define resume=false release:perform -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release
[ https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335887#comment-335887 ] Richard Eckart de Castilho edited comment on MRELEASE-812 at 11/17/13 2:09 PM: --- Last time I checked, it was necessary to change the system language to English for releases to work. In any case, I think this should only be closed when/if the maven-release-plugin itself chooses providers that work. The user should not need to manually upgrade dependencies of a plugin for it to work. was (Author: rec): Last time I checked, it was necessary to change the system language to English for releases to work? In any case, I think this should only be closed when/if the maven-release-plugin itself chooses providers that work. The user should not need to manually upgrade dependencies of a plugin for it to work. > "prepare" does not commit before tagging and therefore deploys snapshot > instead of release > -- > > Key: MRELEASE-812 > URL: https://jira.codehaus.org/browse/MRELEASE-812 > Project: Maven Release Plugin > Issue Type: Bug > Components: Git >Affects Versions: 2.4 >Reporter: Andrei Pozolotin >Priority: Critical > Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt > > > thank you very much for new release! > http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E > it seems we need an emergency fix: > attached are 2 logs: > 1) mvn-2.3.2.txt invocation that works fine with 2.3.2 > 2) mvn-2.4.0.txt invocation that fails with 2.4 > problem: > "perform" does not commit tags, deploys snapshot instead of release > here is project parent: > http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom > build is invoked both times with this: > mvn --define resume=false release:prepare > mvn --define resume=false release:perform -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release
[ https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335886#comment-335886 ] Catalin Patruica commented on MRELEASE-812: --- @Jeremie H has the solution work for you or you are still having problems? because if it has work, then the issue can be close, right? ceers, cp > "prepare" does not commit before tagging and therefore deploys snapshot > instead of release > -- > > Key: MRELEASE-812 > URL: https://jira.codehaus.org/browse/MRELEASE-812 > Project: Maven Release Plugin > Issue Type: Bug > Components: Git >Affects Versions: 2.4 >Reporter: Andrei Pozolotin >Priority: Critical > Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt > > > thank you very much for new release! > http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E > it seems we need an emergency fix: > attached are 2 logs: > 1) mvn-2.3.2.txt invocation that works fine with 2.3.2 > 2) mvn-2.4.0.txt invocation that fails with 2.4 > problem: > "perform" does not commit tags, deploys snapshot instead of release > here is project parent: > http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom > build is invoked both times with this: > mvn --define resume=false release:prepare > mvn --define resume=false release:perform -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release
[ https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335885#comment-335885 ] Jeremie H commented on MRELEASE-812: I lost so mush time on this... > "prepare" does not commit before tagging and therefore deploys snapshot > instead of release > -- > > Key: MRELEASE-812 > URL: https://jira.codehaus.org/browse/MRELEASE-812 > Project: Maven Release Plugin > Issue Type: Bug > Components: Git >Affects Versions: 2.4 >Reporter: Andrei Pozolotin >Priority: Critical > Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt > > > thank you very much for new release! > http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E > it seems we need an emergency fix: > attached are 2 logs: > 1) mvn-2.3.2.txt invocation that works fine with 2.3.2 > 2) mvn-2.4.0.txt invocation that fails with 2.4 > problem: > "perform" does not commit tags, deploys snapshot instead of release > here is project parent: > http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom > build is invoked both times with this: > mvn --define resume=false release:prepare > mvn --define resume=false release:perform -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-733) Bugfixes to mercurial changelog
[ https://jira.codehaus.org/browse/SCM-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335884#comment-335884 ] Mads Mohr Christensen commented on SCM-733: --- Is there any plans on when this is supposed to be released? I'd really like to use this fix in another project. > Bugfixes to mercurial changelog > --- > > Key: SCM-733 > URL: https://jira.codehaus.org/browse/SCM-733 > Project: Maven SCM > Issue Type: Bug >Affects Versions: 1.8.1 >Reporter: Olivier Lamy >Assignee: Olivier Lamy > Fix For: 1.9 > > > see pull request https://github.com/apache/maven-scm/pull/6 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-2205) "provided" scope dependencies must be transitive
[
https://jira.codehaus.org/browse/MNG-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335883#comment-335883
]
Tibor Digana edited comment on MNG-2205 at 11/17/13 9:11 AM:
-
I do not know if the bug is definitely in Maven core or maven-war-plugin 2.2 or
2.4.
The efective-pom correctly resolves the modules DAO(jar) and Services(jar).
For sure I will rollback to Maven 2.2.1 because there the profiles in DAO-BOM
and Services-BOM work as expected.
{code
reactor's parent(pom)
^
+-+
| ^
| |
DAO(jar) -> DAO-BOM(pom)
^ ^
| |
Services(jar) -> Services-BOM(pom)
^
|
webapp(war)}
The development profile has dependencies in DAO(jar):
org.hibernate
hibernate-core
4.2.6.Final
Th production profile has dependencies in DAO(jar):
org.hibernate
hibernate-core
4.2.6.Final
org.jboss.spec.javax.transaction
jboss-transaction-api_1.1_spec
org.jboss.spec.javax.transaction
jboss-transaction-api_1.1_spec
1.0.1.Final
provided
was (Author: tibor17):
I do not know if the bug is definitely in Maven core or maven-war-plugin
2.2 or 2.4.
The efective-pom correctly resolves the modules DAO(jar) and Services(jar).
For sure I will rollback to Maven 2.2.1 because there the profiles in DAO-BOM
and Services-BOM work as expected.
reactor's parent(pom)
^
+-+
| ^
| |
DAO(jar) -> DAO-BOM(pom)
^ ^
| |
Services(jar) -> Services-BOM(pom)
^
|
webapp(war)
The development profile has dependencies in DAO(jar):
org.hibernate
hibernate-core
4.2.6.Final
Th production profile has dependencies in DAO(jar):
org.hibernate
hibernate-core
4.2.6.Final
org.jboss.spec.javax.transaction
jboss-transaction-api_1.1_spec
org.jboss.spec.javax.transaction
jboss-transaction-api_1.1_spec
1.0.1.Final
provided
> "provided" scope dependencies must be transitive
>
>
> Key: MNG-2205
> URL: https://jira.codehaus.org/browse/MNG-2205
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Dependencies
>Reporter: David Boden
>Priority: Critical
> Fix For: 3.x / Backlog
>
> Attachments: transitivetest.zip
>
>
> A provided scope dependency can also be thought of as "compile-only".
> Project A requires Sybase JConnect on the runtime classpath. Project A
> declares a "provided" dependency on Sybase JConnect.
> Project B depends upon Project A. Project B declares a "compile" dependency
> on Project A.
> Project C depends upon Project B. Project C declares a "compile" dependency
> on Project B.
> {noformat}
> C
> | - compile dependency
> B
> | - compile dependency
> A
> | - provided dependency
> Sybase JConnect
> {noformat}
> So, does Project C transitively depend on Sybase JConnect. Yes, of course!
> The "provided" dependency needs to be transitive.
> Ultimately, when Project C gets deployed, Sybase JConnect needs to be
> somewhere on the runtime classpath in order for the application to function.
> It's valid for Project C to assume that Sybase JConnect is available and use
> JDBC all over the Project C code. Project C is safe to do this because it can
> happily deduce that Sybase JConnect will be there in the runtime environment
> because Project A NEEDS IT.
> I've got Use Cases all over my aggregated build which make it absolutely
> critical and common sense that provided scope dependencies are transitive.
> For the (very rare) odd case where you don't want to inherit provided
> dependencies, you can them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-2205) "provided" scope dependencies must be transitive
[
https://jira.codehaus.org/browse/MNG-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335883#comment-335883
]
Tibor Digana commented on MNG-2205:
---
I do not know if the bug is definitely in Maven core or maven-war-plugin 2.2 or
2.4.
The efective-pom correctly resolves the modules DAO(jar) and Services(jar).
For sure I will rollback to Maven 2.2.1 because there the profiles in DAO-BOM
and Services-BOM work as expected.
reactor's parent(pom)
^
+-+
| ^
| |
DAO(jar) -> DAO-BOM(pom)
^ ^
| |
Services(jar) -> Services-BOM(pom)
^
|
webapp(war)
The development profile has dependencies in DAO(jar):
org.hibernate
hibernate-core
4.2.6.Final
Th production profile has dependencies in DAO(jar):
org.hibernate
hibernate-core
4.2.6.Final
org.jboss.spec.javax.transaction
jboss-transaction-api_1.1_spec
org.jboss.spec.javax.transaction
jboss-transaction-api_1.1_spec
1.0.1.Final
provided
> "provided" scope dependencies must be transitive
>
>
> Key: MNG-2205
> URL: https://jira.codehaus.org/browse/MNG-2205
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Dependencies
>Reporter: David Boden
>Priority: Critical
> Fix For: 3.x / Backlog
>
> Attachments: transitivetest.zip
>
>
> A provided scope dependency can also be thought of as "compile-only".
> Project A requires Sybase JConnect on the runtime classpath. Project A
> declares a "provided" dependency on Sybase JConnect.
> Project B depends upon Project A. Project B declares a "compile" dependency
> on Project A.
> Project C depends upon Project B. Project C declares a "compile" dependency
> on Project B.
> {noformat}
> C
> | - compile dependency
> B
> | - compile dependency
> A
> | - provided dependency
> Sybase JConnect
> {noformat}
> So, does Project C transitively depend on Sybase JConnect. Yes, of course!
> The "provided" dependency needs to be transitive.
> Ultimately, when Project C gets deployed, Sybase JConnect needs to be
> somewhere on the runtime classpath in order for the application to function.
> It's valid for Project C to assume that Sybase JConnect is available and use
> JDBC all over the Project C code. Project C is safe to do this because it can
> happily deduce that Sybase JConnect will be there in the runtime environment
> because Project A NEEDS IT.
> I've got Use Cases all over my aggregated build which make it absolutely
> critical and common sense that provided scope dependencies are transitive.
> For the (very rare) odd case where you don't want to inherit provided
> dependencies, you can them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIA-386) Snippet Macro: Reference file does not support UTF-8 file format to generate the page garbage
[
https://jira.codehaus.org/browse/DOXIA-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-386:
-
Attachment: DOXIA-386.patch
A patch which fixes the encoding issue with one glitch: You need to specify the
encoding directly in the snippet.
> Snippet Macro: Reference file does not support UTF-8 file format to generate
> the page garbage
> --
>
> Key: DOXIA-386
> URL: https://jira.codehaus.org/browse/DOXIA-386
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.2
> Environment: windows7 zh_CN
>Reporter: pinghe
>Assignee: Michael Osipov
> Attachments: DOXIA-386.patch
>
>
> {code:xml}
>
> maven-site-plugin
> 2.1
>
> zh_CN
> UTF-8
> UTF-8
>
>
> {code}
> my sample apt file:
> {noformat}
> %{snippet|file=target/site/reference/html/sample.html|verbatim=false}
> {noformat}
> sample.html:
> {code:xml}
>
>PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
> xmlns="http://www.w3.org/1999/xhtml";>中文
> {code}
> {{org.apache.maven.doxia.macro.snippet.SnippetReader}}
> readLines:
> {code}
> reader = new BufferedReader(new InputStreamReader(source.openStream()));
> {code}
> use {{InputStreamReader(InputStream in)}}
> change to:
> {code}
> InputStreamReader(InputStream in, Charset cs)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIA-386) Snippet Macro: Reference file does not support UTF-8 file format to generate the page garbage
[
https://jira.codehaus.org/browse/DOXIA-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-386:
-
Assignee: Michael Osipov
> Snippet Macro: Reference file does not support UTF-8 file format to generate
> the page garbage
> --
>
> Key: DOXIA-386
> URL: https://jira.codehaus.org/browse/DOXIA-386
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.2
> Environment: windows7 zh_CN
>Reporter: pinghe
>Assignee: Michael Osipov
>
> {code:xml}
>
> maven-site-plugin
> 2.1
>
> zh_CN
> UTF-8
> UTF-8
>
>
> {code}
> my sample apt file:
> {noformat}
> %{snippet|file=target/site/reference/html/sample.html|verbatim=false}
> {noformat}
> sample.html:
> {code:xml}
>
>PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>
> xmlns="http://www.w3.org/1999/xhtml";>中文
> {code}
> {{org.apache.maven.doxia.macro.snippet.SnippetReader}}
> readLines:
> {code}
> reader = new BufferedReader(new InputStreamReader(source.openStream()));
> {code}
> use {{InputStreamReader(InputStream in)}}
> change to:
> {code}
> InputStreamReader(InputStream in, Charset cs)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
