[jira] (MRELEASE-812) "prepare" does not commit before tagging and therefore deploys snapshot instead of release

2014-01-18 Thread James Ward (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338825#comment-338825
 ] 

James Ward commented on MRELEASE-812:
-

I just hit this as well.  A release fix would be greatly appreciated since it 
will be easier to bump the maven-release-plugin than to add the new dependency 
to 250 WebJar projects.

> "prepare" does not commit before tagging and therefore deploys snapshot 
> instead of release
> --
>
> Key: MRELEASE-812
> URL: https://jira.codehaus.org/browse/MRELEASE-812
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: Git
>Affects Versions: 2.4
>Reporter: Andrei Pozolotin
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 2.5
>
> Attachments: mvn-2.3.2.txt, mvn-2.4.0.txt
>
>
> thank you very much for new release!
> http://mail-archives.apache.org/mod_mbox/maven-announce/201212.mbox/%3Cop.wpjbptp1kdkhrr@columbia%3E
> it seems we need an emergency fix:
> attached are 2 logs:
> 1) mvn-2.3.2.txt invocation that works fine with 2.3.2
> 2) mvn-2.4.0.txt invocation that fails with 2.4
> problem:
> "perform" does not commit tags, deploys snapshot instead of release
> here is project parent:
> http://search.maven.org/remotecontent?filepath=com/barchart/base/barchart-archon/2.3.6/barchart-archon-2.3.6.pom
> build is invoked both times with this:
> mvn --define resume=false release:prepare
> mvn --define resume=false release:perform

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-167) Documented '*' feature of banned dependencies doesn't work

2014-01-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://jira.codehaus.org/browse/MENFORCER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338823#comment-338823
 ] 

Karl Heinz Marbaise commented on MENFORCER-167:
---

First working state done in [r1559391|http://svn.apache.org/r1559391]

> Documented '*' feature of banned dependencies doesn't work
> --
>
> Key: MENFORCER-167
> URL: https://jira.codehaus.org/browse/MENFORCER-167
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Documentation, Standard Rules
>Affects Versions: 1.3.1
>Reporter: Will May
>Assignee: Karl Heinz Marbaise
> Attachments: regex-banned-dependencies.patch
>
>
> The documentation states that it is possible to ban dependencies with the 
> pattern
> {code}
> org.apache.*:maven-*:*
> {code}
> The attached test case shows that this isn't the case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-143) 'All' propery is not handled by RequireActiveProfile rule

2014-01-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://jira.codehaus.org/browse/MENFORCER-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338496#comment-338496
 ] 

Karl Heinz Marbaise edited comment on MENFORCER-143 at 1/18/14 11:59 AM:
-

Follow up in [r1557604|http://svn.apache.org/r1557604]

  was (Author: khmarbaise):
Follow up in r1557604
  
> 'All' propery is not handled by RequireActiveProfile rule
> -
>
> Key: MENFORCER-143
> URL: https://jira.codehaus.org/browse/MENFORCER-143
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Maciej Kwiecien
>Assignee: Karl Heinz Marbaise
> Fix For: 2.0
>
> Attachments: HandlingAllPropertyInRequireActiveProfileRule.patch, 
> HandlingAllPropertyInRequireActiveProfileRuleSimplified.patch
>
>
> Although you have rules configured, as follows:
> {code}
> ...
>  
>   
>
> dev,selenium
> false
>
>  
>  true
>  
> {code}
> And you run build : mvn clean install *-Pselenium*
> You still get error:
> {code}
> Supported profiles: selenium,dev
> Profile "dev" is not activated.
> {code}
> Fix is quite simple (tested on tag 1.1.1 and trunk) - please find in 
> attachment.
> Best Regards,
> Maciej

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-143) 'All' propery is not handled by RequireActiveProfile rule

2014-01-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://jira.codehaus.org/browse/MENFORCER-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338279#comment-338279
 ] 

Karl Heinz Marbaise edited comment on MENFORCER-143 at 1/18/14 11:59 AM:
-

Fixed in [r1556667|http://svn.apache.org/r1556667].
Using the second code example of Marciej Kwiecien.

  was (Author: khmarbaise):
Fixed in http://svn.apache.org/r1556667.
Using the second code example of Marciej Kwiecien.
  
> 'All' propery is not handled by RequireActiveProfile rule
> -
>
> Key: MENFORCER-143
> URL: https://jira.codehaus.org/browse/MENFORCER-143
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Maciej Kwiecien
>Assignee: Karl Heinz Marbaise
> Fix For: 2.0
>
> Attachments: HandlingAllPropertyInRequireActiveProfileRule.patch, 
> HandlingAllPropertyInRequireActiveProfileRuleSimplified.patch
>
>
> Although you have rules configured, as follows:
> {code}
> ...
>  
>   
>
> dev,selenium
> false
>
>  
>  true
>  
> {code}
> And you run build : mvn clean install *-Pselenium*
> You still get error:
> {code}
> Supported profiles: selenium,dev
> Profile "dev" is not activated.
> {code}
> Fix is quite simple (tested on tag 1.1.1 and trunk) - please find in 
> attachment.
> Best Regards,
> Maciej

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-143) 'All' propery is not handled by RequireActiveProfile rule

2014-01-18 Thread Karl Heinz Marbaise (JIRA)

[ 
https://jira.codehaus.org/browse/MENFORCER-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338279#comment-338279
 ] 

Karl Heinz Marbaise edited comment on MENFORCER-143 at 1/18/14 11:58 AM:
-

Fixed in http://svn.apache.org/r1556667.
Using the second code example of Marciej Kwiecien.

  was (Author: khmarbaise):
Fixed in r1556667.
Using the second code example of Marciej Kwiecien.
  
> 'All' propery is not handled by RequireActiveProfile rule
> -
>
> Key: MENFORCER-143
> URL: https://jira.codehaus.org/browse/MENFORCER-143
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Maciej Kwiecien
>Assignee: Karl Heinz Marbaise
> Fix For: 2.0
>
> Attachments: HandlingAllPropertyInRequireActiveProfileRule.patch, 
> HandlingAllPropertyInRequireActiveProfileRuleSimplified.patch
>
>
> Although you have rules configured, as follows:
> {code}
> ...
>  
>   
>
> dev,selenium
> false
>
>  
>  true
>  
> {code}
> And you run build : mvn clean install *-Pselenium*
> You still get error:
> {code}
> Supported profiles: selenium,dev
> Profile "dev" is not activated.
> {code}
> Fix is quite simple (tested on tag 1.1.1 and trunk) - please find in 
> attachment.
> Best Regards,
> Maciej

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-177) Support packagings for RequirePrerequisite rule, always ignore pom.

2014-01-18 Thread Robert Scholte (JIRA)

 [ 
https://jira.codehaus.org/browse/MENFORCER-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MENFORCER-177.


   Resolution: Fixed
Fix Version/s: 1.4
 Assignee: Robert Scholte

Fixed in [r1559362|http://svn.apache.org/r1559362]

> Support packagings for RequirePrerequisite rule, always ignore pom.
> ---
>
> Key: MENFORCER-177
> URL: https://jira.codehaus.org/browse/MENFORCER-177
> Project: Maven Enforcer Plugin
>  Issue Type: Improvement
>  Components: Standard Rules
>Affects Versions: 1.3, 1.3.1
>Reporter: Robert Scholte
>Assignee: Robert Scholte
> Fix For: 1.4
>
>
> When developing a maven-plugin you can control which version should at least 
> be *used* by defining the prerequisite for Maven. For all packaging types it 
> specifies which version is required to *build* the project.
> Since prerequisites aren't inherited and pom projects only generate a pom, 
> this type should always be ignored.
> In general you probably only want to enforce this for maven-plugins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MENFORCER-177) Support packagings for RequirePrerequisite rule, always ignore pom.

2014-01-18 Thread Robert Scholte (JIRA)
Robert Scholte created MENFORCER-177:


 Summary: Support packagings for RequirePrerequisite rule, always 
ignore pom.
 Key: MENFORCER-177
 URL: https://jira.codehaus.org/browse/MENFORCER-177
 Project: Maven Enforcer Plugin
  Issue Type: Improvement
  Components: Standard Rules
Affects Versions: 1.3.1, 1.3
Reporter: Robert Scholte


When developing a maven-plugin you can control which version should at least be 
*used* by defining the prerequisite for Maven. For all packaging types it 
specifies which version is required to *build* the project.

Since prerequisites aren't inherited and pom projects only generate a pom, this 
type should always be ignored.

In general you probably only want to enforce this for maven-plugins.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5494) Add a license file that corresponds to each GAV in the distribution

2014-01-18 Thread Jason van Zyl (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338821#comment-338821
 ] 

Jason van Zyl commented on MNG-5494:


What is producing the .license files currently. I don't find them particularly 
useful as you can't easily read the license text because it's in html, and it's 
not easily openable in a browser because of the non-standard extension. Either 
we should make them text files, or if we're going to leave them as html give 
them an html extension. Also it would be nice to move them into a separate 
directory as to not pollute the lib dir.

> Add a license file that corresponds to each GAV in the distribution
> ---
>
> Key: MNG-5494
> URL: https://jira.codehaus.org/browse/MNG-5494
> Project: Maven 2 & 3
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Jason van Zyl
>Assignee: Jason van Zyl
> Fix For: 3.2
>
>
> Right now we are not collecting the licenses for each binary artifact in the 
> distribution. We tentatively decided that we will create a license file per 
> artifact and include that in the distribution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

2014-01-18 Thread Jason van Zyl (JIRA)

 [ 
https://jira.codehaus.org/browse/MNG-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason van Zyl updated MNG-5389:
---

Assignee: Igor Fedorenko  (was: Jason van Zyl)

> AbstractMavenLifecycleParticipant need a afterSessionEnd
> 
>
> Key: MNG-5389
> URL: https://jira.codehaus.org/browse/MNG-5389
> Project: Maven 2 & 3
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.0.4
>Reporter: Olivier Lamy
>Assignee: Igor Fedorenko
> Fix For: 3.2
>
>
> we don't have way to know the build end with 
> AbstractMavenLifecycleParticipant.
> So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-863) Document that releaseProfiles must be in Root POM

2014-01-18 Thread Robert Scholte (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338820#comment-338820
 ] 

Robert Scholte commented on MRELEASE-863:
-

Well, that page is generated, just compare it with the goals page of any other 
maven plugin. We could override it with a custom page, but that would mean we 
need to maintain it. So I'm not sure if it's worth it. We could add a line on 
the usage page, assuming people read it. 

> Document that releaseProfiles must be in Root POM
> -
>
> Key: MRELEASE-863
> URL: https://jira.codehaus.org/browse/MRELEASE-863
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 2.4.2
>Reporter: James Olsen
>
> {{releaseProfiles}} configuration must be in the root pom or it does not get 
> applied.  I think this should be made VERY clear in the documentation as 
> trial and error releasing can be very time consuming.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-863) Document that releaseProfiles must be in Root POM

2014-01-18 Thread James Olsen (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338819#comment-338819
 ] 

James Olsen commented on MRELEASE-863:
--

That's nice to know.  So can we get that information added to the Introduction 
and remove the following comment from the Usage section of the Goals page?

{noformat}
{noformat}

> Document that releaseProfiles must be in Root POM
> -
>
> Key: MRELEASE-863
> URL: https://jira.codehaus.org/browse/MRELEASE-863
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 2.4.2
>Reporter: James Olsen
>
> {{releaseProfiles}} configuration must be in the root pom or it does not get 
> applied.  I think this should be made VERY clear in the documentation as 
> trial and error releasing can be very time consuming.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-863) Document that releaseProfiles must be in Root POM

2014-01-18 Thread Robert Scholte (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338818#comment-338818
 ] 

Robert Scholte commented on MRELEASE-863:
-

*_Any_* configuration of the maven-release-plugin must be in the root pom. It 
has no effect on other places.

> Document that releaseProfiles must be in Root POM
> -
>
> Key: MRELEASE-863
> URL: https://jira.codehaus.org/browse/MRELEASE-863
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 2.4.2
>Reporter: James Olsen
>
> {{releaseProfiles}} configuration must be in the root pom or it does not get 
> applied.  I think this should be made VERY clear in the documentation as 
> trial and error releasing can be very time consuming.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-459) releaseProfiles has no effect without passing profiles in the command line

2014-01-18 Thread James Olsen (JIRA)

[ 
https://jira.codehaus.org/browse/MRELEASE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338815#comment-338815
 ] 

James Olsen commented on MRELEASE-459:
--

Note that {{releaseProfiles}} has to be in the root pom.  Knowing that could 
save some time.  Raised MRELEASE-863.

> releaseProfiles has no effect without passing profiles in the command line 
> ---
>
> Key: MRELEASE-459
> URL: https://jira.codehaus.org/browse/MRELEASE-459
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: perform
>Affects Versions: 2.0-beta-8, 2.0-beta-9
>Reporter: Andreas Christoforides
>Assignee: Robert Scholte
>  Labels: contributers-welcome, help-requested, 
> missing-integration-tests
> Fix For: 2.4
>
> Attachments: MRELEASE-459.1.patch, patch.txt
>
>
> The releaseProfiles parameter on the perform goal is not taken into 
> consideration when no other profiles are passed in the command line. In other 
> words, the current code only uses the value of the parameter if you have 
> additional profiles passed in. 
> Example:
> mvn release:perform -P someProfile (uses releaseProfiles value)
> mvn release:perform (does NOT use releaseProfiles value)
> The plugin should use the parameter even if no other profiles are passed. It 
> should actually encourage release profiles configured in your POM as opposed 
> to arbitrary profiles passed in the command line.
> I have included a patch that uses the releaseProfiles parameter regardless of 
> any profiles passed in the command line.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MRELEASE-863) Document that releaseProfiles must be in Root POM

2014-01-18 Thread James Olsen (JIRA)
James Olsen created MRELEASE-863:


 Summary: Document that releaseProfiles must be in Root POM
 Key: MRELEASE-863
 URL: https://jira.codehaus.org/browse/MRELEASE-863
 Project: Maven Release Plugin
  Issue Type: Improvement
  Components: documentation
Affects Versions: 2.4.2
Reporter: James Olsen


{{releaseProfiles}} configuration must be in the root pom or it does not get 
applied.  I think this should be made VERY clear in the documentation as trial 
and error releasing can be very time consuming.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] (MNG-5562) Upgrade Aether

2014-01-18 Thread Benjamin Bentmann (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338814#comment-338814
 ] 

Benjamin Bentmann commented on MNG-5562:


You might find https://github.com/bentmann/maven inspiring with regard to 
Aether adoption.

> Upgrade Aether
> --
>
> Key: MNG-5562
> URL: https://jira.codehaus.org/browse/MNG-5562
> Project: Maven 2 & 3
>  Issue Type: Task
>  Components: Artifacts and Repositories
>Affects Versions: 3.0.4, 3.0.5, 3.1.0-alpha-1, 3.1.0, 3.1.1
>Reporter: Robert Scholte
>Priority: Minor
> Attachments: aether-upgrade.patch
>
>
> Aether-0.9.0-M4 fixes a couple of issues, for instance MDEP-405/MNG-5366 
> Upgrading is a bit tricky due to changed artifacts, see 
> http://wiki.eclipse.org/Aether/New_and_Noteworthy#Transporters
> The attached patch contains the upgrade.
> Jason advises to wait for Aether-1.0, which should be coming Real Soon (tm)
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira