[jira] (MNG-1378) Make dependencies of test-jars transitive
[ https://jira.codehaus.org/browse/MNG-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349694#comment-349694 ] Peter Ansell commented on MNG-1378: --- One alternative if you need to depend on a testsuite that is published by a different module to ensure that the testsuite is published as a "jar", not a "test-jar", and it is pulled into "test" scope in the local module, with all of its dependencies. I have used this "testsuite-module" + "testrunner-module" pattern successfully in the past to publish both concrete and abstract testclasses, although generally only for compliance tests where a specific interface or protocol is being tested based on a well known specification. > Make dependencies of test-jars transitive > - > > Key: MNG-1378 > URL: https://jira.codehaus.org/browse/MNG-1378 > Project: Maven > Issue Type: Bug > Components: Dependencies >Affects Versions: 2.0 >Reporter: Mark Hobson > Fix For: Issues to be reviewed for 3.x > > Attachments: mng1378.tar.gz > > > test-jar transitive dependencies are calculated as per compile scope rather > than test scope. > The situation is demonstrated nicely in it0077: > * module sub1 has a test-scoped dependency of commons-lang > * module sub2 has a test-scoped dependency of sub1 test-jar > sub2 tests should inherit the commons-lang transitive dependency. For > example: > Index: > maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java > === > --- > maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java > (revision > 328307) > +++ > maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java > (working > copy) > @@ -1,6 +1,7 @@ > package org.apache.maven.it0077; > import junit.framework.TestCase; > +import org.apache.commons.lang.BooleanUtils; > public class PersonTwoTest > extends PersonTest > Results in: > [INFO] > > [ERROR] BUILD FAILURE > [INFO] > > [INFO] Compilation failure > c:\maven-components\maven-core-it\it0077\sub2\src\test\java\org\apache\maven\it0077\PersonTwoTest.java:[4,31] > package org.apache.commons.lang does not exist -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MNG-5605) ssh-wagon hangs
[ https://jira.codehaus.org/browse/MNG-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349686#comment-349686 ] Allan commented on MNG-5605: For me, at least, this does not seem to be a wagon-ssh issue. With the wagon-ssh version locked, I can recreate this issue 100% of the time simply by flipping between 3.2.1 (broken) and 3.1.1 (working). I have tried this with both wagon-ssh versions 2.4 and 2.6 with the same result. Unfortunately, I can't seem to test Maven 3.2.2 - I'm running into the same problems that were discussed on the mailing list in [this thread|http://mail-archives.apache.org/mod_mbox/maven-dev/201407.mbox/%3c50066049-f6d1-4bf2-8c12-577658f31...@takari.io%3E] > ssh-wagon hangs > --- > > Key: MNG-5605 > URL: https://jira.codehaus.org/browse/MNG-5605 > Project: Maven > Issue Type: Bug > Components: Deployment >Affects Versions: 3.2.1 >Reporter: Frank Cornelis >Priority: Blocker > > When releasing (using maven-release-plugin) via Maven 3.1.1 everything works > as expected. When doing the same via Maven 3.2.1, ssh-wagon all of the sudden > hangs on the second ssh upload. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-138) Checkstyle plugin is @threadSafe if checkstyle itself is threadsafe
[
https://jira.codehaus.org/browse/MCHECKSTYLE-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349623#comment-349623
]
Herve Boutemy commented on MCHECKSTYLE-138:
---
thank you for the useful references
And I agree with you on
{quote}Note that MCHECKSTYLE-138 and
[#138|https://github.com/checkstyle/checkstyle/issues/138] are IMO 2 separate
(but obviously somehow related issues):
MCHECKSTYLE-138 is about @threadSafe support in Maven, Means: different modules
can be checked in parallel in the same VM. Still each module for itself can be
checked single-threaded (if you need to).
[#138|https://github.com/checkstyle/checkstyle/issues/138] is - AFAI understand
it - about making the check in a single module multi-threaded.
MCHECKSTYLE-138 is surely a precondition for #138, but I don't need to
implement #138 completely to have MCHECKSTYLE-138{quote}
> Checkstyle plugin is @threadSafe if checkstyle itself is threadsafe
> ---
>
> Key: MCHECKSTYLE-138
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-138
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
>Affects Versions: 2.12.1
>Reporter: Kristian Rosenvold
>
> The checkstyle plugin can be marked as threadSafe if checkstyle itself can be
> verified to be thread safe.
> "Someone" should ask the checkstyle community if this is the case.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MNG-5604) make it possible to mark a maven module as deprected
[
https://jira.codehaus.org/browse/MNG-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349612#comment-349612
]
Klaus Claszen commented on MNG-5604:
Thanks for discussing my enhancement request. I never used the enforcer plugin
so far and will have a look if I could handle my use case. Nevertheless it
seems that the modul that possibly uses a deprecated module has to include
something by itself to get the deprecation hint. That could be avoided in a mor
'core' centric solution.
> make it possible to mark a maven module as deprected
>
>
> Key: MNG-5604
> URL: https://jira.codehaus.org/browse/MNG-5604
> Project: Maven
> Issue Type: Wish
> Components: Artifacts and Repositories
>Affects Versions: 3.2.1
>Reporter: Klaus Claszen
>Priority: Minor
> Labels: build, pom.xml
>
> It would be great if it would be possible to mark a maven module as
> 'deprecated'. It would help to document that a module is outdated. The
> information could be used during build processes to show warnings and guide
> the user to a better alternative.
> Maybe it could be a pom enhancement linke this
> {code:xml}
>
> not maintained anymore
>
> foo
> bar
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MNG-3832) Allow wildcards in dependency exclusions
[
https://jira.codehaus.org/browse/MNG-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349608#comment-349608
]
Ciprian Pascu commented on MNG-3832:
This feature does not work with maven-dependency-plugin.
Also Idea development environment is affected.
> Allow wildcards in dependency exclusions
>
>
> Key: MNG-3832
> URL: https://jira.codehaus.org/browse/MNG-3832
> Project: Maven
> Issue Type: New Feature
> Components: Dependencies
>Reporter: Paul Gier
>Assignee: Robert Scholte
> Fix For: 3.2.1
>
> Attachments: MNG-3832-maven-artifact.patch
>
>
> I would like to be able to exclude all transitive dependencies from a certain
> dependencies. This is especially useful when depending on an artifact with a
> classifier that may not have the same dependencies as the main artifact.
> Currently the only way to do this is by excluding each dependency
> individually which requires significant effort and is prone to becoming out
> of date. The following syntax is one possibility.
> Exclude all transitive dependencies
> {code}
>
> *
>
> {code}
> Exclude transitive dependencies with the groupId "org.company"
> {code}
>
> org.company
> *
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MCHECKSTYLE-138) Checkstyle plugin is @threadSafe if checkstyle itself is threadsafe
[ https://jira.codehaus.org/browse/MCHECKSTYLE-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349607#comment-349607 ] Christoph Kutzinski commented on MCHECKSTYLE-138: - Herve, surely the above mentioned http://sourceforge.net/p/checkstyle/feature-requests/600/ (or the newer GitHub issue https://github.com/checkstyle/checkstyle/issues/138) are somehow related, though they describe IMO a different issue (performance improvments for checkstyle on a single module) See also discussion on GitHub PR https://github.com/checkstyle/checkstyle/pull/184 > Checkstyle plugin is @threadSafe if checkstyle itself is threadsafe > --- > > Key: MCHECKSTYLE-138 > URL: https://jira.codehaus.org/browse/MCHECKSTYLE-138 > Project: Maven Checkstyle Plugin > Issue Type: Improvement >Affects Versions: 2.12.1 >Reporter: Kristian Rosenvold > > The checkstyle plugin can be marked as threadSafe if checkstyle itself can be > verified to be thread safe. > "Someone" should ask the checkstyle community if this is the case. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MWAR-314) failOnMissingWebXml ignored when webXml set
Jakob Galbavy created MWAR-314: -- Summary: failOnMissingWebXml ignored when webXml set Key: MWAR-314 URL: https://jira.codehaus.org/browse/MWAR-314 Project: Maven WAR Plugin Issue Type: Bug Affects Versions: 2.4 Environment: Windows 7, IBM RAD 9.0 Reporter: Jakob Galbavy Priority: Minor Attachments: pom.xml Hi, if the webXml attribute is set in the configuration of the plugin (in my case inherited from a parent pom), the failIOnMissingWebXml boolean is ignored. To reproduce that: * import maven project from attached pom OR create new project (simple archetype), package: war * use attached pom.xml OR include the plugin in the pom and set webXml to something and failOnMissingWebXml to false * mvn clean install -> failed * comment the webXml attribute out * mvn clean install -> success cheers Jakob PS: in my understanding of xml, using in the pom should set that attribute to NULL, but that doesn't work either. Is that another bug or supposed to be like that? -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MNG-1378) Make dependencies of test-jars transitive
[
https://jira.codehaus.org/browse/MNG-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349599#comment-349599
]
Didier Loiseau commented on MNG-1378:
-
Then I guess dependencies on test-jars should be completely disallowed. If your
tests depend on some test-jar, and you don't have the dependencies of that
test-jar, it is well possible that your tests cannot compile at all!
It is not just a question of extending test cases, it could also be a question
of reusing some other classes of the test-jar.
For example, suppose you have module X and module Y which depends on X. In the
test classes of module X, you implement a {{TestUtil}} class which relies on
some other class of X's main classpath and on some class from a test-scoped
dependency. Of course, the tests of X depend on {{TestUtil}}.
Now, in the tests of module Y, you would like to reuse {{TestUtil}}. You thus
need to declare a test-scoped dependency on X's test-jar. But for the moment
you also have to redeclare all the test-scoped dependencies of X in order to
use that class. And you cannot move that class somewhere else, due to its
dependencies.
> Make dependencies of test-jars transitive
> -
>
> Key: MNG-1378
> URL: https://jira.codehaus.org/browse/MNG-1378
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 2.0
>Reporter: Mark Hobson
> Fix For: Issues to be reviewed for 3.x
>
> Attachments: mng1378.tar.gz
>
>
> test-jar transitive dependencies are calculated as per compile scope rather
> than test scope.
> The situation is demonstrated nicely in it0077:
> * module sub1 has a test-scoped dependency of commons-lang
> * module sub2 has a test-scoped dependency of sub1 test-jar
> sub2 tests should inherit the commons-lang transitive dependency. For
> example:
> Index:
> maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java
> ===
> ---
> maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java
> (revision
> 328307)
> +++
> maven-core-it/it0077/sub2/src/test/java/org/apache/maven/it0077/PersonTwoTest.java
> (working
> copy)
> @@ -1,6 +1,7 @@
> package org.apache.maven.it0077;
> import junit.framework.TestCase;
> +import org.apache.commons.lang.BooleanUtils;
> public class PersonTwoTest
> extends PersonTest
> Results in:
> [INFO]
>
> [ERROR] BUILD FAILURE
> [INFO]
>
> [INFO] Compilation failure
> c:\maven-components\maven-core-it\it0077\sub2\src\test\java\org\apache\maven\it0077\PersonTwoTest.java:[4,31]
> package org.apache.commons.lang does not exist
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
