[jira] [Comment Edited] (MCHECKSTYLE-315) MismatchedTokenException occurred during the analysis of file and build FAILS.

2015-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072111#comment-15072111
 ] 

Michael Osipov edited comment on MCHECKSTYLE-315 at 12/27/15 10:03 AM:
---

If this happens with Eclipse Checkstyle Plugin too then this is not a Maven 
problem. I am inclined to close this one. Report this issue to the Checkstyle 
folks.


was (Author: michael-o):
If this happens with Eclipse Checkstyle Plugin too then this is not a Maven 
problem. I am inclined to close this one. Report this issue ot the Checkstyle 
folks.

> MismatchedTokenException occurred during the analysis of file and build FAILS.
> --
>
> Key: MCHECKSTYLE-315
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-315
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>  Components: checkstyle:check
>Affects Versions: 2.17
> Environment: OSX 10.11.1, java version "1.8.0_25", Apache Maven 
> 3.1.1, Checkstyle configuration plugin for M2Eclipse1.0.0.201503101518
>Reporter: Cormac O'Mahony
>
> Checkstyle cannot parse an automatically initialize array in method call.
> I experience the issue with both maven-checkstyle and eclipse-checksyle.
> The following code causes checktyle:check to fail. The issues is cause by the 
> second parameter. 
> final SanitisingBeanRecordFieldExtractor extractor =
> new SanitisingBeanRecordFieldExtractor(CreditCardRecord.class,
> { "transactionDescriptionLineText" },
> AbstractTransactionRecord.DATE_FORMAT, HASH_KEY);
> The checksyle:check fails with the following error.
> .../SanitisingBeanRecordFieldExtractorTest.java:109:15: expecting "class", 
> found 'SanitisingBeanRecordFieldExtractor'
> .../SanitisingBeanRecordFieldExtractorTest.java:110:78: expecting IDENT, 
> found ','
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on 
> project sense-batch: Failed during checkstyle configuration: 
> MismatchedTokenException occurred during the analysis of file 
> .../SanitisingBeanRecordFieldExtractorTest.java. expecting EOF, found 
> 'extractor' -> [Help 1]
> To work around the code needs to be changed to the following:
> final SanitisingBeanRecordFieldExtractor extractor =
> new SanitisingBeanRecordFieldExtractor(CreditCardRecord.class,
> new String[] { "transactionDescriptionLineText" },
> AbstractTransactionRecord.DATE_FORMAT, HASH_KEY);
> For reference the constructor I am calling is defined as follows:
> public SanitisingBeanRecordFieldExtractor(final Class type, final String[] 
> fields,
> final String dateFormatPattern, final String hashKey) throws 
> IntrospectionException {
> ...
> }
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MCHECKSTYLE-315) MismatchedTokenException occurred during the analysis of file and build FAILS.

2015-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072111#comment-15072111
 ] 

Michael Osipov commented on MCHECKSTYLE-315:


If this happens with Eclipse Checkstyle Plugin too then this is not a Maven 
problem. I am inclined to close this one. Report this issue ot the Checkstyle 
folks.

> MismatchedTokenException occurred during the analysis of file and build FAILS.
> --
>
> Key: MCHECKSTYLE-315
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-315
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>  Components: checkstyle:check
>Affects Versions: 2.17
> Environment: OSX 10.11.1, java version "1.8.0_25", Apache Maven 
> 3.1.1, Checkstyle configuration plugin for M2Eclipse1.0.0.201503101518
>Reporter: Cormac O'Mahony
>
> Checkstyle cannot parse an automatically initialize array in method call.
> I experience the issue with both maven-checkstyle and eclipse-checksyle.
> The following code causes checktyle:check to fail. The issues is cause by the 
> second parameter. 
> final SanitisingBeanRecordFieldExtractor extractor =
> new SanitisingBeanRecordFieldExtractor(CreditCardRecord.class,
> { "transactionDescriptionLineText" },
> AbstractTransactionRecord.DATE_FORMAT, HASH_KEY);
> The checksyle:check fails with the following error.
> .../SanitisingBeanRecordFieldExtractorTest.java:109:15: expecting "class", 
> found 'SanitisingBeanRecordFieldExtractor'
> .../SanitisingBeanRecordFieldExtractorTest.java:110:78: expecting IDENT, 
> found ','
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on 
> project sense-batch: Failed during checkstyle configuration: 
> MismatchedTokenException occurred during the analysis of file 
> .../SanitisingBeanRecordFieldExtractorTest.java. expecting EOF, found 
> 'extractor' -> [Help 1]
> To work around the code needs to be changed to the following:
> final SanitisingBeanRecordFieldExtractor extractor =
> new SanitisingBeanRecordFieldExtractor(CreditCardRecord.class,
> new String[] { "transactionDescriptionLineText" },
> AbstractTransactionRecord.DATE_FORMAT, HASH_KEY);
> For reference the constructor I am calling is defined as follows:
> public SanitisingBeanRecordFieldExtractor(final Class type, final String[] 
> fields,
> final String dateFormatPattern, final String hashKey) throws 
> IntrospectionException {
> ...
> }
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-793) Cleanning log

2015-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072157#comment-15072157
 ] 

Michael Osipov commented on MASSEMBLY-793:
--

Haven't seen any other log statements in the same package, let's leave it out. 
If someone needs them, he can file a ticket about it.

> Cleanning log
> -
>
> Key: MASSEMBLY-793
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Reporter: Luan Nico
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Removed System.out.println call that was cluttering the maven log.
> If it was crucial or important, I'm glad to change to another solution, like 
> a conditional or something.
> What do you think?
> Already made a PR with a suggested solution:
> https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (MASSEMBLY-793) Cleanning log

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MASSEMBLY-793:


Assignee: Michael Osipov

> Cleanning log
> -
>
> Key: MASSEMBLY-793
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Reporter: Luan Nico
>Assignee: Michael Osipov
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Removed System.out.println call that was cluttering the maven log.
> If it was crucial or important, I'm glad to change to another solution, like 
> a conditional or something.
> What do you think?
> Already made a PR with a suggested solution:
> https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MASSEMBLY-793) Remove cluttering System.out.println statements

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MASSEMBLY-793.

Resolution: Fixed

Fixed with [r1721826|http://svn.apache.org/r1721826].

> Remove cluttering System.out.println statements
> ---
>
> Key: MASSEMBLY-793
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Reporter: Luan Nico
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Removed System.out.println call that was cluttering the maven log.
> If it was crucial or important, I'm glad to change to another solution, like 
> a conditional or something.
> What do you think?
> Already made a PR with a suggested solution:
> https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MEJB-92) Make separate classifier for client and main aritfact

2015-12-27 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MEJB-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MEJB-92.
---
Resolution: Fixed
  Assignee: Karl Heinz Marbaise

Added with
 * [r1721692|http://svn.apache.org/r1721692] 
 * [r1721693|http://svn.apache.org/r1721693]
 * [r1721772|http://svn.apache.org/r1721772]
 * [r1721834|http://svn.apache.org/r1721834]
 * [r1721837|http://svn.apache.org/r1721837]

> Make separate classifier for client and main aritfact
> -
>
> Key: MEJB-92
> URL: https://issues.apache.org/jira/browse/MEJB-92
> Project: Maven EJB Plugin
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.0.0
>
>
> {code:java}
> // Handle the classifier if necessary
> // TODO: For 3.0 this should be changed having a separate classifier 
> for main artifact and ejb-client.
> if ( classifier != null )
> {
> projectHelper.attachArtifact( project, "ejb", classifier, jarFile 
> );
> }
> else
> {
> project.getArtifact().setFile( jarFile );
> }
> if ( generateClient )
> {
> generateEjbClient();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MASSEMBLY-793) Cleanning log

2015-12-27 Thread Luan Nico (JIRA)
Luan Nico created MASSEMBLY-793:
---

 Summary: Cleanning log
 Key: MASSEMBLY-793
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
 Project: Maven Assembly Plugin
  Issue Type: Improvement
Reporter: Luan Nico
Priority: Trivial


Removed System.out.println call that was cluttering the maven log.
If it was crucial or important, I'm glad to change to another solution, like a 
conditional or something.
What do you think?

Already made a PR with a suggested solution:
https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHARED-255) create DomUtils, equivalent from Xpp3DomUtils but working on W3C DOM

2015-12-27 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/MSHARED-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MSHARED-255:
--
Description: 
Maven XML merge features are actually only available for Xpp3Dom.

Having these features on standard DOM implementation would be useful to [get 
away from 
Xpp3|https://cwiki.apache.org/confluence/display/MAVENOLD/Use+StAX+instead+of+XPP3]

  was:
Maven XML merge features are actually only available for Xpp3Dom.
Having these features on standard DOM implementation would be useful to [get 
away from 
Xpp3|https://cwiki.apache.org/confluence/display/MAVENOLD/Use+StAX+instead+of+XPP3]


> create DomUtils, equivalent from Xpp3DomUtils but working on W3C DOM
> 
>
> Key: MSHARED-255
> URL: https://issues.apache.org/jira/browse/MSHARED-255
> Project: Maven Shared Components
>  Issue Type: New Feature
>  Components: maven-shared-utils
>Affects Versions: maven-shared-utils-0.1
>Reporter: Hervé Boutemy
>
> Maven XML merge features are actually only available for Xpp3Dom.
> Having these features on standard DOM implementation would be useful to [get 
> away from 
> Xpp3|https://cwiki.apache.org/confluence/display/MAVENOLD/Use+StAX+instead+of+XPP3]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (MEJB-82) Ability to add additional files to the META-INF directory

2015-12-27 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MEJB-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reopened MEJB-82:
-

It looks like i was too fast with closing this issue...I found out that the 
given configuration does not work...

> Ability to add additional files to the META-INF directory
> -
>
> Key: MEJB-82
> URL: https://issues.apache.org/jira/browse/MEJB-82
> Project: Maven EJB Plugin
>  Issue Type: Improvement
>Affects Versions: 2.5
>Reporter: Alexandre Alvarez
>Assignee: Karl Heinz Marbaise
>
> Currently it is possible to specify the ejb-jar.xml to use via the ejbJar 
> property.   However, some containers require additional configuration files 
> (i.e. weblogic-ejb-jar.xml), so it would be helpful to be able to specify a 
> META-INF folder (with filters) to package.
> 
> projA/META-INF/ejb-jar.xml
> projA/META-INF/weblogic-ejb-jar.xml
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-793) Remove cluttering System.out.println statements

2015-12-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072204#comment-15072204
 ] 

Hudson commented on MASSEMBLY-793:
--

FAILURE: Integrated in maven-plugins #4928 (See 
[https://builds.apache.org/job/maven-plugins/4928/])
[MASSEMBLY-793] Remove cluttering System.out.println statements (michaelo: 
[http://svn.apache.org/viewvc/?view=rev=1721826])
* 
maven-assembly-plugin/src/main/java/org/apache/maven/plugins/assembly/filter/ComponentsXmlArchiverFileFilter.java
* 
maven-assembly-plugin/src/main/java/org/apache/maven/plugins/assembly/filter/SimpleAggregatingDescriptorHandler.java


> Remove cluttering System.out.println statements
> ---
>
> Key: MASSEMBLY-793
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Reporter: Luan Nico
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Removed System.out.println call that was cluttering the maven log.
> If it was crucial or important, I'm glad to change to another solution, like 
> a conditional or something.
> What do you think?
> Already made a PR with a suggested solution:
> https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MSHARED-481) Clean up and update class version detection for Java 7/8

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHARED-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-481.
--
Resolution: Fixed

Fixed with [r1721843|http://svn.apache.org/r1721843].

> Clean up and update class version detection for Java 7/8
> 
>
> Key: MSHARED-481
> URL: https://issues.apache.org/jira/browse/MSHARED-481
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-jar
>Affects Versions: maven-shared-jar-1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: maven-shared-jar-1.2
>
>
> Use proper double values for class versions upto Java 8 in 
> {{JarClassesAnalysis}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MEJB-61) Update plugin for EJB 3.2

2015-12-27 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MEJB-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MEJB-61.
---
   Resolution: Cannot Reproduce
Fix Version/s: (was: waiting-for-feedback)

Unfortunately i can't see what the problem is nor i got feedback..

> Update plugin for EJB 3.2
> -
>
> Key: MEJB-61
> URL: https://issues.apache.org/jira/browse/MEJB-61
> Project: Maven EJB Plugin
>  Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Ian Evans
>
> ejb-version doesn't support "3.2", the latest EJB spec release that's part of 
> Java EE 7:
> http://jcp.org/en/jsr/detail?id=345
> The schema location has changed for EJB-JAR 3.2. It is:
> http://xmlns.jcp.org/xml/ns/javaee/ejb-jar_3_2.xsd
> More info here on the EE 7 schemas here:
> http://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/index.html#7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (MASSEMBLY-744) Use the same namespace pattern for assembly/component format as the rest of Maven

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MASSEMBLY-744:


Assignee: Michael Osipov

> Use the same namespace pattern for assembly/component format as the rest of 
> Maven
> -
>
> Key: MASSEMBLY-744
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-744
> Project: Maven Assembly Plugin
>  Issue Type: Task
>  Components: component descriptor
>Affects Versions: 2.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.0.0
>
>
> Currently, the namespaces are
> bq. http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
> and
> bq. http://maven.apache.org/plugins/maven-assembly-plugin/component/1.1.2
> but Maven and Site Decoration Model use this pattern:
> bq. http://maven.apache.org/POM/4.0.0
> and
> bq. http://maven.apache.org/DECORATION/1.4.0
> We should adapt this pattern and rename the namespaces to 
> bq. http://maven.apache.org/ASSEMBLY/1.1.2
> and
> bq. http://maven.apache.org/COMPONENT/1.1.2
> or better yet
> bq. http://maven.apache.org/ASSEMBLY/COMPONENT/1.1.2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-745) Give the component format schema file a better name

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MASSEMBLY-745:
-
Fix Version/s: 3.0.0

> Give the component format schema file a better name
> ---
>
> Key: MASSEMBLY-745
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-745
> Project: Maven Assembly Plugin
>  Issue Type: Task
>  Components: component descriptor
>Affects Versions: 2.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.0.0
>
>
> The current name and location of the schema file is quite general  
> {{http://maven.apache.org/xsd/component-1.1.2.xsd}}. Without opening that 
> file you do not know that this belongs to MASSEMBLY. Component could be 
> everything.
> For consistency, rename that file to {{assembly-component-1.1.2.xsd}} and the 
> link accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (MASSEMBLY-745) Give the component format schema file a better name

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MASSEMBLY-745:


Assignee: Michael Osipov

> Give the component format schema file a better name
> ---
>
> Key: MASSEMBLY-745
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-745
> Project: Maven Assembly Plugin
>  Issue Type: Task
>  Components: component descriptor
>Affects Versions: 2.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.0.0
>
>
> The current name and location of the schema file is quite general  
> {{http://maven.apache.org/xsd/component-1.1.2.xsd}}. Without opening that 
> file you do not know that this belongs to MASSEMBLY. Component could be 
> everything.
> For consistency, rename that file to {{assembly-component-1.1.2.xsd}} and the 
> link accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-770) List of XSD's on the main site is cluttered.

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MASSEMBLY-770:
-
Fix Version/s: (was: next-release)
   3.0.0

> List of XSD's on the main site is cluttered.
> 
>
> Key: MASSEMBLY-770
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-770
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 2.5.5
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 3.0.0
>
>
> The list of xsd referernces is not correctly formatted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1135) Improve ignore message for TestNG

2015-12-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072164#comment-15072164
 ] 

ASF GitHub Bot commented on SUREFIRE-1135:
--

Github user mbocek closed the pull request at:

https://github.com/apache/maven-surefire/pull/79


> Improve ignore message for TestNG
> -
>
> Key: SUREFIRE-1135
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1135
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: TestNG support
>Reporter: Michal Bocek
>Assignee: Tibor Digana
> Fix For: 2.19.1
>
> Attachments: TEST-testng.SkipExceptionReportTest.xml
>
>
> Once the test is ignored/skipped in TestNG no additional informations are 
> reported. Surefire xml report contains only "skipped" element  without any 
> information. It will be very useful to provide addition info like message. 
> JUnit reporter correctly provide ignore message from "Ignore" annotation so 
> we can similarly provide message from SkipException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-744) Use the same namespace pattern for assembly/component format as the rest of Maven

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MASSEMBLY-744:
-
Fix Version/s: 3.0.0

> Use the same namespace pattern for assembly/component format as the rest of 
> Maven
> -
>
> Key: MASSEMBLY-744
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-744
> Project: Maven Assembly Plugin
>  Issue Type: Task
>  Components: component descriptor
>Affects Versions: 2.5.3
>Reporter: Michael Osipov
> Fix For: 3.0.0
>
>
> Currently, the namespaces are
> bq. http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2
> and
> bq. http://maven.apache.org/plugins/maven-assembly-plugin/component/1.1.2
> but Maven and Site Decoration Model use this pattern:
> bq. http://maven.apache.org/POM/4.0.0
> and
> bq. http://maven.apache.org/DECORATION/1.4.0
> We should adapt this pattern and rename the namespaces to 
> bq. http://maven.apache.org/ASSEMBLY/1.1.2
> and
> bq. http://maven.apache.org/COMPONENT/1.1.2
> or better yet
> bq. http://maven.apache.org/ASSEMBLY/COMPONENT/1.1.2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MSHARED-481) Clean up and update class version detection for Java 7/8

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHARED-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSHARED-481:
---
Summary: Clean up and update class version detection for Java 7/8  (was: 
Clean up and update class version detection)

> Clean up and update class version detection for Java 7/8
> 
>
> Key: MSHARED-481
> URL: https://issues.apache.org/jira/browse/MSHARED-481
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-jar
>Affects Versions: maven-shared-jar-1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: maven-shared-jar-1.2
>
>
> Use proper double values for class versions upto Java 8 in 
> {{JarClassesAnalysis}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MASSEMBLY-310) improve site inclusion handling in assemblies

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MASSEMBLY-310.

Resolution: Won't Fix

Will probably never be implemented.

> improve site inclusion handling in assemblies
> -
>
> Key: MASSEMBLY-310
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-310
> Project: Maven Assembly Plugin
>  Issue Type: New Feature
>  Components: site
>Affects Versions: 2.2-beta-2
> Environment: Maven 2.0.9, Win XP SP2
>Reporter: Michael Osipov
>
> The current state of including the site into an assembly is extremely bad.
> There is  but this suits only for a single module 
> project.
> if you do have a multimodule project, try so assemble all subsites into the 
> parent sie module, you have to struggle with fileset or modulesets or both.
> I was able to solve this for me with:
> {code:xml}
> 
> 
> false
> 
> 
> site/${artifactId}
> target/site
> 
> 
> 
> 
> {code}
> This is a better way than using the regular fiesets but still an ugly 
> solution since I needed several hours to accomplish that the way I wanted.
> I am asking for a more profound and easier solution for this. It could be 
> solved maybe with site:jar and usage of binaries and attachmentClassifer = 
> site but this still seems quite inferior.
> I propose something like this:
> {code:xml}
> 
> 
> true
> 
> {code}
> The in- and excludes would make it quite flexible. An much more easier 
> approach without any flexibility would just be introduce a 
> .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MEJB-60) Optional classifer for ejb-client

2015-12-27 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MEJB-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MEJB-60.
---
Resolution: Fixed
  Assignee: Karl Heinz Marbaise

> Optional classifer for ejb-client
> -
>
> Key: MEJB-60
> URL: https://issues.apache.org/jira/browse/MEJB-60
> Project: Maven EJB Plugin
>  Issue Type: New Feature
>Affects Versions: 2.3
>Reporter: Will Tatam
>Assignee: Karl Heinz Marbaise
> Attachments: generateClassifiedClient.patch
>
>
> It is sometimes necessary to have an EJB jar which requires a classifier, but 
> that does not automatically mean that you want your ejb-client to always have 
> a classifier too and infact the current code has a comment next to the 
> creation of the client stating
> "TODO: shouldn't need classifier"
> Patch attached created new config option called generateClassifiedClient 
> which is true by default, to maintain previous behavour, but can be set to 
> true in the configuration section of the pom to false should you wish to have 
> a non-classified client



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MPIR-336) Upgrade to Maven Shared JAR 1.2

2015-12-27 Thread Michael Osipov (JIRA)
Michael Osipov created MPIR-336:
---

 Summary: Upgrade to Maven Shared JAR 1.2
 Key: MPIR-336
 URL: https://issues.apache.org/jira/browse/MPIR-336
 Project: Maven Project Info Reports Plugin
  Issue Type: Task
Affects Versions: 2.8.1
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.8.2


Maven Shared JAR 1.2 brings improvements with Java 7 and 8 detection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MSHARED-481) Clean up and update class version detection

2015-12-27 Thread Michael Osipov (JIRA)
Michael Osipov created MSHARED-481:
--

 Summary: Clean up and update class version detection
 Key: MSHARED-481
 URL: https://issues.apache.org/jira/browse/MSHARED-481
 Project: Maven Shared Components
  Issue Type: Improvement
  Components: maven-shared-jar
Affects Versions: maven-shared-jar-1.1
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: maven-shared-jar-1.2


Use proper double values for class versions upto Java 8 in 
{{JarClassesAnalysis}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-793) Remove cluttering System.out.println statements

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MASSEMBLY-793:
-
Summary: Remove cluttering System.out.println statements  (was: Cleanning 
log)

> Remove cluttering System.out.println statements
> ---
>
> Key: MASSEMBLY-793
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Reporter: Luan Nico
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Removed System.out.println call that was cluttering the maven log.
> If it was crucial or important, I'm glad to change to another solution, like 
> a conditional or something.
> What do you think?
> Already made a PR with a suggested solution:
> https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-793) Remove cluttering System.out.println statements

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MASSEMBLY-793:
-
Fix Version/s: 3.0.0

> Remove cluttering System.out.println statements
> ---
>
> Key: MASSEMBLY-793
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-793
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Reporter: Luan Nico
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Removed System.out.println call that was cluttering the maven log.
> If it was crucial or important, I'm glad to change to another solution, like 
> a conditional or something.
> What do you think?
> Already made a PR with a suggested solution:
> https://github.com/luanpotter/maven-plugins/commit/279a5be81f491fe43a36147f54f2946ac8fb198d



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (MASSEMBLY-792) Expose merge manifest mode from the plexus archiver

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MASSEMBLY-792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MASSEMBLY-792:
-
Fix Version/s: (was: 3.0.0)

> Expose merge manifest mode from the plexus archiver
> ---
>
> Key: MASSEMBLY-792
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-792
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>Affects Versions: 2.6
>Reporter: Thomas Meyer
> Attachments: massembly-792.patch
>
>
> Expose the "merge manifest mode" attribute from the plexus archiver 
> (JarArchiver) so the assembly plugin can be used to unpack an archive with a 
> manifest file into a jar archive (target format) and merge the contents of 
> the already existing (from the unpack) manifest file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSHARED-481) Clean up and update class version detection for Java 7/8

2015-12-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHARED-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072252#comment-15072252
 ] 

Hudson commented on MSHARED-481:


SUCCESS: Integrated in maven-shared #836 (See 
[https://builds.apache.org/job/maven-shared/836/])
[MSHARED-481] Clean up and update class version detection for Java 7/8 
(michaelo: [http://svn.apache.org/viewvc/?view=rev=1721843])
* 
maven-shared-jar/src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java
* 
maven-shared-jar/src/test/java/org/apache/maven/shared/jar/classes/JarClassesAnalyzerTest.java
* maven-shared-jar/src/test/resources/jars/helloworld-1.7.jar
* maven-shared-jar/src/test/resources/jars/helloworld-1.8.jar


> Clean up and update class version detection for Java 7/8
> 
>
> Key: MSHARED-481
> URL: https://issues.apache.org/jira/browse/MSHARED-481
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-shared-jar
>Affects Versions: maven-shared-jar-1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: maven-shared-jar-1.2
>
>
> Use proper double values for class versions upto Java 8 in 
> {{JarClassesAnalysis}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MPIR-337) Localize sealed information on JARs

2015-12-27 Thread Michael Osipov (JIRA)
Michael Osipov created MPIR-337:
---

 Summary: Localize sealed information on JARs
 Key: MPIR-337
 URL: https://issues.apache.org/jira/browse/MPIR-337
 Project: Maven Project Info Reports Plugin
  Issue Type: Task
  Components: dependencies
Affects Versions: 2.8.1
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.8.2


If a JAR is sealed, only "sealed" is written in verbatim, regardless of the 
language.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (MPIR-337) Localize sealed information on JARs

2015-12-27 Thread Michael Osipov (JIRA)

 [ 
https://issues.apache.org/jira/browse/MPIR-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPIR-337.
---
Resolution: Fixed

Fixed with [r1721853|http://svn.apache.org/r1721853].

> Localize sealed information on JARs
> ---
>
> Key: MPIR-337
> URL: https://issues.apache.org/jira/browse/MPIR-337
> Project: Maven Project Info Reports Plugin
>  Issue Type: Task
>  Components: dependencies
>Affects Versions: 2.8.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 2.8.2
>
>
> If a JAR is sealed, only "sealed" is written in verbatim, regardless of the 
> language.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SUREFIRE-1214) Experimental SPI @ Java 1.6 as in-plugin process Extensions API

2015-12-27 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1214:
--

 Summary: Experimental SPI @ Java 1.6 as in-plugin process 
Extensions API
 Key: SUREFIRE-1214
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1214
 Project: Maven Surefire
  Issue Type: New Feature
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 2.20


in-plugin process API should handle current MOJO execution and enable the user 
to modify Tests Processor as well as ordering and filtering tests to be 
executed afterwards in forked process.
This preprocessing is needed in other features.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MPIR-337) Localize sealed information on JARs

2015-12-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MPIR-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072269#comment-15072269
 ] 

Hudson commented on MPIR-337:
-

FAILURE: Integrated in maven-plugins #4934 (See 
[https://builds.apache.org/job/maven-plugins/4934/])
[MPIR-337] Localize sealed information on JARs (michaelo: 
[http://svn.apache.org/viewvc/?view=rev=1721853])
* 
maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report.properties
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report_cs.properties
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report_de.properties
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report_es.properties
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report_fr.properties
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report_pt.properties
* 
maven-project-info-reports-plugin/src/main/resources/project-info-report_ru.properties


> Localize sealed information on JARs
> ---
>
> Key: MPIR-337
> URL: https://issues.apache.org/jira/browse/MPIR-337
> Project: Maven Project Info Reports Plugin
>  Issue Type: Task
>  Components: dependencies
>Affects Versions: 2.8.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 2.8.2
>
>
> If a JAR is sealed, only "sealed" is written in verbatim, regardless of the 
> language.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SUREFIRE-1213) MOJO pre-integration-test and post-integration-test

2015-12-27 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1213:
--

 Summary: MOJO pre-integration-test and post-integration-test
 Key: SUREFIRE-1213
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1213
 Project: Maven Surefire
  Issue Type: New Feature
  Components: Maven Failsafe Plugin
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 2.20


Introduce MOJO phase pre-integration-test and post-integration-test.
Introduce JSR 223 miscellaneous scriptables (BashShell, JavaScript, Nashorn). 
The goal is to run environment setup and cleanup before/after integration tests.
For the sake of Surefire build already requires JDK 6 (javac 1.5 still used) 
these two MOJOs will be added as experimental implementations of Surefire 3.0 
which will be built on the top of Java 1.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SUREFIRE-726) Test list preprocessor support for tests to be run

2015-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-726:
--
Fix Version/s: 2.20

> Test list preprocessor support for tests to be run
> --
>
> Key: SUREFIRE-726
> URL: https://issues.apache.org/jira/browse/SUREFIRE-726
> Project: Maven Surefire
>  Issue Type: New Feature
>Affects Versions: 2.9
>Reporter: Janmejay Singh
> Fix For: 3.0, 2.20
>
> Attachments: 
> 0001-Adds-test-list-preprocessor-support-which-loads-an-o.patch, 
> 0002-Integration-test-for-preprocessor.-2-modules-one-pro.patch, 
> 0003-exposed-testPreprocessor-configuration-parameter-as-.patch, 
> 0004-exposed-testPreprocessor-for-IntegrationTestMojo-as-.patch
>
>
> This exposes an interface(named TestListPreprocessor, which has a method 
> named preprocessTestClasses) that can be implemented by a user and injected 
> into surefire plugin configuration to have it used for preprocessing list of 
> tests to be run. Given the original test list, user's preprocessing algorithm 
> can choose to prune or reorder the list and return it back from 
> TestListPreprocessor#preprocessTestClasses, which is then used as the list of 
> tests to be executed.
> The patches attached expose a configuration element named "testPreprocessor" 
> the default value of which is "none". User can choose to set it to a value 
> matching the format 
> "[::]" and have 
> the class loaded and called with list of tests to be run. The list of tests 
> returned by the call is then considered for execution.
> Patch description:
> The feature is done in 2 patches. Description follows:
> 0001-Adds-test-list-preprocessor-support-which-loads-an-o.patch
> This patch actually adds the feature and unit tests. It adds the interface, 
> an abstraction that encapsulates aforementioned configuration, booter 
> serialization/deserialization, directory-scanner changes etc. The changes 
> have effect in both forked and in-process execution mode.
> 0002-Integration-test-for-preprocessor.-2-modules-one-pro.patch
> This patch adds an integration test for preprocessor feature. The integration 
> test uses a 2 module setup, where the first module implements the 
> TestListPreprocessor interface which selects only even indexed test classes 
> from the list passed in. The second module(which depends on first) uses the 
> artifact from first and uses the following configuration:
> 
> 
>   
> test.preprocessor.EvenTestOnlyPreprocessor[org.apache.maven.plugins.surefire:preprocessor-impl:1.0-SNAPSHOT]
> 
> 
> The test then asserts that only 2(0th and 2nd) of the 4 test classes the 
> second module has are executed.
> The patches are created on a git-svn clone using format-patch, please use 
> 'patch -p1 < 0001-Adds...'(while in the trunk directory) to apply the patches 
> on svn repository. If using git-svn, git-am can be directly be invoked.
> The patches are done over 
> http://svn.apache.org/repos/asf/maven/surefire/trunk@1091357 (trunk HEAD) so 
> should apply cleanly on any recent enough revision.
> ===
> Context:
> http://stackoverflow.com/questions/5124823/reducing-the-build-time-hudson
> http://code.google.com/p/tlb/issues/detail?id=1
> http://test-load-balancer.github.com



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SUREFIRE-1212) @Component is deprecated. @Parameter should be used instead.

2015-12-27 Thread Tibor Digana (JIRA)
Tibor Digana created SUREFIRE-1212:
--

 Summary: @Component is deprecated. @Parameter should be used 
instead.
 Key: SUREFIRE-1212
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1212
 Project: Maven Surefire
  Issue Type: Bug
  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
Surefire Report Plugin
Reporter: Tibor Digana
Assignee: Tibor Digana
 Fix For: 2.20


>From Maven Mailinglist
http://maven.40175.n5.nabble.com/maven-surefire-git-commit-SUREFIRE-refactoring-after-Sonar-report-td5856512.html

Hi Tibor,

just noticed this:

 @Component
-protected MavenSession session;
+private MavenSession session;


could you make a @Parameter of it, because the @Component is deprecated.
See also https://issues.apache.org/jira/browse/MPLUGIN-257
Actually, I would expect warnings from maven-plugin-plugin about this...

thanks,
Robert



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MPIR-338) Localize alternative text for used icons

2015-12-27 Thread Michael Osipov (JIRA)
Michael Osipov created MPIR-338:
---

 Summary: Localize alternative text for used icons
 Key: MPIR-338
 URL: https://issues.apache.org/jira/browse/MPIR-338
 Project: Maven Project Info Reports Plugin
  Issue Type: Task
Affects Versions: 2.8.1
Reporter: Michael Osipov
 Fix For: 2.8.2


Used icons have by default English text set. That should be localized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (MASSEMBLY-794) Update and revise documentation for 3.0.0 release

2015-12-27 Thread Michael Osipov (JIRA)
Michael Osipov created MASSEMBLY-794:


 Summary: Update and revise documentation for 3.0.0 release
 Key: MASSEMBLY-794
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-794
 Project: Maven Assembly Plugin
  Issue Type: Task
Affects Versions: 3.0.0
Reporter: Michael Osipov
 Fix For: 3.0.0


The documentation has grown over the years, let's wipe out the following 
redundant information:

* All references to old goals (non-single)
* Reference to a version where a feature has been introduced. Most are ancient.
* Remove information which applies to pre-Maven 3

There is probably more to wipe out...

All points apply to the site only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-645) File name of dependency depends on how it is reachable

2015-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072288#comment-15072288
 ] 

Michael Osipov commented on MASSEMBLY-645:
--

This is still present in 3.0.0-SNAPSHOT.

> File name of dependency depends on how it is reachable
> --
>
> Key: MASSEMBLY-645
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-645
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: dependencySet
>Affects Versions: 2.4
>Reporter: Tuure Laurinolli
>Priority: Critical
>
> Please see demonstration at https://github.com/tazle/maven-issue-demo
> After mvn package, the resulting maven-issue-demo-1.0.0-SNAPSHOT-bin.zip 
> contains the following libraries:
> maven-issue-demo-1.0.0-SNAPSHOT/lib/httpcore-4.3-alpha2-SNAPSHOT.jar
> maven-issue-demo-1.0.0-SNAPSHOT/lib/httpclient-4.3-alpha2-20130227.160252-28.jar
> For some reason httpcore has a -SNAPSHOT version whereas httpclient has a 
> unique version. This is clearly not desirable, since e.g. the classpath 
> generator in JAR plugin generates either -SNAPSHOT names or unique names but 
> not both.
> Some analysis:
> Originally versions of both libraries are unique. During resolution, some are 
> changed to -SNAPSHOT versions instead. This appears to affect packages that 
> are both direct and transitive dependencies.
> Some debug output from a modified assembly plugin, with additional debug 
> output:
> [DEBUG] Artifacts before resolution:
> [DEBUG] artifact: org.apache.httpcomponents:httpcore:jar:4.3-alpha2-SNAPSHOT, 
> version: 4.3-alpha2-20130220.230238-15, base version: 4.3-alpha2-SNAPSHOT, 
> resolved: true, scope: compile
> [DEBUG] artifact: 
> org.apache.httpcomponents:httpclient:jar:4.3-alpha2-SNAPSHOT, version: 
> 4.3-alpha2-20130227.160252-28, base version: 4.3-alpha2-SNAPSHOT, resolved: 
> true, scope: compile
> [DEBUG] Resolving project dependencies transitively.
> [DEBUG] maven-issue-demo:maven-issue-demo:jar:1.0.0-SNAPSHOT (selected for 
> null)
> [DEBUG]   org.apache.httpcomponents:httpcore:jar:4.3-alpha2-SNAPSHOT:compile 
> (selected for compile)
> [DEBUG]   
> org.apache.httpcomponents:httpclient:jar:4.3-alpha2-SNAPSHOT:compile 
> (selected for compile)
> [DEBUG] org.apache.httpcomponents:httpcore:jar:4.3-alpha1:compile 
> (removed - nearer found: 4.3-alpha2-SNAPSHOT)
> [DEBUG] commons-logging:commons-logging:jar:1.1.1:compile (selected for 
> compile)
> [DEBUG] commons-codec:commons-codec:jar:1.6:compile (selected for compile)
> [DEBUG] While resolving dependencies of 
> maven-issue-demo:maven-issue-demo:jar:1.0.0-SNAPSHOT:
> [DEBUG] Statistics for Scope filter [null-scope=true, compile=true, 
> runtime=true, test=false, provided=false, system=false]
> [DEBUG] The following scope filters were not used: 
> o Runtime
> o Test
> o Provided
> o System
> [DEBUG] resolved artifact: 
> org.apache.httpcomponents:httpcore:jar:4.3-alpha2-SNAPSHOT, version: 
> 4.3-alpha2-SNAPSHOT, baseVersion: 4.3-alpha2-SNAPSHOT
> [DEBUG] resolved artifact: 
> org.apache.httpcomponents:httpclient:jar:4.3-alpha2-SNAPSHOT, version: 
> 4.3-alpha2-20130227.160252-28, baseVersion: 4.3-alpha2-SNAPSHOT
> [DEBUG] resolved artifact: commons-logging:commons-logging:jar:1.1.1, 
> version: 1.1.1, baseVersion: 1.1.1
> [DEBUG] resolved artifact: commons-codec:commons-codec:jar:1.6, version: 1.6, 
> baseVersion: 1.6



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1192) Fixed Sonar and FindBug issues

2015-12-27 Thread Tibor Digana (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072294#comment-15072294
 ] 

Tibor Digana commented on SUREFIRE-1192:


commit 3780976576ed6fcd458edaec94e9a633b9fa3551

> Fixed Sonar and FindBug issues
> --
>
> Key: SUREFIRE-1192
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1192
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.19
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Minor
> Fix For: 2.19.1
>
>
> Removed "protected" field modofiers on MOJO and used "private" modifiers.
> The array objects returned from getter methods can be modified by the caller. 
> Made clone on File[]. Improved suite-xml files manipulation with arrays.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-689) Upgrade documentation according to best practice

2015-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072293#comment-15072293
 ] 

Michael Osipov commented on MASSEMBLY-689:
--

Why is that a bad practice?

> Upgrade documentation according to best practice
> 
>
> Key: MASSEMBLY-689
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-689
> Project: Maven Assembly Plugin
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 2.4
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the docs say things like this:
> {{It is common practice to create an assembly using the parent POM of a 
> multimodule build. At times, you may want to ensure that this assembly also 
> includes one or more of the module binaries.}} which is not best practice so 
> it should be replaced by better explanations and the best practice. 
> (http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SUREFIRE-528) Splitting tests names in two categories : success and failure

2015-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-528:
--
Fix Version/s: 2.20

> Splitting tests names in two categories : success and failure
> -
>
> Key: SUREFIRE-528
> URL: https://issues.apache.org/jira/browse/SUREFIRE-528
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Affects Versions: 2.0 (2.2 plugin)
>Reporter: Emmanuel Lecharny
> Fix For: 2.20
>
>
> We have to check all the *.txt files to find the ones which contain some 
> errors. The fact that failed tests are listed before does not help a lot when 
> you have hundred of tests run with sometime lot of logs.
> I would rather propose that we either create two sub-directories 
> (failure/success) or that we postfix tests. 
> A good example : 
> ...
> Tests run: 197, Failures: 1, Errors: 0, Skipped: 0
> [INFO] 
> 
> [ERROR] BUILD FAILURE
> [INFO] 
> 
> [INFO] There are test failures.
> Please refer to 
> /home/elecharny/apacheds/mina/trunk/core/target/surefire-reports for the 
> individual test results.
> ...
> Would be better to have :
> Please refer to 
> /home/elecharny/apacheds/mina/trunk/core/target/surefire-reports/failure for 
> the individual test failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SUREFIRE-526) Better support for other plugins to determine which tests are included/excluded and the order the tests get run

2015-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-526:
--
Fix Version/s: 2.20

> Better support for other plugins to determine which tests are 
> included/excluded and the order the tests get run
> ---
>
> Key: SUREFIRE-526
> URL: https://issues.apache.org/jira/browse/SUREFIRE-526
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Reporter: Nick Pellow
> Fix For: 3.0, 2.20
>
>
> Currently, it is possible to provide the 'test' pattern to the 
> maven-surefire-plugin to include/exclude specific tests to be run.
> This can be set on the MavenProject instance of any plugin which runs prior 
> to the surefire plugin.
> Since this is just a pattern of tests to include, it has the following 
> shortcomings:
> * To excludes a single test, you need to add _all_ tests, minus the test to 
> exclude
> * The order of the test patterns is not used when the tests get run.
> If there is no better means to control which tests get run and in which order 
> from outside the surefire plugin, how do you suggest this be achieved? 
> This may require changes to maven core to allow attributes  
> be set as well as Properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MASSEMBLY-616) do not included artifacts with scope system as dependencies

2015-12-27 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072290#comment-15072290
 ] 

Michael Osipov commented on MASSEMBLY-616:
--

Is the JAR included at all? What do you expect to see?

> do not included artifacts with scope system as dependencies
> ---
>
> Key: MASSEMBLY-616
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-616
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 2.3
> Environment: FreeBSD 8, 64bit, openjdk6/7
>Reporter: Radim Kolar
>
> If you are building assembly with dependencies included:
> {code:xml}
> true
> {code}
> and one of dependencies has scope like that:
> {code:xml}
> 
> 
>   jdk.tools
>   jdk.tools
>   1.6
>   system
>   ${java.home}/../lib/tools.jar
> 
> 
> {code}
> then assembly plugin tries to fetch that artifact from repository. Artifact 
> of course is not there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SUREFIRE-1212) @Component is deprecated. @Parameter should be used instead.

2015-12-27 Thread Tibor Digana (JIRA)

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1212:
---
Issue Type: Improvement  (was: Bug)

> @Component is deprecated. @Parameter should be used instead.
> 
>
> Key: SUREFIRE-1212
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1212
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin, Maven 
> Surefire Report Plugin
>Reporter: Tibor Digana
>Assignee: Tibor Digana
> Fix For: 2.20
>
>
> From Maven Mailinglist
> http://maven.40175.n5.nabble.com/maven-surefire-git-commit-SUREFIRE-refactoring-after-Sonar-report-td5856512.html
> Hi Tibor,
> just noticed this:
>  @Component
> -protected MavenSession session;
> +private MavenSession session;
> could you make a @Parameter of it, because the @Component is deprecated.
> See also https://issues.apache.org/jira/browse/MPLUGIN-257
> Actually, I would expect warnings from maven-plugin-plugin about this...
> thanks,
> Robert



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)